[PATCH] D96850: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn abandoned this revision. fhahn added a comment. those have been picked onto 12.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96850/new/ https://reviews.llvm.org/D96850 ___ cfe-commits mailing lis

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn updated this revision to Diff 33. fhahn added a comment. Thank you very much John! I applied your suggestions to the wording and removed the unneeded language feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://revi

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc92ec0dd92ba: [Matrix] Add support for matrix-by-scalar division. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130701 , @SjoerdMeijer wrote: > This introduces another way of setting (optional) architecture extensions and > having two ways to do the same is nearly always a bad thing, which is how one > of my colleagues phrased

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130744 , @DavidSpickett wrote: > There was a similar proposal for crypto https://reviews.llvm.org/D60472. > > Quoting @manojgupta for the pitch for that: > >> The motivation for this change is to make "crypto" setting a

[PATCH] D113779: [Clang] Add mfp16, mfp16fml and mdotprod flags for ARM target features.

fhahn added a comment. In D113779#3130853 , @paulwalker-arm wrote: > Rather than adding connivence options after the fact what about allowing > `-march=` to be specified multiple times? The first must be the usual format > with later ones required to s

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

fhahn added a comment. It is also breaking building `llvm-project/llvm/unittests/Support/Host.cpp` on macOS: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/25781/consoleFull FAILED: unittests/Support/CMakeFiles/SupportTests.dir/Host.cpp.o /Applications/Xcode.app/Co

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added a comment. Thanks for the patch! I left a suggestion inline. Comment at: clang/lib/Sema/SemaChecking.cpp:16721 +bool Sema::SemaBuiltinElementwiseMathFloatArg(CallExpr *TheCall) { + if (checkArgCount(*this, TheCall, 1)) If I understand correctly,

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11337 +def err_builtin_float_invalid_arg_type: Error < + "%ordinal0 argument must be a " There's no need to add a new error message here. `err_builtin_invalid_arg_type`

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2104 +TheCall, [this](QualType ArgTy, SourceLocation ArgLoc) -> bool { + QualType EltTy = ArgTy; + if (auto *VecTy = EltTy->getAs()) Could you add a com

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16727-16728 QualType TyA = A.get()->getType(); - if (checkMathBuiltinElementType(*this, ArgLoc, TyA)) + if (checkMathBuiltinElementType(*this, ArgLoc, TyA) || + ExtraCheck(TyA, ArgLoc)) return

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 469270. fhahn added a comment. Rebase on top of current `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/in

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn updated this revision to Diff 469329. fhahn added a comment. Rebased on current main In D122573#3630767 , @rui.zhang wrote: > I like the direction where this change is leading to and hope there is some > way to land it incrementally. Since Builtin

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef110a491f70: [Builtins] Do not claim most libfuncs are readnone with trapping math. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D129231?vs=448628&id=451800#toc Repository:

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1409 -LIBBUILTIN(round, "dd", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundf, "ff", "fnc", "math.h", ALL_LANGUAGES) -LIBBUILTIN(roundl, "LdLd", "fnc", "math.h", ALL_LANGUAGES) +LIBBUILTIN(round,

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. In D129231#3716363 , @scanon wrote: >>> Looking at implementations of these functions, it looks like GNU libm >>> doesn't raise inexact, but the bionic libm does. I think I'm leaning >>> towards marking all of them as "fng" as it'

[PATCH] D129231: [Builtins] Do not claim all libfuncs are readnone with trapping math.

fhahn added a comment. @john.brawn Are you OK with treating those functions as not setting inexact, as per the C23 clarification, as the committed version does? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129231/new/ https://reviews.llvm.org/D12

[PATCH] D132488: [CMake] Move cxx-headers to RUNTIME_DISTRIBUTION_COMPONENTS in Apple-stage2.cmake

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132488/new/ https://reviews.llvm.org/D132488

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

fhahn added a comment. In D133737#3787066 , @RKSimon wrote: > The elementwise builtins should work for scalars as well (and IIRC we do test > this as well). Yep they should, it is specially specified here: https://clang.llvm.org/docs/LanguageExtensions

[PATCH] D134316: [clang][docs] Fix supported element types for `__builtin_reduce_(add|mul)`

fhahn added a comment. In D134316#3808544 , @jloser wrote: > This landed with > https://github.com/llvm/llvm-project/commit/cf77333da986720e9aded4301d81a581e2be9611. > The revision didn't auto-close for some reason. You need to make sure the commit me

[PATCH] D134441: [ObjC][ARC] Don't use operand bundle "clang.arc.attachedcall" in codegen for Windows

fhahn added a comment. In D134441#3808655 , @sgraenitz wrote: > The symptom is that Clang emits `movq %rax, %rdi` instead of `movq %rax, > %rcx` while `objc_retainAutoreleasedReturnValue()` still expects the value in > `%rcx`. > It appears related to D9

[PATCH] D134441: [ObjC][ARC] Fix target register for call expanded from CALL_RVMARKER on Windows

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! You might want to extend the windows check lines to the other tests as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134441/ne

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

fhahn added a comment. Herald added a project: All. In D106005#2904865 , @SaurabhJha wrote: > In D106005#2904424 , @fhahn wrote: > >> In D106005#2896080 , @SaurabhJha >>

[PATCH] D135011: Add sin and cos llvm intrinsics

fhahn added a comment. Could you update the title to make it clear this adds new Clang builtins, not intrinsics (they are lowered to LLVM intrinsics). The behavior of the new builtins should be specified in `LanguageExtensions.rst` (https://clang.llvm.org/docs/LanguageExtensions.html#vector-bui

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

fhahn added a comment. > Adding this metadata allows {loop.vectorize.enable, false} to be used without > disabling the whole pass. Could you please describe the behavior in more detail here? The new metadata should also be documented in `LangRef`, the new pragma in https://clang.llvm.org/docs/

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

fhahn added a comment. It looks like GISel crashes when building `llvm-test-suite` with -O3 on ARM64. If it isn't trivial to fix we should probably revert the patch to bring things back to green. Reproducer: ; llc -global-isel -O3 target datalayout = "e-m:o-i64:64-i128:128-n32:64-S128"

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

fhahn accepted this revision. fhahn added a comment. LGTM with the suggested changes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits ma

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn commandeered this revision. fhahn added a reviewer: CJ-Johnson. fhahn added a comment. Commandeering after the recent updates to make review + follow-ups easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.or

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn added a comment. Using `ptrmask` here looks good to me, but it looks like a couple of tests need still updating; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 ___ cfe-commits mailing list cf

[PATCH] D133574: [C2x] reject type definitions in offsetof

fhahn added a comment. In D133574#4053647 , @aaron.ballman wrote: > I'll take care of fixing this up on Tuesday (Mon is a holiday here), but if > anyone wants to get to it sooner, what I plan to do is: > > - Add a new `Extension` diagnostic about allowi

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM ,thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422

[PATCH] D126956: [tbaa] Handle base classes in struct tbaa

fhahn added a comment. It looks like this commit is breaking bootstrap builds of LLVM/Clang, e.g. https://lab.llvm.org/buildbot/#/builders/37/builds/14224 FAILED: lib/Bitcode/Reader/CMakeFiles/LLVMBitReader.dir/BitcodeReader.cpp.o /b/sanitizer-x86_64-linux-autoconf/build/tsan_debug_build/bi

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 434471. fhahn added a comment. Rebase & address comments, thanks! Also update the code to link tysan runtime with static linking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 435508. fhahn added a comment. Add TySan library when building on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. Unfortunately it looks like this commit breaks building on ARM64 macOS. I reverted the change for now and added more details on the error in the revert commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950825 , @lenary wrote: > In D137836#3950815 , @fhahn wrote: > >> Unfortunately it looks like this commit breaks building on ARM64 macOS. I >> reverted the change for now and ad

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. (it looks like this job should have sent an email: https://green.lab.llvm.org/green/job/clang-stage1-RA/32031/console) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137836/new/ https://reviews.llvm.org/D137836 _

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

fhahn added a comment. In D137836#3950883 , @lenary wrote: > In D137836#3950846 , @fhahn wrote: > >> (it looks like this job should have sent an email: >> https://green.lab.llvm.org/green/job/clang-stage1-RA/3203

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

fhahn created this revision. fhahn added reviewers: jfb, Bigcheese, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. There are a few places with unexpected indents that trip over sphinx and other syntax errors. Also, the C++ syntax highlighting does not work for

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG684ee2057f5d: [clang/docs] Fix various sphinx warnings/errors in docs. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76534/new/ https:/

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn created this revision. fhahn added reviewers: rsmith, anemet, Bigcheese, dexonsmith. Herald added a subscriber: tschuett. Herald added a project: clang. This patch documents the planned matrix support in Clang, based on the draft specification discussed on cfe-dev in the 'Matrix Support in C

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 252043. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72281/new/ https://reviews.llvm.org/D72281 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/RecursiveAS

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

fhahn added a comment. In D76534#1934943 , @rjmccall wrote: > Is the option issue causing the documentation to be wrong in any way, or does > it just produce a warning? If the latter, we could raise this issue with > them. I think it just produces a w

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, Bigcheese, rsmith, martong. Herald added subscribers: tschuett, arphaman, dexonsmith, rnkovacs. Herald added a project: clang. This patch implements matrix index expressions (matrix[RowIdx][ColumnIdx]). It does so by utilizing

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn added a reviewer: rjmccall. fhahn marked 2 inline comments as done. fhahn added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:647 + return false; +if (Mat1->getNumRows() != Mat2->getNumRows()) + return false; martong

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 252634. fhahn edited the summary of this revision. fhahn added a comment. Include columns in structural equi check, fixed type printing todo & rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72281/new/ http

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, Bigcheese, rsmith, martong. Herald added subscribers: tschuett, dexonsmith, rnkovacs. Herald added a project: clang. This patch implements the + and - binary operators for values of MatrixType. It adds support for matrix +/- mat

[PATCH] D72283: [Matrix] Add __builtin_matrix_insert to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. superseded by D76791 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72283/new/ https://reviews.llvm.org/D72283 __

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn created this revision. fhahn added reviewers: rjmccall, anemet, Bigcheese, rsmith, martong. Herald added subscribers: tschuett, dexonsmith, rnkovacs. Herald added a project: clang. This patch implements the * binary operator for values of MatrixType. It adds support for matrix * matrix, scal

[PATCH] D72774: [Matrix] Add __builtin_matrix_multiply to Clang (WIP).

fhahn added a comment. Superseded by D76794 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72774/new/ https://reviews.llvm.org/D72774 ___ cfe-commits m

[PATCH] D72785: [Matrix] Add __builtin_matrix_scalar_multiply to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. Superseded by D76794 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72785/new/ https://reviews.llvm.org/D72785 ___

[PATCH] D72772: [Matrix] Add __builtin_matrix_extract to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. superseded by D76791 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72772/new/ https://reviews.llvm.org/D72772 __

[PATCH] D72773: [Matrix] Add __builtin_matrix_{add,sub} to Clang (WIP).

fhahn abandoned this revision. fhahn added a comment. superseded by D76793 using operators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72773/new/ https://reviews.llvm.org/D72773 __

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 252995. fhahn added a comment. Update according to comments on cfe-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/docs/LanguageExtensions.rst clang

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

fhahn created this revision. fhahn added reviewers: thegameg, steven_wu. Herald added subscribers: cfe-commits, dang, dexonsmith, zzheng, hiraditya, inglorion. Herald added a project: clang. Currently -fno-unroll-loops is ignored when doing LTO on Darwin. This patch adds a new -lto-no-unroll-loop

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ce198d6ed37: [Darwin] Respect -fno-unroll-loops during LTO. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76916/new/ https://reviews.l

[PATCH] D77010: [OpenMP] set_bits iterator yields unsigned elements, no reference (NFC).

fhahn created this revision. fhahn added reviewers: jdoerfert, rnk. Herald added subscribers: llvm-commits, guansong, hiraditya. Herald added a project: LLVM. BitVector::set_bits() returns an iterator range yielding unsinged elements, which always will be copied while const & gives the impression

[PATCH] D77010: [OpenMP] set_bits iterator yields unsigned elements, no reference (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rG99913ef3d14f: [OpenMP] set_bits iterator yields unsigned elements, no reference (NFC). (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D770

[PATCH] D77058: [Clang] Add llvm.loop.unroll.disable to loops with -fno-unroll-loops.

fhahn created this revision. fhahn added reviewers: Meinersbur, hfinkel, dexonsmith, tejohnson. Herald added a subscriber: zzheng. Herald added a project: clang. Currently Clang does not respect -fno-unroll-loops during LTO. During D76916 it was suggested to respe

[PATCH] D76916: [Darwin] Respect -fno-unroll-loops during LTO.

fhahn marked an inline comment as done. fhahn added a comment. Thanks for taking a look @dexonsmith! In D76916#1947324 , @dexonsmith wrote: > @fhahn, please revert, this isn't how we usually pass options in LTO. Reverted in 7899a111ea1160e2ae0aae42de37b

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 254228. fhahn added a comment. Use placeholder type for incomplete matrix index expressions, as suggested by @rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76791/new/ https://reviews.llvm.org/D76791 Fi

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 254505. fhahn added a comment. Update arithmetic conversion rules after recent discussion on cfe-dev. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files: clang/docs/

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn updated this revision to Diff 254602. fhahn added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76794/new/ https://reviews.llvm.org/D76794 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 254598. fhahn added a comment. Implement conversions for matrix/scalar variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76793/new/ https://reviews.llvm.org/D76793 Files: clang/include/clang/Sema/Sema.h

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn updated this revision to Diff 254601. fhahn added a comment. Implement conversion for matrix/scalar variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76794/new/ https://reviews.llvm.org/D76794 Files: clang/include/clang/Sema/Sema.h

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

fhahn added inline comments. Comment at: clang/include/clang/AST/Type.h:3236 QualType ElementType; + unsigned NumElements; I think you could keep NumElements in VectorTypeBitfields (just remove the bit specifier), as the size of those bitfields can be up t

[PATCH] D77378: [Clang] Include size and maximum in vector size error message.

fhahn created this revision. fhahn added reviewers: hokein, sammccall, rnk. Herald added a project: clang. The error message for invalid vector sizes can be a bit more helpful by including the actual maximum. This should match the recently added suggestions for error messages in the coding standar

[PATCH] D77378: [Clang] Include size and maximum in vector size error message.

fhahn updated this revision to Diff 254744. fhahn added a comment. Fix wrong formatting of check lines.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77378/new/ https://reviews.llvm.org/D77378 Files: clang/include/clang/AST/Type.h clang/inclu

[PATCH] D72281: [Matrix] Add matrix type to Clang.

fhahn updated this revision to Diff 254746. fhahn marked an inline comment as done. fhahn added a comment. Use 20 bits in MatrixTypeBitfields for both number of rows and number of columns. This leaves 24 bits for NumTypeBits, while providing a large ranges for number of rows/columns. Repositor

[PATCH] D70779: AArch64: add support for newer Apple CPUs

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, but it might be good to wait with committing until next week, so people in the US have a chance to take a look as well. Comment at: clang/lib/Driver/ToolChains/Arch/AArc

[PATCH] D70779: AArch64: add support for newer Apple CPUs

fhahn added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143 MtuneLowerCase = llvm::sys::getHostCPUName(); - if (MtuneLowerCase == "cyclone") { + if (MtuneLowerCase == "cyclone" || MtuneLowerCase.find("apple") == 0) { Features.push_back("+

[PATCH] D71499: Add builtins for aligning and checking alignment of pointers and integers

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14323 +Result = Builder.CreateIntrinsic( +Intrinsic::ptrmask, {Args.SrcType, SrcForMask->getType(), Args.IntType}, +{SrcForMask, NegatedMask}, nullptr, "aligned_result"); ---

[PATCH] D72281: [Matrix] Add matrix type to Clang (WIP).

fhahn added subscribers: jwakely, jfb. fhahn added a comment. @jwakely it would be great if you could have a brief look at our recent proposal for matrix support in Clang and could let us know if you have any concerns? The original proposal is being discussed on cfe-dev (http://lists.llvm.org/p

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

fhahn added a comment. It looks like this may cause ASan failures http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/38749/steps/check-clang%20asan/logs/stdio It would be great if you could take a look and possibly revert the change if it takes some time to investigate. Repo

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fhahn added a comment. It looks like this patch (or the other related changes committed recently) may cause ASan failures running `Transforms/OpenMP/gtid.ll ` and `Transforms/OpenMP/parallel_deletion.ll` http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6960/consoleFull It would be

[PATCH] D73162: [test] Avoid loop-unroll.c test getting confused by fadd in git revision

fhahn added a comment. I think we could also just add a single match for something after the generated functions, to limit the scope of CHECK-NOT, e.g add something like `CHECK : !0 =` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73162/new/ htt

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

fhahn added a reviewer: rengolin. fhahn added a comment. Thanks for looking into this Eli! Adding the architecture version as target feature looks good to me. Comment at: lib/Basic/Targets/ARM.cpp:342 + // rely on the target triple. + switch (ArchKind) { + case llvm::ARM::A

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

fhahn added a comment. We also add thumb-mode to the target features, for a similar reason, allowing mixed Thumb/Arm codegen with LTO. Repository: rC Clang https://reviews.llvm.org/D45240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

fhahn added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:345 // get default FPU features + llvm::ARM::ArchKind Arch = llvm::ARM::parseArch(getTriple().getArchName()); unsigned FPUKind = llvm::ARM::getDefaultFPU(CPU, Arch); Is there a reason we re

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

fhahn accepted this revision. fhahn added a comment. Thanks for updating it to use the stuff from TargetParser. LGTM, with tests for the cases @joerg mentiond. Comment at: lib/Basic/Targets/ARM.cpp:345 // get default FPU features + llvm::ARM::ArchKind Arch = llvm::ARM::par

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

fhahn added a comment. Could you upload a diff with more context, as suggested in http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface? That would make it easier to review the patch. Repository: rL LLVM https://reviews.llvm.org/D39321 __

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! > The __builtin_align_{up,down} code generation could also make use of this > IIRC. I think the reason I didn't do this initially was concerns about > ptrmask not being optimized

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 502607. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitiz

[PATCH] D145151: clang: Handle MatrixType in hasFloatingRepresentation

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145151/new/ https://reviews.llvm.org/D145151 ___ cfe-commits mailing list cfe-co

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:643 + T __builtin_elementwise_exp(T x)returns the base-e exponential, or e^x, of the specified value floating point types + T __builtin_elementwise_exp2(T x) returns the base-2 exp

[PATCH] D145270: Add codegen for llvm exp/exp2 elementwise builtins

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145270/new/ https://reviews.llvm.org/D145270

[PATCH] D122573: [TBAA] Emit distinct TBAA tags for pointers with different depths,types.

fhahn added a comment. In D122573#4125641 , @bipmis wrote: > @fhahn We are also observing scenarios where this maybe necessary. A couple > of points on where it may be missing > > 1. createScalarTypeNode(OutName, AnyPtr, Size) -> This will generate > di

[PATCH] D151076: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

fhahn created this revision. fhahn added reviewers: rjmccall, aaron.ballman, efriedma. Herald added a subscriber: StephenFan. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is an infinite cycle i

[PATCH] D151061: [test] Add ext_vector_type tests for C

fhahn added a comment. Thanks for texting the test coverage! Comment at: clang/test/Sema/ext_vector_ops.c:30 +void test_int_vector_scalar(unsigned int ua, v2u v2ua) { + // Integer vector vs integer operators. These will splat + (void)(v2ua + ua); Not sure if

[PATCH] D146987: [Assignment Tracking] Enable by default

fhahn added a comment. Looks like this is causing a crash on current `main`: https://github.com/llvm/llvm-project/issues/62838 Please take a look and revert the commit if it requires longer to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146

[PATCH] D151061: [test] Add ext_vector_type tests for C

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151061/new/ https://reviews.llvm.org/D151061

[PATCH] D151059: [test] Add C++ ext_vector_type tests

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151059/new/ https://reviews.llvm.org/D151059

[PATCH] D151076: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0687b47a0ce: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151076/n

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

fhahn updated this revision to Diff 526163. fhahn added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32199/new/ https://reviews.llvm.org/D32199 Files: clang/include/clang/Basic/Features.def clang/include/clang/Basic/Sanitiz

[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jobnoorman. LGTM, thanks! Looks like a straight-forward extension of the existing builtins. Comment at: clang/test/Sema/aarch64-sve-vector-log-ops.c:

[PATCH] D148381: [WIP][Clang] Add element_count attribute

fhahn added reviewers: rapidsna, fcloutier. fhahn added a comment. Adding a few people who have been working on `-fbounds-safety` proposal (https://llvm.swoogo.com/2023eurollvm/session/1414468/keynote-“-fbounds-safety”-enforcing-bounds-safety-for-production-c-code) Repository: rG LLVM Github

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

fhahn resigned from this revision. fhahn added a comment. Sorry, I am not familiar at all with this code. Perhaps @shafik could suggest more appropriate reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148944/new/ https://reviews.llvm.org/D

[PATCH] D149006: [llvm][Support] Replace `%` operator with `&` in `Align::isAligned(...)`

fhahn added a comment. > it is easier to check reminder by conjunction with mask, which is (Pow2Value > - 1). Hmm, easier in what respect? Isn't the original code more straight-forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149006/new/ ht

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn added inline comments. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than x + T__builtin_elementwise_canonicalize(T x) return the platform specific canonical encoding of a floating-point number floati

[PATCH] D139640: clang: Add __builtin_elementwise canonicalize and copysign

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, but please make sure the `.rst` file builds with `sphinx`. Comment at: clang/docs/LanguageExtensions.rst:644 magnitude than

<    1   2   3   4   5   6   7   8   >