fhahn added a comment.
Thanks for the patch! I left a suggestion inline.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:16721
+bool Sema::SemaBuiltinElementwiseMathFloatArg(CallExpr *TheCall) {
+ if (checkArgCount(*this, TheCall, 1))
----------------
If I understand correctly, this is similar to
`SemaBuiltinElementwiseMathOneArg`, but with the additional restriction to only
allow floating point element types?
Do you think it would be possible to extend `SemaBuiltinElementwiseMathOneArg`
to handle this case directly, without needing to duplicate most of the other
logic?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114688/new/
https://reviews.llvm.org/D114688
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
