[PATCH] D48903: [VirtualFileSystem] InMemoryFileSystem::status: Return a Status with the requested name

eric_niebler added a comment. > It seems to me like the warning is valid, even though we use precompiled > headers. Agreed. Repository: rC Clang https://reviews.llvm.org/D48903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D39768: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

eric_niebler accepted this revision. eric_niebler added a comment. This revision is now accepted and ready to land. Looks ok to me. https://reviews.llvm.org/D39768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D7573: [libc++] Fix PR20084 - std::is_function failed.

eric_niebler added a comment. I just ran into this problem while trying to get range-v3 working on clang-3.6. This `is_function` implementation //probably// instantiates fewer templates than the version currently shipping with libc++. Disclaimer: I haven't tested it exhaustively yet. templat

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

eric_niebler added a comment. > Is this behavior specified somewhere? Or are we simply adding an extension to > Clang? It is not specified anywhere //yet// but Gor has promised a paper for Jacksonville. > If so I would really prefer to add my co_promise solution (but I need to > write a paper

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

eric_niebler added a subscriber: karies. eric_niebler added inline comments. Comment at: lib/Lex/PPDirectives.cpp:1983 + isLeadingSeparator = false; +else + Path.append(Component); What happens on Windows for an absolute path like "C:/he

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

eric_niebler added a comment. My question was more about whether the code is correct for absolute paths on Windows, not about whether this particular test would pass or fail. Have you tested an incorrectly-cased absolute path on a Windows machine? https://reviews.llvm.org/D3 ___

[PATCH] D30000: Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters

eric_niebler accepted this revision. eric_niebler added a comment. This revision is now accepted and ready to land. Nope looks good. https://reviews.llvm.org/D3 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D32263: Preprocessor: Suppress -Wnonportable-include-path for header maps

eric_niebler added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:401 + } + /// \brief Look up a subframework for the specified \#include file. Why not just add a `, bool *IsMapped = nullptr` parameter to the existing `LookupFile`? htt