eric_niebler added a subscriber: karies. eric_niebler added inline comments.
================ Comment at: lib/Lex/PPDirectives.cpp:1983 + isLeadingSeparator = false; + else + Path.append(Component); ---------------- What happens on Windows for an absolute path like "C:/hello/world.h", I wonder? Does this correctly generate the fixit? @karies? ================ Comment at: test/Lexer/case-insensitive-include-pr31836.sh:8 +// CHECK: warning: non-portable path to file +// CHECK-NOT: Ccase-insensitive-include-pr31836.h +// CHECK: {{$}} ---------------- @twoh I'm curious why you chose to check that the output was not a specific incorrect answer instead of checking that the output was the correct answer. https://reviews.llvm.org/D30000 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits