m.org:8080/green/job/clang-stage2-cmake-modulesRDA_build/4776/
>
> Cheers,
> Juergen
>
> On Tue, Mar 28, 2017 at 6:05 AM, Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: ioeric
> Date: Tue Mar 28 08:05:32 2017
> New Revision: 298913
>
I've sent an email to cfe-dev (and Tanya) about this. And this patch will
be abandoned since it doesn't fix anything.
On Sun, Jan 15, 2017 at 10:04 PM Aaron Ballman
wrote:
> On Sun, Jan 15, 2017 at 1:00 PM, Eric Liu via Phabricator
> wrote:
> > ioeric added a comment.
> >
> > In https://reviews
Hi all,
Sorry about the short notice, but I am about to push an upgrade for
Phabricator. The upgrade might take a while (<30 mins hopefully).
Thanks,
Eric
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Upgrade done. Phab is up again.
On Mon, Jan 16, 2017 at 9:36 PM Eric Liu wrote:
> Hi all,
>
> Sorry about the short notice, but I am about to push an upgrade for
> Phabricator. The upgrade might take a while (<30 mins hopefully).
>
> Thanks,
> Eric
>
_
Author: ioeric
Date: Thu Jan 26 09:08:44 2017
New Revision: 293182
URL: http://llvm.org/viewvc/llvm-project?rev=293182&view=rev
Log:
[change-namespace] add leading '::' to references in new namespace when name
conflict is possible.
Summary:
For example, when we change 'na' to "nb::nc", we need t
Author: ioeric
Date: Thu Jan 26 10:31:32 2017
New Revision: 293187
URL: http://llvm.org/viewvc/llvm-project?rev=293187&view=rev
Log:
[change-namespace] correctly shorten namespace when references have leading '::'
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://review
Author: ioeric
Date: Thu Feb 2 09:29:54 2017
New Revision: 293897
URL: http://llvm.org/viewvc/llvm-project?rev=293897&view=rev
Log:
[change-namespace] check using shadow decl correctly when shortening namespace
specifiers.
Summary:
This fixes mismatch between template decls and template special
Author: ioeric
Date: Thu Feb 2 11:40:38 2017
New Revision: 293909
URL: http://llvm.org/viewvc/llvm-project?rev=293909&view=rev
Log:
[change-namespace] fix unscoped enum constant references.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D29460
Modi
This is breaking build bots, and I am trying to fix it. Feel free to revert
the change if this blocks you.
On Thu, Feb 2, 2017 at 6:51 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Thu Feb 2 11:40:38 2017
> New Revision: 29390
Author: ioeric
Date: Thu Feb 2 13:46:12 2017
New Revision: 293927
URL: http://llvm.org/viewvc/llvm-project?rev=293927&view=rev
Log:
[change-namespace] trying to fix build bot failure caused by r293909.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
Modified: clang-to
r293927 should appease bots.
On Thu, Feb 2, 2017 at 7:59 PM Eric Liu wrote:
This is breaking build bots, and I am trying to fix it. Feel free to revert
the change if this blocks you.
On Thu, Feb 2, 2017 at 6:51 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
Author:
Author: ioeric
Date: Mon Jul 10 09:05:48 2017
New Revision: 307551
URL: http://llvm.org/viewvc/llvm-project?rev=307551&view=rev
Log:
Avoid white spaces in file names. NFC
Summary: White spaces in file names are causing Phabricator/SVN to crash.
Reviewers: bkramer
Subscribers: bogner, cfe-commit
Author: ioeric
Date: Wed Jan 17 09:37:11 2018
New Revision: 322691
URL: http://llvm.org/viewvc/llvm-project?rev=322691&view=rev
Log:
[Tooling] Don't deduplicate tool results in the All-TUs executor.
Summary:
As result deduplication or reduction is not supported in the framework,
we should leave t
Author: ioeric
Date: Wed Jan 17 10:27:41 2018
New Revision: 322722
URL: http://llvm.org/viewvc/llvm-project?rev=322722&view=rev
Log:
[clangd] Deduplicate symbols collected in global-symbol-builder tool.
Summary: After D42111, the executor framework no longer deduplicate tool
results.
Reviewers:
Author: ioeric
Date: Mon Jan 22 03:48:20 2018
New Revision: 323101
URL: http://llvm.org/viewvc/llvm-project?rev=323101&view=rev
Log:
[clangd] Add support for different file URI schemas.
Summary: I will replace the existing URI struct in Protocol.h with the new URI
and rename FileURI to URI in a
Author: ioeric
Date: Mon Jan 22 05:03:25 2018
New Revision: 323111
URL: http://llvm.org/viewvc/llvm-project?rev=323111&view=rev
Log:
[clangd] Try to fix build bot failue in r323101
Modified:
clang-tools-extra/trunk/unittests/clangd/URITests.cpp
Modified: clang-tools-extra/trunk/unittests/cla
Author: ioeric
Date: Fri Jan 26 03:10:32 2018
New Revision: 323517
URL: http://llvm.org/viewvc/llvm-project?rev=323517&view=rev
Log:
[Tooling] Test more APIs of ToolExecutor. NFC.
Modified:
cfe/trunk/unittests/Tooling/ExecutionTest.cpp
Modified: cfe/trunk/unittests/Tooling/ExecutionTest.cpp
Author: ioeric
Date: Mon Jan 29 05:21:23 2018
New Revision: 323647
URL: http://llvm.org/viewvc/llvm-project?rev=323647&view=rev
Log:
[Lexer] Support adding working directory to relative search dir for #include
shortening in HeaderSearch.
Reviewers: bkramer
Subscribers: mgorny, hintonda, cfe-com
Author: ioeric
Date: Mon Jan 29 07:13:29 2018
New Revision: 323658
URL: http://llvm.org/viewvc/llvm-project?rev=323658&view=rev
Log:
[clangd] Add a fallback directory for collected symbols with relative paths.
Reviewers: hokein, sammccall
Subscribers: klimek, ilya-biryukov, jkorous-apple, cfe-co
Author: ioeric
Date: Mon Jan 29 07:37:46 2018
New Revision: 323660
URL: http://llvm.org/viewvc/llvm-project?rev=323660&view=rev
Log:
[clangd] Use new URI with scheme support in place of the existing LSP URI
Summary:
o Replace the existing clangd::URI with a wrapper of FileURI which also
carries a
Author: ioeric
Date: Mon Jan 29 14:28:08 2018
New Revision: 323703
URL: http://llvm.org/viewvc/llvm-project?rev=323703&view=rev
Log:
[clangd] Fix r323658 test failure on windows.
Modified:
clang-tools-extra/trunk/unittests/clangd/SymbolCollectorTests.cpp
clang-tools-extra/trunk/unittests/
-windows10pro-fast
> . . .
> Failing Tests (1):
> Extra Tools Unit Tests ::
> clangd/./ClangdTests.exe/SymbolCollectorTest.SymbolRelativeWithFallback
>
> The builder was already red and did not send notifications on the changes.
> Please have a look?
>
> Thanks
>
>
> Ga
Author: ioeric
Date: Wed Jan 31 08:26:27 2018
New Revision: 323885
URL: http://llvm.org/viewvc/llvm-project?rev=323885&view=rev
Log:
[clangd] Add a test URI scheme for lit tests to unbreak platform-specific URI
failures.
Summary:
This should also fix the current windows buildbot breakage
(http:/
Author: ioeric
Date: Thu Feb 1 04:44:52 2018
New Revision: 323957
URL: http://llvm.org/viewvc/llvm-project?rev=323957&view=rev
Log:
[clangd] Fix URI scheme conflict and an unused variable warning in tests. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra
Author: ioeric
Date: Fri Feb 2 02:31:42 2018
New Revision: 324065
URL: http://llvm.org/viewvc/llvm-project?rev=324065&view=rev
Log:
[clangd] Skip inline namespace when collecting scopes for index symbols.
Summary:
Some STL symbols are defined in inline namespaces. For example,
```
namespace std
Author: ioeric
Date: Fri Feb 2 03:25:38 2018
New Revision: 324073
URL: http://llvm.org/viewvc/llvm-project?rev=324073&view=rev
Log:
[clangd] Remove a unused include. NFC
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified: clang-tools-extra/trunk/clangd/index/SymbolC
Author: ioeric
Date: Fri Feb 2 10:19:22 2018
New Revision: 324113
URL: http://llvm.org/viewvc/llvm-project?rev=324113&view=rev
Log:
[Tooling] Returns non-zero status code when files are skipped.
Reviewers: hokein, bkramer
Reviewed By: bkramer
Subscribers: bkramer, klimek, cfe-commits
Differen
Author: ioeric
Date: Mon Feb 13 11:24:14 2017
New Revision: 294969
URL: http://llvm.org/viewvc/llvm-project?rev=294969&view=rev
Log:
[change-namespace] add an option to dump changed files in YAML.
Reviewers: hokein
Reviewed By: hokein
Subscribers: fhahn, cfe-commits
Differential Revision: http
Author: ioeric
Date: Fri Feb 24 05:54:45 2017
New Revision: 296110
URL: http://llvm.org/viewvc/llvm-project?rev=296110&view=rev
Log:
[change-namepsace] make it possible to whitelist symbols so they don't get
updated.
Reviewers: hokein
Reviewed By: hokein
Subscribers: cfe-commits
Differential
Author: ioeric
Date: Fri Feb 24 06:56:51 2017
New Revision: 296113
URL: http://llvm.org/viewvc/llvm-project?rev=296113&view=rev
Log:
[change-namespace] fix asan failure in r296110.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-tools-extra/tr
> Clang Tools :: change-namespace/white-list.cpp
>
>
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/6153/steps/test/logs/stdio
>
> Please have a look.
>
> Thanks
>
>
> Galina
>
>
> On Fri, Feb 24, 2017 at 3:54
Author: ioeric
Date: Tue Feb 28 04:00:15 2017
New Revision: 296458
URL: http://llvm.org/viewvc/llvm-project?rev=296458&view=rev
Log:
[change-namespace] trying to fix windows buildbot failure.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-too
ro-fast/builds/6153/steps/test/logs/stdio
>
> Please have a look.
>
> Thanks
>
>
> Galina
>
>
> On Fri, Feb 24, 2017 at 3:54 AM, Eric Liu via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: ioeric
> Date: Fri Feb 24 05:54:45 2017
> New Re
Author: ioeric
Date: Wed Mar 1 04:29:39 2017
New Revision: 296604
URL: http://llvm.org/viewvc/llvm-project?rev=296604&view=rev
Log:
[change-namespace] get insertion points of forward declarations correct.
Summary:
Previously, the insertion points would conflict with the old namespace
deletion.
Author: ioeric
Date: Wed Mar 1 07:14:01 2017
New Revision: 296616
URL: http://llvm.org/viewvc/llvm-project?rev=296616&view=rev
Log:
Introducing clang::tooling::AtomicChange for refactoring tools.
Summary:
An AtomicChange is used to create and group a set of source edits, e.g.
replacements or hea
Author: ioeric
Date: Wed Mar 8 09:53:10 2017
New Revision: 297289
URL: http://llvm.org/viewvc/llvm-project?rev=297289&view=rev
Log:
Add missing implementation for AtomicChange::replace(...)
Summary: Just realized the implementation is missing...
Reviewers: klimek
Reviewed By: klimek
Subscribe
This revision was automatically updated to reflect the committed changes.
ioeric marked an inline comment as done.
Closed by commit rL286873: [change-namespace] consider typedef/using alias
decls in the moved namespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26
ioeric added a comment.
Test comment.
Repository:
rL LLVM
https://reviews.llvm.org/D26592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added a comment.
Test comment to check if cfe-commits is in the email cc list
https://reviews.llvm.org/D26637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Tue Nov 15 13:05:40 2016
New Revision: 287008
URL: http://llvm.org/viewvc/llvm-project?rev=287008&view=rev
Log:
Add comments on how to print error retuned by tooling::Replacements::add().
Modified:
cfe/trunk/include/clang/Tooling/Core/Replacement.h
Modified: cfe/trunk/in
ioeric updated this revision to Diff 78148.
ioeric added a comment.
- Don't fix base class initializers at all.
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-names
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:414
+ Optional> InMovedSymbolNames;
for (StringRef ClassName : Spec.Names) {
llvm::StringRef GlobalClassName = ClassName.trim().ltrim(':');
s/ClassName/SymbolName/
Comm
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg with two nits.
Comment at: clang-move/ClangMove.cpp:145
+ void run(const MatchFinder::MatchResult &Result) override {
+auto *SM = &Result.Context->getSourceManager();
ioeric updated this revision to Diff 78180.
ioeric added a comment.
- Minor fix
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
I
ioeric updated this revision to Diff 78183.
ioeric marked 8 inline comments as done.
ioeric added a comment.
- Addressed comments.
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests
ioeric updated this revision to Diff 78188.
ioeric added a comment.
- Add lambda-function.cpp test back.
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-namespace/Ch
ioeric updated this revision to Diff 78190.
ioeric added a comment.
- nits
https://reviews.llvm.org/D26637
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
test/change-namespace/lambda-function.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index:
Author: ioeric
Date: Wed Nov 16 10:54:53 2016
New Revision: 287118
URL: http://llvm.org/viewvc/llvm-project?rev=287118&view=rev
Log:
[change-namespace] handle constructor initializer: Derived : Base::Base() {}
and added conflict detections
Summary:
namespace nx { namespace ny { class Base { publ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287118: [change-namespace] handle constructor initializer:
Derived : Base::Base() {}… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26637?vs=78190&id=78201#toc
Repository:
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
bkramer wrote:
> hokein wrote:
> > I have a concern that
ioeric added inline comments.
Comment at: include-fixer/IncludeFixer.cpp:136
+
+auto Begin = StartOfFile.getLocWithOffset(Placed.getOffset());
+auto End = Begin.getLocWithOffset(Placed.getLength());
hokein wrote:
> ioeric wrote:
> > bkramer wrote:
> > > h
ioeric added inline comments.
Comment at: test/clang-move/move-multiple-classes.cpp:21
// CHECK-OLD-TEST-CPP: #include "{{.*}}multiple_class_test.h"
+// CHECK-OLD-TEST-CPP: using a::Move1;
+// CHECK-OLD-TEST-CPP: using namespace a;
Would there be empty lines bet
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D26844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric created this revision.
ioeric added reviewers: klimek, djasper, bkramer.
ioeric added a subscriber: cfe-commits.
The new error information contains the type of error (e.g. overlap or bad file
path)
and the replacement(s) that is causing the error. This enables us to resolve
some errors.
F
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This avoid inserting/deleting #include into/from:
- raw string literals containing #include.
- #if block.
- Special #include among declarations (e.g. function
ioeric added a comment.
@djasper This is not very urgent. Feel free to leave it until you are back from
vacation :)
https://reviews.llvm.org/D26909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
ioeric updated this revision to Diff 78733.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D26853
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
ioeric added a comment.
Thanks for the review!
https://reviews.llvm.org/D26853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:309
+ llvm::StringRef FileName, bool IsHeader = false,
+ StringRef OldHeaderInclude = "") {
std::string NewCode;
How do you handle the case w
Author: ioeric
Date: Tue Nov 22 07:46:42 2016
New Revision: 287639
URL: http://llvm.org/viewvc/llvm-project?rev=287639&view=rev
Log:
Make llvm::Error generated from replacement interfaces more specific.
Summary:
The new error information contains the type of error (e.g. overlap or bad file
path)
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287639: Make llvm::Error generated from replacement
interfaces more specific. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D26853?vs=78733&id=78861#toc
Repository:
rL LLVM
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:604
+ // Post process of cleanup around all the replacements.
+ for (auto& It: FileToReplacements) {
+StringRef FilePath = It.first;
Maybe call this `FileAndReplacements` instead of `It`, wh
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg.
Comment at: unittests/clang-move/ClangMoveTests.cpp:424
+ const char TestHeader[] = "class A {};\n"
+ "class B {};\n";
+ const char Test
ioeric created this revision.
ioeric added a reviewer: klimek.
ioeric added subscribers: djasper, cfe-commits.
Herald added a subscriber: mgorny.
An edit list is used to create and group a set of source edits, e.g.
replacements or header insertions. Edits in an EditList should be related,
e.g. rep
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Do not submit!
https://reviews.llvm.org/D27058
Files:
include/clang/Tooling/Refactoring/EditList.h
lib/Tooling/Refactoring/EditList.cpp
unittests/Tooli
ioeric added inline comments.
Comment at: clang-move/ClangMove.h:90
+
+// When moving all declarations in old header, all code in old.h/cc will be
+// moved.
Is this the right place for this comment? Seems a bit unexpected.
Comment at: unittest
ioeric added a comment.
LG with a nit.
Comment at: clang-move/tool/ClangMoveMain.cpp:155
+ // Don't print trailing "," at the end of last element.
+ if (DeclPair != *(--Declarations.end()))
+llvm::outs() << ",\n";
This check is run in each ite
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
For example, this case was missed when looking for different but canonical
namespaces. UseContext in this case should be considered as in the canonical
namespa
ioeric added a comment.
Test email sender.
https://reviews.llvm.org/D27125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Fri Nov 25 06:39:03 2016
New Revision: 287924
URL: http://llvm.org/viewvc/llvm-project?rev=287924&view=rev
Log:
Consider nested namespaces in the canonical namespace as canonical as well.
Summary:
For example, this case was missed when looking for different but canonical
name
Author: ioeric
Date: Fri Nov 25 10:02:49 2016
New Revision: 287929
URL: http://llvm.org/viewvc/llvm-project?rev=287929&view=rev
Log:
Do not do raw name replacement when FromDecl is a class forward-declaration.
Summary:
If the `FromDecl` is a class forward declaration, the reference is
still consi
Hi all,
Emails from Phabricator are now sent with "senders" as:
via Phabricator
Previously, Phabricator sent emails on behalf of users using their email
addresses, which has caused DMARC failure for some mail service providers
(e.g. gmail, yahoo). Some of your emails might have been marked
Author: ioeric
Date: Tue Nov 29 08:15:14 2016
New Revision: 288139
URL: http://llvm.org/viewvc/llvm-project?rev=288139&view=rev
Log:
[change-namespace] fix non-calling function references.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D27208
Modifie
Author: ioeric
Date: Thu Dec 1 11:25:55 2016
New Revision: 288376
URL: http://llvm.org/viewvc/llvm-project?rev=288376&view=rev
Log:
[change-namespace] don't generate replacements for files that don't match file
pattern.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https:/
Author: ioeric
Date: Fri Dec 2 05:01:43 2016
New Revision: 288493
URL: http://llvm.org/viewvc/llvm-project?rev=288493&view=rev
Log:
[ClangFormat] Only insert #include into the #include block in the beginning of
the file.
Summary:
This avoid inserting #include into:
- raw string literals contain
Author: ioeric
Date: Fri Dec 2 05:23:07 2016
New Revision: 288495
URL: http://llvm.org/viewvc/llvm-project?rev=288495&view=rev
Log:
Fix a buildbot failure in include-fixer.
Modified:
clang-tools-extra/trunk/unittests/include-fixer/IncludeFixerTest.cpp
Modified: clang-tools-extra/trunk/unitt
Author: ioeric
Date: Sat Dec 3 09:28:03 2016
New Revision: 288586
URL: http://llvm.org/viewvc/llvm-project?rev=288586&view=rev
Log:
[clang-move] don't miss ',' in json output when there are duplicate elements.
Modified:
clang-tools-extra/trunk/clang-move/tool/ClangMoveMain.cpp
Modified: cla
Author: ioeric
Date: Mon Dec 5 05:17:04 2016
New Revision: 288662
URL: http://llvm.org/viewvc/llvm-project?rev=288662&view=rev
Log:
[change-namespace] get changing namespace to global correct.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
clang-tools-extra/trunk/
Author: ioeric
Date: Tue Dec 6 04:12:23 2016
New Revision: 288791
URL: http://llvm.org/viewvc/llvm-project?rev=288791&view=rev
Log:
[clang-move] ignore unsupported symbol kinds when checking if all symbols are
moved.
Modified:
clang-tools-extra/trunk/clang-move/ClangMove.cpp
clang-tools
Author: ioeric
Date: Wed Dec 7 08:20:52 2016
New Revision: 288908
URL: http://llvm.org/viewvc/llvm-project?rev=288908&view=rev
Log:
[change-namespace] move template class forward-declarations and don't move
fwd-decls in classes.
Summary:
Forward declarations in moved namespaces should be moved
Author: ioeric
Date: Wed Dec 7 11:04:07 2016
New Revision: 288919
URL: http://llvm.org/viewvc/llvm-project?rev=288919&view=rev
Log:
[change-namespace] don't fix using shadow decls in classes.
Summary:
Using shadow declarations in classes always refers to base class, which does not
need to be fix
Author: ioeric
Date: Wed Dec 7 14:08:02 2016
New Revision: 288969
URL: http://llvm.org/viewvc/llvm-project?rev=288969&view=rev
Log:
[change-namespace] always add a '::' prefix when a symbol reference needs to be
fully-qualified.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNames
Author: ioeric
Date: Fri Dec 9 05:45:50 2016
New Revision: 289203
URL: http://llvm.org/viewvc/llvm-project?rev=289203&view=rev
Log:
[clang-format] calculate MaxInsertOffset in the original code correctly.
Reviewers: djasper
Subscribers: klimek, cfe-commits
Differential Revision: https://review
Author: ioeric
Date: Thu May 4 07:05:40 2017
New Revision: 302141
URL: http://llvm.org/viewvc/llvm-project?rev=302141&view=rev
Log:
Revert "IR: Use pointers instead of GUIDs to represent edges in the module
summary. NFCI."
This reverts commit r302108.
Modified:
cfe/trunk/lib/CodeGen/Backen
Author: ioeric
Date: Wed May 10 02:48:45 2017
New Revision: 302624
URL: http://llvm.org/viewvc/llvm-project?rev=302624&view=rev
Log:
Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks
Summary: This is the first change as part of developing a clang-query based
search and r
clang-apply-replacements has some legacy code and needs some refactoring in
order to take advantage of the cleanup feature (because of the new
tooling::Replacements implementation). I had a plan to refactor it but
thought it was a low priority since most refactoring tools are using
replacements app
Author: ioeric
Date: Wed Oct 19 03:19:46 2016
New Revision: 284573
URL: http://llvm.org/viewvc/llvm-project?rev=284573&view=rev
Log:
[clang-format] Add comment manipulation header
Summary:
Introduces a separate target for comment manipulation.
Currently, comment manipulation is in BreakableCommen
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:356
Finder->addMatcher(
- namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
-inAnonymousNamespace)
- .bind("decls_in_anonymous_ns"),
+ usingDecl(InOldCC,
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
Comment at: clang-move/ClangMove.cpp:372
+ // Match static functions/variabale definitions which are defined in named
+ // spaces.
+ auto IsOldCCStaticDefinition =
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
when replacing symbol references in moved namespaces, trying to make the replace
name as short as possible by considering UsingDecl (i.e. UsingShadow) and
UsingDirectiveDecl (i.e. using namespace
ioeric abandoned this revision.
ioeric added a comment.
Thanks all!
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
hokein wrote:
> Yeah, it
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
ioeric wrote:
> hokein wr
ioeric updated this revision to Diff 75280.
ioeric added a comment.
- Ignore using decls in old ns but not the inner-most old ns.
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.
ioeric added a comment.
Still missing one case... working on a fix.
https://reviews.llvm.org/D25771
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 75281.
ioeric added a comment.
- Add a missing test case.
https://reviews.llvm.org/D25771
Files:
change-namespace/ChangeNamespace.cpp
change-namespace/ChangeNamespace.h
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namesp
ioeric marked 3 inline comments as done.
ioeric added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:566
+ break;
+if (isDeclVisibleAtLocation(*Result.SourceManager, Using, DeclCtx, Start))
{
+ for (const auto *UsingShadow : Using->shadows()) {
-
ioeric accepted this revision.
ioeric added inline comments.
Comment at: test/clang-tidy/modernize-use-default-copy.cpp:85
+ // CHECK-MESSAGES: :[[@LINE-2]]:3: warning: use '= default'
+ // CHECK-FIXES: /* don't delete */ = default;
int Field;
malcolm.parso
Author: ioeric
Date: Mon Oct 31 03:28:29 2016
New Revision: 285549
URL: http://llvm.org/viewvc/llvm-project?rev=285549&view=rev
Log:
[change-namespace] fix namespace specifiers of template arguments.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
clang-tools-extra/
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The current version does not deduplicate equivalent file paths correctly.
For example, a relative path and an absolute path are considered inequivalent.
Compar
501 - 600 of 970 matches
Mail list logo
