ioeric added a comment. LG with a nit.
================ Comment at: clang-move/tool/ClangMoveMain.cpp:155 + // Don't print trailing "," at the end of last element. + if (DeclPair != *(--Declarations.end())) + llvm::outs() << ",\n"; ---------------- This check is run in each iteration... maybe just loop from `begin()` to `end()-1` and special casing the last element, in which case you don't need to check in each run. https://reviews.llvm.org/D27059 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
