Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

Sure. That sounds great. Thanks! On Wed, Feb 26, 2020 at 10:45 AM Sanjay Patel wrote: > To be clear - the test is checking IR instructions, but it's checking -O1 > IR for various targets. > So there must be different expectations per target... > But I just tried a test of turning everything down

[clang] 30e7ee3 - Temporarily Revert "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

Author: Eric Christopher Date: 2019-11-18T10:46:48-08:00 New Revision: 30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 URL: https://github.com/llvm/llvm-project/commit/30e7ee3c4bac4a12ea584a879aa320bd4e035cc2 DIFF: https://github.com/llvm/llvm-project/commit/30e7ee3c4bac4a12ea584a879aa320bd4e035cc2.di

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

Hi All, I've gone ahead and temporarily reverted here: echristo@jhereg ~/s/llvm-project> git push To github.com:llvm/llvm-project.git a77b66a0562..30e7ee3c4ba master -> master and we can just reapply when the issues are fixed. Thanks :) -eric On Mon, Nov 18, 2019 at 6:58 AM Melanie Blower

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

No, it's just the bug that Jorge found. I understand it might have highlighted an existing bug, but reverting back to clean is the best bet here and then we can recommit when we get the latent bug fixed :) On Mon, Nov 18, 2019 at 11:08 AM Melanie Blower via Phabricator wrote: > > mibintc added a

Re: [PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

The C bindings, in general, don't have stability guarantees outside of a few cases. Whitequark owns all of this now though :) -eric On Tue, Nov 19, 2019 at 1:38 PM Adrian Prantl via Phabricator wrote: > > aprantl added a subscriber: echristo. > aprantl added a comment. > > In D70111#1752215

[clang-tools-extra] e807569 - Fix an unused variable warning where a variable was only used in an assert.

Author: Eric Christopher Date: 2019-11-25T15:29:33-08:00 New Revision: e8075692589dc1274585bd7445f3e3b830b96c69 URL: https://github.com/llvm/llvm-project/commit/e8075692589dc1274585bd7445f3e3b830b96c69 DIFF: https://github.com/llvm/llvm-project/commit/e8075692589dc1274585bd7445f3e3b830b96c69.di

[clang] 8ff85ed - As a follow-up to my initial mail to llvm-dev here's a first pass at the O1 described there.

Author: Eric Christopher Date: 2019-11-25T17:16:46-08:00 New Revision: 8ff85ed905a7306977d07a5cd67ab4d5a56fafb4 URL: https://github.com/llvm/llvm-project/commit/8ff85ed905a7306977d07a5cd67ab4d5a56fafb4 DIFF: https://github.com/llvm/llvm-project/commit/8ff85ed905a7306977d07a5cd67ab4d5a56fafb4.di

Re: [PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

Usually nice to give a link if there is one :) On Mon, Nov 25, 2019, 8:42 PM Muhammad Omair Javaid via Phabricator < revi...@reviews.llvm.org> wrote: > omjavaid reopened this revision. > omjavaid added a comment. > This revision is now accepted and ready to land. > > Re-opening this because I hav

Re: [PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

Aha, found it in the revert. Bunch of tests use -O1 and probably have something specific in O1 they wanted. -eric On Mon, Nov 25, 2019 at 8:55 PM Eric Christopher wrote: > > Usually nice to give a link if there is one :) > > On Mon, Nov 25, 2019, 8:42 PM Muhammad Omair Javaid via Phabricator >

[clang] 9c6b7f6 - Revert "[ARM][MVE] Add intrinsics for immediate shifts."

Author: Eric Christopher Date: 2019-12-09T16:47:38-08:00 New Revision: 9c6b7f68b807250e7c3aa01938339fdbd239c4ea URL: https://github.com/llvm/llvm-project/commit/9c6b7f68b807250e7c3aa01938339fdbd239c4ea DIFF: https://github.com/llvm/llvm-project/commit/9c6b7f68b807250e7c3aa01938339fdbd239c4ea.di

[clang-tools-extra] 52b1c94 - Turn off unused variable checking here since we're explicitly adding

Author: Eric Christopher Date: 2019-12-09T19:14:04-08:00 New Revision: 52b1c94a5fe47c8bb5e189bc40bfd50255ce5795 URL: https://github.com/llvm/llvm-project/commit/52b1c94a5fe47c8bb5e189bc40bfd50255ce5795 DIFF: https://github.com/llvm/llvm-project/commit/52b1c94a5fe47c8bb5e189bc40bfd50255ce5795.di

Re: [clang] d82b6ba - Revert "[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified."

You don't need to revert for a missing differential revision, just close the revision yourself :) -eric On Tue, Dec 10, 2019 at 11:51 AM Sourabh Singh Tomar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sourabh Singh Tomar > Date: 2019-12-11T01:20:40+05:30 > New Revision: d82b

[clang] f4a7d56 - Remove debugging printf and reformat code.

Author: Eric Christopher Date: 2019-12-10T15:04:45-08:00 New Revision: f4a7d5659df7cb56c1baa34a39e9fe2639472741 URL: https://github.com/llvm/llvm-project/commit/f4a7d5659df7cb56c1baa34a39e9fe2639472741 DIFF: https://github.com/llvm/llvm-project/commit/f4a7d5659df7cb56c1baa34a39e9fe2639472741.di

Re: [clang] 7f9b513 - Reapply af57dbf12e54 "Add support for options -frounding-math, ftrapping-math, -ffp-model=, and -ffp-exception-behavior="

So you left some debugging code in that I've fixed thusly: "Enclosing function uses fp intrinsics" commit f4a7d5659df7cb56c1baa34a39e9fe2639472741 Author: Eric Christopher Date: Tue Dec 10 15:02:29 2019 -0800 Remove debugging printf and reformat code. On Thu, Dec 5, 2019 at 3:48 AM Melan

[clang] 259a9b1 - Update line number after previous patch added an additional unsupported

Author: Eric Christopher Date: 2019-12-12T14:45:05-08:00 New Revision: 259a9b1039093a1d036c1e6efcae699873f93ba5 URL: https://github.com/llvm/llvm-project/commit/259a9b1039093a1d036c1e6efcae699873f93ba5 DIFF: https://github.com/llvm/llvm-project/commit/259a9b1039093a1d036c1e6efcae699873f93ba5.di

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

As a quick note, this broke the test because you didn't update the line numbers in the checks. Fixed thusly: echristo@athyra ~/r/llvm-project> git push To github.com:llvm/llvm-project.git 6bed43f3c40..259a9b10390 master -> master :) -eric On Thu, Dec 12, 2019 at 12:25 PM Petr Hosek via Pha

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

No worries, it happens. On Thu, Dec 12, 2019, 10:59 PM Michał Górny wrote: > On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > > As a quick note, this broke the test because you didn't update the line > > numbers in the checks. > > > > Fixed thusly: > > > > echristo@athyra ~/r/llvm-pr

[clang-tools-extra] 5623bd5 - Fix -Wswitch-coverage warning in clang-tidy after ak_addrspace introduction.

Author: Eric Christopher Date: 2019-12-13T12:57:48-08:00 New Revision: 5623bd52acd34db2e9cfc11d1510407610a14db0 URL: https://github.com/llvm/llvm-project/commit/5623bd52acd34db2e9cfc11d1510407610a14db0 DIFF: https://github.com/llvm/llvm-project/commit/5623bd52acd34db2e9cfc11d1510407610a14db0.di

Re: [PATCH] D71486: [clang-tools-extra] Fix switch coverage warning

On Fri, Dec 13, 2019 at 1:18 PM Dávid Bolvanský via Phabricator < revi...@reviews.llvm.org> wrote: > xbolva00 added a comment. > > In D71486#1784079 , @sammccall > wrote: > > > It should be possible to test this by adapting a test case from the > original e

[clang] 2369560 - Fix -Wunused-lambda-capture warnings.

Author: Eric Christopher Date: 2019-12-26T15:27:21-08:00 New Revision: 2369560f4a7720b19edfbf9de14ef061307ff773 URL: https://github.com/llvm/llvm-project/commit/2369560f4a7720b19edfbf9de14ef061307ff773 DIFF: https://github.com/llvm/llvm-project/commit/2369560f4a7720b19edfbf9de14ef061307ff773.di

Re: [PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

You can sign up for an account by emailing the admin account. On Thu, Dec 26, 2019, 5:04 PM Anton Yudintsev via Phabricator < revi...@reviews.llvm.org> wrote: > AntonYudintsev added a comment. > > I have found bug in clang-cl (win32 clang), related to recent inroduction > of ffp-exception-behavio

r329001 - Temporarily revert r328404:

Author: echristo Date: Mon Apr 2 11:33:47 2018 New Revision: 329001 URL: http://llvm.org/viewvc/llvm-project?rev=329001&view=rev Log: Temporarily revert r328404: commit 519b97132a4c960e8dedbfe4290d86970d92e995 Author: Richard Trieu Date: Sat Mar 24 00:52:44 2018 + [ODRHash] Support p

r318371 - Add NDEBUG checks around LLVM_DUMP_METHOD functions for Wunused-function warnings.

Author: echristo Date: Wed Nov 15 19:18:09 2017 New Revision: 318371 URL: http://llvm.org/viewvc/llvm-project?rev=318371&view=rev Log: Add NDEBUG checks around LLVM_DUMP_METHOD functions for Wunused-function warnings. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp

Re: r291123 - CodeGen: plumb header search down to the IAS

Hi Saleem, Love that you wanted to add a test for it, but I'd really prefer that you not engage the backend here in order to do it. You can verify some of it from the backend and just that the module is correct via the front end if you'd like. Ensuring the paths are correct is a bit of a sticky pr

Re: r291123 - CodeGen: plumb header search down to the IAS

Ok, thanks. I agree that it's a problem. I'm definitely open for testing ideas here. There are a few other things in the TargetOptions/MCTargetOptions area that are already problematic to test. -eric On Thu, Jan 5, 2017 at 6:27 PM Saleem Abdulrasool wrote: > This was certainly the problem that

Re: r291123 - CodeGen: plumb header search down to the IAS

Thanks! -eric On Thu, Jan 5, 2017 at 6:38 PM Saleem Abdulrasool wrote: > SVN r291208 > > On Thu, Jan 5, 2017 at 6:30 PM, Eric Christopher > wrote: > > Ok, thanks. I agree that it's a problem. I'm definitely open for testing > ideas here. There are a few other things in the > TargetOptions/MCTa

Re: r291123 - CodeGen: plumb header search down to the IAS

On Fri, Jan 6, 2017 at 5:56 AM Hal Finkel wrote: > > On 01/05/2017 08:30 PM, Eric Christopher via cfe-commits wrote: > > Ok, thanks. I agree that it's a problem. I'm definitely open for testing > ideas here. There are a few other things in the > TargetOptions/M

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

echristo added a subscriber: echristo. echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This revision is now accepted and ready to land. LGTM. Might want to fix the braces while you're there. -eric https://reviews.llvm.org/D23531 __

r297917 - Fix up testcase to:

Author: echristo Date: Wed Mar 15 18:41:58 2017 New Revision: 297917 URL: http://llvm.org/viewvc/llvm-project?rev=297917&view=rev Log: Fix up testcase to: a) avoid actually compiling anything b) avoid depositing files in the test directory c) use a check line to make sure that we're looking for t

Re: r297890 - enable -save-temps with -finclude-defult-header

Hi Guansong, So this wasn't quite the right way to write this testcase. You really wanted a CHECK/CHECK-NOT line along with the actual commands. You also didn't want to (as you noticed later) depend on full compilation. You can check for this sort of thing in the future by using the -### command l

r298006 - Add a small test for __STRUCT_PARM_ALIGN__ for ppc64 darwin.

Author: echristo Date: Thu Mar 16 17:31:07 2017 New Revision: 298006 URL: http://llvm.org/viewvc/llvm-project?rev=298006&view=rev Log: Add a small test for __STRUCT_PARM_ALIGN__ for ppc64 darwin. Modified: cfe/trunk/test/Preprocessor/init.c Modified: cfe/trunk/test/Preprocessor/init.c URL:

Re: r295156 - Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce.

ric Christopher wrote: > The PPC one should inherit from this. You're right I should have tested it > though. Mostly ppc Darwin isn't well supported. > > On Wed, Feb 15, 2017, 12:06 AM Tim Shen wrote: > > On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-co

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

On Thu, Mar 16, 2017 at 5:37 PM Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added a comment. > > In https://reviews.llvm.org/D30415#703398, @echristo wrote: > > > Different suggestion: > > > > Remove the faltivec option. Even gcc doesn't support it anymore afaict. > > >

r298022 - Remove setting LessPreciseFPMADOption on the TargetOption as it's

Author: echristo Date: Thu Mar 16 19:37:53 2017 New Revision: 298022 URL: http://llvm.org/viewvc/llvm-project?rev=298022&view=rev Log: Remove setting LessPreciseFPMADOption on the TargetOption as it's unused anywhere in llvm. Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trun

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

On Thu, Mar 16, 2017 at 5:45 PM Hal Finkel wrote: > > On 03/16/2017 07:40 PM, Eric Christopher wrote: > > > > On Thu, Mar 16, 2017 at 5:37 PM Hal Finkel via Phabricator < > revi...@reviews.llvm.org> wrote: > > hfinkel added a comment. > > In https://reviews.llvm.org/D30415#703398, @echristo wrote

Re: r298027 - [Serialization] Follow-up to r297972, deserialize name/loc in separate statements to make sure they deserialize in defined order.

Also gcc bots fwiw :) -eric On Thu, Mar 16, 2017 at 6:01 PM Argyrios Kyrtzidis via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: akirtzidis > Date: Thu Mar 16 19:49:42 2017 > New Revision: 298027 > > URL: http://llvm.org/viewvc/llvm-project?rev=298027&view=rev > Log: > [Serializatio

Re: r298027 - [Serialization] Follow-up to r297972, deserialize name/loc in separate statements to make sure they deserialize in defined order.

;) On Thu, Mar 16, 2017 at 7:13 PM Argyrios Kyrtzidis wrote: > *b* at the gcc bots, those are the worst… :-P > > On Mar 16, 2017, at 6:39 PM, Eric Christopher wrote: > > Also gcc bots fwiw :) > > -eric > > On Thu, Mar 16, 2017 at 6:01 PM Argyrios Kyrtzidis via cfe-commits < > cfe-commits@li

Re: [PATCH] D30415: Fix -mno-altivec cannot overwrite -maltivec option

Great, thanks! Can you make this change instead Sean? :) -eric On Thu, Mar 16, 2017 at 7:20 PM Hal Finkel wrote: > > On 03/16/2017 08:11 PM, Eric Christopher wrote: > > > > On Thu, Mar 16, 2017 at 5:45 PM Hal Finkel wrote: > > > On 03/16/2017 07:40 PM, Eric Christopher wrote: > > > > On Thu, M

r298307 - Turn on HTM on power8 and later (including powerpc64le) since it's

Author: echristo Date: Mon Mar 20 16:12:53 2017 New Revision: 298307 URL: http://llvm.org/viewvc/llvm-project?rev=298307&view=rev Log: Turn on HTM on power8 and later (including powerpc64le) since it's available by default on those cpus and configurations. Modified: cfe/trunk/lib/Basic/Target

r298318 - Fix parsing of htmxlintrin.h in C++ mode

Author: echristo Date: Mon Mar 20 17:31:33 2017 New Revision: 298318 URL: http://llvm.org/viewvc/llvm-project?rev=298318&view=rev Log: Fix parsing of htmxlintrin.h in C++ mode - Fix a variable naming mismatch - Fix gcc extension pointer arithmetic on void to cast to char *. - Test that the head

r298449 - Remove the -faltivec alias option and replace it with -maltivec everywhere.

Author: echristo Date: Tue Mar 21 17:06:18 2017 New Revision: 298449 URL: http://llvm.org/viewvc/llvm-project?rev=298449&view=rev Log: Remove the -faltivec alias option and replace it with -maltivec everywhere. The alias was only ever used on darwin and had some issues there, and isn't used in pra

Re: [PATCH] D30760: Record command lines in objects built by clang

I think that's a good idea. On Tue, Mar 21, 2017 at 5:19 PM Adrian Prantl via Phabricator < revi...@reviews.llvm.org> wrote: > aprantl added a comment. > > Sorry for being late to the party, but have you looked at > CodeGenOptions::DwarfDebugFlags? It looks like it almost does what you > want, bu

r298487 - Move setting of LangOpts based on target flags out of CompilerInstance

Author: echristo Date: Wed Mar 22 01:36:09 2017 New Revision: 298487 URL: http://llvm.org/viewvc/llvm-project?rev=298487&view=rev Log: Move setting of LangOpts based on target flags out of CompilerInstance and into TargetInfo::adjust so that it gets called in more places throughout the compiler (A

Re: [PATCH] D30760: Record command lines in objects built by clang, Clang part

Not sure, that's why I asked. Is it useful? Is it one of those things we want to remove since it'll be common among all of the TUs that want the text? On Fri, Mar 24, 2017 at 3:43 PM Zhizhou Yang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Sure I can add some more tests here. > > For -

r298759 - Add preprocessor defines for a bare powerpc64le triple/cpu.

Author: echristo Date: Fri Mar 24 21:29:18 2017 New Revision: 298759 URL: http://llvm.org/viewvc/llvm-project?rev=298759&view=rev Log: Add preprocessor defines for a bare powerpc64le triple/cpu. The le triple didn't exist until power8, so use that as a default (this also matches what gcc does). M

r298761 - __BIGGEST_ALIGNMENT__ has always been 16 on all power platforms rather

Author: echristo Date: Fri Mar 24 21:55:21 2017 New Revision: 298761 URL: http://llvm.org/viewvc/llvm-project?rev=298761&view=rev Log: __BIGGEST_ALIGNMENT__ has always been 16 on all power platforms rather than the default of 8 in clang, fix and update tests accordingly. Modified: cfe/trunk/l

r298765 - Add the _CALL_LINUX preprocessor define for ppc linux platforms.

Author: echristo Date: Fri Mar 24 22:33:59 2017 New Revision: 298765 URL: http://llvm.org/viewvc/llvm-project?rev=298765&view=rev Log: Add the _CALL_LINUX preprocessor define for ppc linux platforms. This typically is only for a new enough linker (bfd >= 2.16.2 or gold), but our ppc suppport post

r298769 - Define __HAVE_BSWAP__ on ppc to match gcc since we support both builtins as well.

Author: echristo Date: Sat Mar 25 00:40:13 2017 New Revision: 298769 URL: http://llvm.org/viewvc/llvm-project?rev=298769&view=rev Log: Define __HAVE_BSWAP__ on ppc to match gcc since we support both builtins as well. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Preprocessor/i

Re: r298767 - [AMDGPU] Switch address space mapping by triple environment amdgiz

On Fri, Mar 24, 2017 at 8:58 PM Yaxun Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yaxunl > Date: Fri Mar 24 22:46:25 2017 > New Revision: 298767 > > URL: http://llvm.org/viewvc/llvm-project?rev=298767&view=rev > Log: > [AMDGPU] Switch address space mapping by triple environm

r298770 - Add the __LONGDOUBLE128 define for ppc targets that have 128 bit long doubles.

Author: echristo Date: Sat Mar 25 01:37:23 2017 New Revision: 298770 URL: http://llvm.org/viewvc/llvm-project?rev=298770&view=rev Log: Add the __LONGDOUBLE128 define for ppc targets that have 128 bit long doubles. Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Preprocessor/init.

r298771 - Update the comment on not yet generated preprocessor defines to remove __LONGDOUBLE128.

Author: echristo Date: Sat Mar 25 01:38:57 2017 New Revision: 298771 URL: http://llvm.org/viewvc/llvm-project?rev=298771&view=rev Log: Update the comment on not yet generated preprocessor defines to remove __LONGDOUBLE128. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Ba

r298778 - _CALL_LINUX is only defined on 64-bit ppc linux platforms, not 32-bit.

Author: echristo Date: Sat Mar 25 14:26:04 2017 New Revision: 298778 URL: http://llvm.org/viewvc/llvm-project?rev=298778&view=rev Log: _CALL_LINUX is only defined on 64-bit ppc linux platforms, not 32-bit. Adjust and add a test for the 32-bit side. Modified: cfe/trunk/lib/Basic/Targets.cpp

Re: r298765 - Add the _CALL_LINUX preprocessor define for ppc linux platforms.

ote: > Shouldn't this only be defined on 64-bit PPC platforms? I think that's > what GCC does: > https://github.com/gcc-mirror/gcc/blob/700a97608cadfe8adcd1a98e6388a5cbee9d76f6/gcc/config/rs6000/linux64.h#L372 > > On Fri, Mar 24, 2017 at 8:33 PM, Eric Christopher via

Re: [PATCH] D30760: Record command lines in objects built by clang, Clang part

ment to omit it. I'd probably leave > it in for simplicity. > > On Fri, Mar 24, 2017 at 5:48 PM Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Not sure, that's why I asked. Is it useful? Is it one of those things we > want to remo

r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

Author: echristo Date: Tue Mar 28 18:03:19 2017 New Revision: 298956 URL: http://llvm.org/viewvc/llvm-project?rev=298956&view=rev Log: Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors: http://www.intel.co

Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

o have the affected units. -eric On Tue, Mar 28, 2017 at 4:15 PM Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echristo > Date: Tue Mar 28 18:03:19 2017 > New Revision: 298956 > > URL: http://llvm.org/viewvc/llvm-project?rev=298956&view=r

Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

haswell and broadwell cpu to handle this > different feature set or just leave it as an optional "enable it yourself" > since it's an errata fix? > > I went ahead and committed with this question outstanding so that users > won't get illegal instructions if they hap

Re: r298956 - Default enable the rtm feature only on skylake and later for now because Intel disabled the feature on some haswell and broadwell processors:

urself" > since it's an errata fix? > > I went ahead and committed with this question outstanding so that users > won't get illegal instructions if they happen to have the affected units. > > -eric > > > On Tue, Mar 28, 2017 at 4:15 PM Eric Christopher via cf

r299037 - Add the -grecord-gcc-switches option and pass the flags down on the compile unit.

Author: echristo Date: Wed Mar 29 18:34:20 2017 New Revision: 299037 URL: http://llvm.org/viewvc/llvm-project?rev=299037&view=rev Log: Add the -grecord-gcc-switches option and pass the flags down on the compile unit. Patch by Zhizhou Yang Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp

r299148 - Fix typo, defind -> defined.

Author: echristo Date: Thu Mar 30 20:45:39 2017 New Revision: 299148 URL: http://llvm.org/viewvc/llvm-project?rev=299148&view=rev Log: Fix typo, defind -> defined. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/include/clang/B

r299151 - Update x86-64 ABI link with the one from linuxbase.org since the other

Author: echristo Date: Thu Mar 30 20:59:40 2017 New Revision: 299151 URL: http://llvm.org/viewvc/llvm-project?rev=299151&view=rev Log: Update x86-64 ABI link with the one from linuxbase.org since the other seems to be down. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h Modified: cfe/t

r300395 - When we turn on vsx it should also turn on altivec explicitly, same

Author: echristo Date: Sat Apr 15 01:15:00 2017 New Revision: 300395 URL: http://llvm.org/viewvc/llvm-project?rev=300395&view=rev Log: When we turn on vsx it should also turn on altivec explicitly, same with disabling it as well as disabling all vsx specific features when turning off altivec. Fix

r291879 - Add a necessary newline for diagnose_if documentation.

Author: echristo Date: Thu Jan 12 19:52:04 2017 New Revision: 291879 URL: http://llvm.org/viewvc/llvm-project?rev=291879&view=rev Log: Add a necessary newline for diagnose_if documentation. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.t

Re: r291879 - Add a necessary newline for diagnose_if documentation.

Great, thanks! On Fri, Jan 13, 2017, 11:52 AM Hans Wennborg wrote: > Merged in r291952. > > Thanks, > Hans > > On Thu, Jan 12, 2017 at 5:52 PM, Eric Christopher via cfe-commits > wrote: > > Author: echristo > > Date: Thu Jan 12 19:52:04 2017 > >

Re: [PATCH] D28037: [Altivec] Change vec_sl to a << (b % (sizeof(a) * 8))

Please go ahead and commit, we'll worry about speed after correctness. -eric On Fri, Jan 20, 2017 at 2:10 PM Tim Shen via Phabricator < revi...@reviews.llvm.org> wrote: > timshen added a comment. > > In https://reviews.llvm.org/D28037#652021, @echristo wrote: > > > Going to commit this? > > > I'

r294680 - Update C style comments to C++ style.

Author: echristo Date: Thu Feb 9 18:20:26 2017 New Revision: 294680 URL: http://llvm.org/viewvc/llvm-project?rev=294680&view=rev Log: Update C style comments to C++ style. Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.cpp URL: http://

r306769 - Unified logic for computing target ABI in backend and front end by moving this common code to Support/TargetParser.

Author: echristo Date: Thu Jun 29 17:03:56 2017 New Revision: 306769 URL: http://llvm.org/viewvc/llvm-project?rev=306769&view=rev Log: Unified logic for computing target ABI in backend and front end by moving this common code to Support/TargetParser. Modeled Triple::GNU after front end code (aap

r306790 - Add -no-canonical-prefixes to the test line so that we can handle different build modes.

Author: echristo Date: Thu Jun 29 23:03:47 2017 New Revision: 306790 URL: http://llvm.org/viewvc/llvm-project?rev=306790&view=rev Log: Add -no-canonical-prefixes to the test line so that we can handle different build modes. Modified: cfe/trunk/test/Driver/openmp-offload.c Modified: cfe/trun

r306928 - Update clang support for -mexecute-only/-mpure-code for backend change to use subtarget feature rather than command line option.

Author: echristo Date: Fri Jun 30 19:55:23 2017 New Revision: 306928 URL: http://llvm.org/viewvc/llvm-project?rev=306928&view=rev Log: Update clang support for -mexecute-only/-mpure-code for backend change to use subtarget feature rather than command line option. Added: cfe/trunk/test/CodeGe

r307594 - IsSpecialLong was only ever set in release mode as all of the uses are in asserts. Wrap in ifndef NDEBUG.

Author: echristo Date: Mon Jul 10 14:28:54 2017 New Revision: 307594 URL: http://llvm.org/viewvc/llvm-project?rev=307594&view=rev Log: IsSpecialLong was only ever set in release mode as all of the uses are in asserts. Wrap in ifndef NDEBUG. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modifie

r307988 - Change dyn_casts with unused variables to isa statements to avoid unused variables.

Author: echristo Date: Thu Jul 13 18:42:57 2017 New Revision: 307988 URL: http://llvm.org/viewvc/llvm-project?rev=307988&view=rev Log: Change dyn_casts with unused variables to isa statements to avoid unused variables. Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp cfe/trunk/lib/Sema/S

r307989 - Use EXPECT_TRUE rather than EXPECT_EQ(true, ...) to clean up the code and silence a null conversion warning.

Author: echristo Date: Thu Jul 13 19:03:03 2017 New Revision: 307989 URL: http://llvm.org/viewvc/llvm-project?rev=307989&view=rev Log: Use EXPECT_TRUE rather than EXPECT_EQ(true, ...) to clean up the code and silence a null conversion warning. Modified: cfe/trunk/unittests/ASTMatchers/Dynami

r309004 - Revert "This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements." as it is causing msan failures.

Author: echristo Date: Tue Jul 25 12:17:32 2017 New Revision: 309004 URL: http://llvm.org/viewvc/llvm-project?rev=309004&view=rev Log: Revert "This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements." as it is causing msan failures. This revert

Re: [PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

I've reverted this and Nemanja's attempt at fixing in: echristo@athyra ~/s/l/t/clang> git svn dcommit Committing to https://llvm.org/svn/llvm-project/cfe/trunk ... D test/CodeGen/x86-ms-inline-asm-enum_feature.cpp M lib/Sema/SemaStmtAsm.cpp M test/CodeGen/ms-inline-asm.c M test/CodeGenCXX/ms-inlin

Re: [PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

And this: echristo@athyra ~/s/llvm> git svn dcommit Committing to https://llvm.org/svn/llvm-project/llvm/trunk ... M include/llvm/MC/MCParser/MCAsmParser.h M lib/Target/X86/AsmParser/X86AsmParser.cpp Committed r309005 On Tue, Jul 25, 2017 at 12:18 PM Eric Christopher wrote: > I've reverted th

r322427 - Remove unused addIfPresent function.

Author: echristo Date: Fri Jan 12 16:46:47 2018 New Revision: 322427 URL: http://llvm.org/viewvc/llvm-project?rev=322427&view=rev Log: Remove unused addIfPresent function. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp URL: http://llvm.org/viewvc

r323902 - Clarify that optimization levels -O2 and above are recommended for use of PGO.

Author: echristo Date: Wed Jan 31 11:52:58 2018 New Revision: 323902 URL: http://llvm.org/viewvc/llvm-project?rev=323902&view=rev Log: Clarify that optimization levels -O2 and above are recommended for use of PGO. Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.

r294703 - For X86-64 linux and PPC64 linux align int128 to 16 bytes.

Author: echristo Date: Thu Feb 9 21:32:34 2017 New Revision: 294703 URL: http://llvm.org/viewvc/llvm-project?rev=294703&view=rev Log: For X86-64 linux and PPC64 linux align int128 to 16 bytes. For other platforms we should find out what they need and likely make the same change, however, a small

r294708 - Temporarily revert "For X86-64 linux and PPC64 linux align int128 to 16 bytes."

Author: echristo Date: Thu Feb 9 22:35:21 2017 New Revision: 294708 URL: http://llvm.org/viewvc/llvm-project?rev=294708&view=rev Log: Temporarily revert "For X86-64 linux and PPC64 linux align int128 to 16 bytes." until we can get better TargetMachine::isCompatibleDataLayout to compare - otherwi

r295156 - Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce.

Author: echristo Date: Wed Feb 15 01:50:11 2017 New Revision: 295156 URL: http://llvm.org/viewvc/llvm-project?rev=295156&view=rev Log: Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce. Modified: cfe/trunk/lib/Basic/Targets

Re: r295156 - Add a definition for __STRUCT_PARM_ALIGN__ for elfv2 and 64-bit darwin platforms to match what other compilers produce.

The PPC one should inherit from this. You're right I should have tested it though. Mostly ppc Darwin isn't well supported. On Wed, Feb 15, 2017, 12:06 AM Tim Shen wrote: > On Wed, Feb 15, 2017, 00:01 Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote

r296490 - Migrate all of aarch64-linux-gnu to \01_mcount instead of just when passing along gnueabi as this matches both gcc and what the kernel expects.

Author: echristo Date: Tue Feb 28 11:22:05 2017 New Revision: 296490 URL: http://llvm.org/viewvc/llvm-project?rev=296490&view=rev Log: Migrate all of aarch64-linux-gnu to \01_mcount instead of just when passing along gnueabi as this matches both gcc and what the kernel expects. More of PR27311

Re: [PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

Looks like this is failing on a number of bots... On Fri, Mar 10, 2017 at 1:37 PM Juergen Ributzka via Phabricator via cfe-commits wrote: > ributzka added a comment. > > Thanks Bruno. Committed in r297510. > > > Repository: > rL LLVM > > https://reviews.llvm.org/D30768 > > > >

Re: [PATCH] D30768: [PATCH][VFS] Ignore broken symlinks in the directory iterator.

Nevermind, I see you've fixed. Thanks :) On Fri, Mar 10, 2017 at 3:21 PM Eric Christopher wrote: > Looks like this is failing on a number of bots... > > On Fri, Mar 10, 2017 at 1:37 PM Juergen Ributzka via Phabricator via > cfe-commits wrote: > > ributzka added a comment. > > Thanks Bruno. Comm

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

echristo added a comment. Inline comment. Comment at: test/CodeGenCUDA/link-device-bitcode.cu:23-28 @@ +22,8 @@ +// +// NVVMReflect is a target-specific pass runs after -emit-llvm prints +// IR, so we need to check NVPTX to make sure that the pass did happen +// and __nvvm_refle

Re: [PATCH] D11664: [CUDA] Implemented additional processing steps needed to link with CUDA libdevice bitcode.

echristo added a comment. Works for me, thanks. http://reviews.llvm.org/D11664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12505: [X86] Set MaxVectorAlign for non-Darwin targets as well.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. This seems reasonable to me, I can't see why it wouldn't be ok. Thanks! -eric http://reviews.llvm.org/D12505 ___ cfe-commits mailing list c

Re: r246229 - [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX.

On Mon, Aug 31, 2015 at 4:03 PM Ahmed Bougacha wrote: > On Thu, Aug 27, 2015 at 7:19 PM, Eric Christopher > wrote: > >> Hi Ahmed, >> >> A quick note: I think this is going to fail in the presence of the target >> attribute. I.e. if someone decorates a function with >> __attribute__((target("avx5

Re: [PATCH] D12505: [X86] Set MaxVectorAlign for non-Darwin targets as well.

echristo added a comment. (This ACK btw means "yes we should do this on all platforms", not that it's necessarily safe on any platform, see my mail on the original thread). -eric http://reviews.llvm.org/D12505 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D11279: Initial patch for PS4 toolchain

echristo accepted this revision. echristo added a comment. One set of inline comments, and also: test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep eh? -eric Comment at: lib/Driver/Tools.cpp:10025-10029 @@ +10024,7 @@ + const char *Exec = +#ifdef LLVM_ON_WIN32 +

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Interesting. I'm down with putting this in - would it make more sense to put this alongside the buildit bits in the llvm/utils repo? -eric http://reviews.llvm.org/D12817 _

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

echristo added a comment. Standalone as "clang that only sorta depends on llvm"? http://reviews.llvm.org/D12817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

Ah sure. Make it so then. On Tue, Sep 15, 2015, 1:04 PM Chris Bieneman wrote: > beanz added a comment. > > Standalone as in using the base system's LLVM installation. So you don't > actually have to have an llvm checkout. > > There's goop in the root clang CMakeLists file to support building cla

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Yuck. No better ideas off the top of my head other than diagnosing and erroring though. (Is that a possibility? :) -eric http://reviews.llvm.org/D12892 __

Re: [PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Commit message could use some more elaborating on why you'll need to know this information. Just a bit as the main commit will have a lot of that information. Thanks! -eric http://revie

Re: [PATCH] D12892: [CUDA] Minor cuda-related driver fixes.

echristo added a comment. Sure. Seems reasonable. Thanks! -eric http://reviews.llvm.org/D12892 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12893: Augmented CudaHostAction to carry device-side triple.

echristo added a comment. Sounds good. Thanks! http://reviews.llvm.org/D12893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11279: Initial patch for PS4 toolchain

echristo added a comment. In http://reviews.llvm.org/D11279#247377, @kromanova wrote: > test/Driver/Inputs/scei-ps4_tree/target/include_common/ and > test/Driver/Inputs/scei-ps4_tree/target/include/ are expected to be present > by a test ps4-header-search.c. This test checks that these directo

Re: [PATCH] D11279: Initial patch for PS4 toolchain

echristo added a comment. In http://reviews.llvm.org/D11279#247402, @kromanova wrote: > Hi Eric, > I don't mind changing .keep into README. However, originally we did it for > consistency purpose. If you grep for .keep in > /llvm/tools/clang/test/Driver/Inputs directory, you will find hundreds

Re: [PATCH] D12917: [CUDA] Allow parsing of host and device code simultaneously.

echristo added a comment. One inline request and one inline comment, otherwise looks pretty good! Thanks :) -eric Comment at: include/clang/Frontend/CompilerInstance.h:355 @@ -350,3 +354,3 @@ - /// Replace the current diagnostics engine. + /// Replace the current Target.

<    1   2   3   4   5   6   >