No, it's just the bug that Jorge found. I understand it might have highlighted an existing bug, but reverting back to clean is the best bet here and then we can recommit when we get the latent bug fixed :)
On Mon, Nov 18, 2019 at 11:08 AM Melanie Blower via Phabricator <revi...@reviews.llvm.org> wrote: > > mibintc added a comment. > > In D62731#1750312 <https://reviews.llvm.org/D62731#1750312>, @echristo wrote: > > > In D62731#1749916 <https://reviews.llvm.org/D62731#1749916>, @mibintc wrote: > > > > > Thanks I see it, I'm working on a patch. Previously there was no support > > > for frounding-math (unimplemented). This patch enables the option. In the > > > IR builder, there's a call to a runtime function in the exception handler > > > which is unexpectedly null. I start by adding a null pointer check. > > > > > > Had a crash on valid here for days, let's revert and then get a fix when > > recommitting. I'll respond to the thread when reverting. Thanks :) > > > @echristo I just saw the bug was reported today, is the "crash on valid" > visible on the bots? Can you provide url showing same? Thanks > I opened https://bugs.llvm.org/show_bug.cgi?id=44048 for @jgorbe > > > Repository: > rL LLVM > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D62731/new/ > > https://reviews.llvm.org/D62731 > > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
