Re: [PATCH] D11753: [X86] Add support for _MM_ALIGN16

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments, otherwise LGTM. -eric Comment at: test/CodeGen/ms-mm-align.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility

r244111 - Remove unused comparison operators from the Builtin Info struct.

Author: echristo Date: Wed Aug 5 15:11:04 2015 New Revision: 244111 URL: http://llvm.org/viewvc/llvm-project?rev=244111&view=rev Log: Remove unused comparison operators from the Builtin Info struct. Modified: cfe/trunk/include/clang/Basic/Builtins.h Modified: cfe/trunk/include/clang/Basic/B

r244125 - Remove unused function GetBuiltinNames.

Author: echristo Date: Wed Aug 5 16:04:24 2015 New Revision: 244125 URL: http://llvm.org/viewvc/llvm-project?rev=244125&view=rev Log: Remove unused function GetBuiltinNames. Modified: cfe/trunk/include/clang/Basic/Builtins.h cfe/trunk/lib/Basic/Builtins.cpp Modified: cfe/trunk/include/c

r244126 - Rename builtin_lang -> Langs to match the rest of the code a bit better.

Author: echristo Date: Wed Aug 5 16:04:28 2015 New Revision: 244126 URL: http://llvm.org/viewvc/llvm-project?rev=244126&view=rev Log: Rename builtin_lang -> Langs to match the rest of the code a bit better. Modified: cfe/trunk/include/clang/Basic/Builtins.h cfe/trunk/lib/Basic/Builtins.c

r244178 - Rename DescriptionString -> DataLayoutString as it matches the actual

Author: echristo Date: Wed Aug 5 18:48:05 2015 New Revision: 244178 URL: http://llvm.org/viewvc/llvm-project?rev=244178&view=rev Log: Rename DescriptionString -> DataLayoutString as it matches the actual use of the string. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/li

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

Still broken here locally on my machine after updating: FAIL: Clang :: Index/print-mangled-name.cpp (3844 of 22837) TEST 'Clang :: Index/print-mangled-name.cpp' FAILED Script: -- /usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-t

r244186 - Rename the non-coding style conformant functions in namespace Builtins

Author: echristo Date: Wed Aug 5 20:01:12 2015 New Revision: 244186 URL: http://llvm.org/viewvc/llvm-project?rev=244186&view=rev Log: Rename the non-coding style conformant functions in namespace Builtins to match the rest of their brethren and reformat the bits that need it. Modified: cfe/t

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

t -arch x86_64 > -mmacosx-version-min=10.6 %s > +// RUN: c-index-test -write-pch %t_macho.ast -target x86_64-apple-darwin > %s > > // RUN: c-index-test -test-print-mangle %t_macho.ast | FileCheck %s > --check-prefix=MACHO > > // RUN: c-index-test -write-pch %t_msft.a

r333154 - Migrate libcalls-fno-builtin.c test from checking optimized assembly

Author: echristo Date: Wed May 23 23:00:50 2018 New Revision: 333154 URL: http://llvm.org/viewvc/llvm-project?rev=333154&view=rev Log: Migrate libcalls-fno-builtin.c test from checking optimized assembly to checking for attributes on the call site - and fix up builtin functions that we were testin

r333156 - Add Builtins.def support for fread and fwrite to ensure that -fno-builtin-

Author: echristo Date: Wed May 23 23:09:28 2018 New Revision: 333156 URL: http://llvm.org/viewvc/llvm-project?rev=333156&view=rev Log: Add Builtins.def support for fread and fwrite to ensure that -fno-builtin- works with them and test accordingly. Modified: cfe/trunk/include/clang/Basic/Built

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

Hi Vedant, So this actually broke -fsanitize=function on linux. Han is working up a testcase for it, but letting you know for now that we'll probably need some change here. -eric On Tue, Sep 12, 2017 at 5:05 PM Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vedantk

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

e across sections trying to compile things with the current code. Thanks! -eric > vedant > > > vedant > > > On Oct 13, 2017, at 1:33 PM, Eric Christopher wrote: > > Hi Vedant, > > So this actually broke -fsanitize=function on linux. Han is working up a > t

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

On Fri, Oct 13, 2017 at 2:50 PM Vedant Kumar wrote: > On Oct 13, 2017, at 1:44 PM, Eric Christopher wrote: > > > > On Fri, Oct 13, 2017 at 1:42 PM Vedant Kumar wrote: > >> On Oct 13, 2017, at 1:39 PM, Vedant Kumar wrote: >> >> Hey Eric, >> >>

Re: [PATCH] D51358: [driver] Do not pass "-flavor old-gnu" option to LLD linker

LGTM On Tue, Aug 28, 2018, 7:49 AM Simon Atanasyan via Phabricator < revi...@reviews.llvm.org> wrote: > atanasyan created this revision. > atanasyan added reviewers: echristo, ruiu. > > The "-flavor old-gnu" option were introduced to enable old version of LLD > ELF linker implementation. This opt

r338327 - Add a definition for FieldSize that seems to make sense here.

Author: echristo Date: Mon Jul 30 16:17:27 2018 New Revision: 338327 URL: http://llvm.org/viewvc/llvm-project?rev=338327&view=rev Log: Add a definition for FieldSize that seems to make sense here. This could be sunk out of the if statements, but fix the warning for now. Modified: cfe/trunk/li

r338328 - Revert "Add a definition for FieldSize that seems to make sense here."

Author: echristo Date: Mon Jul 30 16:21:51 2018 New Revision: 338328 URL: http://llvm.org/viewvc/llvm-project?rev=338328&view=rev Log: Revert "Add a definition for FieldSize that seems to make sense here." This reverts commit r338327, the problem was previously fixed in r338321. Modified: cf

Re: r338321 - Fix use of uninitialized variable in r338299

Is 0 right for FieldOffset for OpenCL here? Seems a little odd. -eric On Mon, Jul 30, 2018 at 3:56 PM Scott Linder via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: scott.linder > Date: Mon Jul 30 15:52:07 2018 > New Revision: 338321 > > URL: http://llvm.org/viewvc/llvm-project?rev=

Re: r338321 - Fix use of uninitialized variable in r338299

ghts? At any rate if you could document what the intended code is here I'd appreciate it. -eric On Tue, Jul 31, 2018 at 9:18 AM wrote: > I think this version is right; the FieldOffset for OpenCL here will be 2 > * getTypeSize(IntTy). The final `FieldOffset += FieldSize` that was >

Re: r338321 - Fix use of uninitialized variable in r338299

part of the code when you get a chance to do the rest of the cleanup I'd appreciate it. -eric > Scott > > On 2018-07-31 18:03, Eric Christopher wrote: > > I'm probably missing something, from looking here: > > > > FieldOffset = 0; > > if (

Re: [PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

Fair. Did you want to handle this a different way? I thought the list at least seemed reasonable for spelling. On Thu, Feb 8, 2018, 11:44 AM Artem Belevich via Phabricator < revi...@reviews.llvm.org> wrote: > tra added inline comments. > > > > Comment at: test/Misc/target-invalid

Re: [PATCH] D10831: Attach attribute "trap-func-name" to IR function

It could, but then you'd need to change every front end to have the same sort of behavior, maybe you want to configure it differently, etc. That said, I really have no strong opinions here :) -eric On Wed, Feb 14, 2018 at 6:51 PM Peter Collingbourne via Phabricator < revi...@reviews.llvm.org> wr

Re: [PATCH] D43514: Start settinng dso_local for COFF

On Thu, Feb 22, 2018 at 4:40 PM Rafael Avila de Espindola via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Eric Christopher via Phabricator writes: > > > echristo added inline comments. > > > > > > > > Comment at: lib/CodeGen/C

Re: [PATCH] D44218: Correct the alignment for the PS4 target

LGTM. On Wed, Mar 7, 2018, 11:02 AM Matthew Voss via Phabricator < revi...@reviews.llvm.org> wrote: > ormris created this revision. > ormris added reviewers: rsmith, craig.topper, echristo, erichkeane. > > See above. > > > Repository: > rC Clang > > https://reviews.llvm.org/D44218 > > Files: >

r333594 - Add fopen to the list of builtins that we check and whitelist.

Author: echristo Date: Wed May 30 14:11:45 2018 New Revision: 333594 URL: http://llvm.org/viewvc/llvm-project?rev=333594&view=rev Log: Add fopen to the list of builtins that we check and whitelist. Modified: cfe/trunk/include/clang/Basic/Builtins.def cfe/trunk/test/CodeGen/libcalls-fno-bu

Re: [PATCH] D52703: Allow ifunc resolvers to accept arguments

SGTM. On Tue, Oct 9, 2018, 7:57 AM James Y Knight via Phabricator < revi...@reviews.llvm.org> wrote: > jyknight accepted this revision. > jyknight added a comment. > This revision is now accepted and ready to land. > > Given that there's no technical reason for the compiler to prohibit this > (it

Re: r352690 - [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Looks like this broke optimized asan builds via an assert in SCCP. I'll see what I can do about a testcase (or Eric will), however, would you mind reverting in the meantime? Thanks! -eric On Wed, Jan 30, 2019 at 4:41 PM Julian Lettner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Autho

Re: [PATCH] D53919: [X86] Don't allow illegal vector types to return by direct value on x86-64.

On Mon, Nov 5, 2018 at 9:45 AM H.J Lu via Phabricator < revi...@reviews.llvm.org> wrote: > hjl.tools added a comment. > > In https://reviews.llvm.org/D53919#1287510, @echristo wrote: > > > In https://reviews.llvm.org/D53919#1282994, @hjl.tools wrote: > > > > > In https://reviews.llvm.org/D53919#12

Re: [PATCH] D61464: [RiscV] Typo in register aliases

I'll get it. On Sat, May 4, 2019 at 3:47 AM John LLVM via Phabricator wrote: > > JohnLLVM added a comment. > > What should I do now? I do not have rights to commit. > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D61464/new/ > > https://reviews.llvm.org/D61464 > > > _

r360104 - Fix typo in risc-v register aliases.

Author: echristo Date: Mon May 6 17:45:47 2019 New Revision: 360104 URL: http://llvm.org/viewvc/llvm-project?rev=360104&view=rev Log: Fix typo in risc-v register aliases. Patch by John. Differential Revision: https://reviews.llvm.org/D61464 Modified: cfe/trunk/lib/Basic/Targets/RISCV.cpp

Re: r342053 - [CodeGen] Align rtti and vtable data

Hi David, I'm seeing test failures after this patch. I'm trying to get a test case reduced, but can we revert until we figure it out? Thanks! -eric On Wed, Sep 12, 2018 at 7:10 AM David Green via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dmgreen > Date: Wed Sep 12 07:09:06 201

Re: r342053 - [CodeGen] Align rtti and vtable data

Thanks for looking Jordan! On Mon, Sep 17, 2018, 11:16 AM Jordan Rupprecht wrote: > > Interesting, what kind of failures? > > > > If they are causing you problems, of course feel free to revert. > > > > Dave > > Turns out they are all real issues which running the test under asan > mode flags as

r342667 - r342177 introduced a hint in cases where an #included file is not found. It tries to find a suggestion by removing leading or trailing non-alphanumeric characters and checking if a matching

Author: echristo Date: Thu Sep 20 10:21:56 2018 New Revision: 342667 URL: http://llvm.org/viewvc/llvm-project?rev=342667&view=rev Log: r342177 introduced a hint in cases where an #included file is not found. It tries to find a suggestion by removing leading or trailing non-alphanumeric character

r342668 - Add testcases for r342667.

Author: echristo Date: Thu Sep 20 10:22:43 2018 New Revision: 342668 URL: http://llvm.org/viewvc/llvm-project?rev=342668&view=rev Log: Add testcases for r342667. Added: cfe/trunk/test/Preprocessor/include-leading-nonalpha-no-suggest.c cfe/trunk/test/Preprocessor/include-leading-nonalpha-s

Re: r342668 - Add testcases for r342667.

\llvm.src\tools\clang\test\Preprocessor\include-leading-nonalpha-suggest.c > Line 3: '/empty_file_to_include.h' file not found, did you mean > 'empty_file_to_include.h'? > > 1 error generated. > > > error: command failed with exit status: 1 > > Oof. Tha

Re: r342668 - Add testcases for r342667.

FWIW we're trying to reproduce here real fast and then will revert or fix real fast. Thanks! -eric On Thu, Sep 20, 2018 at 2:46 PM Eric Christopher wrote: > Adding Jorge... > > On Thu, Sep 20, 2018 at 2:36 PM wrote: > >> Hi Eric, >> >> The test that you add

Re: r342668 - Add testcases for r342667.

and trailing non-alphanumeric characters. >> >> The other test in r342668 works because it includes a file that doesn't >> exist even if you interpret the path as relative so it should be OK to keep >> while the bug is found. >> >> I'll go find a bug about

Re: [PATCH] D58326: [Driver][Gnu] Support -nolibc flag

Weird. Ok. On Sat, Feb 16, 2019, 5:20 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek created this revision. > phosek added reviewers: echristo, mcgrathr. > Herald added a project: clang. > Herald added a subscriber: cfe-commits. > > This can be used to disable libc link

Re: [PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation

Don't wait on me here. On Thu, Aug 31, 2017, 10:53 PM Craig Topper via Phabricator < revi...@reviews.llvm.org> wrote: > craig.topper accepted this revision. > craig.topper added a comment. > This revision is now accepted and ready to land. > > LGTM > > > https://reviews.llvm.org/D36707 > > > > __

Re: [PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

Will do. On Sun, Jun 2, 2019 at 5:43 AM A. Skrobov via Phabricator wrote: > > t.yomitch added a comment. > > Thanks Eric! > I don't have commit access; could someone please commit this for me? > > > Repository: > rC Clang > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D62133/new/ >

r362462 - Remove test/CodeGen/builtin-stackaddress.c as it duplicates

Author: echristo Date: Mon Jun 3 16:16:06 2019 New Revision: 362462 URL: http://llvm.org/viewvc/llvm-project?rev=362462&view=rev Log: Remove test/CodeGen/builtin-stackaddress.c as it duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c. Differential Revision: https://reviews.llvm.org/D

r366155 - Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic"

Author: echristo Date: Mon Jul 15 16:49:31 2019 New Revision: 366155 URL: http://llvm.org/viewvc/llvm-project?rev=366155&view=rev Log: Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic" The commit had tests that would only work with names

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

Just wanted to let you know I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: ba7decf8c91 Temporarily Revert "fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic" Sendingcfe/trunk/lib/CodeGen/CGExpr.c

r366157 - Temporarily revert "add -fthinlto-index= option to clang-cl"

Author: echristo Date: Mon Jul 15 17:02:40 2019 New Revision: 366157 URL: http://llvm.org/viewvc/llvm-project?rev=366157&view=rev Log: Temporarily revert "add -fthinlto-index= option to clang-cl" This is causing testsuite failures on (at least) darwin release+asserts. This reverts commit r366146

Re: r366146 - add -fthinlto-index= option to clang-cl

Hi Bob, I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 1dbd2f85903 Temporarily revert "add -fthinlto-index= option to clang-cl" Sendingcfe/trunk/include/clang/Driver/Options.td Deleting cfe/trunk/test/Driver/cl-thinlto-backen

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

t; > and cannot reproduce the issue. If you could send me the cmake > command line which caused failure in your environment. That will > be great! > > Thanks, > > Yonghong > > On 7/15/19, 4:50 PM, "Eric Christopher" wrote: > > Just wanted to let you kno

r360703 - Temporarily revert "Change -gz and -Wa, --compress-debug-sections to use gABI compression (SHF_COMPRESSED)"

Author: echristo Date: Tue May 14 12:40:42 2019 New Revision: 360703 URL: http://llvm.org/viewvc/llvm-project?rev=360703&view=rev Log: Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)" This affects users of older (pre 2.26) binutils in suc

Re: r360403 - Change -gz and -Wa, --compress-debug-sections to use gABI compression (SHF_COMPRESSED)

Hi Ray, I've temporarily reverted this here: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: fda79815a33 Temporarily revert "Change -gz and -Wa,--compress-debug-sections to use gABI compression (SHF_COMPRESSED)" Sendingcfe/trunk/docs/ReleaseNotes.rst Sendingcfe

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

That said, prior art in gcc in this area: -fasynchronous-unwind-tables Generate unwind table in DWARF format, if supported by target machine. The table is exact at each instruction boundary, so it can be used for stack unwinding from asynchronous events (such as debugger or garbage collector). -

Re: r335084 - Append new attributes to the end of an AttributeList.

On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 23 June 2018 at 22:34, Michael Kruse via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi, >> >> multiple comments in the code indicate that the attribute order was >> surprising and

[libunwind] r336012 - Revert "Revert "Support for multiarch runtimes layout""

Author: echristo Date: Fri Jun 29 13:27:40 2018 New Revision: 336012 URL: http://llvm.org/viewvc/llvm-project?rev=336012&view=rev Log: Revert "Revert "Support for multiarch runtimes layout"" This reverts commit r336005 that was accidentally committed. Modified: libunwind/trunk/CMakeLists.txt

r336630 - Update crash diagnostics test to avoid attempting to write into various

Author: echristo Date: Mon Jul 9 18:01:38 2018 New Revision: 336630 URL: http://llvm.org/viewvc/llvm-project?rev=336630&view=rev Log: Update crash diagnostics test to avoid attempting to write into various directories if possible and to not require %t to have "Output" in the name. Modified:

r337321 - Remove unnecessary trailing ; in macro intrinsic definition.

Author: echristo Date: Tue Jul 17 13:22:17 2018 New Revision: 337321 URL: http://llvm.org/viewvc/llvm-project?rev=337321&view=rev Log: Remove unnecessary trailing ; in macro intrinsic definition. Modified: cfe/trunk/lib/Headers/avx512dqintrin.h Modified: cfe/trunk/lib/Headers/avx512dqintrin.

r374838 - In the new pass manager use PTO.LoopUnrolling to determine when and how

Author: echristo Date: Mon Oct 14 15:56:07 2019 New Revision: 374838 URL: http://llvm.org/viewvc/llvm-project?rev=374838&view=rev Log: In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a few occasions where we need to know whether or not we'

Re: [PATCH] D68535: Fix loop unrolling initialization in the new pass manager

Thanks for the text - I didn't have anything to add or change so I just used it verbatim :) Committed thusly: Committed revision 374838. Committed f64329154c3 to svn. On Mon, Oct 7, 2019 at 9:36 AM Alina Sbirlea via Phabricator wrote: > > asbirlea added a comment. > > Maybe elaborate in the pat

r374840 - Add -fno-experimental-pass-manager to make clear which pass manager

Author: echristo Date: Mon Oct 14 16:01:48 2019 New Revision: 374840 URL: http://llvm.org/viewvc/llvm-project?rev=374840&view=rev Log: Add -fno-experimental-pass-manager to make clear which pass manager we're running and to make flipping the default not regress testing. Modified: cfe/trunk/te

r374842 - Temporarily Revert [Modules][PCH] Hash input files content

Author: echristo Date: Mon Oct 14 16:14:24 2019 New Revision: 374842 URL: http://llvm.org/viewvc/llvm-project?rev=374842&view=rev Log: Temporarily Revert [Modules][PCH] Hash input files content as it's breaking a few bots. This reverts r374841 (git commit 2a1386c81de504b5bda44fbecf3f7b4cdfd748fc)

Re: r374841 - [Modules][PCH] Hash input files content

This was breaking a few bots and I couldn't find you on irc so I've reverted it thusly: echristo@jhereg ~/s/llvm-project> git llvm push Pushing 1 commit: 175b1b856ea Temporarily Revert [Modules][PCH] Hash input files content as it's breaking a few bots. Sendingcfe/trunk/include/clang/Bas

[clang] 97a133f - Temporarily Revert "[Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts"

Author: Eric Christopher Date: 2020-05-26T18:51:00-07:00 New Revision: 97a133f15724aa7ddf5d9b62dc9c0657a4efd115 URL: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115 DIFF: https://github.com/llvm/llvm-project/commit/97a133f15724aa7ddf5d9b62dc9c0657a4efd115

[clang] c554c5e - Fix full unrolling with new pass manager.

Author: Eric Christopher Date: 2020-05-29T20:08:21-07:00 New Revision: c554c5e159aee43c5cd8236e077817e9f29dea78 URL: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78 DIFF: https://github.com/llvm/llvm-project/commit/c554c5e159aee43c5cd8236e077817e9f29dea78

Re: [clang] 059ba74 - Revert "[codeview] Put !heapallocsite on calls to operator new"

FWIW before you reapply this let me know. I've seen some other failures associated and would like to give it a run through. -eric On Sat, Jun 6, 2020 at 4:38 PM Douglas Yung via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Douglas Yung > Date: 2020-06-06T23:30:46Z > New Revision:

Re: [PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

On Sun, Jul 5, 2020 at 8:47 PM Arthur Eubanks via Phabricator < revi...@reviews.llvm.org> wrote: > aeubanks added a comment. > > In D83013#2132070 , @echristo > wrote: > > > Adding Chandler and Alina here as well. > > > > In general, I don't think that this

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there? Stacktrace for the curious :) @ 0x56420187cbbe llvm::MCStreamer::emitIntValue() @ 0x5641fec38899 llvm::MCStreamer::emitInt16() @ 0x5641ff73b337 llvm::CodeViewDe

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

You'll probably want the assert as well: assert.h assertion failed at llvm-project/llvm/lib/MC/MCStreamer.cpp:134 in virtual void llvm::MCStreamer::emitIntValue(uint64_t, unsigned int): (isUIntN(8 * Size, Value) || isIntN(8 * Size, Value)) && "Invalid size" On Fri, Jul 1

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

Release+Asserts on x86_64-linux and the debug-info-codeview-buildinfo.c test. Sorry if the latter wasn't clear :) -eric On Fri, Jul 10, 2020 at 4:12 PM Alexandre Ganea wrote: > Thanks for letting me know Eric. What test fails exactly? What config? > > > > *De :* Eric Ch

[clang-tools-extra] f92011d - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:12:18-07:00 New Revision: f92011d875cfdca1ed97bf0ab6956364c604b578 URL: https://github.com/llvm/llvm-project/commit/f92011d875cfdca1ed97bf0ab6956364c604b578 DIFF: https://github.com/llvm/llvm-project/commit/f92011d875cfdca1ed97bf0ab6956364c604b578

[clang-tools-extra] 937c135 - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:41:06-07:00 New Revision: 937c135dd57e86ccd3fd64ca7b07915a75157986 URL: https://github.com/llvm/llvm-project/commit/937c135dd57e86ccd3fd64ca7b07915a75157986 DIFF: https://github.com/llvm/llvm-project/commit/937c135dd57e86ccd3fd64ca7b07915a75157986

[clang-tools-extra] f8a463c - As part of using inclusive language within the llvm project,

Author: Eric Christopher Date: 2020-06-19T15:43:51-07:00 New Revision: f8a463c170964bff7e239bb8268a4927a4547d3c URL: https://github.com/llvm/llvm-project/commit/f8a463c170964bff7e239bb8268a4927a4547d3c DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] a146991 - Update error to read a little better when an error occurs.

Author: Eric Christopher Date: 2020-06-19T23:34:30-07:00 New Revision: a1469914fd7542526693b07a26a0bdcaa27591a3 URL: https://github.com/llvm/llvm-project/commit/a1469914fd7542526693b07a26a0bdcaa27591a3 DIFF: https://github.com/llvm/llvm-project/commit/a1469914fd7542526693b07a26a0bdcaa27591a3

[clang] 1f593f4 - [AST/Lex/Parse/Sema] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T01:15:32-07:00 New Revision: 1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 URL: https://github.com/llvm/llvm-project/commit/1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7 DIFF: https://github.com/llvm/llvm-project/commit/1f593f46f35b3afb1ba6e4700285cf8fd1b81bc7

[clang-tools-extra] d313cb6 - Update redirected output file.

Author: Eric Christopher Date: 2020-06-19T23:30:16-07:00 New Revision: d313cb6e956de9448e4b979763ee8d12ce4103cb URL: https://github.com/llvm/llvm-project/commit/d313cb6e956de9448e4b979763ee8d12ce4103cb DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] 25ed42f - [clang-change-namespace] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-19T23:01:42-07:00 New Revision: 25ed42f05d07d3ad85c58ee001752338211c911c URL: https://github.com/llvm/llvm-project/commit/25ed42f05d07d3ad85c58ee001752338211c911c DIFF: https://github.com/llvm/llvm-project/commit

Re: [PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white, black}list to -fsanitize-coverage-{allow,block}list

On Fri, Jun 19, 2020 at 10:43 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added inline comments. > > > > Comment at: clang/docs/ClangCommandLineReference.rst:891 > > Restrict sanitizer coverage instrumentation exclusively to modules and > function

[clang-tools-extra] 16897e4 - Update test file.

Author: Eric Christopher Date: 2020-06-19T23:13:28-07:00 New Revision: 16897e47baa2b7cd1f63f40f8355c372b841f83d URL: https://github.com/llvm/llvm-project/commit/16897e47baa2b7cd1f63f40f8355c372b841f83d DIFF: https://github.com/llvm/llvm-project/commit

[clang] 10563e1 - [Analysis/Transforms/Sanitizers] As part of using inclusive language

Author: Eric Christopher Date: 2020-06-20T00:42:26-07:00 New Revision: 10563e16aa2c432a883695ddd714da68751bbd77 URL: https://github.com/llvm/llvm-project/commit/10563e16aa2c432a883695ddd714da68751bbd77 DIFF: https://github.com/llvm/llvm-project/commit/10563e16aa2c432a883695ddd714da68751bbd77

[clang-tools-extra] ef455a5 - Update comment to be more clear.

Author: Eric Christopher Date: 2020-06-20T14:44:41-07:00 New Revision: ef455a55bcf2cfea04a99c361b182ad18b7f03f1 URL: https://github.com/llvm/llvm-project/commit/ef455a55bcf2cfea04a99c361b182ad18b7f03f1 DIFF: https://github.com/llvm/llvm-project/commit/ef455a55bcf2cfea04a99c361b182ad18b7f03f1

[clang-tools-extra] da6332f - [clang-tidy] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T15:20:11-07:00 New Revision: da6332f5f9f15f7b182f27bc9b8edbf709b48093 URL: https://github.com/llvm/llvm-project/commit/da6332f5f9f15f7b182f27bc9b8edbf709b48093 DIFF: https://github.com/llvm/llvm-project/commit/da6332f5f9f15f7b182f27bc9b8edbf709b48093

[clang] 0861889 - [clang/llvm] As part of using inclusive language within

Author: Eric Christopher Date: 2020-06-20T16:03:58-07:00 New Revision: 0861889be103bf7bcf013768e913695ed94b50bf URL: https://github.com/llvm/llvm-project/commit/0861889be103bf7bcf013768e913695ed94b50bf DIFF: https://github.com/llvm/llvm-project/commit

[clang-tools-extra] faf2dce - Temporarily revert "Add a facility to get system cache directory and use it in clangd"

Author: Eric Christopher Date: 2020-04-28T15:49:46-07:00 New Revision: faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced URL: https://github.com/llvm/llvm-project/commit/faf2dce1dd6ae25aa75d2685ac7bb27ec31e2ced DIFF: https://github.com/llvm/llvm-project/commit

Re: [PATCH] D78501: Add a facility to get system cache directory and use it in clangd

I've had to temporarily revert this as it was breaking some tests: .../sources/llvm-project/llvm/unittests/Support/Path.cpp:334:5: error: use of undeclared identifier 'set' set(Value); ^ 1 error generated. Happy to help diagnose this with you if you need some assistance.

[clang-tools-extra] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914

[clang] 35edd70 - Temporarily revert "build: use `find_package(Python3)` if available"

Author: Eric Christopher Date: 2020-04-28T16:41:22-07:00 New Revision: 35edd704e0fda09e8e634515c0b451d4a8b6b914 URL: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914 DIFF: https://github.com/llvm/llvm-project/commit/35edd704e0fda09e8e634515c0b451d4a8b6b914

Re: [PATCH] D85231: Protect against filenames with no extension at all.

Could maybe add an assert along with the patch as well as an assert only test? On Tue, Aug 4, 2020, 1:42 PM Sterling Augustine via Phabricator < revi...@reviews.llvm.org> wrote: > saugustine added a comment. > > The darwin-dsymutil.c tests this code path right now on line 33. I found > this error

Re: [PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

Ow. Can revert and reapply after we fix the caching problem perhaps? -eric On Tue, Aug 4, 2020 at 3:48 PM Nick Desaulniers via Phabricator < revi...@reviews.llvm.org> wrote: > nickdesaulniers added a comment. > > I just collected a perf profile for an entire build. > `getImpliedDisabledFeatures`

Re: [PATCH] D72281: [Matrix] Add matrix type to Clang.

FWIW this broke lldb builds due to an unhandled enumeration. I've fixed them in: commit cd7cb1f4ce3ffc8be1146eeba28ae7dc50089459 (origin/master, origin/HEAD) Author: Eric Christopher Date: Mon May 11 13:44:12 2020 -0700 Update lldb for rG10658691951f to avoid Werror messages a

Re: [clang] d82538b - Fix -Wunused compiler warning.

Very much so. Also nice all_of use! I'd have never thought about that :) -eric On Mon, May 11, 2020 at 7:03 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Mon, May 11, 2020 at 12:21 AM Haojian Wu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Autho

r282007 - Remove some boilerplate comments that don't explain anything.

Author: echristo Date: Tue Sep 20 14:45:06 2016 New Revision: 282007 URL: http://llvm.org/viewvc/llvm-project?rev=282007&view=rev Log: Remove some boilerplate comments that don't explain anything. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://

Re: [PATCH] D24979: [CUDA] Support and std::min/max on the device.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D24979#554378, @jlebar wrote: > > I' personally would prefer to force-include these files. I suspect it will > > not change things much as we already include a

Re: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:1393 @@ +1392,3 @@ + +if (std::find(FeaturesVec.begin(), FeaturesVec.end(), "+power9-vector") != +FeaturesVec.end()) { Can you combine this with the power8 check above?

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Going to accept this pending the backend patch, but when that one is applied I wanted you to feel OK to add this. A couple of inline nitpick comments and some agreement that we should do s

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

echristo added inline comments. > spatel wrote in CGCall.cpp:1735 > I'm probably not imagining some use case, but I was hoping that we can just > delete the 4 (fast/inf/nan/nsz) that are already covered by instruction-level > FMF. An auto-upgrade might be needed within LLVM...and/or a big pile

[PATCH] D24909: fix for not copying fp denormal and trapping options.

echristo added a comment. Yes, none of this should be added or expanded in TargetOptions. Thanks! -eric https://reviews.llvm.org/D24909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D24815: [clang] make reciprocal estimate codegen a function attribute

echristo added inline comments. > mehdi_amini wrote in CGCall.cpp:1735 > I think I remember folks being against FMF on calls (Chris Lattner?), I'll > try to find the relevant discussion. > Otherwise your plan seems fine to me! Agreed. Also shouldn't hold up this patch :) https://reviews.llvm.o

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

echristo added a comment. There are two things pushing and pulling here: a) You want to be able to pass compiler code generation options at the time we're actually doing the code generation, b) "Traditionally" we don't pass CFLAGS to the linker. I think I'd like to see us passing more options d

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

echristo added a comment. In https://reviews.llvm.org/D24644#562286, @mehdi_amini wrote: > What about function attributes? Hey that's the trend :) > You could have a subset of the functions in their own sections but not all. > With LTO it means that you can disable this for a single input file.

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Hi Serge, I have a few questions here about this: In general this appears to be a lot more complex than the existing plugin solutions and requires quite a lot of custom cmake rules that are difficult to maintain. Why do we want this in general for the project? I understand the desire to make poll

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

Hi Serge! Thanks for a lot of the answers here :) > > The proposed infrastructure makes this process smoother and non intrusive > to the > llvm-project codebase: all development can be done in a separate git repo, > integration is controlled through cmake flags, and integration to > clang/opt/bug

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 3:07 PM Michael Kruse wrote: > Am Di., 7. Jan. 2020 um 18:57 Uhr schrieb Eric Christopher via > cfe-commits : > >> Is there anything I should have done? Probably reaching llvm-dev before > >> commiting. Reaching the right reviewers has always bee

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Wed, Jan 8, 2020 at 1:40 AM Serge Guelton wrote: > On Tue, Jan 07, 2020 at 04:57:29PM -0800, Eric Christopher wrote: > > > ; CHECK-EP-VECTORIZER-START-NEXT: Running pass: NoOpFunctionPass > > > +; CHECK-EXT: Running pass: {{.*}}::Bye on foo > > > &g

[clang-tools-extra] 549e55b - Temporarily Revert "[clangd] Add Random Forest runtime for code completion."

Author: Eric Christopher Date: 2020-09-18T14:47:43-07:00 New Revision: 549e55b3d5634870aa9d42135f51ad46a6a0e347 URL: https://github.com/llvm/llvm-project/commit/549e55b3d5634870aa9d42135f51ad46a6a0e347 DIFF: https://github.com/llvm/llvm-project/commit/549e55b3d5634870aa9d42135f51ad46a6a0e347

Re: [PATCH] D85384: [X86] Add basic support for -mtune command line option in clang

This would be because at that point the default cpu was that and it probably had something to do with fallbacks. At this point it can be changed I imagine to whatever makes sense. On Wed, Aug 19, 2020, 1:12 AM Craig Topper via Phabricator < revi...@reviews.llvm.org> wrote: > craig.topper added a

  1   2   3   4   5   6   7   8   9   >