Thanks for the text - I didn't have anything to add or change so I just used it verbatim :)
Committed thusly: Committed revision 374838. Committed f64329154c3 to svn. On Mon, Oct 7, 2019 at 9:36 AM Alina Sbirlea via Phabricator <revi...@reviews.llvm.org> wrote: > > asbirlea added a comment. > > Maybe elaborate in the patch description what `determine when and how we will > unroll loops.` means? > e.g.: > "The default before and after this patch is for LoopUnroll to be enabled, and > for it to use a cost model to determine whether to unroll the loop > (`OnlyWhenForced = false`). Before this patch, disabling loop unroll would > not run the LoopUnroll pass. After this patch, the LoopUnroll pass is being > run, but it restricts unrolling to only the loops marked by a pragma > (`OnlyWhenForced = true`). > In addition, this patch disables the UnrollAndJam pass when disabling > unrolling." > > Otherwise LGTM. > > > Repository: > rG LLVM Github Monorepo > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D68535/new/ > > https://reviews.llvm.org/D68535 > > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
