[clang] [flang] [llvm] [AArch64] Add ability to list extensions enabled for a target (PR #95805)

2024-06-26 Thread David Spickett via cfe-commits
DavidSpickett wrote: I very much doubt it is, your change is still in the next build (https://lab.llvm.org/buildbot/#/builders/134/builds/681) and that's green. https://github.com/llvm/llvm-project/pull/95805 ___ cfe-commits mailing list cfe-commits@l

[clang] [flang] [llvm] Re-land: "[AArch64] Add ability to list extensions enabled for a target" (#95805) (PR #96795)

2024-06-27 Thread David Spickett via cfe-commits
@@ -343,7 +350,9 @@ bool isX18ReservedByDefault(const Triple &TT); // themselves, they are sequential (0, 1, 2, 3, ...). uint64_t getCpuSupportsMask(ArrayRef FeatureStrs); -void PrintSupportedExtensions(StringMap DescMap); +void PrintSupportedExtensions(); + +void printEnabled

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111369 The configure Python script was removed by d6e0e6d255a7d54a3873b7a5d048eee00ef6bb6d / https://reviews.llvm.org/D69966. The readme was never updated with the cmake way to do it. I couldn't find any dedicat

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: One "andrew-podko" did request this get updated but that was in October 2020, so I expect they're not around anymore. https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Remove mention of BSD license in readme (PR #111371)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-07 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Remove mention of BSD license in readme (PR #111371)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111371 This seems to be an artifact from the intial import in 2012, but even if not, folks are better off reading the LICENSE.TXT file for the full details if they need them. Fixes #109968 >From 34f7c9c40cac39

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/111798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LGTM with the wording fixed. https://github.com/llvm/llvm-project/pull/111798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-14 Thread David Spickett via cfe-commits
@@ -598,6 +598,8 @@ WebAssembly Support AVR Support ^^^ +- Reject C/C++ compilation for avr1 devices which has no SRAM. DavidSpickett wrote: "which have no", since devices is plural. https://github.com/llvm/llvm-project/pull/111798 __

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-14 Thread David Spickett via cfe-commits
DavidSpickett wrote: Please add a release note in https://clang.llvm.org/docs/ReleaseNotes.html#avr-support (`clang/docs/ReleaseNotes.rst`). Otherwise, this looks good to me. https://github.com/llvm/llvm-project/pull/111798 ___ cfe-commits mailing l

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111528 I just tried using LLVM backend names here e.g. NVPTX but libclc want's targets more like triples. This change adds a mesasge to tell you that. Before you got: ``` libclc target 'AMDGCN' is enabled CMak

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111528 >From 686a0404c968d3bcec56bca232599465a9549312 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 8 Oct 2024 12:40:40 + Subject: [PATCH 1/2] [libclc] Give a helpful error when an unknown target i

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
@@ -151,6 +147,17 @@ if( "spirv-mesa3d-" IN_LIST LIBCLC_TARGETS_TO_BUILD OR "spirv64-mesa3d-" IN_LIST endif() endif() +if( LIBCLC_TARGETS_TO_BUILD STREQUAL "all" ) DavidSpickett wrote: I've put this after the spir-v tool check so that if you already knew t

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111369 >From a2dd2330359ecd3c04e01b6f9121481e6784014a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 7 Oct 2024 12:29:41 + Subject: [PATCH 1/2] [libclc] Update build instructions in readme The conf

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
@@ -23,29 +23,41 @@ generic implementations of most library requirements, allowing the target to override the generic implementation at the granularity of individual functions. -libclc currently only supports the PTX target, but support for more +libclc currently supports NVP

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also do you know if libclc has any tests worth running in CI? It doesn't have a check-libclc so I'm not sure if that's because there's not much to run, or running the tests requires a GPU or something else. Context is I've been looking at the pipeline we use for PRs and it

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From e02b44cf94c71c15235bb4727211587283778189 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH 1/5] [clang][Sema] Bad register variable type error should

[libclc] [libclc] Convert README to Markdown (PR #111549)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Github won't preview the markdown in the diff because the file moved, but you can see it here: https://github.com/llvm/llvm-project/blob/c84c1754ed6142293a2a06e75900772054cfcc67/libclc/README.md https://github.com/llvm/llvm-project/pull/111549 _

[clang] d079743 - [clang] Fix comment typos in CodeGen::EmitLoadOfGlobalRegLValue

2024-10-08 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-10-08T15:48:59Z New Revision: d079743fe67e05697fe55409115a3614e6fe5c45 URL: https://github.com/llvm/llvm-project/commit/d079743fe67e05697fe55409115a3614e6fe5c45 DIFF: https://github.com/llvm/llvm-project/commit/d079743fe67e05697fe55409115a3614e6fe5c45.diff LOG

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111528 >From 686a0404c968d3bcec56bca232599465a9549312 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 8 Oct 2024 12:40:40 + Subject: [PATCH 1/3] [libclc] Give a helpful error when an unknown target i

[clang] [clang] Change "bad" to "unsupported" in register type error (PR #111550)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111550 This is maybe a personal take but I expect "bad" to either mean: * Allowed but not ideal, like a "bad" memory alignment might work but it is slow. * The tool won't allow it but is going to tell me why it d

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-08 Thread David Spickett via cfe-commits
@@ -137,10 +137,6 @@ if( llvm-spirv_exe ) list( APPEND LIBCLC_TARGETS_ALL spirv-mesa3d- spirv64-mesa3d- ) endif() -if( LIBCLC_TARGETS_TO_BUILD STREQUAL "all" ) - set( LIBCLC_TARGETS_TO_BUILD ${LIBCLC_TARGETS_ALL} ) -endif() - list( SORT LIBCLC_TARGETS_TO_BUILD ) -

[libclc] [libclc] Convert README to Markdown (PR #111549)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change "bad" to "unsupported" in register type error (PR #111550)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/111550 >From 9e3a58e00ae5c52e6e0238e2288a21c8f895628d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 8 Oct 2024 15:41:51 + Subject: [PATCH 1/2] [clang] Change "bad" to "unsupported" in register type

[clang] [clang] Change "bad" to "unsupported" in register type error (PR #111550)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Added a release note. https://github.com/llvm/llvm-project/pull/111550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/110239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Change "bad" to "unsupported" in register type error (PR #111550)

2024-10-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111550 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Give a helpful error when an unknown target is requested (PR #111528)

2024-10-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From 84946607fc58927b1b44da2b70566abca041bbfb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH 1/3] [clang][Sema] Bad register variable type error should

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
@@ -7949,7 +7949,8 @@ NamedDecl *Sema::ActOnVariableDeclarator( } if (!R->isIntegralType(Context) && !R->isPointerType()) { -Diag(D.getBeginLoc(), diag::err_asm_bad_register_type); +Diag(TInfo->getTypeLoc().getBeginLoc(), + diag::err_asm

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From 84946607fc58927b1b44da2b70566abca041bbfb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH 1/5] [clang][Sema] Bad register variable type error should

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > This is still missing a release note, and adding the source range too would > be nice. Both done. https://github.com/llvm/llvm-project/pull/110239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-07 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From 84946607fc58927b1b44da2b70566abca041bbfb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH 1/4] [clang][Sema] Bad register variable type error should

[clang] [llvm] [ARM] Fix -mno-omit-leaf-frame-pointer flag doesn't works on 32-bit ARM (PR #109628)

2024-10-21 Thread David Spickett via cfe-commits
DavidSpickett wrote: FYI we found an issue with this when testing lldb - https://github.com/llvm/llvm-project/issues/113154 No clear indication yet whether this change uncovered an existing problem, or has caused a new one. https://github.com/llvm/llvm-project/pull/109628

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-21 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113160 >From 950796f7294617709ead792ed322772e7f8205fd Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/2] [ci] Write test results to unique file names In this

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-21 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113160 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/2] [ci] Write test results to unique file names In this

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-21 Thread David Spickett via cfe-commits
DavidSpickett wrote: You can see the new artifacts here: https://buildkite.com/llvm-project/github-pull-requests/builds/111782#0192af36-eae5-4676-b226-f6cf98fc1083 Just rebased to maybe get a clean Windows build, I think the failure there is due to the newline policy changes recently. https:/

[clang] f5aec03 - [clang][analyzer][NFC] Fix strange bracket placement

2024-10-10 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-10-10T15:51:06Z New Revision: f5aec03f6dd2f92590ecec9e3419b38b11d8476e URL: https://github.com/llvm/llvm-project/commit/f5aec03f6dd2f92590ecec9e3419b38b11d8476e DIFF: https://github.com/llvm/llvm-project/commit/f5aec03f6dd2f92590ecec9e3419b38b11d8476e.diff LOG

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Update build instructions in readme (PR #111369)

2024-10-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Thankyou! So I think in CI we can not add any extra testing targets if libclc is included in the build. If you have some in future I'm happy to help enable them. https://github.com/llvm/llvm-project/pull/111369 ___ cfe-commits ma

[libclc] [libclc] Convert README to Markdown (PR #111549)

2024-10-08 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/111549 A bit nicer to read on GitHub and with clickable links. No content changes purely formatting. >From c84c1754ed6142293a2a06e75900772054cfcc67 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 8 Oct

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-23 Thread David Spickett via cfe-commits
@@ -15,3 +15,5 @@ documentation setup. If you are writing a package for LLVM, see docs/Packaging.rst for our suggestions. + +Test line. DavidSpickett wrote: I should have mentioned this in a comment, https://github.com/llvm/llvm-project/pull/113160/commits/e

[clang] [llvm] Ci plugin (PR #113290)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 01/12] [ci] Write test results to unique file names In th

[clang] [llvm] Ci plugin (PR #113290)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 01/13] [ci] Write test results to unique file names In th

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/5] [ci] Write test results to unique file names In this

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113290 do not commit - testing plugins >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/3] [ci] Write test resu

[clang] [llvm] Ci plugin (PR #113290)

2024-10-23 Thread David Spickett via cfe-commits
DavidSpickett wrote: Abandoning this, as confirmed by https://discourse.llvm.org/t/using-plugins-in-buildkite-ci-that-require-docker/82701/3?u=davidspickett we cannot run docker on our Linux instances without a lot of hassle. Plus, the plugin authors do not want to support running without dock

[clang] [llvm] Ci plugin (PR #113290)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/113290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113447 Do not commit! >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/4] [ci] Write test results to unique fil

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
DavidSpickett wrote: ``` _bk;t=1728546187607Failed Tests (1): _bk;t=1728546187607 Clang :: Driver/hip-partial-link.hip ``` And the CI test failure is this, the reporting is not great because we run check- targets one after another. This test was already failing on main. If it fails again d

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, void AVRToolChain::addClangTargetOptions( const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, Action::OffloadKind DeviceOffloadKind) const { + // Reject C

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, void AVRToolChain::addClangTargetOptions( const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, Action::OffloadKind DeviceOffloadKind) const { + // Reject C

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, void AVRToolChain::addClangTargetOptions( const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, Action::OffloadKind DeviceOffloadKind) const { + // Reject C

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, void AVRToolChain::addClangTargetOptions( const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, Action::OffloadKind DeviceOffloadKind) const { + // Reject C

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/111798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/111798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: Thanks for getting to this I had forgotten I raised that issue. You should move your commit's message into the PR description, as the PR description is what's used for the final commit when we merge this. https://github.com/llvm/llvm-project/pull/111

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, void AVRToolChain::addClangTargetOptions( const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, Action::OffloadKind DeviceOffloadKind) const { + // Reject C

[clang] [Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
@@ -400,6 +400,14 @@ void AVRToolChain::AddClangSystemIncludeArgs(const ArgList &DriverArgs, void AVRToolChain::addClangTargetOptions( const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args, Action::OffloadKind DeviceOffloadKind) const { + // Reject C

[clang] [clang][Driver][AVR] Reject c/c++ compilation for avr1 devices (PR #111798)

2024-10-11 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/111798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/4] [ci] Write test results to unique file names In this

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 01/10] [ci] Write test results to unique file names In th

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 01/11] [ci] Write test results to unique file names In th

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/8] [ci] Write test results to unique file names In this

[clang] [llvm] Ci plugin (PR #113290)

2024-10-22 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113290 >From df728276026481b7397d2008541bfaed572774a7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/9] [ci] Write test results to unique file names In this

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Do we make any guarantees about supporting lit flags in the future? It's > mostly an internal tool, and I would personally be in support of removing > flags that are no longer used in tree, unless there are some extremely > compelling downstream use cases and there is an

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Basically, the sort of "plain text" report that gets added is the difference. > Is that correct? Yes, there is also a Linux report there that shows that it succeeded, but you have to select "All" on the "All | Failed" button. Which is maybe redundant but folks like seei

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From e9e79e33f06942e471dca6b727a4cd9cd6fa4563 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 29 Oct 2024 15:38:12 + Subject: [PATCH 1/4] [llvm][llvm-lit] Hide --use-unique-output-file-name f

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
DavidSpickett wrote: > FWIW, I didn't mean to derail this effort or create significant additional > complexity by saying what I said above. My intention was only to point out > the tradeoff of adding new functionality for a temporary benefit, which > wasn't clear to me had been thought about i

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
DavidSpickett wrote: I have updated this PR to include marking the option as hidden. If folks would be ok with that approach, I will break this up into individual parts for review and landing separately. If no, I will work more on the lit wrapper approach. @boomanaiden154 what do you think to

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
DavidSpickett wrote: I also looked through GitHub code search to see if anyone else was hitting this same issue. ROCm avoids it by splitting each check target into its own step: https://github.com/ROCm/ROCm/blob/bce439ecacc86b7f48934f5cc6be7ce2044412cf/.azuredevops/components/llvm-project.yml#L

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113660 None >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Bui

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: FYI Arm 32 bit is failing on a different test than most of these - https://lab.llvm.org/buildbot/#/builders/154/builds/6442 https://github.com/llvm/llvm-project/pull/97277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] 81e536e - [clang][test] Fix typo in arm-mfp8.cpp

2024-10-25 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-10-25T15:43:47Z New Revision: 81e536ec87a108d012cf9156a2c3fc672fb92155 URL: https://github.com/llvm/llvm-project/commit/81e536ec87a108d012cf9156a2c3fc672fb92155 DIFF: https://github.com/llvm/llvm-project/commit/81e536ec87a108d012cf9156a2c3fc672fb92155.diff LOG

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,91 @@ +// RUN: %clang_cc1 -std=c++11 -triple aarch64-arm-none-eabi -target-feature -fp8 -ast-dump %s | \ +// RUN: FileCheck %s --strict-whitespace + +// REQUIRES: aarch64-registered-target || arm-registered-target + +/* Various contexts where type __mfp8 can appear.

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: The version that does not use the lit feature: https://github.com/llvm/llvm-project/pull/113660 It's not complete but it's good enough to compare approaches I think. Another, probably objectionable choice, is to write a wrapper script that replaces lit, looks for the resu

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,91 @@ +// RUN: %clang_cc1 -std=c++11 -triple aarch64-arm-none-eabi -target-feature -fp8 -ast-dump %s | \ +// RUN: FileCheck %s --strict-whitespace + +// REQUIRES: aarch64-registered-target || arm-registered-target + +/* Various contexts where type __mfp8 can appear.

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113703 >From b7c270ad11c7b19edc7eff71922be9e19e830362 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113703 None >From b7c270ad11c7b19edc7eff71922be9e19e830362 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Bui

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,91 @@ +// RUN: %clang_cc1 -std=c++11 -triple aarch64-arm-none-eabi -target-feature -fp8 -ast-dump %s | \ +// RUN: FileCheck %s --strict-whitespace + +// REQUIRES: aarch64-registered-target || arm-registered-target + +/* Various contexts where type __mfp8 can appear.

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: mkfifo is a dead end, it silently fails to make the fifo when using bash for Windows. https://github.com/llvm/llvm-project/pull/113703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/113703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/4] [ci] Write test results to unique file names In this

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/4] [ci] Write test results to unique file names In this

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
DavidSpickett wrote: Passing result: https://buildkite.com/llvm-project/github-pull-requests/builds/112495 https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
DavidSpickett wrote: First version of the annotation: https://buildkite.com/llvm-project/github-pull-requests/builds/112464#annotation-linux-x64-test-results https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lis

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/7] [ci] Write test results to unique file names In this

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
DavidSpickett wrote: Now with styles, a failing build: https://buildkite.com/llvm-project/github-pull-requests/builds/112485 https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

<    1   2   3   4   5   6   7   >