DavidSpickett wrote: > FWIW, I didn't mean to derail this effort or create significant additional > complexity by saying what I said above. My intention was only to point out > the tradeoff of adding new functionality for a temporary benefit, which > wasn't clear to me had been thought about in those terms.
It didn't derail it, in fact it was good you brought it up because I was too hasty landing that part. I could and should have left it approved and included it as part of larger PRs like this before making any decisions. I don't consider working on any of the alternatives to be wasted time, I needed to think through them anyway. Not adding the lit option avoids any dependency on the GitHub Actions move, which would be when we could remove the option. We could take the risk there but we have a lot of holidays coming up who knows whether we'll get there before the 20 branch. > We configure in another directory, patch that lit, and configure with > -DLLVM_EXTERNAL_LIT=<path to the other lit> (which I have yet to test) So I think this is the best of the remaining methods to do this. Or the one that just occurred to me, which is hiding the lit option: https://docs.python.org/3/library/argparse.html#help (as usual, I'm not sure why I didn't think of this earlier) https://github.com/llvm/llvm-project/pull/113447 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
