Re: r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

Is this a workaround for now with the intent to fix this to allow such implicit specializations to have their debug info modularized? I believe this does work correctly in modular debug info with expliict modules, would probably be sort of nice to have these things be consistent/similar? On Tue, O

Re: r344957 - Give Multiversion-inline functions linkonce linkage

On Mon, Oct 29, 2018 at 11:30 AM Keane, Erich wrote: > GCC actually doesn’t support function multiversioning in C mode, so this > fix is part of our extension to support C with multiversioning. > Ah, what's the motivation for that? > I perhaps wonder if this is part of the reason GCC only su

Re: r344957 - Give Multiversion-inline functions linkonce linkage

On Mon, Oct 29, 2018 at 11:46 AM Keane, Erich wrote: > > > > > *From:* David Blaikie [mailto:dblai...@gmail.com] > *Sent:* Monday, October 29, 2018 11:41 AM > *To:* Keane, Erich > *Cc:* Eric Christopher ; cfe-commits@lists.llvm.org > > > *Subject:* Re: r344957 - Give Multiversion-inline function

Re: r345109 - Debug Info (-gmodules): emit full types for non-anchored template specializations

Fair enough - pity we couldn't readily have a single implementation or at least semantics for modular debug info between implicit and explicit modes (I mean, my fault in part for building a separate/new system when I did modular codegen anyway) but hopefully we'll move to explicit modules across th

Re: r350856 - Split -Wdelete-non-virtual-dtor into two groups

Might be handy to summarize the changes from the previous reverted version of this patch (& mention the original commit revision and revert revision) - in the commit message is ideal, but in a reply to the commit after the fact will do in a pinch On Fri, Jan 11, 2019 at 4:06 AM Erik Pilkington via

Re: r345695 - Change "struct" to "class" to avoid warnings

Could you link to/quote the warnings - might be helpful to understanding what's being addressed here On Tue, Oct 30, 2018 at 10:00 PM Bill Wendling via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: void > Date: Tue Oct 30 21:58:34 2018 > New Revision: 345695 > > URL: http://llvm.org/

Re: r345591 - [CodeGen] Disable the machine verifier on a ThinLTO test

If ThinLTO doesn't pass the machine verifier - should it maybe be turned off at the thinlto level in general, rather than for this specific test? On Tue, Oct 30, 2018 at 5:20 AM Francis Visoiu Mistrih via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: thegameg > Date: Tue Oct 30 05:18

Re: r342827 - Fix modules build with shared library.

Shuai - have you had a chance to look at this? On Mon, Oct 22, 2018 at 4:43 PM Richard Smith wrote: > On Mon, 22 Oct 2018 at 14:57, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Richard - any further thoughts here (re: layering/dependencies, e

r346439 - [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too

Author: dblaikie Date: Thu Nov 8 12:47:30 2018 New Revision: 346439 URL: http://llvm.org/viewvc/llvm-project?rev=346439&view=rev Log: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too The current version only emits the below error for a module (attempted to be

Re: r346266 - Don't use std::next() on an input iterator; NFC.

The previous code didn't have a conditional for Iter != End - was that a bug? Should there be a test case for that bug? If that's not an actual change in behavior, could it be an assert instead of a condition? On Tue, Nov 6, 2018 at 1:14 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.o

Re: r346266 - Don't use std::next() on an input iterator; NFC.

Thanks! On Mon, Nov 12, 2018 at 2:14 PM Aaron Ballman wrote: > On Mon, Nov 12, 2018 at 1:30 PM David Blaikie wrote: > > > > The previous code didn't have a conditional for Iter != End - was that a > bug? Should there be a test case for that bug? > > > > If that's not an actual change in behavio

r346789 - DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use.

Author: dblaikie Date: Tue Nov 13 12:08:13 2018 New Revision: 346789 URL: http://llvm.org/viewvc/llvm-project?rev=346789&view=rev Log: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use. Summary: This saves a lot of relocations in optimized object files (at the cost of

r346928 - Fix combining pragma __debug dump & parser_crash with -E

Author: dblaikie Date: Wed Nov 14 19:04:21 2018 New Revision: 346928 URL: http://llvm.org/viewvc/llvm-project?rev=346928&view=rev Log: Fix combining pragma __debug dump & parser_crash with -E Previously these would be transformed into annotation tokens and the preprocessor would then assume they

r346926 - Stmt bits: Make ExprBits relative to StmtBits

Author: dblaikie Date: Wed Nov 14 19:04:18 2018 New Revision: 346926 URL: http://llvm.org/viewvc/llvm-project?rev=346926&view=rev Log: Stmt bits: Make ExprBits relative to StmtBits Seems like it makes it a bit easier to read/validate/update in the future. Modified: cfe/trunk/include/clang/AS

r346927 - Rewrite-imports on crash: Simplify handling

Author: dblaikie Date: Wed Nov 14 19:04:19 2018 New Revision: 346927 URL: http://llvm.org/viewvc/llvm-project?rev=346927&view=rev Log: Rewrite-imports on crash: Simplify handling -frewrite-imports already implies -frewrite-includes (it piggy-backs on/extends the implementation) so there's no need

r346929 - NFC cleanup: Prefer make_unique over reset(new T())

Author: dblaikie Date: Wed Nov 14 19:04:23 2018 New Revision: 346929 URL: http://llvm.org/viewvc/llvm-project?rev=346929&view=rev Log: NFC cleanup: Prefer make_unique over reset(new T()) Modified: cfe/trunk/lib/Parse/ParsePragma.cpp Modified: cfe/trunk/lib/Parse/ParsePragma.cpp URL: http://

r347141 - Sink BuryPointer from Clang into LLVM for reuse there

Author: dblaikie Date: Sat Nov 17 10:04:13 2018 New Revision: 347141 URL: http://llvm.org/viewvc/llvm-project?rev=347141&view=rev Log: Sink BuryPointer from Clang into LLVM for reuse there Modified: cfe/trunk/include/clang/Frontend/CompilerInstance.h cfe/trunk/include/clang/Frontend/Utils

Re: r347035 - [clang] - Simplify tools::SplitDebugName.

Just copying some of the information given through Phab ( https://reviews.llvm.org/rL347035 ) - this patch was reverted in r347676. Would be great to get that fixed/recommitted! On Fri, Nov 16, 2018 at 12:01 AM George Rimar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: grimar > D

Re: r347588 - Revert "[clang][slh] add attribute for speculative load hardening"

Also, including the SVN revision (llvm's util/git-svn/git-svnrevert script can help with this) is helpful for other folks following along who may not be using git. On Mon, Nov 26, 2018 at 12:19 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Nov 26, 2018 at 3:13 PM

Re: r348131 - [AST] Fix an uninitialized bug in the bits of FunctionDecl

Why the change from using setter functions to direct assignment? On Mon, Dec 3, 2018 at 5:06 AM Bruno Ricci via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: brunoricci > Date: Mon Dec 3 05:04:10 2018 > New Revision: 348131 > > URL: http://llvm.org/viewvc/llvm-project?rev=348131&vie

Re: r348131 - [AST] Fix an uninitialized bug in the bits of FunctionDecl

Ah, thanks for the explanation! No worries about pre-commit review or anything - this is what post-commit review is :) Only note for the future is that it might be worth mentioning in the body of the commit message (title/first line was fine) so it's clear why this "extra" work is being done. Than

Re: [PATCH] D55377: Allow forwarding -fdebug-compilation-dir to cc1as

Would it be worth considering whether -fdebug-compilation-dir and -fdebug-prefix-map could be unified, perhaps by having a placeholder that could be used in -fdebug-prefix-map for the current directory? I guess they're low-maintenance enough that it's probably not, but figured I'd ask. On Thu, De

Re: r348685 - Move diagnostic enums into Basic.

Hey Richard, Thanks for cleaning up some of the layering here! I /think/ I vaguely recall having a conversation with Richard Smith about a different direction to fix the layering of the diagnostics system - but it was/is more involved. Ah, here, apparently I sent out a WIP patch & must've got eng

Re: r354843 - [CGDebugInfo] Set NonTrivial DIFlag to a c++ record if it's not trivial

Hi Aaron, I don't see any mention of this in D44406 - so it might have been good to have a separate review for this (or included this in the review of D44406, which I think is possible with the monorepo). Specifically - this change is missing test coverage (there should be a clang test that goes

r358464 - DebugInfo: Default to standalone debug when tuning for LLDB

Author: dblaikie Date: Mon Apr 15 17:16:29 2019 New Revision: 358464 URL: http://llvm.org/viewvc/llvm-project?rev=358464&view=rev Log: DebugInfo: Default to standalone debug when tuning for LLDB LLDB can't currently handle Clang's default (limit/no-standalone) DWARF, so platforms that default to

r358795 - Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter

Author: dblaikie Date: Fri Apr 19 16:02:30 2019 New Revision: 358795 URL: http://llvm.org/viewvc/llvm-project?rev=358795&view=rev Log: Modules: Search for a visible definition of the decl context when computing visibility of a default template parameter The code is/was already correct for the ca

r358796 - Modules: Adopt template parameters for variable templates to set their decl context correctly

Author: dblaikie Date: Fri Apr 19 16:04:05 2019 New Revision: 358796 URL: http://llvm.org/viewvc/llvm-project?rev=358796&view=rev Log: Modules: Adopt template parameters for variable templates to set their decl context correctly Exposed by a related bug about visibility of default arguments of n

r359217 - DebugInfo: Fix bitrotted test case

Author: dblaikie Date: Thu Apr 25 11:11:48 2019 New Revision: 359217 URL: http://llvm.org/viewvc/llvm-project?rev=359217&view=rev Log: DebugInfo: Fix bitrotted test case This test was updated with some CHECK suffix variants, but dropped checking for the unsuffixed 'CHECK' Modified: cfe/trunk

r359235 - Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug)

Author: dblaikie Date: Thu Apr 25 13:05:47 2019 New Revision: 359235 URL: http://llvm.org/viewvc/llvm-project?rev=359235&view=rev Log: Skip type units/type uniquing when we know we're only emitting the type once (vtable-based emission when triggered by a strong vtable, with -fno-standalone-debug

r359800 - Do not warn on switches over enums that do not use [[maybe_unused]] enumerators

Author: dblaikie Date: Thu May 2 09:30:49 2019 New Revision: 359800 URL: http://llvm.org/viewvc/llvm-project?rev=359800&view=rev Log: Do not warn on switches over enums that do not use [[maybe_unused]] enumerators PR36231, [dcl.attr.unused]p3 Reviewers: aaron.ballman Differential Revision: htt

r359854 - SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload notes

Author: dblaikie Date: Thu May 2 17:44:50 2019 New Revision: 359854 URL: http://llvm.org/viewvc/llvm-project?rev=359854&view=rev Log: SemaOverload: Complete candidates before emitting the error, to ensure diagnostics emitted (or suppressed) during completion don't interfere with the overload no

r359913 - Remove else-after-return

Author: dblaikie Date: Fri May 3 11:11:31 2019 New Revision: 359913 URL: http://llvm.org/viewvc/llvm-project?rev=359913&view=rev Log: Remove else-after-return Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org/viewvc/llvm-project/

Re: r359960 - Reduce amount of work ODR hashing does.

Does the ODR hashing have some sort of cycle breaking infrastructure - so that if the same type is seen more than once (eg: classes have members that have pointers back to the outer class type, etc) they don't cause indefinite cycles? Should that infrastructure have caught these cases & avoided the

Re: r359960 - Reduce amount of work ODR hashing does.

On Mon, May 6, 2019 at 4:24 PM Richard Trieu wrote: > > There was no cycle for this crash. Oh, yeah, didn't mean to imply there were - but that a system designed to prevent cycles might also be used/help prevent redundant work like this. > What happened is that an exponential runtime is reduced

r360195 - -frewrite-imports: Add support for wildcard rules in umbrella modules with

Author: dblaikie Date: Tue May 7 14:38:51 2019 New Revision: 360195 URL: http://llvm.org/viewvc/llvm-project?rev=360195&view=rev Log: -frewrite-imports: Add support for wildcard rules in umbrella modules with This trips over a few other limitations, but in the interests of incremental developme

Re: r342165 - Support -fno-omit-frame-pointer with -pg.

Seems like it might be problematic to have this separate implementation of checking whether frame pointers are enabled compared to the canonical one (the one actually used to enable/disable frame pointers) in the static "shouldUseFramePointer" Function? (eg: apparently on some targets (mustUseNonL

Re: r342214 - remove 11 years old videos from the homepage. if you have a suggestion, please drop me an email

If you're going to remove these, might as well remove the html files they link to? On the other hand, might be worth keeping these around/linked to, but for posterity/archival purposes, rather than as sources of legitimately useful information for people trying to use LLVM today. On Fri, Sep 14,

r342510 - Fix fomit-frame-pointe+pg error

Author: dblaikie Date: Tue Sep 18 13:11:45 2018 New Revision: 342510 URL: http://llvm.org/viewvc/llvm-project?rev=342510&view=rev Log: Fix fomit-frame-pointe+pg error Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL: http://llvm.org

Re: [PATCH] D52191: Fix logic around determining use of frame pointer with -pg.

Fixed in r342510 with the solution I mentioned up-thread. On Tue, Sep 18, 2018 at 1:10 PM Volodymyr Sapsai via Phabricator < revi...@reviews.llvm.org> wrote: > vsapsai added a comment. > > Confirm that reverting the change locally fixes the tests. If nobody beats > me to it, I plan to revert the

Re: r342827 - Fix modules build with shared library.

Hey Eric - thanks for the fix - but could you explain the issue here in a bit more detail, as I'm a bit confused (& really interested in understanding any layering problems in LLVM - and fixing them/making sure they're fixed/holding the line/etc) What do you mean by "pull all of the AST matchers l

Re: r342827 - Fix modules build with shared library.

+Shuai Wang On Tue, Sep 25, 2018 at 2:14 PM David Blaikie wrote: > Hey Eric - thanks for the fix - but could you explain the issue here in a > bit more detail, as I'm a bit confused (& really interested in > understanding any layering problems in LLVM - and fixing them/making sure > they're fixe

Re: r343224 - [Tooling] Get rid of uses of llvm::Twine::str which is slow. NFC

On Thu, Sep 27, 2018 at 7:51 AM Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date: Thu Sep 27 07:50:24 2018 > New Revision: 343224 > > URL: http://llvm.org/viewvc/llvm-project?rev=343224&view=rev > Log: > [Tooling] Get rid of uses of llvm::Twine::str which is sl

Re: r342912 - [CodeGen] Revert commit https://reviews.llvm.org/rL342717

When reverting patches it's helpful to include some context (links to buildbots, plus inline/textual descriptions of errors, etc) for why the change is being made - so people looking to explain the failure they're seeing can see if this change is intended to address it, or if someone's going back t

Re: r343279 - [cxx2a] P0624R2: Lambdas with no capture-default are

Awesome - should/does this mean stateless lambdas can be used in uninitialized contexts? std::set s; Would be kind of neat/handy (so you didn't have to pass in the comparator on construction, etc) On Thu, Sep 27, 2018 at 3:48 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote:

Re: r343279 - [cxx2a] P0624R2: Lambdas with no capture-default are

Excellent, excellent - thanks! On Mon, Oct 1, 2018 at 10:22 AM Richard Smith wrote: > On Mon, 1 Oct 2018, 09:55 David Blaikie via cfe-commits, < > cfe-commits@lists.llvm.org> wrote: > >> Awesome - should/does this mean stateless lambdas can be used in >> uninitializ

Re: r342827 - Fix modules build with shared library.

I can't really reproduce this - when I try to build clang/llvm with LLVM_ENABLE_MODULES in CMake I'm still seeing an error I reported March on a cfe-dev thread - something to do with unique_ptr instantiations for MappedBlockStream in the PDB parsing code. So, I'm wondering what error you hit, Eric

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Seems like a rather complex test case - could you explain what's going on there? (maybe in the form of a comment in the code - what path through all those classes is required to tickle this) On Wed, Aug 23, 2017 at 2:25 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Autho

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

*nod* Thanks - let me know if you have trouble simplifying or explaining it & I'll see if fresh eyes help :) On Mon, Aug 28, 2017 at 4:46 PM Adrian Prantl wrote: > It's possible that this testcase can be golfed some more. I copied it > almost verbatim from the PR. I'll see what I can do. The imp

Re: [PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

On Fri, Aug 18, 2017 at 6:59 PM Stephan T. Lavavej via Phabricator via cfe-commits wrote: > STL_MSFT added a comment. > > In https://reviews.llvm.org/D36860#846232, @thakis wrote: > > > Many driver tests check in a basic representative directory structure > (e.g. test/Driver/Inputs/basic_freebsd_

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

Feels like this alignment attribute may be a bit of a death trap, then? Should other uses of the attribute be scrutinized, or could we come up with a portable way to use it safely? (using a different attribute on different compilers - sounded like maybe one form worked with MSVC and a different for

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

On Mon, Aug 28, 2017 at 5:21 PM Reid Kleckner wrote: > On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote: > >> Feels like this alignment attribute may be a bit of a death trap, then? >> Should other uses of the attribute be scrutinized, or could we come up with >> a portable way to use it saf

r312268 - Disable clang-format's MemoizationTest as it becomes prohibitive with EXPENSIVE_CHECKS

Author: dblaikie Date: Thu Aug 31 11:49:34 2017 New Revision: 312268 URL: http://llvm.org/viewvc/llvm-project?rev=312268&view=rev Log: Disable clang-format's MemoizationTest as it becomes prohibitive with EXPENSIVE_CHECKS EXPENSIVE_CHECKS enables libstdc++'s library consistency checks, which inc

Re: [PATCH] D37428: Debug info: Fixed faulty debug locations for attributed statements

Seems like the test case should/could be simplified a bit, maybe? (could it be something really simple like "void f(bool b) { #pragma ... while (b) ; }"?) Also, is it relying on LLVM optimizations to run (add "-disable-llvm-passes" to the command line to be sure it isn't, perhaps?)? On Sun, Sep 3

Re: [PATCH] D37428: Debug info: Fixed faulty debug locations for attributed statements

Fine to remove it if it didn't change the test - it just wasn't clear to me what exactly was being tested at the time so it was more "does this test still work with/without -disable-llvm-passes". No worries. On Tue, Sep 5, 2017 at 10:58 PM Karl-Johan Karlsson via Phabricator < revi...@reviews.llv

Re: r312580 - Fix memory leak after r312467. The ModuleMap is the owner of the global module object until it's reparented under a real module.

On Tue, Sep 5, 2017 at 2:47 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Sep 5 14:46:22 2017 > New Revision: 312580 > > URL: http://llvm.org/viewvc/llvm-project?rev=312580&view=rev > Log: > Fix memory leak after r312467. The ModuleMap is the o

Re: r362005 - Fix an unused-variable error.

If this is the only use of 'S', might be better/good to roll the expression into the assertion? On Wed, May 29, 2019 at 11:33 AM Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Wed May 29 11:36:54 2019 > New Revision: 362005 > > URL: http://llvm.org/viewvc

r362856 - DebugInfo: Add support for 'nodebug' attribute on typedefs and alias templates

Author: dblaikie Date: Fri Jun 7 17:01:21 2019 New Revision: 362856 URL: http://llvm.org/viewvc/llvm-project?rev=362856&view=rev Log: DebugInfo: Add support for 'nodebug' attribute on typedefs and alias templates Seems like a logical extension to me - and of interest because it might help reduce

Re: r362856 - DebugInfo: Add support for 'nodebug' attribute on typedefs and alias templates

I admit the names can take > up space. > (I'm not really objecting, it's just hard to intuit a big size benefit.) > --paulr > > > -Original Message- > > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > David Blaiki

r363606 - PR42205: DebugInfio: Do not attempt to emit debug info metadata for static member variable template partial specializations

Author: dblaikie Date: Mon Jun 17 12:40:52 2019 New Revision: 363606 URL: http://llvm.org/viewvc/llvm-project?rev=363606&view=rev Log: PR42205: DebugInfio: Do not attempt to emit debug info metadata for static member variable template partial specializations Would cause a crash in an attempt to

Re: r367940 - [Sema] Add -Wpointer-compare

This seems a bit narrow - could it be generalized to all cases of '\0' as a null pointer? On Mon, Aug 5, 2019 at 3:14 PM George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date: Mon Aug 5 15:15:40 2019 > New Revision: 367940 > > URL: http://llvm.org/viewvc/ll

r365406 - [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

Author: dblaikie Date: Mon Jul 8 16:24:41 2019 New Revision: 365406 URL: http://llvm.org/viewvc/llvm-project?rev=365406&view=rev Log: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable. This is a fix for rG864949 which only disabled default constru

Re: r360452 - Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways

What's the practical difference between "UNSUPPORTED: foo" and "REQUIRES: !foo"? (I see some of the fixes you've made go one way, some the other way) On Fri, May 10, 2019 at 11:30 AM Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: probinson > Date: Fri May 10 11:32:53

Re: r360452 - Replace 'REQUIRES: nozlib' with '!zlib' because we don't need two ways

Fair enough - since they're already there I don't feel super serious about converging on one (though I probably wouldn't've been in favor of adding a second spelling at the point it was proposed). On Tue, May 14, 2019 at 8:03 AM wrote: > > There's no practical difference. I view it as a matter o

Re: r359960 - Reduce amount of work ODR hashing does.

On Tue, May 7, 2019 at 7:40 PM Richard Trieu wrote: > > > From: David Blaikie > Date: Mon, May 6, 2019 at 4:39 PM > To: Richard Trieu > Cc: cfe-commits > >> On Mon, May 6, 2019 at 4:24 PM Richard Trieu wrote: >> > >> > There was no cycle for this crash. >> >> Oh, yeah, didn't mean to imply there

r361428 - Modules: Code generation of enum constants for merged enum definitions

Author: dblaikie Date: Wed May 22 13:36:06 2019 New Revision: 361428 URL: http://llvm.org/viewvc/llvm-project?rev=361428&view=rev Log: Modules: Code generation of enum constants for merged enum definitions Found in a bootstrap of LLVM with implicit modules, resulting in a deadlock of some Orc uni

r361439 - Fix r361428 for Windows buildbots/mangling

Author: dblaikie Date: Wed May 22 14:58:17 2019 New Revision: 361439 URL: http://llvm.org/viewvc/llvm-project?rev=361439&view=rev Log: Fix r361428 for Windows buildbots/mangling Modified: cfe/trunk/test/Modules/enum-codegen.cpp Modified: cfe/trunk/test/Modules/enum-codegen.cpp URL: http://l

Re: r361428 - Modules: Code generation of enum constants for merged enum definitions

Please have a look? > . . . > Failing Tests (1): > Clang :: Modules/enum-codegen.cpp > > The builder was already red and did not send any notifications. > > Thanks > > Galina > > On Wed, May 22, 2019 at 1:33 PM David Blaikie via cfe-commits < > cfe-commits@lists.llvm.or

Re: r346789 - DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use.

(tiny factoid: turns out gold's 64 bit gdb-index support is also broken in a different, more subtle way... - so best folks don't use this flag except with lld, it seems, if you're using gdb-index) On Tue, Nov 13, 2018 at 12:10 PM David Blaikie via cfe-commits < cfe-commits@lis

r349669 - PR40096: Forwards-compatible with C++20 rule regarding aggregates not having user-declared ctors

Author: dblaikie Date: Wed Dec 19 11:33:35 2018 New Revision: 349669 URL: http://llvm.org/viewvc/llvm-project?rev=349669&view=rev Log: PR40096: Forwards-compatible with C++20 rule regarding aggregates not having user-declared ctors Looks like these were in place to make these types move-only. Th

Re: r350143 - Add vtable anchor to classes.

While I realize it's in the coding standard - is there any particular other motivation for this? (Given you've been doing layering cleanup - I'm wondering fi this is an interesting workaround for some layering problems, for instance?) On Sat, Dec 29, 2018 at 1:05 PM Richard Trieu via cfe-commits <

Re: r372681 - Support for DWARF-5 C++ language tags.

This broke gnu_pubnames and other forms of DWARF index of C++ code - fixed in r373420 (feel free to post-comimt review, etc, of course) On Mon, Sep 23, 2019 at 5:36 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Mon Sep 23 17:38:49 2019 > New Revisi

Re: r372681 - Support for DWARF-5 C++ language tags.

Out of curiosity, should/would this've shown up for you Apple folks too? (as a failure in the apple/lldb accelerator tables - because the names would be similarly incorrect) had it just not got to the necessary testing yet? On Wed, Oct 2, 2019 at 8:29 AM Adrian Prantl wrote: > > > On Oct 1, 2019

Re: r372681 - Support for DWARF-5 C++ language tags.

Yeah, something about linkage - but that's not the part that's as likely to be a problem as the other part: the other test for C++ language was what causes LLVM to compute the fully qualified name of an entity in the accelerator table ("foo::bar" instead of just "bar" (eg: the bug was things like "

Re: r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

(mostly joking) any interest in seeing what it'd take to make Clang/LLVM -Wmissing-prototype clean? (which would also catch the same sort of issues, I think?) On Tue, Oct 1, 2019 at 4:10 PM John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rjmccall > Date: Tue Oct 1 16:1

Re: [PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

I'm not sure this is a practical direction to pursue - though perhaps others disagree. It's likely non-trivial to plumb a flag through most build systems to be applied only to test code (& likely would suppress the warning in headers only included in test code - so for example, in a header-only li

Re: [PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

On Mon, Apr 16, 2018 at 12:08 PM Roman Lebedev via Phabricator < revi...@reviews.llvm.org> wrote: > lebedev.ri added a comment. > > In https://reviews.llvm.org/D45685#1069040, @dblaikie wrote: > > > I'm not sure this is a practical direction to pursue - though perhaps > > others disagree. > > > >

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

FWIW I don't fundamentalyl object to also having something like -wtest. Probably needs a better name though (unfortunately the double-negative gets confusing... - like you want to describe the set of diagnostics that should not be used in test code, so that as a group might be "-Wnon-test" but then

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

Is there anything else in the "-w" namespace other than the literal "-w" so far? I mean, I could imagine it might make more sense to default these warnings off & users can turn them on for non-test code, potentially? So "-Wnon-test" might make sense. On Mon, Apr 23, 2018 at 3:22 PM John McCall vi

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < revi...@reviews.llvm.org> wrote: > rjmccall added a comment. > > In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: > > > Is there anything else in the "-w" namespace other than the literal "-w" > so > > far? > > > No. This w

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: > On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > >> On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < >> revi...@reviews.llvm.org> wrote: >> >>> rjmccall added a comment. >>> >>> In https://reviews.llvm.org/D45766#1076176, @

r330671 - Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM

Author: dblaikie Date: Mon Apr 23 17:59:22 2018 New Revision: 330671 URL: http://llvm.org/viewvc/llvm-project?rev=330671&view=rev Log: Fix build break due to content moving from Scalar.h to InstCombine.h in LLVM Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp Modified: cfe/trunk/lib/CodeGen/

Re: r331536 - [NFC]Convert Class to use member initialization instead of inline.

Perhaps this should use non-static data member initializers instead? On Fri, May 4, 2018 at 9:23 AM Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Fri May 4 09:19:53 2018 > New Revision: 331536 > > URL: http://llvm.org/viewvc/llvm-project?rev=331536

Re: r331536 - [NFC]Convert Class to use member initialization instead of inline.

On Mon, May 7, 2018 at 12:57 PM Keane, Erich wrote: > I don’t believe the member initialization for bitfields (of which all the > ‘0’ values are) happened until C++17, right? > Ah, fair point - I hadn't looked at the types, just what was visible in the patch. (& I don't especially know/recall wh

Re: r335022 - Revert r335019 "Update NRVO logic to support early return (Attempt 2)"

Whenever possible, do include context for why a patch is being reverted in the commit message - buildbot links, but also potentially describing/copy-pasting inline whatever the problem(s) are. This makes it easier for people tracking the state of upstream to know whether they may need to pull in th

r335938 - DebugInfo: Add -gno-gnu-pubnames to allow disabling gnu-pubnames later in the command line

Author: dblaikie Date: Thu Jun 28 15:58:04 2018 New Revision: 335938 URL: http://llvm.org/viewvc/llvm-project?rev=335938&view=rev Log: DebugInfo: Add -gno-gnu-pubnames to allow disabling gnu-pubnames later in the command line Modified: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/

Re: [PATCH] D47953: [builtin] Add bitfield support for __builtin_dump_struct

Yeah, doesn't look like this code handles a value crossing the boundary of the size of the bitfield type (it's reading only the low bit). I suspect looking at the code that generates bitfield accesses would be useful - and/or maybe actually calling into that very code, rather than reimplementing i

r336020 - Spurious commit just to help Richard, because git is weird.

Author: dblaikie Date: Fri Jun 29 14:58:24 2018 New Revision: 336020 URL: http://llvm.org/viewvc/llvm-project?rev=336020&view=rev Log: Spurious commit just to help Richard, because git is weird. Modified: cfe/trunk/test/Modules/codegen.test Modified: cfe/trunk/test/Modules/codegen.test URL:

Re: r336219 - Fix crash in clang.

Did this fail on an existing regression test, or is there a need for more test coverage? (guessing it failed on existing tests) Also, is the makeArrayRef necessary? Looks like if the original code compiled (implicitly converting from vector to ArrayRef) then the new code wouldn't need a makeArrayR

Re: r336219 - Fix crash in clang.

On Mon, Jul 9, 2018 at 1:52 PM Zachary Turner wrote: > makeArrayRef() isn't necessary, but when I was first looking at this I had > to stare at the code for a bit to see that there was an implicit conversion > happening. So I put the makeArrayRef() just for the benefit of the person > reading th

Re: r336475 - Check returned type is valid before using it.

Thanks for the fix! Though maybe this isn't the best diagnostic experience - given that 'bar' isn't technically an overloaded function, but is a function template - worth doing something more precise here? (maybe not) Wonder if there's similar handling for other diagnostic cases that could be use

Re: [PATCH] D49265: [Tooling] Add operator== to CompileCommand

Any chance this can/should be unit tested? (also, in general (though might not matter in this instance), symmetric operators like == should be implemented as non-members (though they can still be friends and if they are, can be defined inline in the class definition as a member could be), so any im

r375304 - DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

Author: dblaikie Date: Fri Oct 18 16:58:34 2019 New Revision: 375304 URL: http://llvm.org/viewvc/llvm-project?rev=375304&view=rev Log: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization Differential Revision: https:/

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

+1 to what Nico said/ping on this. Jian - could you see if these tests could be made portable as Nico's suggested? On Mon, Oct 14, 2019 at 3:54 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hm, this means the test can't run on non-linux, so if someone breaks it on > e.g. w

Re: r374844 - Revert "Dead Virtual Function Elimination"

+1/ping on this - Jorge, could you include some details about the reason for the revert & the revision? On Mon, Oct 14, 2019 at 5:06 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Jorge, > > Please mention the reason for a revert in revert commit messages. Also, > unti

Re: [clang] 9671d1d - [clang]Fixup clang -Werror, , -Wcovered-switch-default build failures

FWIW that probably produces a -Wreturn-type warning because other compilers don't conservatively assume that only the enumerator values can be in an enum variable (rather than all of its representable values). The subsequent -Wreturn-type warning was fixed in 45787e56829f (moving the unreachable to

Re: r374837 - [clang] add requirements to -Wa,-W test cases.

Thanks for the details! Generally it's fine to have these discussions on-list, or at least to include a summary reply so it's clear loose ends were tied up. On Mon, Oct 28, 2019 at 4:26 PM Jian Cai wrote: > Hi David, > > Thanks for the follow up. I already discussed it with Nico over email and >

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

On Thu, Oct 24, 2019 at 3:24 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator < > revi...@reviews.llvm.org> wrote: > > dblaikie added a comment. > > In D67723#1720509 , @a

Re: [clang-tools-extra] 61559d0 - [clangd] Squash GCC error with StringRef + gtest MatchesRegex()

Might be handy to link to a buildbot and/or quote the specific error message in the commit message for changes like this so it's clear what's being addressed by the change. On Tue, May 19, 2020 at 4:58 AM Sam McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Sam McCall > Dat

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Did this end up moving to a review thread? Could someone include a link to that phab review, if it did. Otherwise - I'd still be curious about the answer to Sam's question about SuppressUnwrittenScope & see if the inline namespaces could be avoided & then going for the "modifying getFullyQualified

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Ah, thanks for the context/update! On Tue, Jun 2, 2020 at 12:37 AM Jean-Baptiste Lespiau wrote: > Yes it was: https://reviews.llvm.org/D80800#2065643 > > Thanks to Sam, I understand the situation better, but I have been slowed > down quite a lot by the fact that > (a) the logic to print types is

<    1   2   3   4   5   6   7   8   9   10   >