On Mon, Aug 28, 2017 at 5:21 PM Reid Kleckner <r...@google.com> wrote:
> On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie <dblai...@gmail.com> wrote: > >> Feels like this alignment attribute may be a bit of a death trap, then? >> Should other uses of the attribute be scrutinized, or could we come up with >> a portable way to use it safely? (using a different attribute on different >> compilers - sounded like maybe one form worked with MSVC and a different >> form worked with GCC? Maybe the attribute could be improved to use those as >> appropriate?) >> > > I never was able to reproduce the user issue, so I have very little > information. I have a hard time believing that mingw32 gcc miscompiles all > alignment attributes. There must have been something funny about our usage > of it in ExprConstant.cpp that triggered the bug. In the unlikely case that > we hit it again, hopefully the next user that hits the bug will provide > more information about what went wrong. > Hrm - I really don't like the idea of making changes without really understanding what's being addressed. :/ - Dave
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
