[clang] [HLSL] Vector vector standard conversions (PR #71098)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/71098 >From 6bf40beff47c6bfcc73ce4c5d75bd47b52e6959c Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 1 Nov 2023 12:18:43 -0500 Subject: [PATCH] [HLSL] Vector vector standard conversions HLSL supports vecto

[clang] Avoid copying Param and Constr (PR #65488)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/65488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

llvm-beanz wrote: @cor3ntin, I've in parallel been working on fleshing out the immediately relevant bits of our language spec. This PR describes the _pp-number_ and _vector-literal_ grammars roughly correctly to this change. I think I've addressed all the other feedback on the PR, please let m

[clang] Document runtime config directory options (PR #66593)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/66593 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [flang] [compiler-rt] [clang] GitHub learn (PR #66806)

https://github.com/llvm-beanz approved this pull request. Please make sure the commit title and description are updated before merging, but this looks good. https://github.com/llvm/llvm-project/pull/66806 ___ cfe-commits mailing list cfe-commits@lists

[clang] [docs] Remove Visual Studio 2017 references and bump VS 2019 to VS 2022 (PR #70759)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/70759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Vector standard conversions (PR #71098)

https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/71098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) llvm-beanz wrote: This approach slightly bothers me.

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/72139 This change implements parsing for HLSL's parameter modifier keywords `in`, `out` and `inout`. Because HLSL doesn't support references or pointers, these keywords are used to allow parameters to be passed in

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

llvm-beanz wrote: Friendly ping @AaronBallman & @cor3ntin. https://github.com/llvm/llvm-project/pull/67700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH] [HLSL] Parameter modifier parsing and AST This change implem

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) llvm-beanz wrote: > Well yes, but I'm not introducin

[clang] [HLSL] Vector standard conversions (PR #71098)

llvm-beanz wrote: @rjmccall & @efriedma-quic, do the CodeGen changes here look okay to you? https://github.com/llvm/llvm-project/pull/71098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH 1/2] [HLSL] Parameter modifier parsing and AST This change im

[clang] [NFC] Cleanup and sort hlsl_intrinsics.h (PR #72414)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/72414 This is just a simple cleanup of hlsl_intrinsics.h. I've broken this into two commits to make it easier to follow during review. The first commit replaces the `__attribute__` annotations with preprocessor mac

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH 1/3] [HLSL] Parameter modifier parsing and AST This change im

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/72139 >From 8be56542f25b08ee5d6a325f76d12c28c4a366d7 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 13 Nov 2023 11:14:06 -0600 Subject: [PATCH 1/4] [HLSL] Parameter modifier parsing and AST This change im

[clang] [NFC] Cleanup and sort hlsl_intrinsics.h (PR #72414)

@@ -11,557 +11,614 @@ namespace hlsl { -__attribute__((availability(shadermodel, introduced = 6.0))) -__attribute__((clang_builtin_alias(__builtin_hlsl_wave_active_count_bits))) uint -WaveActiveCountBits(bool bBit); +// Note: Functions in this file are sorted alphabetically,

[clang] [SPIRV] Add -spirv option to DXC driver (PR #65989)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/65989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a crash when using ast-dump=json (PR #70224)

llvm-beanz wrote: @elizabethandrews ignore the clang-format failure. The action isn't fetching enough commits from git in some cases which leads to this failure. https://github.com/llvm/llvm-project/pull/70224 ___ cfe-commits mailing list cfe-commits@

[clang] [HLSL] Vector vector standard conversions (PR #71098)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/71098 HLSL supports vector truncation and element conversions as part of standard conversion sequences. The vector truncation conversion is a C++ second conversion in the conversion sequence. If a vector truncation

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/75397 This adds a new document that covers the HLSL approach to function calls and parameter semantics. At time of writing this document is a proposal for the implementation. >From d6f57c27a3030f242bba62077ecd84ba

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/75397 >From 4ebc0c58dc751f422de85b0909636cb1a87f8ce4 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 13 Dec 2023 16:44:09 -0600 Subject: [PATCH] [HLSL][Docs] Add documentation for HLSL functions This adds

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

@@ -0,0 +1,300 @@ +=== +HLSL Function Calls +=== + +.. contents:: + :local: + +Introduction + + +This document descries the design and implementation of HLSL's function call +semantics in Clang. This includes details related to argumen

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

@@ -0,0 +1,300 @@ +=== +HLSL Function Calls +=== + +.. contents:: + :local: + +Introduction + + +This document descries the design and implementation of HLSL's function call +semantics in Clang. This includes details related to argumen

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/75397 >From 4ebc0c58dc751f422de85b0909636cb1a87f8ce4 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 13 Dec 2023 16:44:09 -0600 Subject: [PATCH 1/2] [HLSL][Docs] Add documentation for HLSL functions This a

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

@@ -0,0 +1,316 @@ +=== +HLSL Function Calls +=== + +.. contents:: + :local: + +Introduction + + +This document describes the design and implementation of HLSL's function call +semantics in Clang. This includes details related to argume

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/75397 >From 4ebc0c58dc751f422de85b0909636cb1a87f8ce4 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 13 Dec 2023 16:44:09 -0600 Subject: [PATCH 1/3] [HLSL][Docs] Add documentation for HLSL functions This a

[llvm] [clang] [clang-tools-extra] [HLSL] Vector standard conversions (PR #71098)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/71098 >From 91e8d9d9f63fe2ac481bb01549e3d69ac59d68f8 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 1 Nov 2023 12:18:43 -0500 Subject: [PATCH 1/7] [HLSL] Vector vector standard conversions HLSL supports v

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

@@ -0,0 +1,316 @@ +=== +HLSL Function Calls +=== + +.. contents:: + :local: + +Introduction + + +This document describes the design and implementation of HLSL's function call +semantics in Clang. This includes details related to argume

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

@@ -0,0 +1,316 @@ +=== +HLSL Function Calls +=== + +.. contents:: + :local: + +Introduction + + +This document describes the design and implementation of HLSL's function call +semantics in Clang. This includes details related to argume

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

@@ -0,0 +1,316 @@ +=== +HLSL Function Calls +=== + +.. contents:: + :local: + +Introduction + + +This document describes the design and implementation of HLSL's function call +semantics in Clang. This includes details related to argume

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/75397 >From 4ebc0c58dc751f422de85b0909636cb1a87f8ce4 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 13 Dec 2023 16:44:09 -0600 Subject: [PATCH 1/4] [HLSL][Docs] Add documentation for HLSL functions This a

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

llvm-beanz wrote: @rjmccall, I'm curious if you have any thoughts on the proposed implementation approach here? The TL;DR for the gnarly bit is to have AST nodes representing parameters that need temporary values, and for "output" parameters where there may be cast sequences involved the AST

[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/75633 This change adds a list of supported langauges as part of the server capabilities. This is related to a PR to add HLSL support to the clangd VSCode plugin (https://github.com/clangd/vscode-clangd/pull/392).

[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

llvm-beanz wrote: > 1. Since the key we're adding to the server capabilities is a non-standard > extension, I'm a bit uneasy about giving it a general name like > `"languages"`. If the LSP were to add a key with that name but a different > format or interpretation, we could run into trouble. C

[clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/75397 >From 4ebc0c58dc751f422de85b0909636cb1a87f8ce4 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 13 Dec 2023 16:44:09 -0600 Subject: [PATCH 1/5] [HLSL][Docs] Add documentation for HLSL functions This a

[llvm] [clang-tools-extra] [clang] [HLSL] Vector standard conversions (PR #71098)

llvm-beanz wrote: ping @efriedma-quic & @rjmccall https://github.com/llvm/llvm-project/pull/71098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [HLSL] Vector standard conversions (PR #71098)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/71098 >From 91e8d9d9f63fe2ac481bb01549e3d69ac59d68f8 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 1 Nov 2023 12:18:43 -0500 Subject: [PATCH 1/7] [HLSL] Vector vector standard conversions HLSL supports v

[clang] [HLSL] Vector standard conversions (PR #71098)

llvm-beanz wrote: @AaronBallman, gentle ping 😄 https://github.com/llvm/llvm-project/pull/71098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Cleanup and sort hlsl_intrinsics.h (PR #72414)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/72414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Parameter modifier parsing and AST (PR #72139)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/72139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

llvm-beanz wrote: Friendly ping @AaronBallman & @cor3ntin. https://github.com/llvm/llvm-project/pull/67700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Support vector swizzles on scalars (PR #67700)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/67700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Vector standard conversions (PR #71098)

@@ -123,82 +123,59 @@ CompareDerivedToBaseConversions(Sema &S, SourceLocation Loc, /// GetConversionRank - Retrieve the implicit conversion rank /// corresponding to the given implicit conversion kind. ImplicitConversionRank clang::GetConversionRank(ImplicitConversionKind Kind

[clang] [HLSL] Vector standard conversions (PR #71098)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/71098 >From 91e8d9d9f63fe2ac481bb01549e3d69ac59d68f8 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 1 Nov 2023 12:18:43 -0500 Subject: [PATCH 1/5] [HLSL] Vector vector standard conversions HLSL supports v

[clang] [HLSL] Vector standard conversions (PR #71098)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/71098 >From 91e8d9d9f63fe2ac481bb01549e3d69ac59d68f8 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 1 Nov 2023 12:18:43 -0500 Subject: [PATCH 1/6] [HLSL] Vector vector standard conversions HLSL supports v

[clang] [HLSL] Vector standard conversions (PR #71098)

@@ -123,82 +123,59 @@ CompareDerivedToBaseConversions(Sema &S, SourceLocation Loc, /// GetConversionRank - Retrieve the implicit conversion rank /// corresponding to the given implicit conversion kind. ImplicitConversionRank clang::GetConversionRank(ImplicitConversionKind Kind

[clang] [llvm] [lld] [llvm-driver] Fix usage of `InitLLVM` on Windows (PR #76306)

llvm-beanz wrote: @aganea, this ends up being a nice way to collapse down a tiny bit of shared tool boilerplate. Thank you! This LGTM, but let's make sure @MaskRay is happy too. https://github.com/llvm/llvm-project/pull/76306 ___ cfe-commits mailing

[clang] [CMake][PGO] Use check targets to generate profdata for PGO builds (PR #77347)

llvm-beanz wrote: Looping in some Apple people. I'm unsure if Apple is still using this infrastructure for generating PGO data. If so this change will impact them. When I wrote this, Apple had some additional test cases that got layered on top of the publicly available tests. It might make se

[clang-tools-extra] [llvm] [clang] [HLSL] Vector standard conversions (PR #71098)

@@ -4763,6 +4763,20 @@ Sema::PerformImplicitConversion(Expr *From, QualType ToType, CK_ZeroToOCLOpaqueType, From->getValueKind()).get(); break; + case ICK_HLSL_Vector_Truncation: { +// Note: HLSL vectors are Ex

[clang-tools-extra] [llvm] [clang] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/75397 >From 4ebc0c58dc751f422de85b0909636cb1a87f8ce4 Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Wed, 13 Dec 2023 16:44:09 -0600 Subject: [PATCH 1/5] [HLSL][Docs] Add documentation for HLSL functions This a

[llvm] [clang] [clang-tools-extra] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/75397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] [HLSL][Docs] Add documentation for HLSL functions (PR #75397)

@@ -0,0 +1,321 @@ +=== +HLSL Function Calls +=== + +.. contents:: + :local: + +Introduction + + +This document describes the design and implementation of HLSL's function call +semantics in Clang. This includes details related to argume

[clang] [HLSL] Implement array temporary support (PR #79382)

@@ -4655,6 +4655,13 @@ void CodeGenFunction::EmitCallArg(CallArgList &args, const Expr *E, return emitWritebackArg(*this, args, CRE); } + // If an argument is an array paramter expression being passed through. Emit + // the argument to a temporary and pass the tempora

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/83938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/llvm-beanz commented: Minor suggestion about the diagnostic. @MaskRay do you have any thoughts about a follow-up change to add a `DriverOptions` structure so that we could use argument marshalling for driver options? https://github.com/llvm/llvm-project/pull/83938 _

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -8545,6 +8545,11 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E", KIND_JOINED_OR_SEPARATE>, Group, Visibility<[DXCOption]>, HelpText<"Entry point name">; +def dxc_hlsl_version : Option<["/", "-"], "HV", KIN

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -753,6 +753,9 @@ def err_drv_hlsl_bad_shader_required_in_target : Error< def err_drv_hlsl_bad_shader_unsupported : Error< "%select{shader model|Vulkan environment|shader stage}0 '%1' in target '%2' is invalid for HLSL code generation">; +def err_drv_hlsl_dxc_bad_argument

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -8545,6 +8545,13 @@ def dxc_entrypoint : Option<["--", "/", "-"], "E", KIND_JOINED_OR_SEPARATE>, Group, Visibility<[DXCOption]>, HelpText<"Entry point name">; +def dxc_hlsl_version : Option<["/", "-"], "HV", KIN

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/llvm-beanz approved this pull request. Two small nits with suggestions. Otherwise LGTM. https://github.com/llvm/llvm-project/pull/83938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/83938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

@@ -753,6 +753,7 @@ def err_drv_hlsl_bad_shader_required_in_target : Error< def err_drv_hlsl_bad_shader_unsupported : Error< "%select{shader model|Vulkan environment|shader stage}0 '%1' in target '%2' is invalid for HLSL code generation">; + llvm-beanz wrot

[clang] [HLSL] Implement array temporary support (PR #79382)

@@ -3173,41 +3174,46 @@ class ArrayType : public Type, public llvm::FoldingSetNode { return T->getTypeClass() == ConstantArray || T->getTypeClass() == VariableArray || T->getTypeClass() == IncompleteArray || - T->getTypeClass() == DependentS

[clang] [llvm] [DXIL] `exp`, `any`, `lerp`, & `rcp` Intrinsic Lowering (PR #84526)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/84526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement `clamp` intrinsic (PR #85424)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/85424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/85716 In PR #79382, I need to add a new type that derives from ConstantArrayType. This means that ConstantArrayType can no longer use `llvm::TrailingObjects` to store the trailing optional Expr*. This change refac

[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

https://github.com/llvm-beanz commented: One comment, otherwise looks good. https://github.com/llvm/llvm-project/pull/85662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/85662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

@@ -5484,6 +5484,19 @@ bool CheckFloatOrHalfRepresentations(Sema *S, CallExpr *TheCall) { checkFloatorHalf); } +bool CheckNoDoubleVectors(Sema *S, CallExpr *TheCall) { + auto checkDoubleVector = [](clang::QualType PassedType) -> bool { +

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

@@ -3182,34 +3182,98 @@ class ArrayType : public Type, public llvm::FoldingSetNode { /// For example, the canonical type for 'int A[4 + 4*100]' is a /// ConstantArrayType where the element type is 'int' and the size is 404. class ConstantArrayType final -: public ArrayType

[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/85662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][docs] Document hlsl.h in the HLSL docs (PR #84081)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/84081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= Message-ID: In-Reply-To: @@ -1295,11 +1295,13 @@ double4 trunc(double4); /// true, across all active lanes in the cur

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

@@ -4258,6 +4258,18 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts, ArgList &Args, } else { llvm_unreachable("expected DXIL or SPIR-V target"); } + // validate that if fnative-half-type is given, that + // the language standard is at

[clang] [CMake][HLSL] Add SPIRV to target list for build (PR #86323)

https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/86323 This change just enables the SPIR-V target by default in the HLSL build configurations. Since SPIR-V support is something we expect from the full HLSL compiler releases for pairity with DXC we should enable i

[clang] [HLSL] Remove double pow intrinsics (PR #86407)

https://github.com/llvm-beanz approved this pull request. Nice catch! Thank you! https://github.com/llvm/llvm-project/pull/86407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

llvm-beanz wrote: Philosophically I agree with this change, but I think some subprojects may need to adopt specific policies about how they handle files that are expected to be specific line endings. Specifically, Clang needs testing that verifies correct behavior on both CRLF and LF files in

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= Message-ID: In-Reply-To: @@ -1295,11 +1295,13 @@ double4 trunc(double4); /// true, across

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= Message-ID: In-Reply-To: @@ -1295,11 +1295,13 @@ double4

[clang] [CMake][HLSL] Add SPIRV to target list for build (PR #86323)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/86323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/85716 >From 4a11a73b4dd41637b1d730489954c2994489d6be Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 18 Mar 2024 17:30:41 -0500 Subject: [PATCH 1/2] [NFC] Refactor ConstantArrayType size storage In PR #793

[clang] [HLSL] remove double impelementation of log, sin, trunc intrinsics (PR #86440)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/86440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DXIL] Add Float `Dot` Intrinsic Lowering (PR #86071)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/86071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] prevent generation of double intrinsics via the builtins (PR #86555)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/86555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][DXIL] implement `sqrt` intrinsic (PR #86560)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/86560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

llvm-beanz wrote: > I am not saying this isn't a problem at all, but how often has anyone done a > one line change and caused a 50k diff, and submitted it without noticing? Way more often than you would hope. I don't have numbers but if you search through the git history for `crlf` or `dos2uni

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

llvm-beanz wrote: > This ^ seems a bit problematic to me, though (where the contents of the repo > isn't representative of the bits we want - but perhaps it's schrodinger's > line endings & it doesn't matter if it's always checked out as crlf - though > if we one day converted to another sourc

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

llvm-beanz wrote: > I'm a bit confused. Are you saying that as I've expressed it, `autocrlf=true` > won't work correctly? I _think_ you're saying you're in favour of this patch > _in principal_, but I need to fix the mixed line endings case? Sorry for being unclear. I meant to express that I'm

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/85716 >From 4a11a73b4dd41637b1d730489954c2994489d6be Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 18 Mar 2024 17:30:41 -0500 Subject: [PATCH 1/4] [NFC] Refactor ConstantArrayType size storage In PR #793

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/85716 >From 4a11a73b4dd41637b1d730489954c2994489d6be Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 18 Mar 2024 17:30:41 -0500 Subject: [PATCH 1/5] [NFC] Refactor ConstantArrayType size storage In PR #793

[clang] [HLSL] Enable -fconvergent-functions by default (PR #86571)

llvm-beanz wrote: Hi @aniplcc, thank you for the PR. We do require test cases for bug fixes and new features (see the [Developer Policy](https://llvm.org/docs/DeveloperPolicy.html#test-cases). Because this general feature is already tested for OpenCL, we can make a really simple test for this

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= Message-ID: In-Reply-To: https://github.com/llvm-beanz approved this pull

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/85716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/llvm-beanz commented: One nit, but otherwise looks good. https://github.com/llvm/llvm-project/pull/85340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/85340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add validation for the -enable-16bit-types option (PR #85340)

@@ -753,7 +753,10 @@ def err_drv_hlsl_unsupported_target : Error< "HLSL code generation is unsupported for target '%0'">; def err_drv_hlsl_bad_shader_required_in_target : Error< "%select{shader model|Vulkan environment|shader stage}0 is required as %select{OS|environment}1

[clang] [HLSL] Enable -fconvergent-functions by default (PR #86571)

llvm-beanz wrote: > I was getting match errors with the RUN script. I went ahead and updated it > with the checks in: `clang/test/CodeGen/convergent-functions.cpp` Hope that's > correct/OK? > > ```hlsl > // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.4-library -emit-llvm > -disable-llvm-pass

[clang] [HLSL] Enable -fconvergent-functions by default (PR #86571)

https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/86571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Doc][HLSL] Add documentation for root signature. (PR #83933)

@@ -0,0 +1,426 @@ + +HLSL Root Signatures + + +.. contents:: + :local: + +Usage += + +In HLSL, the `root signature +`_ +defines what types of resources are bo

  1   2   3   4   5   6   7   8   9   10   >