llvm-beanz wrote:

Hi @aniplcc, thank you for the PR.

We do require test cases for bug fixes and new features (see the [Developer 
Policy](https://llvm.org/docs/DeveloperPolicy.html#test-cases).

Because this general feature is already tested for OpenCL, we can make a really 
simple test for this. Something like this should be fine:

```hlsl
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.4-library -emit-llvm 
-disable-llvm-passes -o - %s | FileCheck %s

void fn() {
};

// CHECK: define void @"?fn@@YAXXZ"() local_unnamed_addr #[[Attr:[0-9]+]]
// CHECK: attributes #[[Attr]] = { {{[^}]*}}convergent{{[^}]*}} }
```

Put that into a file `clang/test/CodeGenHLSL/convergent-functions.hlsl` and 
build the `check-clang` target to verify that it works.

https://github.com/llvm/llvm-project/pull/86571
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to