[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. Oh, I was thinking that I could use "arc land" to commit my patch, but just now realize that I don't have the commit privileges. Would you please commit for me? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

cchen created this revision. cchen added reviewers: ABataev, sfantao. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. - Removed a restriction that list items for target update directive must have contiguous storage. - A restrict

[PATCH] D69316: [OpenMP 5.0] target update list items need not be contiguous (Sema)

cchen updated this revision to Diff 226067. cchen added a comment. Fix summary message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69316/new/ https://reviews.llvm.org/D69316 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/S

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4463-4890 + if (AStmt && !CurContext->isDependentContext()) { assert(isa(AStmt) && "Captured statement expected"); // Check default data sharing attributes for referenced variables. DSAAttr

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4463-4890 + if (AStmt && !CurContext->isDependentContext()) { assert(isa(AStmt) && "Captured statement expected"); // Check default data sharing attribute

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:1987-2001 + /// Build a new OpenMP 'defaultmap' clause. + /// + /// By default, performs semantic analysis to build the new OpenMP clause. + /// Subclasses may over

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 265562. cchen added a comment. Herald added a subscriber: sstefan1. Remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen created this revision. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. cchen added a comment. cchen added a reviewer: ABataev. cchen added subscribers: dreachem, sandoval. Haven't added test yet since I'm n

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen added a comment. Haven't added test yet since I'm not sure in which file should I add the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 ___ cfe-co

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen added a comment. In D80590#2056009 , @ABataev wrote: > In D80590#2055937 , @cchen wrote: > > > Haven't added test yet since I'm not sure in which file should I add the > > test. > > > Where is the directive?

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

cchen updated this revision to Diff 266370. cchen added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/sema_alignas.cpp Index

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2049838 , @ABataev wrote: > How are you going to pass this non-contiguous data in the runtime? Are you > going to map it in a loop or convert this non-contiguous data into the > contiguous and map it as a contiguous chunk

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:5315 + private llvm::TrailingObjects< + OMPMapClause, Expr *, ValueDecl *, bool, unsigned, + OMPClauseMappableExprCommon::MappableCompone

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2058516 , @ABataev wrote: > Is my guess correct that for OpenMP >= 50 for target update directive we > always emit `possibly non-continuous` runtime calls? My intent is to emit `possibly non-contiguous` runtime calls onl

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2058608 , @ABataev wrote: > In D79972#2058555 , @cchen wrote: > > > In D79972#2058516 , @ABataev wrote: > > > > > Is my guess correct that fo

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16537 AllowWholeSizeArraySection = false; +} else if (DKind == OMPD_target_update && + SemaRef.getLangOpts().OpenMP >= 50) {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 266921. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenM

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8397-8400 + if (OASE || OAShE || + dyn_cast(I->getAssociatedExpression())) { +DimSize++; + } ABataev wrote: > Do you

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 267725. cchen added a comment. - Use PointerIntPair to pass non-contiguous information in AST - Error out in Sema if we don't have enough size information for cases involving pointers - Allows `*arr[N][M]` since we don't need size information for the last dime

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2068976 , @ABataev wrote: > Still: Did you think about implementing it in the compiler instead of the > runtime? I'm not sure I understand your question, which part of code are you asking? The main work compiler needs to

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069358 , @ABataev wrote: > In D79972#2069322 , @cchen wrote: > > > In D79972#2068976 , @ABataev wrote: > > > > > Still: Did you think about

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 268009. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069435 , @ABataev wrote: > In D79972#2069366 , @cchen wrote: > > > In D79972#2069358 , @ABataev wrote: > > > > > In D79972#2069322

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. In order not to modify the `tgt_target_data_update` information but still be able to pass the extra in

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen abandoned this revision. cchen added a comment. Created a new patch with the support for stride: https://reviews.llvm.org/D84192. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2164885 , @ABataev wrote: > Also, what about compatibility with declare mapper? Can you add tests for it? There's a restriction for map clause that non-contiguous is not allowed and I guess it also applies to declare map

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 279631. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165249 , @ABataev wrote: > In D84192#2165235 , @cchen wrote: > > > In D84192#2164885 , @ABataev wrote: > > > > > Also, what about compatibil

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165249 , @ABataev wrote: > In D84192#2165235 , @cchen wrote: > > > In D84192#2164885 , @ABataev wrote: > > > > > Also, what about compatibil

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165438 , @ABataev wrote: > In D84192#2165396 , @cchen wrote: > > > In D84192#2165249 , @ABataev wrote: > > > > > In D84192#2165235

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165522 , @ABataev wrote: > In D84192#2165517 , @cchen wrote: > > > In D84192#2165438 , @ABataev wrote: > > > > > In D84192#2165396

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2167649 , @ABataev wrote: > In D84192#2167636 , @cchen wrote: > > > In D84192#2165522 , @ABataev wrote: > > > > > In D84192#2165517

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, is there any other concern for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 ___ cfe-commits mailing list cfe-com

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 280474. cchen added a comment. Fix coding style and argument on getIntTypeForBitwidth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files: clang/include/clang/AST/Ope

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, do I need to wait for the runtime patch to commit this one? If so, do you have some recommend reviewers for me to add to that patch? I have pinged several times for that patch but haven't got many reviews for it. Thanks! Repository: rG LLVM Github Monorepo C

[PATCH] D77581: Add map-type check for target and target data directive

cchen created this revision. cchen added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenM

[PATCH] D77581: Add map-type check for target and target data directive

cchen updated this revision to Diff 255481. cchen added a comment. Do not use lint on test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_d

[PATCH] D77581: Add map-type check for target and target data directive

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:17001-17038 + // target, target data + // OpenMP 5.0 [2.12.2, Restrictions, p. 163] + // OpenMP 5.0 [2.12.5, Restrictions, p. 174] + // A map-type in

[PATCH] D77581: Add map-type check for target and target data directive

cchen updated this revision to Diff 255497. cchen added a comment. Reuse existing function for target/target data check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 Files: clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D77581: Add map-type check for target and target data directive

cchen added a comment. @ABataev , can you land it for me when you have time? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77581/new/ https://reviews.llvm.org/D77581 ___ cfe-commits mailing list

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 269663. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2082017 , @ABataev wrote: > Do you have a test for mapping of something like `arr[0][:n]`, where the base > is an array subscript and the remaining part is an array section? I'm not having it right now, but it seems like

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 269961. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 4 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7821 + Context.getTypeSizeInChars(ElementType).getQuantity(); +} else if (VAT) { + ElementType = VAT->getElementType().

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 270536. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 270880. cchen added a comment. Resolve issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOpenMP

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 3 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7834 +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } else if (VAT) {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7834 +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } else if (VAT) {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 271183. cchen added a comment. Fix Int64Ty issue (The bitNum of APInt I used before is 32) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AS

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 271221. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 275196. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/include/clang/AST/ExprOpenMP.h clan

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 275241. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Expr

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' cchen wrote: > ABataev wrote: > > Seems to me

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked 8 inline comments as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' ABataev wrote: > Seems to me, it is too broad

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 275834. cchen added a comment. Move analysis of stride from Sema to Parse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/i

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 275856. cchen added a comment. Fix based on comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/include/clang/AST/ExprO

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' ABataev wrote: > You need to insert an additi

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1933 } +if (getLangOpts().OpenMP >= 50 && Tok.is(tok::colon)) { + // Consume ':' cchen wrote: > ABataev wrote: > > You need to

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 276589. cchen added a comment. Fix message and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/include/clang/AST/Exp

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen added a comment. @ABataev , can you commit this patch for me when you have time? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 ___ cfe-commits m

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen added a comment. In D82800#2141819 , @ABataev wrote: > In D82800#2141818 , @cchen wrote: > > > @ABataev , can you commit this patch for me when you have time? Thanks. > > > I think you can request commit acces

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2da9572a9b10: [OPENMP50] extend array section for stride (Parsing/Sema/AST) (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ ht

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 272564. cchen added a comment. Updated test for clarification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273484. cchen added a comment. Fix coding style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOpen

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8781 MappableExprsHandler::MapFlagsArrayTy &MapTypes, - CGOpenMPRuntime::TargetDataInfo &Info) { +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:16624 + if (IsPointer && !AllowAnotherPtr) +SemaRef.Diag(ELoc, diag::err_omp_section_length_undefined) << true; + else ABataev wrote:

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273517. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273529. cchen added a comment. Pass Info directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOp

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273747. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 273778. cchen added a comment. Rebase and resolve conflictions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, sstefan1, arphaman, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82800 Files: clang/inclu

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 274209. cchen added a comment. Revert unnecessary changes made by bot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h clang/inclu

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked 3 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7893-7897 +llvm::errs() << "DEBUG in CGOpenMPRuntime.cpp\n"; +OASE->getLowerBound()->dump(); +OASE->getLength()->dump(); +OASE->g

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 274275. cchen added a comment. 1. Remove a commit that is not on master branch 2. Add a rule in Sema to avoid non-contiguous array section for map clause 3. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7046-7049 +/// Signal that the runtime library should use args as an array of +/// descriptor_dim pointers and use args_size as dims. Used when we have +

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev , I'm considering emitting an extra dimension for a non-contiguous descriptor to support stride in this patch (stride = 1 in array section is just a special case for computing stride, however, the formula computing stride do not change). Do you think I should do

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause

cchen created this revision. cchen added reviewers: jdoerfert, ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a project: clang. cchen requested review of this revision. Herald added a subscriber: sstefan1. LValue map checker should handle CXXOperatorCallExpr Repos

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212 - Shouldn't error out while using overloaded operator for map clause

cchen updated this revision to Diff 284082. cchen added a comment. Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85563/new/ https://reviews.llvm.org/D85563 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/target_map_me

[PATCH] D85563: [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator for map clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3adc9aeb250c: [OpenMP 5.0] Fix PR-45212: Shouldn't error out while using overloaded operator… (authored by cchen). Repository: rG LLVM Github Mono

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

cchen added a comment. In PR45212 comment 5 (https://bugs.llvm.org/show_bug.cgi?id=45212#c5), there is a reduced test case that failed after adding this patch. The assertion is from OMPChildren::getInnermostCapturedStmt. Test case: #include #include #include class Myclass {

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. In order not to modify the `tgt_target_data_update` information but still be able to pass the extra information

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 264266. cchen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClause.cpp c

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG086b65340cca: [OpenMP] atomic compare fail : Parser & AST support (authored by koops, committed by cchen). Repository: rG LLVM Github Monorepo CH

[PATCH] D125669: Adding support for target in_reduction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8322fe200d60: Adding support for target in_reduction (authored by RitanyaB, committed by cchen). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen created this revision. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. The previous patch (https://reviews.llvm.org/D54441) support the relational-op != very well for openmp canonical loop form, however, it didn't update the

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. Is there any way that I can find the OpenMP version in Clang? I couldn't find any example in source code. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 __

[PATCH] D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator

cchen added a comment. Herald added a reviewer: jdoerfert. Herald added a project: LLVM. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54441/new/ https://reviews.llvm.org/D54441 ___ cfe-commits mailing list cfe-commits@

[PATCH] D66903: [OPENMP] Update the diagnosis message for canonical loop form

cchen created this revision. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. The previous patch (https://reviews.llvm.org/D54441) support the relational-op != very well for openmp canonical loop form, however, it didn't update the

[PATCH] D66903: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. I should update a revision instead of creating this new one, so I'll just remove the subscriber. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66903/new/ https://reviews.llvm.org/D66903 ___

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen updated this revision to Diff 217710. cchen added a comment. Update the diagnosis message for canonical loop form based on OpenMP version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 Files: clang

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. Haven't updated the lit test for OpenMP 5.0 yet since I'm not able to check OPENMP version by using _OPENMP with preprocessor condition checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. @ABataev thanks so much for your instruction, I'll look into that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___ cfe-commits mailin

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. "parallel_for_codegen" cannot pass now since it has two test cases for "!=" and it's hard to just add "fopenmp-version=50" since it will break lots of other test cases that have different codegen for OpenMP 5.0. I can remove the "!=" case from "parallel_for_codegen" and ad

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen marked an inline comment as done. cchen added a comment. I'm not able to `arc land` my patch since I updated the patch for a minor refactor and the state is "not approve" now. Do I wait for the approval for the new patch so that I can `arc land` or I don't need to do `arc land` myself? Tha

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen marked an inline comment as done. cchen added a comment. @ABataev, could you mark it as ready to land, please. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___

  1   2   3   >