cchen marked 2 inline comments as done.
cchen added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8397-8400
+ if (OASE || OAShE ||
+ dyn_cast<ArraySubscriptExpr>(I->getAssociatedExpression())) {
+ DimSize++;
+ }
----------------
ABataev wrote:
> Do you really need to count `DimSize` for array shaping operators and array
> subscript expressions? I don't see tests for it.
You're right, I don't need to count `DimSize` for array shaping and array
subscript.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:16537
AllowWholeSizeArraySection = false;
+ } else if (DKind == OMPD_target_update &&
+ SemaRef.getLangOpts().OpenMP >= 50) {
----------------
ABataev wrote:
> cchen wrote:
> > @ABataev , I guess you're saying the condition should be
> > `!AllowWholeSizeArraySection && DKind == OMPD_target_update &&
> > SemaRef.getLangOpts().OpenMP >= 50`?
> No, what I want is to try to simplify the code. I see now why do you need
> this flag. I'm just thinking can we avoid adding this flag to the clause and
> save some mem space?
But we also don't want to do the analysis in codegen I guess? Also, if we emit
non-contiguous runtime for every target update call, we need to change tons of
stuff (tons of lit tests, runtime implementation, etc...).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79972/new/
https://reviews.llvm.org/D79972
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
