[clang] c131883 - [clang][NFC] Remove extraneous normalized value

2022-10-06 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2022-10-06T11:01:25-07:00 New Revision: c131883146c2efdef5c6ee17d624f8cada277d9d URL: https://github.com/llvm/llvm-project/commit/c131883146c2efdef5c6ee17d624f8cada277d9d DIFF: https://github.com/llvm/llvm-project/commit/c131883146c2efdef5c6ee17d624f8cada277d9d.diff

[clang] 8c7b346 - [clang] Update ASM goto documentation to reflect how Clang differs from GCC

2022-10-13 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2022-10-13T12:05:40-07:00 New Revision: 8c7b3461a5346a66088d884500c2b3c2829b4652 URL: https://github.com/llvm/llvm-project/commit/8c7b3461a5346a66088d884500c2b3c2829b4652 DIFF: https://github.com/llvm/llvm-project/commit/8c7b3461a5346a66088d884500c2b3c2829b4652.diff

[clang] 91b3823 - [clang][Sema] Use size of char in bits for void types

2022-10-14 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2022-10-14T14:46:19-07:00 New Revision: 91b3823bd000b1a6ffde96a6363098f59307317a URL: https://github.com/llvm/llvm-project/commit/91b3823bd000b1a6ffde96a6363098f59307317a DIFF: https://github.com/llvm/llvm-project/commit/91b3823bd000b1a6ffde96a6363098f59307317a.diff

[clang] f85a9a6 - [randstruct] Don't allow implicit forward decl to stop struct randomization

2023-02-06 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-02-06T14:26:32-08:00 New Revision: f85a9a6452e8f49f9768d66a86434a88a5891614 URL: https://github.com/llvm/llvm-project/commit/f85a9a6452e8f49f9768d66a86434a88a5891614 DIFF: https://github.com/llvm/llvm-project/commit/f85a9a6452e8f49f9768d66a86434a88a5891614.diff

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/2] [NFC][CodeGen] Create method to clear registers Place the

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/2] [NFC][CodeGen] Create method to clear registers Place the

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/3] [NFC][CodeGen] Create method to clear registers Place the

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/66958 >From ed8d57d182510f2d33ad4fe78cd88c717cefbd47 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 20 Sep 2023 15:11:00 -0700 Subject: [PATCH 1/3] [NFC][CodeGen] Create method to clear registers Place the

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
bwendling wrote: > I'm assuming there are other targets that would benefit from being converted > as well? Not asking you to do it, just wondering what the best way to get it > done is. Yeah, the other platforms can implement this when / if they need it. It's really just a convenience functio

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
bwendling wrote: > I'm assuming there are other targets that would benefit from being converted > as well? Not asking you to do it, just wondering what the best way to get it > done is. Yeah, the other platforms can implement this when / if they need it. It's really just a convenience functio

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, bwendling wrote: Yes, in particular I want to call it

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, bwendling wrote: Yes, in particular I want to call it

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -2057,6 +2057,14 @@ class TargetInstrInfo : public MCInstrInfo { "Target didn't implement TargetInstrInfo::insertOutlinedCall!"); } + /// Insert an architecture-specific instruction to clear a register. + virtual void buildClearRegister(Register Reg, MachineBasi

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/66958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, bwendling wrote: I added more context to the commit m

[clang-tools-extra] [NFC][CodeGen] Create method to clear registers (PR #66958)

2023-09-21 Thread Bill Wendling via cfe-commits
@@ -8335,6 +8335,26 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( return MF.getFunction().hasMinSize(); } +void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, bwendling wrote: I added more context to the commit m

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-25 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/2] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -9796,27 +9796,34 @@ X86InstrInfo::insertOutlinedCall(Module &M, MachineBasicBlock &MBB, return It; } -void X86InstrInfo::buildClearRegister(Register Reg, - MachineBasicBlock &MBB, +void X86InstrInfo::buildClearRegister(Register Reg,

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling edited https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/4] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/4] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-27 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/5] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-27 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,23 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-27 Thread Bill Wendling via cfe-commits
@@ -2088,12 +2088,12 @@ class TargetInstrInfo : public MCInstrInfo { } /// Insert an architecture-specific instruction to clear a register. If you - /// need to avoid sideeffects (e.g. XOR on x86), set \p NoSideEffects to \p - /// true. + /// need to avoid sideeffects (

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-27 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,23 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

Re: [PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-10-03 Thread Bill Wendling via cfe-commits
Yes, I mean to do it as a direct follow-up. 😊 -bw On Tue, Oct 3, 2023, 6:31 AM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added inline comments. > > > > Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8420-8428 > +if (Result.getResultKind()

[clang] [CodeGen] Respect pointer-overflow sanitizer for void pointers (PR #67772)

2023-10-04 Thread Bill Wendling via cfe-commits
https://github.com/bwendling approved this pull request. https://github.com/llvm/llvm-project/pull/67772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9a954c6 - [Clang] Implement the 'counted_by' attribute

2023-10-04 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-10-04T18:26:15-07:00 New Revision: 9a954c693573281407f6ee3f4eb1b16cc545033d URL: https://github.com/llvm/llvm-project/commit/9a954c693573281407f6ee3f4eb1b16cc545033d DIFF: https://github.com/llvm/llvm-project/commit/9a954c693573281407f6ee3f4eb1b16cc545033d.diff

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-10 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/68750 The 'counted_by' attribute is used on flexible array members. The argument for the attribute is the name of the field member in the same structure holding the count of elements in the flexible array. This info

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-10 Thread Bill Wendling via cfe-commits
bwendling wrote: This is identical to the original change (9a954c693573281407f6ee3f4eb1b16cc545033d), but with a fix for the issue @alexfh discovered (https://github.com/llvm/llvm-project/commit/9a954c693573281407f6ee3f4eb1b16cc545033d#commitcomment-129529574). The change is on lines 473-475

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-10 Thread Bill Wendling via cfe-commits
bwendling wrote: And @AaronBallman, I haven't forgotten my promise to change the diagnostics. I've been on vacation, and it's become trickier to get them to work the other way than I had first thought. The change is coming soon though. https://github.com/llvm/llvm-project/pull/68750 __

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-10 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/2] [Clang] Implement the 'counted_by' attribute The 'counted_b

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-11 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/3] [Clang] Implement the 'counted_by' attribute The 'counted_b

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-11 Thread Bill Wendling via cfe-commits
bwendling wrote: @AaronBallman I just added a patch that modifies the diagnostics to be more in line with what you wanted. PTAL. https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-11 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/4] [Clang] Implement the 'counted_by' attribute The 'counted_b

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-13 Thread Bill Wendling via cfe-commits
bwendling wrote: @nickdesaulniers and @alexfh Any comments? :-) https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-10-17 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/5] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-10-17 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-10-17 Thread Bill Wendling via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-10-17 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StackProtector] Clear out stack protector slot (PR #65461)

2023-09-08 Thread Bill Wendling via cfe-commits
bwendling wrote: >From the feedback, I think this change may be a bit premature. As I mentioned, >there's already a way to zero the stack upon entry to the function. What I *really* want to do is zero out the register that held the stack guard value, like in the GCC patch @nickdesaulniers poin

[clang] [StackProtector] Clear out stack protector slot (PR #65461)

2023-09-08 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/65461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/66339: Minimize the headers included in header files to reduce the number of files that need recompiled after a change. >From fafc158270aa454253d885111c297ab0aaaca7dc Mon Sep 17 00:00:00 2001 From: Bill Wendling Da

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling review_requested https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling review_requested https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Minimize header includes (PR #66339)

2023-09-14 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/66339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6713652 - [NFC] Cleanup some #includes in header files

2023-09-01 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-09-01T15:23:46-07:00 New Revision: 671365225ccce00b063f7becfee4388aa7ab013a URL: https://github.com/llvm/llvm-project/commit/671365225ccce00b063f7becfee4388aa7ab013a DIFF: https://github.com/llvm/llvm-project/commit/671365225ccce00b063f7becfee4388aa7ab013a.diff

[clang] b0cbf3a - [NFC] remove unneded header includes

2023-09-05 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-09-05T13:12:01-07:00 New Revision: b0cbf3a0dac51d426dd38c307f745e74f409aed7 URL: https://github.com/llvm/llvm-project/commit/b0cbf3a0dac51d426dd38c307f745e74f409aed7 DIFF: https://github.com/llvm/llvm-project/commit/b0cbf3a0dac51d426dd38c307f745e74f409aed7.diff

[clang] 7d6283f - [NFC] Remove unneeded header includes

2023-09-05 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-09-05T13:12:00-07:00 New Revision: 7d6283fd09016fda711a3ad211be7d25336dabc6 URL: https://github.com/llvm/llvm-project/commit/7d6283fd09016fda711a3ad211be7d25336dabc6 DIFF: https://github.com/llvm/llvm-project/commit/7d6283fd09016fda711a3ad211be7d25336dabc6.diff

[clang] 3e19b10 - Partial revert of b0cbf3a0dac5

2023-09-05 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-09-05T16:18:20-07:00 New Revision: 3e19b10b02a72c21c3961fbfd3a0aa86dbe60c70 URL: https://github.com/llvm/llvm-project/commit/3e19b10b02a72c21c3961fbfd3a0aa86dbe60c70 DIFF: https://github.com/llvm/llvm-project/commit/3e19b10b02a72c21c3961fbfd3a0aa86dbe60c70.diff

[clang] 768107d - [NFC] Remove unneeded #include files.

2022-12-02 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2022-12-02T15:05:29-08:00 New Revision: 768107d77993f3e84517cef8fd8f0c2f5d7c41c7 URL: https://github.com/llvm/llvm-project/commit/768107d77993f3e84517cef8fd8f0c2f5d7c41c7 DIFF: https://github.com/llvm/llvm-project/commit/768107d77993f3e84517cef8fd8f0c2f5d7c41c7.diff

[clang] 50cac24 - Support output constraints on "asm goto"

2020-02-24 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2020-02-24T18:51:29-08:00 New Revision: 50cac248773c3a023e8f6ceb9938bdd5e9f15da2 URL: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2 DIFF: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2.diff

Re: [PATCH] D69876: Support output constraints on "asm goto"

2020-02-25 Thread Bill Wendling via cfe-commits
Okay. I'll take a look at it. Sorry about the failure. On Tue, Feb 25, 2020 at 1:37 AM Yvan Roux wrote: > Hi Bill, > > This commit broke AArch64 bots, logs are available here: > > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/22291/steps/ninja%20check%201/logs/FAIL%3A%20Clan

[clang] e11f9fb - Add 'l' constraint to goto label reference

2020-02-25 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2020-02-25T11:48:23-08:00 New Revision: e11f9fb4508534d31b09d2ba6cd22428ccc75f65 URL: https://github.com/llvm/llvm-project/commit/e11f9fb4508534d31b09d2ba6cd22428ccc75f65 DIFF: https://github.com/llvm/llvm-project/commit/e11f9fb4508534d31b09d2ba6cd22428ccc75f65.diff

Re: [PATCH] D69876: Support output constraints on "asm goto"

2020-02-25 Thread Bill Wendling via cfe-commits
Hi Vlad, I just submitted a fix for this: e11f9fb4508534d31b09d2ba6cd22428ccc75f65 On Tue, Feb 25, 2020 at 11:42 AM Vlad Vereschaka via Phabricator < revi...@reviews.llvm.org> wrote: > vvereschaka added a comment. > > Hello @void , > > this commit breaks Aarch64 builder with failed > `Clang::uni

[clang] 6d0d1a6 - Use "nop" to avoid size warnings.

2020-02-25 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2020-02-25T12:31:53-08:00 New Revision: 6d0d1a63f2a6c120f206a83e7c1ddae9fa5a569a URL: https://github.com/llvm/llvm-project/commit/6d0d1a63f2a6c120f206a83e7c1ddae9fa5a569a DIFF: https://github.com/llvm/llvm-project/commit/6d0d1a63f2a6c120f206a83e7c1ddae9fa5a569a.diff

Re: [PATCH] D69876: Support output constraints on "asm goto"

2020-02-25 Thread Bill Wendling via cfe-commits
I had to re-do the patch. It works for me now...Sorry about the failure! On Tue, Feb 25, 2020 at 12:10 PM Leonard Chan via Phabricator < revi...@reviews.llvm.org> wrote: > leonardchan added a comment. > > Woops, sorry. Didn't see you sent out > https://reviews.llvm.org/rGe11f9fb4508534d31b09d2ba6

[clang] ee10d93 - Fix typo so that '-O0' is correctly specified

2019-11-05 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2019-11-05T13:15:55-08:00 New Revision: ee10d93449eccfd3b6e6ae8f02551b1a03a4 URL: https://github.com/llvm/llvm-project/commit/ee10d93449eccfd3b6e6ae8f02551b1a03a4 DIFF: https://github.com/llvm/llvm-project/commit/ee10d93449eccfd3b6e6ae8f02551b1a03a4.diff

[clang] 9180f8a - Don't report "main" as missing a prototype in freestanding mode

2019-11-22 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2019-11-22T12:35:43-08:00 New Revision: 9180f8a57436da0ce91d9d4885702a10f89571bc URL: https://github.com/llvm/llvm-project/commit/9180f8a57436da0ce91d9d4885702a10f89571bc DIFF: https://github.com/llvm/llvm-project/commit/9180f8a57436da0ce91d9d4885702a10f89571bc.diff

[clang] 2b79563 - Fix typo to separate "-x" from warning flag.

2019-11-22 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2019-11-22T12:51:41-08:00 New Revision: 2b795637b9024d76e53cd303ad74ac02ba22da5b URL: https://github.com/llvm/llvm-project/commit/2b795637b9024d76e53cd303ad74ac02ba22da5b DIFF: https://github.com/llvm/llvm-project/commit/2b795637b9024d76e53cd303ad74ac02ba22da5b.diff

[clang-tools-extra] 936de1c - Remove extraneous semicolon.

2019-12-02 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2019-12-02T14:09:21-08:00 New Revision: 936de1c5bc2dfbec25318985cddb7345d989a7ee URL: https://github.com/llvm/llvm-project/commit/936de1c5bc2dfbec25318985cddb7345d989a7ee DIFF: https://github.com/llvm/llvm-project/commit/936de1c5bc2dfbec25318985cddb7345d989a7ee.diff

[clang] 72aa619 - Warn of uninitialized variables on asm goto's indirect branch

2020-03-10 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2020-03-10T13:48:48-07:00 New Revision: 72aa619a7fe0e2f90959b0614f6388c09aba8913 URL: https://github.com/llvm/llvm-project/commit/72aa619a7fe0e2f90959b0614f6388c09aba8913 DIFF: https://github.com/llvm/llvm-project/commit/72aa619a7fe0e2f90959b0614f6388c09aba8913.diff

[clang] 218dd33 - Add triple for non-x86 environments.

2020-03-10 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2020-03-10T15:26:03-07:00 New Revision: 218dd339541f574f76d7310f6c3269bfe3262d08 URL: https://github.com/llvm/llvm-project/commit/218dd339541f574f76d7310f6c3269bfe3262d08 DIFF: https://github.com/llvm/llvm-project/commit/218dd339541f574f76d7310f6c3269bfe3262d08.diff

[clang] 554ba99 - Revert "[Clang] Refactor "Designators" into a unified implementation [NFC]"

2023-03-02 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-03-02T12:09:29-08:00 New Revision: 554ba996956559acdab777d18999b9985d95be4c URL: https://github.com/llvm/llvm-project/commit/554ba996956559acdab777d18999b9985d95be4c DIFF: https://github.com/llvm/llvm-project/commit/554ba996956559acdab777d18999b9985d95be4c.diff

[clang] bfee6f1 - [Clang][NFC] Refactor "Designators" to be more similar

2023-04-05 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-04-05T15:46:40-07:00 New Revision: bfee6f1142368e522d09551930ef90f4e6be1f42 URL: https://github.com/llvm/llvm-project/commit/bfee6f1142368e522d09551930ef90f4e6be1f42 DIFF: https://github.com/llvm/llvm-project/commit/bfee6f1142368e522d09551930ef90f4e6be1f42.diff

[clang] 2cbf512 - [Clang] Improve designated inits diagnostic location

2023-04-07 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-04-07T11:37:05-07:00 New Revision: 2cbf5127d58553fd6224a1ec809536bccc5b8510 URL: https://github.com/llvm/llvm-project/commit/2cbf5127d58553fd6224a1ec809536bccc5b8510 DIFF: https://github.com/llvm/llvm-project/commit/2cbf5127d58553fd6224a1ec809536bccc5b8510.diff

[clang-tools-extra] 3c07db5 - [Clang] Refactor "Designators" into a unified implementation [NFC]

2023-02-07 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-02-07T12:59:17-08:00 New Revision: 3c07db5f58e9852f35202f0fffed50fc7506f37b URL: https://github.com/llvm/llvm-project/commit/3c07db5f58e9852f35202f0fffed50fc7506f37b DIFF: https://github.com/llvm/llvm-project/commit/3c07db5f58e9852f35202f0fffed50fc7506f37b.diff

[clang-tools-extra] b51a03e - [Clang][NFC] Rename methods/vars to reflect their real usage

2023-04-18 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2023-04-18T13:48:08-07:00 New Revision: b51a03e1bbe7ea8868ffb24472fc532d0c00943c URL: https://github.com/llvm/llvm-project/commit/b51a03e1bbe7ea8868ffb24472fc532d0c00943c DIFF: https://github.com/llvm/llvm-project/commit/b51a03e1bbe7ea8868ffb24472fc532d0c00943c.diff

[clang] 7fa8585 - [NFC][clang] Remove trailing whitespaces

2024-02-21 Thread Bill Wendling via cfe-commits
Author: Bill Wendling Date: 2024-02-21T12:21:35-08:00 New Revision: 7fa8585fdefd98dd73940c74165aa55da1175f02 URL: https://github.com/llvm/llvm-project/commit/7fa8585fdefd98dd73940c74165aa55da1175f02 DIFF: https://github.com/llvm/llvm-project/commit/7fa8585fdefd98dd73940c74165aa55da1175f02.diff

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-02-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling approved this pull request. https://github.com/llvm/llvm-project/pull/82432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-02-21 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/82432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-07-08 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/86858 >From 31af119d614ef2108b5404f9c9387ec45aa1bfef Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Thu, 21 Mar 2024 15:07:31 -0700 Subject: [PATCH 1/8] [Clang][objectsize] Generate object size calculation for s

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-07-08 Thread Bill Wendling via cfe-commits
bwendling wrote: That last commit message was a mistake. :-/ This is almost ready for another look. Please stay tunded. https://github.com/llvm/llvm-project/pull/86858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-07-08 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/86858 >From 31af119d614ef2108b5404f9c9387ec45aa1bfef Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Thu, 21 Mar 2024 15:07:31 -0700 Subject: [PATCH 1/8] [Clang][objectsize] Generate object size calculation for s

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-07-08 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/86858 >From 31af119d614ef2108b5404f9c9387ec45aa1bfef Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Thu, 21 Mar 2024 15:07:31 -0700 Subject: [PATCH 01/10] [Clang][objectsize] Generate object size calculation for

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-04 Thread Bill Wendling via cfe-commits
https://github.com/bwendling created https://github.com/llvm/llvm-project/pull/107300 Refactor attribute parsing so that the main code parsing an attribute can be called by a separate code path that doesn't start with the '__attribute' keyword. >From c30c6c11686cc95ba20eb7000d210b17757fbfe3 M

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-04 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/107300 >From c30c6c11686cc95ba20eb7000d210b17757fbfe3 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Sep 2024 12:49:04 -0700 Subject: [PATCH 1/2] [Parser][NFC] Move the core parsing of an attribute into a

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Bill Wendling via cfe-commits
@@ -2943,6 +2943,9 @@ class Parser : public CodeCompletionHandler { return false; } + bool ParseGNUSingleAttribute(ParsedAttributes &Attrs, SourceLocation &EndLoc, bwendling wrote: > Ah, I see. The WG14 specified one is __builtin_has_c_attribute, corre

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/107300 >From c30c6c11686cc95ba20eb7000d210b17757fbfe3 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Sep 2024 12:49:04 -0700 Subject: [PATCH 1/3] [Parser][NFC] Move the core parsing of an attribute into a

[clang] [Parser][NFC] Move the core parsing of an attribute into a separate method (PR #107300)

2024-09-06 Thread Bill Wendling via cfe-commits
https://github.com/bwendling closed https://github.com/llvm/llvm-project/pull/107300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-08 Thread Bill Wendling via cfe-commits
@@ -4248,6 +4248,22 @@ bool CompilerInvocation::ParseLangArgs(LangOptions &Opts, ArgList &Args, Diags.Report(diag::err_drv_invalid_value) << A->getAsString(Args) << Val; } + if (auto *A = Args.getLastArg(OPT_fsanitize_overflow_pattern_exclusion_EQ)) { +for (int i

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-08 Thread Bill Wendling via cfe-commits
@@ -0,0 +1,83 @@ +// Check for potential false positives from patterns that _almost_ match classic overflow-dependent or overflow-prone code patterns bwendling wrote: In general, I think it's expected the RUN lines will be first and any comments about the test

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-08 Thread Bill Wendling via cfe-commits
@@ -555,6 +570,11 @@ class LangOptions : public LangOptionsBase { /// The default stream kind used for HIP kernel launching. GPUDefaultStreamKind GPUDefaultStream; + /// Which overflow patterns should be excluded from sanitizer instrumentation + int OverflowPatternExclus

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-08 Thread Bill Wendling via cfe-commits
@@ -2877,6 +2888,17 @@ ScalarExprEmitter::EmitScalarPrePostIncDec(const UnaryOperator *E, LValue LV, } else if (type->isIntegerType()) { QualType promotedType; bool canPerformLossyDemotionCheck = false; + +// Is the pattern "while (i--)" and overflow exclusion? +

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-08 Thread Bill Wendling via cfe-commits
@@ -293,6 +293,40 @@ To silence reports from unsigned integer overflow, you can set ``-fsanitize-recover=unsigned-integer-overflow``, is particularly useful for providing fuzzing signal without blowing up logs. +Disabling instrumentation for common overflow patterns +

<    1   2   3   4   5   6   7   >