[clang] Crash when referencing capture in static lambda (PR #74661)

2023-12-06 Thread Ben Jackson via cfe-commits
https://github.com/puremourning created https://github.com/llvm/llvm-project/pull/74661 The constant evaluator could try to reference a lambda capture in a static lambda call operator. Static lambdas can't have captures, so we simply abort. Either the lambda needs to be made non-static, or the

[clang] Crash when referencing capture in static lambda (PR #74661)

2023-12-06 Thread Ben Jackson via cfe-commits
puremourning wrote: I guess should ping @royjacobson on this one? https://github.com/llvm/llvm-project/pull/74661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Crash when referencing capture in static lambda (PR #74661)

2023-12-06 Thread Ben Jackson via cfe-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/74661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Crash when referencing capture in static lambda (PR #74661)

2023-12-07 Thread Ben Jackson via cfe-commits
https://github.com/puremourning updated https://github.com/llvm/llvm-project/pull/74661 >From 8a72385996824f9cdd0feb5a1ca7aa771c03fe99 Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Wed, 6 Dec 2023 21:59:21 + Subject: [PATCH] Crash when referencing capture in static lambda The constant e

[clang] [clang] Crash when referencing capture in static lambda (PR #74661)

2023-12-07 Thread Ben Jackson via cfe-commits
puremourning wrote: > Can you add a release note? Otherwise it looks good to me Yep, sure thing. Done. https://github.com/llvm/llvm-project/pull/74661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang] Crash when referencing capture in static lambda (PR #74661)

2023-12-07 Thread Ben Jackson via cfe-commits
https://github.com/puremourning updated https://github.com/llvm/llvm-project/pull/74661 >From 13afd0e5087340c62b31ff5d35c06b28f93086a5 Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Wed, 6 Dec 2023 21:59:21 + Subject: [PATCH] Crash when referencing capture in static lambda The constant e

[clang] [clang] Crash when referencing capture in static lambda (PR #74661)

2023-12-07 Thread Ben Jackson via cfe-commits
https://github.com/puremourning updated https://github.com/llvm/llvm-project/pull/74661 >From cdd9b653de7aed3d54b5ac6c98fc943183509278 Mon Sep 17 00:00:00 2001 From: Ben Jackson Date: Wed, 6 Dec 2023 21:59:21 + Subject: [PATCH] Crash when referencing capture in static lambda The constant e

[clang] [clang][Interp] Reject static lambdas with captures (PR #74718)

2023-12-11 Thread Ben Jackson via cfe-commits
https://github.com/puremourning edited https://github.com/llvm/llvm-project/pull/74718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Reject static lambdas with captures (PR #74718)

2023-12-11 Thread Ben Jackson via cfe-commits
https://github.com/puremourning commented: Lgtm https://github.com/llvm/llvm-project/pull/74718 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Reject static lambdas with captures (PR #74718)

2023-12-11 Thread Ben Jackson via cfe-commits
@@ -61,6 +61,11 @@ ByteCodeEmitter::compileFunc(const FunctionDecl *FuncDecl) { MD->getParent()->getCaptureFields(LC, LTC); for (auto Cap : LC) { +// Static lambdas cannot have any captures. If this one does, +// it has already been diagnosed and we

Re: [PATCH] D11976: [libclang] Return deduced type for auto type, not the one written in the source.

2015-08-22 Thread Ben Jackson via cfe-commits
puremourning added a comment. I can confirm that this patch fixes a number test cases found in ycmd (a code-completion server). Specifically these ones marked as 'sic' So I

Re: [PATCH] D22129: [clang-rename] add documentation

2016-07-11 Thread Ben Jackson via cfe-commits
puremourning added a subscriber: puremourning. puremourning added a comment. Couple of drive-by comments. Thanks for doing this. Comment at: docs/clang-rename.rst:45 @@ +44,3 @@ + +The tool is currently supporting renaming actions inside single Translation Unit +only. It is pla