[PATCH] D94019: Switching Clang UniqueInternalLinkageNamesPass scheduling to using the LLVM one with newpm.

aeubanks added a comment. In D94019#2478423 , @dblaikie wrote: > In D94019#2478378 , @aeubanks wrote: > >> Oh sorry, yeah this isn't NFC. >> >> But I still don't think this needs a new test. We're going from a custo

[PATCH] D94257: [test] Move coro-retcon-unreachable.ll into llvm/test

aeubanks created this revision. Herald added a subscriber: lxfind. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94257 Files: clang/test/CodeGe

[PATCH] D94257: [test] Move coro-retcon-unreachable.ll into llvm/test

This revision was automatically updated to reflect the committed changes. Closed by commit rGd002cd4e0f10: [test] Move coro-retcon-unreachable.ll into llvm/test (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D94257?vs=315209&id=315240#toc Repository: rG LLVM Github

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. In D93743#2485876 , @ahatanak wrote: > Is this change safe considering calls to `EP.get()` can add function > declarations to the module as you mentioned in > https://reviews.llvm.org/D86178? It's definitely safe right now sinc

[PATCH] D92806: Single function compilation mode.

aeubanks added a comment. WDYT about adding optnone to all functions except the ones you're interested in? Would that cut down the compile times? We could reuse ForceFunctionAttrsPass rather than adding so much plumbing. This is too much plumbing for my liking. And since this is a debug thing,

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:462 + if (!PIC->hasPassName(P)) +report_fatal_error("unrecognized pass name: " + P); +} hoy wrote: > @aeubanks This seems not working with MIR passes under newpm. Would i

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. In D93743#2487987 , @ahatanak wrote: > LGTM. ARC contract pass isn't being run by the NPM, but you are going to > change that in the future, I guess? Looks like that's part of the codegen pipeline and not the optimization pipel

[PATCH] D93743: [NewPM] Run ObjC ARC passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG756dd707668c: [NewPM] Run ObjC ARC passes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://reviews.llvm.org/D93743

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks created this revision. Herald added subscribers: wenlei, steven_wu, hiraditya, eraman. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. And revert much of D91567 . D91567 <

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks updated this revision to Diff 316550. aeubanks added a comment. test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 Files: clang/test/CodeGen/thinlto-distributed-newpm.ll clang/test/Fronte

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks added a comment. In D94644#2497125 , @mtrofin wrote: > Would running the function simplification pipeline after the always inline > pass address the issue? Probably yes, but last time we measured the compile time implications of that, it was ve

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks added a comment. An alternative is to run the mandatory inliner in the same CGSCC pipeline as everything else, but the way InlineAdvisorAnalysis is setup made it hard to implement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks added a comment. It's not an emergency. The issue with InlineAdvisorAnalysis is that the ModuleInlineWrapperPass presets the InliningAdvisorMode of the InlineAdvisorAnalysis. We could force override it, but then what's the point of InlineAdvisorAnalysis? Can't we just create an InlineA

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks created this revision. Herald added subscribers: hiraditya, eraman. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94808 Files: clang/t

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks added a comment. Wondering if this makes sense to you (before I go and finish cleaning up all the tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94808/new/ https://reviews.llvm.org/D94808 ___

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks added inline comments. Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:661 FunctionAnalysisManager &FAM, Module &M) { + if (Mandatory) { +OwnedAdvisor = std::make_unique(FAM); mtrofin wrote: > This should move to line 675: i

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

aeubanks added a comment. overall looks good, just a couple small comments Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +MandatoryInliningKind::Always == -

[PATCH] D94825: [NewPM][Inliner] Move the 'always inliner' case in the same CGSCC pass as 'regular' inliner

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:463 +return getAdviceImpl(CB); + bool Advice = CB.getCaller() != CB.getCalledFunction() && +Manda

[PATCH] D94644: [Inliner] Inline alwaysinline calls first

aeubanks abandoned this revision. aeubanks added a comment. https://reviews.llvm.org/D94825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94644/new/ https://reviews.llvm.org/D94644 ___ cfe-commits mailin

[PATCH] D94808: [NewPM][Inliner] Move mandatory inliner inside function simplification pipeline

aeubanks abandoned this revision. aeubanks added a comment. https://reviews.llvm.org/D94825 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94808/new/ https://reviews.llvm.org/D94808 ___ cfe-commits mailin

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks updated this revision to Diff 377333. aeubanks added a comment. update test I checked to make sure that we're not accepting -clear-ast-before-backend as a driver flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://revie

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377335. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update some clang uses to fix errors/warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/

[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

aeubanks accepted this revision. aeubanks added a comment. lg, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110891/new/ https://reviews.llvm.org/D110891 ___ cfe-commits mailing list cfe-commits@

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we're limited to 32 bit ints in diagnostics. With support for 4GB alignments coming soon, we need to report 4GB as the max alignment allowed

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedfff2f8b043: [clang] Allow printing 64 bit ints in diagnostics (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D110451: [IR] Increase max alignment to 4GB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf84c1fe7813: [IR] Increase max alignment to 4GB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks created this revision. aeubanks added reviewers: hans, rsmith. Herald added a reviewer: aaron.ballman. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Followup to D110451 which set LLVM's

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377631. aeubanks added a comment. more types changed throughout the codebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451 Files: clang/lib/CodeGen/CGBlocks.cpp

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks updated this revision to Diff 377633. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451 Files: clang/lib/CodeGen/CGBlocks.cpp clang/lib/CodeGen/CGCall.cpp cla

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:179 -static const unsigned kAllocaRzSize = 32; +static const uint64_t kAllocaRzSize = 32; MaskRay wrote: > You may switch to namespace scope/global `constexpr

[PATCH] D110451: [IR] Increase max alignment to 4GB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05392466f02b: Reland [IR] Increase max alignment to 4GB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend.c:2-3 +// RUN: %clang -target x86_64-linux-gnu -c -Xclang -clear-ast-before-backend %s -S +// RUN: %clang -target x86_64-linux-gnu -c -Xclang -clear-ast-before-backend %s -S -### 2>&1 | FileChe

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks updated this revision to Diff 377669. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://reviews.llvm.org/D05 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6522b7cc3240: [clang] Add option to clear AST memory before running LLVM passes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks updated this revision to Diff 377675. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.llvm.org/D111250 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/l

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

aeubanks added a comment. In D05#3046585 , @dblaikie wrote: >> This is similar to perf testing which we don't really have in tree tests >> for. Typically these things are mostly monitored separately (e.g. >> llvm-compile-time-tracker). > > Except in

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

aeubanks updated this revision to Diff 377915. aeubanks added a comment. add more codegen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.llvm.org/D111250 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen

[PATCH] D111250: [clang] Set max allowed alignment to 2^32

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6891d2104fc: [clang] Set max allowed alignment to 2^32 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111250/new/ https://reviews.ll

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added a comment. Yes a stack trace/repro would be nice. I see a couple places that might be causing issues, I'll try fixing those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added a comment. I've comitted https://reviews.llvm.org/rGa0a493518245fa20fe15703a1be6babcb0c43c0a, if your stack trace is different, the fix will probably be very similar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https:/

[PATCH] D110451: [IR] Increase max alignment to 4GB

aeubanks added a comment. Sorry about that, should be fixed with 20a0c482e0 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110451/new/ https://reviews.llvm.org/D110451

[PATCH] D111472: [docs] Mention in release notes that we now support 2^32 alignment

aeubanks updated this revision to Diff 378719. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. mention in Clang release notes as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111472/new/ https:/

[PATCH] D111472: [docs] Mention in release notes that we now support 2^32 alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb41cfbfcbbe2: [docs] Mention in release notes that we now support 2^32 alignment (authored by aeubanks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D111582: [clang] Clear IR analyses before codegen pipeline

aeubanks created this revision. Herald added a subscriber: ormris. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This saves a tiny bit of memory in non-LTO builds [1]. [1] https://llvm-compile-time-tracker.com/compare.php?from=

[PATCH] D111582: [clang] Clear IR analyses before codegen pipeline

aeubanks updated this revision to Diff 379111. aeubanks added a comment. refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111582/new/ https://reviews.llvm.org/D111582 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib/CodeGen/Backe

[PATCH] D111582: [clang] Teardown new PM data structures before running codegen pipeline

aeubanks updated this revision to Diff 379175. aeubanks added a comment. add back a (similar) comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111582/new/ https://reviews.llvm.org/D111582 Files: clang/lib/CodeGen/BackendUtil.cpp Index: cla

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

aeubanks added a comment. In D110684#3057498 , @nikic wrote: > I noticed this a few time in the past already, but this is the worst one yet: > > Compile-time: > https://llvm-compile-time-tracker.com/compare.php?from=6641d29b70993bce6dbd7e0e0f1040753d3884

[PATCH] D111582: [clang] Teardown new PM data structures before running codegen pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cadef6537b3: [clang] Teardown new PM data structures before running codegen pipeline (authored by aeubanks). Repository: rG LLVM Github Monorepo

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

aeubanks created this revision. aeubanks added a reviewer: MaskRay. Herald added a subscriber: ormris. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. aeubanks requested review of this revision. Herald added a project: clang. Herald added a s

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

aeubanks updated this revision to Diff 379208. aeubanks added a comment. add comment I'd rather switch everything to lowerCamel at once rather than just a few methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111680/new/ https://reviews.llvm.o

[PATCH] D111680: [NFC] Rename EmitAssemblyHelper new/legacy PM methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a8c695542b: [NFC] Rename EmitAssemblyHelper new/legacy PM methods (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aeubanks created this revision. aeubanks updated this revision to Diff 378327. aeubanks added a comment. aeubanks edited the summary of this revision. aeubanks retitled this revision from "[clang] Always pass -clear-ast-before-backend" to "[clang] Pass -clear-ast-before-backend". aeubanks edited t

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks created this revision. aeubanks added a reviewer: dblaikie. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously without -disable-free, -clear-ast-before-backend would crash in ~ASTContext() due to various reasons.

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aeubanks added a comment. In D111270#3060484 , @dblaikie wrote: > Plan is still to address the "this only works with disable free" issue? (I've > some preference that be addressed before this feature is turned on by default) https://reviews.llvm.org/D11

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:355-356 + if (CodeGenOpts.ClearASTBeforeBackend) { +// The ASTContext may be unusable after this. +C.cleanup(); C.getAllocator().Reset(); dblaikie wrote:

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

aeubanks updated this revision to Diff 379827. aeubanks added a comment. add more comments about the cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111767/new/ https://reviews.llvm.org/D111767 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D111767: [clang] Support -clear-ast-before-backend without -disable-free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a5f61c4f6f: [clang] Support -clear-ast-before-backend without -disable-free (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

aeubanks updated this revision to Diff 379866. aeubanks added a comment. force off for the clang interpreter I thought I ran check-clang, apparently I didn't Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111270/new/ https://reviews.llvm.org/D111270

[PATCH] D111270: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47eb99aa44ab: [clang] Pass -clear-ast-before-backend in Clang::ConstructJob() (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

aeubanks created this revision. aeubanks added a reviewer: dblaikie. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We still need access to various things in the ASTContext when printing stats. Repository: rG LLVM Github Monor

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

This revision was automatically updated to reflect the committed changes. Closed by commit rGab41a1c50558: [clang] Disable -clear-ast-before-backend with -print-stats (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D111973?vs=380281&id=380421#toc Repository: rG LLVM

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

aeubanks added a comment. In D111973#3069304 , @dblaikie wrote: > Could you check some of the stats output is valid/expected, not just > corrupt/garbage? "just doesn't crash" isn't a great criteria for a test. forgot to upload the diff, but I did so in

[PATCH] D111973: [clang] Disable -clear-ast-before-backend with -print-stats

aeubanks added a comment. In D111973#3070519 , @aeubanks wrote: > In D111973#3069304 , @dblaikie > wrote: > >> Could you check some of the stats output is valid/expected, not just >> corrupt/garbage? "just doesn

[PATCH] D111184: [clang] Allow printing 64 bit ints in diagnostics

aeubanks added a comment. In D84#3071422 , @dblaikie wrote: > Is there no diagnostic that could reasonably produce such a large value that > would be easy to test (without needing a giant binary, etc)? (seem surprising > to see this change without a

[PATCH] D112096: [clang] Add plugin ActionType to run command line plugin before main action

aeubanks created this revision. aeubanks added reviewers: hans, dblaikie. Herald added a subscriber: mgorny. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we have a way to run a plugin if specified on the command line a

[PATCH] D112100: [clang] Add option to disable -clear-ast-before-backend

aeubanks created this revision. aeubanks added reviewers: hans, dblaikie. Herald added a subscriber: dang. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some downstream users have plugins that -clear-ast-before-backend may affect

[PATCH] D112100: [clang] Add option to disable -clear-ast-before-backend

aeubanks updated this revision to Diff 380847. aeubanks added a comment. use BoolOption td files are very hard to use... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112100/new/ https://reviews.llvm.org/D112100 Files: clang/include/clang/Driver

[PATCH] D112100: [clang] Add option to disable -clear-ast-before-backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG063c2f89aa7f: [clang] Add option to disable -clear-ast-before-backend (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D112096: [clang] Add plugin ActionType to run command line plugin before main action

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe66433fe119: [clang] Add plugin ActionType to run command line plugin before main action (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Downstream users may have Clang plugins. By default these plugins run after the main action if they are specified on the command line. Since these plu

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

aeubanks updated this revision to Diff 381112. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112190/new/ https://reviews.llvm.org/D112190 Files: clang/lib/Frontend/FrontendAction.cpp clang/test/Misc/clear-ast-b

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/null -load %llvmshlibdir/PrintFunctionNames%pluginext %s 2>&1 | FileCheck %s --che

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dcad7754a20: [clang] Don't clear AST if we have consumers running after the main action (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112190: [clang] Don't clear AST if we have consumers running after the main action

aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend-plugins.c:3-8 +// RUN: %clang_cc1 -mllvm -debug-only=codegenaction -clear-ast-before-backend -emit-obj -o /dev/null -load %llvmshlibdir/PrintFunctionNames%pluginext %s 2>&1 | FileCheck %s --che

[PATCH] D112253: [test] Make sure plugin actually runs in clear-ast-before-backend-plugins.c

aeubanks created this revision. aeubanks added a reviewer: dblaikie. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112253 Files: clang/test/Misc/clear-ast-before

[PATCH] D112253: [test] Make sure plugin actually runs in clear-ast-before-backend-plugins.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdb66eda77a0: [test] Make sure plugin actually runs in clear-ast-before-backend-plugins.c (authored by aeubanks). Repository: rG LLVM Github Monor

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. this is good, but IMO it's not clear enough in the description that this is a breaking change in terms of CMake flags (use -DLLVM_ENABLE_NEW_PASS_MANAGER instead of -DEXPERIMENTAL_NEW_PASS

[PATCH] D108775: [CMake] Change -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=off to -DLLVM_ENABLE_NEW_PASS_MANAGER=off

aeubanks added a comment. lg, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108775/new/ https://reviews.llvm.org/D108775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D108789: [clang][NewPM] Mention that legacy PM flags are deprecated

aeubanks created this revision. aeubanks added a reviewer: MaskRay. Herald added a subscriber: dang. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108789 Files:

[PATCH] D108789: [clang][NewPM] Mention that legacy PM flags are deprecated

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6eed1fb349de: [clang][NewPM] Mention that legacy PM flags are deprecated (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D108789: [clang][NewPM] Mention that legacy PM flags are deprecated

aeubanks added a comment. @tstellar is it ok to cherry-pick this into 13.x? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108789/new/ https://reviews.llvm.org/D108789 ___ cfe-commits mailing list cfe-com

[PATCH] D109707: [HIP] [AlwaysInliner] Disable AlwaysInliner to eliminate undefined symbols

aeubanks added a comment. should the `amdgpu-early-inline-all` flag be deleted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109707/new/ https://reviews.llvm.org/D109707 ___ cfe-commits mailing list cfe

<    3   4   5   6   7   8