aeubanks added a comment. In D111105#3046585 <https://reviews.llvm.org/D111105#3046585>, @dblaikie wrote:
>> This is similar to perf testing which we don't really have in tree tests >> for. Typically these things are mostly monitored separately (e.g. >> llvm-compile-time-tracker). > > Except in this case it isn't tested at all because it's behind a flag. Unless > we're bringing up a buildbot/tracker that tracks this configuration? It'll be on by default soon, bringing up a separate tracker in the meantime is not worth it. I've already run llvm-compile-time-tracker before with this turned on with good results. >> As for making sure that optimizations still happen, -emit-obj requires that. >> If that isn't happening with -emit-obj then something is very wrong. I'll >> add a function and make this -O1 though so we test more passes. > > I think checking the IR would be worthwhile too, otherwise this is still a > "does anything other than crash" test, which I think is a bit too broad of a > test. I still don't think that is useful at all, this code doesn't touch that sort of stuff so that's more of an unrelated thing. Given that we're about to turn this on by default, I think it's much more useful to run this over a large codebase, see if anything crashes, and add those as regression tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111105/new/ https://reviews.llvm.org/D111105 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
