[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat created this revision. Herald added a subscriber: xazax.hun. werat requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The encoding used for opening files depends on the OS and might be different from UTF-8 (e.g. on Windows it

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat added a comment. > Hi! Thanks for the patch, it makes sense to me! Honestly, I think having the > open shadow is maybe not the best way to solve this (please feel free to let > me know if there are reasons it would be better), maybe spell it out > explicitly (there aren't that many cases

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat updated this revision to Diff 362677. werat added a comment. Use `io.open` explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106792/new/ https://reviews.llvm.org/D106792 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat updated this revision to Diff 362678. werat added a comment. Fix incorrect replace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106792/new/ https://reviews.llvm.org/D106792 Files: clang-tools-extra/clang-tidy/add_new_check.py clang-tool

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat added a comment. In D106792#2912955 , @kbobyrev wrote: > Honestly, I don't really think we should have more Unicode symbols in the > docs for generators I'm not very familiar with the documentation build process, but maybe we could enforce only-A

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

werat updated this revision to Diff 363413. werat added a comment. Moved the comment to the first usage of `io.open`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106792/new/ https://reviews.llvm.org/D106792 Files: clang-tools-extra/clang-tidy/

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG307b1fddd4d8: [clang-tidy] Always open files using UTF-8 encoding (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT