ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4260-4273
@@ -4259,2 +4259,16 @@
+/// \brief look inside a Body stmt for a LF statement discarding any
+/// intervening CompoundStmt's
+template
+const static LF *hasEnclosingOpenMPDirective(const Stmt *
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG, except for the small comment
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4260
@@ -4259,1 +4259,3 @@
+/// \brief discard all CompoundStmts intervening between two const
Author: abataev
Date: Wed Apr 13 08:36:48 2016
New Revision: 266198
URL: http://llvm.org/viewvc/llvm-project?rev=266198&view=rev
Log:
[OPENMP 4.0] Fixed DSA analysis for taskloop directives.
Patch make clang to perform analysis for task-based directives also for
taskloop-based directives.
Modifi
Author: abataev
Date: Tue Apr 19 04:10:27 2016
New Revision: 266722
URL: http://llvm.org/viewvc/llvm-project?rev=266722&view=rev
Log:
[OPENMP] Codegen for untied tasks.
If the untied clause is present on a task construct, any thread in the team can
resume the task region after a suspension. Patc
Author: abataev
Date: Tue Apr 19 04:27:38 2016
New Revision: 266724
URL: http://llvm.org/viewvc/llvm-project?rev=266724&view=rev
Log:
Revert "[OPENMP] Codegen for untied tasks."
This reverts commit 266722.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/CodeGen/CGOpenMP
Author: abataev
Date: Tue Apr 19 11:27:55 2016
New Revision: 266754
URL: http://llvm.org/viewvc/llvm-project?rev=266754&view=rev
Log:
[OPENMP] Codegen for untied tasks.
If the untied clause is present on a task construct, any thread in the
team can resume the task region after a suspension. Patch
Author: abataev
Date: Tue Apr 19 11:36:01 2016
New Revision: 266755
URL: http://llvm.org/viewvc/llvm-project?rev=266755&view=rev
Log:
Revert "[OPENMP] Codegen for untied tasks."
This reverts commit r266754.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/CodeGen/CGOpenM
Author: abataev
Date: Tue Apr 19 23:01:36 2016
New Revision: 266853
URL: http://llvm.org/viewvc/llvm-project?rev=266853&view=rev
Log:
[OPENMP] Codegen for untied tasks.
If the untied clause is present on a task construct, any thread in the
team can resume the task region after a suspension. Patch
Author: abataev
Date: Thu Apr 21 22:56:56 2016
New Revision: 267101
URL: http://llvm.org/viewvc/llvm-project?rev=267101&view=rev
Log:
[OPENMP] Fix for LCV in simd directives in explicit clauses.
If loop control variable for simd-based directives is explicitly marked
as linear/lastprivate in claus
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2789-2797
@@ +2788,11 @@
+// \brief Expression associated with the component.
+Expr *AssociatedExpression;
+// \brief Declaration associated with the declaration. If the component
does
+//
Author: abataev
Date: Fri Apr 22 04:05:03 2016
New Revision: 267125
URL: http://llvm.org/viewvc/llvm-project?rev=267125&view=rev
Log:
[OPENMP] Fix for PR27463: Privatizing struct fields with array type
causes code generation failure.
The codegen part of firstprivate clause for member decls used t
ABataev added inline comments.
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+if (Cache.count(D))
+ continue;
I think you'd better to count and to store canonical decls rather than the
decls themselves. It will r
Author: abataev
Date: Mon Apr 25 07:22:29 2016
New Revision: 267395
URL: http://llvm.org/viewvc/llvm-project?rev=267395&view=rev
Log:
[OPENMP 4.5] Codegen for 'taskloop' directive.
The taskloop construct specifies that the iterations of one or more associated
loops will be executed in parallel u
ABataev accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/AST/OpenMPClause.cpp:546
@@ +545,3 @@
+ for (auto *D : Declarations) {
+assert(
+(!D || D->isCanonicalDecl()) &&
sfantao wrote:
> Ok, using canonical decl
Author: abataev
Date: Tue May 24 02:40:12 2016
New Revision: 270536
URL: http://llvm.org/viewvc/llvm-project?rev=270536&view=rev
Log:
[OPENMP] Fixed codegen for firstprivate vars in standalone worksharing
directives.
If firstprivate variable is is captured by value in outlined region and then
us
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4874-4878
@@ -4881,1 +4873,7 @@
+OMP_MAP_IS_PTR = 0x10,
+/// \brief This flags signals that an argument is the first one relating to
+/// a map/private clause expression. For some cases a single
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5630-5639
@@ -5599,6 +5629,12 @@
// type, the default is 'tofrom'.
CurMapTypes.push_back(ElementType->isAggregateType()
? (MappableExprsHandler::OM
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:10218-10220
@@ +10217,5 @@
+Sema &SemaRef, DSAStackTy *DSAS, OpenMPClauseKind CKind,
+ArrayRef VarList, SmallVector &Vars,
+OMPClauseMappableExprCommon::MappableExprComponentLists &ClauseComponents,
+
ABataev added a comment.
Add a test for nesting of regions here
Comment at: lib/Parse/ParseOpenMP.cpp:42
@@ -42,1 +41,3 @@
+ OMPD_target_exit,
+ OMPD_update
};
Please, add a comma after 'OMPD_update' to reduce number of changes in the next
modification of th
ABataev added a comment.
Missed a test for printing and serialization/deserialization
Comment at: test/OpenMP/nesting_of_regions.cpp:1832
@@ -1831,3 +1831,3 @@
for (int i = 0; i < 10; ++i) {
-#pragma omp target update to(a)
+#pragma omp target update from(a)
}
Author: abataev
Date: Wed May 25 07:36:08 2016
New Revision: 270690
URL: http://llvm.org/viewvc/llvm-project?rev=270690&view=rev
Log:
[OPENMP 4.5] Codegen for dacross loop synchronization constructs.
OpenMP 4.5 adds support for doacross loop synchronization. Patch
implements codegen for this cons
Author: abataev
Date: Wed May 25 07:51:24 2016
New Revision: 270693
URL: http://llvm.org/viewvc/llvm-project?rev=270693&view=rev
Log:
Fix build problem in MSVC
Modified:
cfe/trunk/lib/AST/OpenMPClause.cpp
Modified: cfe/trunk/lib/AST/OpenMPClause.cpp
URL:
http://llvm.org/viewvc/llvm-project/
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D15944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG, with a small nit.
Comment at: lib/Sema/SemaOpenMP.cpp:10214
@@ +10213,3 @@
+// expressions.
+struct MappableVarListInfo {
+ // The list of expressions.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D20650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: abataev
Date: Wed May 25 23:56:05 2016
New Revision: 270822
URL: http://llvm.org/viewvc/llvm-project?rev=270822&view=rev
Log:
[OPENMP] Set '_OPENMP' macro to '201511' value to reflect support for
OpenMP 4.5.
According to OpenMP 4.5 the _OPENMP macro name is defined to have the decimal
va
n't support #pragma omp declare target (which
> it only recently gained).
> Would you be ok reverting this commit?
>
> Cheers,
> Jonas
>
>> -Original Message-----
>> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
>> Of Alexey
t we tried to do within the ompt.h header and we had to add an
>>> exception because Clang 3.8 reported 201307 but didn't support #pragma
>>> omp declare target (which it only recently gained).
>>> Would you be ok reverting this commit?
>>>
>>> Cheers
Author: abataev
Date: Thu May 26 06:10:11 2016
New Revision: 270838
URL: http://llvm.org/viewvc/llvm-project?rev=270838&view=rev
Log:
[OPENMP] Add option '-fopenmp-version=[31|40|45]' allowing choosing
OpenMP version.
If '-fopenmp' option is provided '-fopenmp-version=' allows to control,
which v
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added a comment.
Hi Daniel,
Will fix it ASAP
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
27.05.2016 1:33, Samuel Antao пишет:
> sfantao updated the summary for this revision.
>
> http://reviews.llvm.org/D18110
http://reviews.llvm.org/D18110
Author: abataev
Date: Thu May 26 23:13:39 2016
New Revision: 270962
URL: http://llvm.org/viewvc/llvm-project?rev=270962&view=rev
Log:
[OPENMP] Fixed processing of '-fopenmp-version=' option and test.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
Author: abataev
Date: Mon May 30 04:06:50 2016
New Revision: 271201
URL: http://llvm.org/viewvc/llvm-project?rev=271201&view=rev
Log:
[OPENMP 4.5] Fixed codegen for 'priority' and destructors in task-based
directives.
'kmp_task_t' record type added a new field for 'priority' clause and
changed th
I can try to rebase it to 3.8.1 but Tom wants an approve from Richard.
Ping him!
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
30.05.2016 14:19, Hahnfeld, Jonas пишет:
> Hi,
>
> last possible ping as changes are required to be merged by tomorrow...
>
> Cheers,
Author: abataev
Date: Mon May 30 08:05:14 2016
New Revision: 271204
URL: http://llvm.org/viewvc/llvm-project?rev=271204&view=rev
Log:
[OPENMP 4.5] Additional codegen for statically scheduled loops with
'simd' modifier.
Runtime library defines new schedule constant kmp_sch_static_balanced_chunked
Hi Will,
Thanks for the report and sorry for a delay with answer. Generally, your patch
looks good with some small nits. I can fix some minor issues like extra braces
etc. and commit it if you don't mind.
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
28.05.2016
Author: abataev
Date: Tue May 31 01:21:27 2016
New Revision: 271251
URL: http://llvm.org/viewvc/llvm-project?rev=271251&view=rev
Log:
[MSVC] Fix stack overflow in unqualified type lookup logic, by Will
Wilson.
An unqualified lookup for in base classes may cause stack overflow if
the base class is
Author: abataev
Date: Tue May 31 06:17:08 2016
New Revision: 271263
URL: http://llvm.org/viewvc/llvm-project?rev=271263&view=rev
Log:
[OPENMP] Update in ReleaseNotes for OpenMP support.
Added notes about full support of all non-offloading features of OpenMP
4.5 + info about option -fopenmp-versio
Hi Tom,
I'm on a vacation right now without an access to the computer. Could you do it
yourself?
Best regards,
Alexey Bataev
Отправлено с iPhone
> 7 июня 2016 г., в 22:49, Tom Stellard написал(а):
>
> Hi Alexy,
>
> Can you merge this?
>
> Thanks,
> Tom
>
>> On Tue, Jun 07, 2016 at 09:40:44A
Author: abataev
Date: Wed Jun 15 06:19:39 2016
New Revision: 272774
URL: http://llvm.org/viewvc/llvm-project?rev=272774&view=rev
Log:
[MSVC] Late parsing of in-class defined member functions in template
classes.
MSVC actively uses unqualified lookup in dependent bases, lookup at the
instantiation
Author: abataev
Date: Wed Jun 15 06:20:48 2016
New Revision: 272775
URL: http://llvm.org/viewvc/llvm-project?rev=272775&view=rev
Log:
[OPENMP] Fix crash for 'schedule|dist_schedule' clauses during
instantiation.
Added checks for non-dependent context when trygin to capture
non-constant schedule c
Author: abataev
Date: Wed Jun 15 06:24:54 2016
New Revision: 272776
URL: http://llvm.org/viewvc/llvm-project?rev=272776&view=rev
Log:
Revert accidential "[MSVC] Late parsing of in-class defined member functions in
template"
This reverts commit 0253605771b8bd9d414aba74fe2742c730d6fd1a.
Modified:
ABataev abandoned this revision.
ABataev added a comment.
Revision is abandoned as the construct is supported already.
http://reviews.llvm.org/D15321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D21150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added inline comments.
Comment at: include/clang/AST/StmtOpenMP.h:2884-2896
@@ +2883,15 @@
+
+ /// Increment expression for distribute loop (OMPLoopDirective contains
+ /// increment expression for #for loop)
+ Expr *DistIncExpr;
+
+ /// \brief EnsureUpperBound for #pr
ABataev requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:1868-1871
@@ -1867,1 +1867,6 @@
+void CodeGenFunction::EmitOMPDistributeParallelForDirective(
+const OMPDistributeParallelForDirective &S) {
+
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a small nit
Comment at: lib/Sema/SemaOpenMP.cpp:6384-6386
@@ -6383,1 +6383,5 @@
+} else {
+ auto *OED = dyn_cast(S);
+ if (!OED || !isOpenMPTeamsDirect
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D21564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ABataev added a comment.
LG
Comment at: lib/Sema/SemaOpenMP.cpp:1826-1827
@@ +1825,4 @@
+std::make_pair(".bound_tid.", KmpInt32PtrTy),
+std::make_pair(".previous.lb.", KmpUInt64Ty),
+std::make_pair(".previous.ub.", KmpUInt64Ty),
+std::make_pair(St
Carlo, yes this is what I meant.
Best regards,
Alexey Bataev
Отправлено с iPhone
> 24 июня 2016 г., в 18:16, Carlo Bertolli написал(а):
>
> carlo.bertolli added a comment.
>
> Thanks for the hint - I have updated the diff to use Context.getSizeType().
> Please let me know if this is what yo
ABataev added a comment.
LG
http://reviews.llvm.org/D21617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D21841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added inline comments.
Comment at: lib/Driver/Driver.cpp:464-468
@@ +463,7 @@
+ RuntimeName = A->getValue();
+HasCompatibleOpenMP = llvm::StringSwitch(RuntimeName)
+ .Case("libomp", true)
+
ABataev added a comment.
General comment: remove '\brief' tags, they are not required anymore, just
'\\\' is enough
Comment at: include/clang/Driver/Action.h:94
@@ -93,1 +93,3 @@
+ /// \brief Flag that is set to true if this action can be collapsed with
+ /// others actions
ABataev added inline comments.
Comment at: include/clang/Driver/Action.h:158
@@ -157,1 +157,3 @@
std::string getOffloadingFileNamePrefix(StringRef NormalizedTriple) const;
+ /// \brief Return a string containing a offload kind name.
+ static std::string getOffloadKindName(Off
ABataev added a comment.
Remove '\brief'
Comment at: include/clang/Driver/Action.h:158-160
@@ -158,1 +157,5 @@
+ /// non-device kinds, except if \a CreatePrefixForHost is set.
+ static std::string
+ getOffloadingFileNamePrefix(OffloadKind Kind, StringRef NormalizedTriple,
+
ABataev added inline comments.
Comment at: include/clang/Driver/Action.h:493
@@ -491,1 +492,3 @@
+class OffloadUnbundlingJobAction : public JobAction {
+ void anchor() override;
'final'?
Comment at: include/clang/Driver/Action.h:499
@@ +498,3
ABataev added inline comments.
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:324-334
@@ -314,1 +323,13 @@
+// Handler for object files. The bundles are organized by sections with a
+// designated name.
+//
+// In order to bundle we create an IR file with the co
ABataev added inline comments.
Comment at: include/clang/Driver/Compilation.h:73
@@ +72,3 @@
+ /// architecture, and device offload kind.
+ struct TCArgsKey {
+const ToolChain *TC;
1. 'final'
2. default initializers for fields.
Comment at:
ABataev added a comment.
Remove empty 'return' and ';' statements where they are not required.
Comment at: test/Driver/clang-offload-bundler.c:14
@@ +13,3 @@
+//
+// RUN: touch %t.empty
+
Hmm, will it work on Windows? Maybe it is better just to add an empty test
ABataev added inline comments.
Comment at: lib/Driver/Tools.cpp:297
@@ +296,3 @@
+ StringRef Name = llvm::sys::path::filename(Output.getFilename());
+ StringRef Prefix = Name.rsplit('.').first;
+ if (C.getDriver().isSaveTempsEnabled()) {
Use llvm::sys::path::re
ABataev added inline comments.
Comment at: lib/Driver/Driver.cpp:1778
@@ +1777,3 @@
+ /// phase.
+ class OpenMPActionBuilder : public DeviceActionBuilder {
+/// \brief The OpenMP actions for the current input.
'final'
http://reviews.llvm.org/D21845
ABataev added a comment.
No '\brief's
Comment at: lib/Driver/Driver.cpp:1393
@@ +1392,3 @@
+/// generate the required device actions.
+class OffloadingActionBuilder {
+ /// \brief Flag used to trace errors in the builder.
1. 'final'
2. default initializers for
ABataev added a comment.
No '\brief's
Comment at: include/clang/Driver/Action.h:204
@@ -159,1 +203,3 @@
+/// kind to its dependences.
+class OffloadAction : public Action {
virtual void anchor();
'final'
Comment at: include/clang/Driver/Acti
ABataev added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8318
@@ -8317,1 +8317,3 @@
+def err_omp_usedeviceptr_not_a_pointer : Error<
+ "item used in 'use_device_pointer' clause is not a pointer">;
} // end of OpenMP category
It's be
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
sfantao wrote:
>
ABataev added a comment.
In http://reviews.llvm.org/D18172#471861, @jlebar wrote:
> Alexey, it seems that you're asking for "final" on all classes that are not
> inherited from. Forgive my ignorance, but would you mind pointing me to the
> document that talks about our position on "final" in L
ABataev added a comment.
In http://reviews.llvm.org/D21904#472074, @carlo.bertolli wrote:
> I think that Kelvin is right. This is what that sentence refers to:
> int * bla = ..;
> #pragma omp target data use_device_ptr(bla)
> {
>
> .. bla .. // <-- this is the 'reference' that sentence is ab
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:4221
@@ +4220,3 @@
+
+/// \brief This represents clause 'use_device_ptr' in the '#pragma omp ...'
+/// directives.
No \brief's
Comment at: include/clang/Basic/DiagnosticS
Author: abataev
Date: Thu Jul 7 06:04:06 2016
New Revision: 274745
URL: http://llvm.org/viewvc/llvm-project?rev=274745&view=rev
Log:
[OPENMP] Do not create helper expressions in dependent contexts, NFC.
OpenMP relies on some helper expressions generated during semantic
analysis. But they are req
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22169
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22096
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added a comment.
No positive tests for the construct
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8333
@@ -8332,1 +8332,3 @@
"expected at least one 'to' clause or 'from' clause specified to '#pragma
omp target update'">;
+def err_omp_usedeviceptr_not_a_poi
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:10667-10668
@@ +10666,4 @@
+ if (Type.isNull() || Type->isAnyPointerType() ||
+ CheckArrayExpressionDoesNotReferToWholeSize(SemaRef,
+ SI->getAssociatedExpression(),Type))
+
ABataev added a comment.
I don't see successful test for the clause, which prints AST and checks
serialization/deserialization. Also it should include a template test to check
that dependent objects are handled correctly
Comment at: include/clang/AST/OpenMPClause.h:4236
@@ +42
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D21904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D22075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Hi Paul,
Could you provide a little bit more info about diagnostic you see? Maybe
the tests just need to be fixed
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
15.07.2016 2:09, Paul Robinson пишет:
> probinson added a subscriber: probinson.
> probinson added a c
Kelvin,
Please look at these messages and fix the tests. Or tell me and I will
fix them
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
15.07.2016 9:23, Robinson, Paul пишет:
>
>> -Original Message-
>> From: Alexey Bataev [mailto:a.bat...@hotmail.com]
>> S
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: abataev
Date: Sun Feb 28 23:54:20 2016
New Revision: 262199
URL: http://llvm.org/viewvc/llvm-project?rev=262199&view=rev
Log:
[OPENMP 4.5] Initial support for data members in 'reduction' clauses.
OpenMP 4.5 allows to privatize non-static data members of current class
in non-static member
Author: abataev
Date: Tue Mar 1 22:57:40 2016
New Revision: 262460
URL: http://llvm.org/viewvc/llvm-project?rev=262460&view=rev
Log:
[OPENMP 4.5] Codegen for data members in 'reduction' clause.
OpenMP 4.5 allows to privatize non-static data members of current class
in non-static member functions
ABataev added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7787-7789
@@ -7786,5 +7786,5 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "array section can only be assoc
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:9016-9023
@@ +9015,10 @@
+
+ // If this is an array subscript, it refers to the whole size if the size of
+ // the dimension is constant and equals 1. Also, an array section assumes the
+ // format of an array s
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:256-296
@@ -255,26 +255,43 @@
/// \brief RAII for emitting code of OpenMP constructs.
class InlinedOpenMPRegionRAII {
CodeGenFunction &CGF;
+ /// \brief Saves the varaibles that were forced to be loca
Author: abataev
Date: Wed Mar 2 21:52:24 2016
New Revision: 262578
URL: http://llvm.org/viewvc/llvm-project?rev=262578&view=rev
Log:
[OPENMP 4.5] Initial support for data members in 'linear' clause.
OpenMP 4.5 allows to privatize data members of current class in member
functions. Patch adds init
Author: abataev
Date: Wed Mar 2 23:21:39 2016
New Revision: 262582
URL: http://llvm.org/viewvc/llvm-project?rev=262582&view=rev
Log:
[OPENMP 4.0] Initial support for 'omp declare reduction' construct.
Add parsing, sema analysis and serialization/deserialization for 'declare
reduction' construct
This revision was automatically updated to reflect the committed changes.
Closed by commit rL262582: [OPENMP 4.0] Initial support for 'omp declare
reduction' construct. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D11182?vs=45149&id=49707#toc
Repository:
rL LLVM
h
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:49-51
@@ -48,2 +48,5 @@
TargetRegion,
+/// \brief Region that do not require function outlining and uses
+/// information from a inner scope.
+InlinedInnerRegion,
};
Do
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:9071
@@ +9070,3 @@
+/// 0 if it is inconclusive.
+static int CheckArrayExpressionReferToWholeSize(Sema &SemaRef, const Expr *E,
+QualType BaseQTy) {
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:9127
@@ +9126,3 @@
+// whose base type is \a BaseQTy.
+static int CheckArrayExpressionDoesNotReferToUnitySize(Sema &SemaRef,
+ const Expr *E,
T
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D17853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3790
@@ -3923,3 +3789,3 @@
// where DD_ is an ID unique to the file (device and file IDs), PP is the
- // mangled name of the function that encloses the target region and BB is the
+ // mangled nam
1301 - 1400 of 2198 matches
Mail list logo
