Re: [PATCH] D21564: [OpenMP] Initial implementation of parse and sema for composite pragma 'distribute parallel for'

[Alexey Bataev via cfe-commits]

ABataev added a comment.

LG


================
Comment at: lib/Sema/SemaOpenMP.cpp:1826-1827
@@ +1825,4 @@
+        std::make_pair(".bound_tid.", KmpInt32PtrTy),
+        std::make_pair(".previous.lb.", KmpUInt64Ty),
+        std::make_pair(".previous.ub.", KmpUInt64Ty),
+        std::make_pair(StringRef(), QualType()) // __context with shared vars
----------------
Just a small comment - I believe, it is better to use SizeTy, rather than 
KmpUInt64Ty. SizeTy is platform dependent and on 32 bit targets may result in 
more effective code. 


Repository:
  rL LLVM

http://reviews.llvm.org/D21564



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits