Author: arichardson
Date: Thu Aug 23 03:21:36 2018
New Revision: 340522
URL: http://llvm.org/viewvc/llvm-project?rev=340522&view=rev
Log:
Update avr attributes test for output change in r340519
After this commit there is an addrspace(1) before the attribute #. Since
these tests are only checking
Author: arichardson
Date: Sun Oct 15 11:48:14 2017
New Revision: 315871
URL: http://llvm.org/viewvc/llvm-project?rev=315871&view=rev
Log:
Convert clang::LangAS to a strongly typed enum
Summary:
Convert clang::LangAS to a strongly typed enum
Currently both clang AST address spaces and target spec
Author: arichardson
Date: Tue Jul 24 05:40:56 2018
New Revision: 337824
URL: http://llvm.org/viewvc/llvm-project?rev=337824&view=rev
Log:
Stop wrapping __has_include in another macro
Summary:
This is not guaranteed to work since the characters after '__has_include('
have special lexing rules that
Author: arichardson
Date: Fri Feb 23 07:19:48 2018
New Revision: 325914
URL: http://llvm.org/viewvc/llvm-project?rev=325914&view=rev
Log:
Allow passing additional compiler/linker flags for the tests
Summary:
These flags can be specified using the CMake variables
LIBCXX_TEST_LINKER_FLAGS and LIBCX
Author: arichardson
Date: Mon Jun 25 09:49:52 2018
New Revision: 335495
URL: http://llvm.org/viewvc/llvm-project?rev=335495&view=rev
Log:
Use Triple::isMIPS() instead of enumerating all Triples. NFC
Reviewed By: atanasyan
Differential Revision: https://reviews.llvm.org/D48549
Modified:
cfe/
https://github.com/arichardson commented:
This looks good to me, nice way of saving one of the bits.
https://github.com/llvm/llvm-project/pull/71272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/71272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2518,9 +2521,9 @@ static void combineVersionedSymbol(Symbol &sym,
sym.symbolKind = Symbol::PlaceholderKind;
sym.isUsedInRegularObj = false;
} else if (auto *sym1 = dyn_cast(&sym)) {
-if (sym2->versionId > VER_NDX_GLOBAL
-? config->versionDefinition
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/71272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2518,9 +2521,9 @@ static void combineVersionedSymbol(Symbol &sym,
sym.symbolKind = Symbol::PlaceholderKind;
sym.isUsedInRegularObj = false;
} else if (auto *sym1 = dyn_cast(&sym)) {
-if (sym2->versionId > VER_NDX_GLOBAL
-? config->versionDefinition
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/71272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson approved this pull request.
I'm happy with this as is but I'd wait for at least one other positive review
before merging.
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llv
@@ -223,6 +223,21 @@
} while (0)
#endif
+#define _LIBUNWIND_TRACING_DWARF_EVAL (0)
arichardson wrote:
Maybe it would be best to follow the same pattern as above and allow turning it
on for debug builds? But seeing as it's always been hardcoded to false,
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson approved this pull request.
I would assume this is already transformed to memcpy but I guess it won't be
for -O0
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -143,7 +143,7 @@ _Unwind_Backtrace(_Unwind_Trace_Fn callback, void *ref) {
// Create a mock exception object for force unwinding.
_Unwind_Exception ex;
memset(&ex, '\0', sizeof(ex));
- strcpy((char *)&ex.exception_class, "CLNGUNW");
+ memcpy(&ex.exception_class, "CLN
@@ -143,7 +143,7 @@ _Unwind_Backtrace(_Unwind_Trace_Fn callback, void *ref) {
// Create a mock exception object for force unwinding.
_Unwind_Exception ex;
memset(&ex, '\0', sizeof(ex));
- strcpy((char *)&ex.exception_class, "CLNGUNW");
+ memcpy(&ex.exception_class, "CLN
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson commented:
Making it consistent is good, but it sounds like we should update the
.clang-format config file or reformat this whole file to not be indented.
https://github.com/llvm/llvm-project/pull/72314
___
cfe-commits m
arichardson wrote:
> > Making it consistent is good, but it sounds like we should update the
> > .clang-format config file or reformat this whole file to not be indented.
>
> I'm not sure what the clang-format policy for libunwind is. How about landing
> this as is and updating `.clang-format`
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/72314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arichardson wrote:
> Gentle ping!
Sorry for the delay - I was busy with the RISC-V summit last week, hoping to
get to this PR later this week.
https://github.com/llvm/llvm-project/pull/67860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -672,7 +671,7 @@ inline bool LocalAddressSpace::findFunctionName(pint_t
addr, char *buf,
Dl_info dyldInfo;
if (dladdr((void *)addr, &dyldInfo)) {
if (dyldInfo.dli_sname != NULL) {
- snprintf(buf, bufLen, "%s", dyldInfo.dli_sname);
+ strncpy(buf, dyldInfo.d
@@ -681,7 +680,7 @@ inline bool LocalAddressSpace::findFunctionName(pint_t
addr, char *buf,
uint16_t nameLen;
char *funcName = getFuncNameFromTBTable(addr, nameLen, offset);
if (funcName != NULL) {
-snprintf(buf, bufLen, "%.*s", nameLen, funcName);
+strncpy(buf,
https://github.com/arichardson approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/72040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson commented:
All my comments have been resolved, thank you very much!
https://github.com/llvm/llvm-project/pull/67166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -121,6 +136,17 @@ def getStdFlag(cfg, std):
AddCompileFlag(lambda cfg: getStdFlag(cfg, std)),
],
),
+Parameter(
+name="optimization",
+choices=["none", "speed", "size"],
+type=str,
+help="The version of the standard
@@ -87,6 +87,21 @@ def getStdFlag(cfg, std):
return "-std=" + fallbacks[std]
return None
+def getSpeedOptimizationFlag(cfg):
+if _isClang(cfg) or _isAppleClang(cfg) or _isGCC(cfg):
+return "-O3"
+elif _isMSVC(cfg):
+return "/O2"
+else:
+
@@ -43,6 +43,12 @@
#define LIBUNWIND_AVAIL
#endif
+#if defined(__SANITIZE_MEMORY__) ||
\
arichardson wrote:
Sounds good. In that case I'll update the PR when I'm back in the office next
Thursday.
https://github.
https://github.com/arichardson approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2974,6 +2966,39 @@ bool UnwindCursor::getFunctionName(char *buf,
size_t bufLen,
buf, bufLen, offset);
}
+#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN)
+template
+bool UnwindCursor::isReadableAddr(const pint_t addr) const {
+ // T
@@ -2974,6 +2966,39 @@ bool UnwindCursor::getFunctionName(char *buf,
size_t bufLen,
buf, bufLen, offset);
}
+#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN)
+template
+bool UnwindCursor::isReadableAddr(const pint_t addr) const {
+ // T
@@ -2974,6 +2966,39 @@ bool UnwindCursor::getFunctionName(char *buf,
size_t bufLen,
buf, bufLen, offset);
}
+#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN)
+template
+bool UnwindCursor::isReadableAddr(const pint_t addr) const {
+ // T
@@ -2817,7 +2817,7 @@ bool UnwindCursor::setInfoForSigReturn(Registers_s390x &) {
const pint_t pc = static_cast(this->getReg(UNW_REG_IP));
// The PC might contain an invalid address if the unwind info is bad, so
// directly accessing it could cause a SIGSEGV.
- if (!isRe
https://github.com/arichardson requested changes to this pull request.
The commit message is slightly misleading, it appears there are some parts of
the file that are actually used?
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits maili
arichardson wrote:
> The commit message is slightly misleading, it appears there are some parts of
> the file that are actually used?
Other than this, the change looks good to me.
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailin
arichardson wrote:
When I first came across this code I found it quite surprising that both clang
and LLVM need handling for atomic libcalls. I feel it would be a lot nicer if
this could all be handled inside the LLVM backend logic. Would it also be
possible to emit the unoptimized libcall fro
arichardson wrote:
> > The commit message is slightly misleading, it appears there are some parts
> > of the file that are actually used?
>
> As the commit message says, we only use
> https://github.com/llvm/llvm-project/blob/main/libunwind/src/Unwind-wasm.c
> and not libunwind.cpp. We don't
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/73196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson approved this pull request.
Just one question otherwise this looks good to me.
https://github.com/llvm/llvm-project/pull/74791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -2974,6 +2966,37 @@ bool UnwindCursor::getFunctionName(char *buf,
size_t bufLen,
buf, bufLen, offset);
}
+#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN)
+template
+bool UnwindCursor::isReadableAddr(const pint_t addr) const {
+ // T
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/74791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -886,7 +893,7 @@ def ARMInterrupt : InheritableAttr,
TargetSpecificAttr {
// MSP430Interrupt's, MipsInterrupt's and AnyX86Interrupt's spellings
// must match.
let Spellings = [GCC<"interrupt">];
- let Args = [EnumArgument<"Interrupt", "InterruptType",
+ let Args = [
https://github.com/arichardson commented:
While I think this is a reasonable change, I don't think we can change this
function signature without breaking the ABI. So it probably needs to be a new
function instead.
https://github.com/llvm/llvm-project/pull/77185
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/77534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
#endif
}
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
// The generic implementation only works for ieee754 floating point. For other
// floating point
@@ -189,11 +189,15 @@ typedef long double tf_float;
#define CRT_LDBL_IEEE_F128
#endif
#define TF_C(x) x##L
-#elif __LDBL_MANT_DIG__ == 113
-// Use long double instead of __float128 if it matches the IEEE 128-bit format.
+#elif __LDBL_MANT_DIG__ == 113 ||
@@ -15,8 +15,6 @@
#include "int_lib.h"
#include "int_math.h"
-#if defined(CRT_HAS_TF_MODE)
arichardson wrote:
I'm not sure if we support architectures without a "tf" floating point type. To
be safe I believe we still need a guard here since this file is comp
@@ -13,8 +13,6 @@
#define QUAD_PRECISION
#include "fp_lib.h"
-#if defined(CRT_HAS_TF_MODE)
arichardson wrote:
I'd suggest replacing this with CRT_HAS_F128 as noted below (unless you're will
to audit all current uses of CRT_HAS_TF_MODE since that currently is
https://github.com/arichardson commented:
Thanks, this looks great once all of @jrtc27's comments have been addressed.
https://github.com/llvm/llvm-project/pull/85460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -11,20 +11,27 @@
// Basic test for float registers number are accepted.
-#include
#include
#include
#include
+// Using __attribute__((section("main_func"))) is Linux specific, but then
arichardson wrote:
Nit: This is not specific to Linux it is s
@@ -792,13 +792,14 @@ EncompassingIntegerType(ArrayRef Types) {
Value *CodeGenFunction::EmitVAStartEnd(Value *ArgValue, bool IsStart) {
Intrinsic::ID inst = IsStart ? Intrinsic::vastart : Intrinsic::vaend;
- return Builder.CreateCall(CGM.getIntrinsic(inst), ArgValue);
+ re
https://github.com/arichardson approved this pull request.
LGTM thanks! Please wait for @jrtc27 to also approve before committing though.
https://github.com/llvm/llvm-project/pull/85460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
arichardson wrote:
CI looks unhappy, mlir also seems to need updates:
MLIR :: Target/LLVMIR/llvmir.mlir
MLIR :: mlir-cpu-runner/x86-varargs.mlir
https://github.com/llvm/llvm-project/pull/85460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
arichardson wrote:
It might make sense to restore the `message(FATAL_ERROR)` since that is any
easy mistake to make considering it used to be the default way of building
libunwind.
https://github.com/llvm/llvm-project/pull/86351
___
cfe-commits maili
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/85460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,122 @@
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -fsycl-is-device
-disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
+void bar(int &Data) {}
+// CHECK-DAG: define dso_local void @[[RAW_REF:[a-zA-Z0-9_]+]](ptr noundef
nonnull align 4 dereferenceable(4) %
+voi
@@ -285,6 +289,20 @@ void
NVPTXTargetCodeGenInfo::addNVVMMetadata(llvm::GlobalValue *GV,
bool NVPTXTargetCodeGenInfo::shouldEmitStaticExternCAliases() const {
return false;
}
+
+llvm::Constant *
+NVPTXTargetCodeGenInfo::getNullPointer(const CodeGen::CodeGenModule &CGM,
+
@@ -285,6 +289,20 @@ void
NVPTXTargetCodeGenInfo::addNVVMMetadata(llvm::GlobalValue *GV,
bool NVPTXTargetCodeGenInfo::shouldEmitStaticExternCAliases() const {
return false;
}
+
+llvm::Constant *
+NVPTXTargetCodeGenInfo::getNullPointer(const CodeGen::CodeGenModule &CGM,
+
@@ -0,0 +1,122 @@
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda -fsycl-is-device
-disable-llvm-passes -emit-llvm %s -o - | FileCheck %s
+void bar(int &Data) {}
+// CHECK-DAG: define dso_local void @[[RAW_REF:[a-zA-Z0-9_]+]](ptr noundef
nonnull align 4 dereferenceable(4) %
+voi
https://github.com/arichardson commented:
It does seem like all other libunwind sources use `#include "` to find headers
that are part of libunwind, so I think doing it for the includes that are
installed should also be fine. I don't think installing these headers into
separate directories and
arichardson wrote:
This will cause huge merge conflicts for all downstreams. While they are easy
to resolve it can be quite annoying. I think we should just do this as part of
the global clang-format.
https://github.com/llvm/llvm-project/pull/82838
_
@@ -33,9 +33,9 @@ void test_i32_atomics(_Atomic(int32_t) * a, int32_t b) {
}
void test_i64_atomics(_Atomic(int64_t) * a, int64_t b) {
- // LA32: call i64 @__atomic_load_8
- // LA32: call void @__atomic_store_8
- // LA32: call i64 @__atomic_fetch_add_8
+ // LA32: load atomi
https://github.com/arichardson approved this pull request.
Thanks this looks good to me now and should not change anything for other
targets.
https://github.com/llvm/llvm-project/pull/77554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/arichardson closed
https://github.com/llvm/llvm-project/pull/77554
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) {
#endif
}
-#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE)
+#elif defined(QUAD_PRECISION)
arichardson wrote:
Looks like this was actually required. Probably needs to be c
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/78054
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson commented:
Overall this looks great to me, very happy to see reduced duplication between
clang and llvm.
It would be great if we could just emit the atomic IR in all cases but
unfortunately non-power-of-two sizes result in a verifier error. We could
probably emi
@@ -43,6 +43,12 @@
#define LIBUNWIND_AVAIL
#endif
+#if defined(__SANITIZE_MEMORY__) ||
\
arichardson wrote:
Ah I assumed it was needed for GCC since it doesn't have __has_feature().
https://github.com/llvm/llvm-p
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/67860
>From e39c568ba557fbca5d3ef17f3d4f4d74f15e8205 Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Fri, 29 Sep 2023 13:25:39 -0700
Subject: [PATCH 1/2] [libunwind] Fix running tests with MSan
In order to ru
@@ -28,6 +28,14 @@ if @LIBUNWIND_USES_ARM_EHABI@:
if not @LIBUNWIND_ENABLE_THREADS@:
config.available_features.add('libunwind-no-threads')
+config.extra_executor_env = ""
arichardson wrote:
Agreed that would be way better, I'll see if I can get back to th
https://github.com/arichardson converted_to_draft
https://github.com/llvm/llvm-project/pull/67861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/67201
>From 6d650b781080d46ccae02793529cf63b18859f3f Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Wed, 6 Sep 2023 11:41:56 -0700
Subject: [PATCH 1/4] [libunwind][libc++][libc++abi] Add cross-compilation
fl
arichardson wrote:
Debugging shows that the reason this is failing on the clang-cl bots is that
the CMAKE_CXX_FLAGS_INIT are using the MSVC syntax but we pass
--driver-mode=g++ explicitly:
```
lit: C:\ws\src\libcxx\utils\libcxx\test\format.py:55: note: Command
["'C:/Program Files/LLVM/bin/cla
@@ -45,10 +45,10 @@ config.substitutions.append(('%{flags}',
'-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else
''
))
config.substitutions.append(('%{compile_flags}',
-'-nostdinc++ -I %{include} -I %{libcxx}/test/support'
+'@CMAKE_CXX_FLAGS_
@@ -6411,6 +6411,40 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value
*Op0, Value *Op1,
return Constant::getNullValue(ReturnType);
break;
}
+ case Intrinsic::ptrmask: {
+if (isa(Op0) || isa(Op1))
+ return PoisonValue::get(Op0->getType());
+
+
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/67166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6411,6 +6411,40 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value
*Op0, Value *Op1,
return Constant::getNullValue(ReturnType);
break;
}
+ case Intrinsic::ptrmask: {
+if (isa(Op0) || isa(Op1))
+ return PoisonValue::get(Op0->getType());
+
+
https://github.com/arichardson created
https://github.com/llvm/llvm-project/pull/67201
There is currently only limited support for passing target-specific flags (e.g.
-mabi= or -march=) to the testsuites if you don't have a compiler (or wrapper
script) that defaults to the expected flags. Howe
https://github.com/arichardson created
https://github.com/llvm/llvm-project/pull/67205
I was trying to run the tests on FreeBSD and noticed that we weren't printing
symbol names. It turns out this is because of the missing -Wl,--export dynamic
flag. Instead of hardcoding the name of the flag a
arichardson wrote:
> Is there a reason why _all_ configurations shouldn't be doing this?
I think it would be good if all of them did it, the reason I didn't is that I
limited it to the ones I can test locally. Seeing as there is probably CI
coverage for all of the configs, should I try updatin
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/67205
>From 27c0526c4b21e2b19eeeae3c23928421437b885a Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Fri, 22 Sep 2023 16:11:49 -0700
Subject: [PATCH] [libunwind] Pass -Wl,--export-dynamic on all supported
pla
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/67205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/66545
>From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Mon, 25 Sep 2023 08:22:27 -0700
Subject: [PATCH] [libunwind][libc++][libc++abi] Allow overriding the executo
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/66545
>From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Mon, 25 Sep 2023 08:22:27 -0700
Subject: [PATCH] [libunwind][libc++][libc++abi] Allow overriding the executo
@@ -330,5 +330,14 @@ def getModuleFlag(cfg, enable_modules):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
arichardson wrote:
Done now, tested both the default and the case where LIBCXX_EXECUTOR is set.
@@ -330,5 +330,14 @@ def getModuleFlag(cfg, enable_modules):
AddCompileFlag("-D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES"),
],
),
+Parameter(
arichardson wrote:
Done now, tested both the default and the case where LIBCXX_EXECUTOR is set.
@@ -134,3 +134,8 @@ ABI Affecting Changes
Build System Changes
+
+- The ``LIBCXX_EXECUTOR`` CMake variable has been deprecated. If you are
relying on this, the new replacement
+ is either passing ``-Dexecutor=...`` to `llvm-lit`` or to make it persistent
@@ -134,3 +134,8 @@ ABI Affecting Changes
Build System Changes
+
+- The ``LIBCXX_EXECUTOR`` CMake variable has been deprecated. If you are
relying on this, the new replacement
+ is either passing ``-Dexecutor=...`` to `llvm-lit`` or to make it persistent
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/66545
>From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Mon, 25 Sep 2023 08:22:27 -0700
Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Allow overriding the
ex
https://github.com/arichardson updated
https://github.com/llvm/llvm-project/pull/66545
>From eb6f23cbc308bb30fd78094aba4259e3aae6657c Mon Sep 17 00:00:00 2001
From: Alex Richardson
Date: Mon, 25 Sep 2023 08:22:27 -0700
Subject: [PATCH 1/2] [libunwind][libc++][libc++abi] Allow overriding the
ex
arichardson wrote:
> > I think it would be good if all of them did it, the reason I didn't is that
> > I limited it to the ones I can test locally. Seeing as there is probably CI
> > coverage for all of the configs, should I try updating the remaining ones?
>
> Yes, I think it makes sense for
https://github.com/arichardson closed
https://github.com/llvm/llvm-project/pull/67205
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arichardson wrote:
> Is this really desirable? It can actually break applications as it changes
> ELF semantics.
I agree that it's not generally desirable, but this is only for the libunwind
tests (which expect these semantics).
https://github.com/llvm/llvm-project/pull/67205
arichardson wrote:
> Can you as a small follow-up just update the comment to include that part?
> E.g.
>
Will do.
> ```
> # On ELF platforms, link tests with -Wl,--export-dynamic if supported by the
> linker.
> ```
>
> Side note: the much older way for doing this is actually `-rdynamic`.
It
https://github.com/arichardson commented:
Could also use %p instead of `0x% Pri*`and cast the `uintptr_t` to `void *`?
That would avoid the need for the new macros.
https://github.com/llvm/llvm-project/pull/67390
___
cfe-commits mailing list
cfe-commi
arichardson wrote:
Or alternatively use PRIxPTR unconditionally, using PRIuPTR with 0x-prefixed
outputs is super confusing
https://github.com/llvm/llvm-project/pull/67390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/arichardson closed
https://github.com/llvm/llvm-project/pull/66545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 313 matches
Mail list logo
