================ @@ -2518,9 +2521,9 @@ static void combineVersionedSymbol(Symbol &sym, sym.symbolKind = Symbol::PlaceholderKind; sym.isUsedInRegularObj = false; } else if (auto *sym1 = dyn_cast<Defined>(&sym)) { - if (sym2->versionId > VER_NDX_GLOBAL - ? config->versionDefinitions[sym2->versionId].name == suffix1 + 1 - : sym1->section == sym2->section && sym1->value == sym2->value) { + if (sym2->versionId == VER_NDX_GLOBAL || sym2->versionId == nonExported ---------------- arichardson wrote:
In that case we should keep to the more common style. I think I just found it slightly harder to parse since I initially viewed this diff on mobile. https://github.com/llvm/llvm-project/pull/71272 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits