Re: [PATCH] D23728: [Clang-tidy] Fix style in some checks documentation

alexfh added a comment. In https://reviews.llvm.org/D23728#522710, @Eugene.Zelenko wrote: > Address review comment. Thanks! Still LG. Repository: rL LLVM https://reviews.llvm.org/D23728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh updated this revision to Diff 68967. alexfh added a comment. - Set proper working directory and build step name for clang extra tools SVN checkout. https://reviews.llvm.org/D23787 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocsBuilder.py Index: zo

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh marked an inline comment as done. Comment at: zorg/buildbot/builders/SphinxDocsBuilder.py:46 @@ +45,3 @@ + defaultBranch='trunk', + workdir=clang_srcdir)) + gribozavr wrote: > I think workdir should be `clang_tools_

[clang-tools-extra] r279516 - [clang-tidy] Fix the order of ExtraArgsBefore

Author: alexfh Date: Tue Aug 23 09:13:31 2016 New Revision: 279516 URL: http://llvm.org/viewvc/llvm-project?rev=279516&view=rev Log: [clang-tidy] Fix the order of ExtraArgsBefore Added tests for the relative order of -extra-arg(-before) and ExtraArgs(Before). Added: clang-tools-extra/trunk/t

[clang-tools-extra] r279519 - [clang-tidy] Merge ExtraArgs(Before) instead of overriding them.

Author: alexfh Date: Tue Aug 23 09:48:29 2016 New Revision: 279519 URL: http://llvm.org/viewvc/llvm-project?rev=279519&view=rev Log: [clang-tidy] Merge ExtraArgs(Before) instead of overriding them. Added proper tests. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp clan

Re: [PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/google-readability-namespace-comments.rst:9 @@ -8,3 @@ - -http://llvm.org/docs/CodingStandards.html#namespace-indentation - Please move the

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

This revision was automatically updated to reflect the committed changes. alexfh marked an inline comment as done. Closed by commit rL279624: Add builder for clang extra tools Sphinx docs (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D23787?vs=68967&id=69110#toc Repos

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh added a comment. Do you know whether build slaves should pick this configuration change up automatically? Repository: rL LLVM https://reviews.llvm.org/D23787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/llvm/HeaderGuardCheck.cpp:18 @@ +17,3 @@ + StringRef extension = ::llvm::sys::path::extension(Filename); + if (extension.size() > 0 && extension.front() == '.') { +

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. A few nits. Comment at: clang-tidy/readability/MisplacedArrayIndexCheck.h:19 @@ +18,3 @@ + +/// Warn about unusual array index syntax (index[array] instead of +/// a

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added a comment. Thank you! I've just noticed that we had completely ignored the actual docs =\ See the inline comment for details. Comment at: clang-tidy/llvm/HeaderGuardCheck.h:20 @@ -19,1 +19,3 @@ /// Finds and fixes header guards that do not adhere to LLVM style. +/

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:215 @@ +214,3 @@ +"number(s)"); + diag(RhsExpr->getExprLoc(), "Used here as a bitmask.", +

Re: [PATCH] D23815: [Clang-tidy] Documentation style. Two Google checks are aliases

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome. Thanks! LG Repository: rL LLVM https://reviews.llvm.org/D23815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of nits. Do you need me to submit the patch for you? (If yes, I can fix the doc myself) Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:8 @@ +7,3 @@

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Awesome! A few comments. Comment at: CMakeLists.txt:6 @@ -5,2 +5,3 @@ add_subdirectory(clang-tidy) +add_subdirectory(clang-tidy-vs) endif() Shoul

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added inline comments. Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13 @@ +12,3 @@ + + ... + `...` was meant to represent the description of the option. Not literally `...` ;) The description should be indented by at least two columns and sho

Re: [PATCH] D20512: [PATCH] Bug 27475 - Request header guard check processes .hpp files as well as .h files

alexfh added inline comments. Comment at: docs/clang-tidy/checks/llvm-header-guard.rst:13 @@ +12,2 @@ + +A comma-separated list of filename extensions of header files (The filename extension should not contain "." prefix). Default value is ",h,hh,hpp,hxx". For extension-less he

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added a comment. In https://reviews.llvm.org/D23848#524608, @zturner wrote: > I can fix the empty lines, but keep in mind that Visual Studio's C# editor is > MUCH more aggressive about auto-formatting your code. So it seems like a > fruitless endeavor to me, as we will constantly be fig

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Actually, there's just one comment. Otherwise it's looking good. https://reviews.llvm.org/D23842 ___ cfe-commits mailing list cfe-commits@lists.l

[clang-tools-extra] r279666 - [clang-tidy misc-move-const-arg] more specific messages + suggest alternative solution

Author: alexfh Date: Wed Aug 24 16:23:24 2016 New Revision: 279666 URL: http://llvm.org/viewvc/llvm-project?rev=279666&view=rev Log: [clang-tidy misc-move-const-arg] more specific messages + suggest alternative solution Modified: clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCh

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } zturner wrote: > Are the .rst files in the rep

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyProperties.cs:82 @@ +81,3 @@ +public bool CERTDCL50 +{ +get { return GetInheritableProperty("CERTDCL50").Value; } zturner wrote: > alexfh wrote: > > zturner wro

[PATCH] D24024: Checkout cfe when building clang-tools-extra docs.

alexfh created this revision. alexfh added a reviewer: gribozavr. alexfh added a subscriber: cfe-commits. Checkout cfe when building clang-tools-extra docs. Otherwise cmake doesn't find clang-tools-extra cmake files. https://reviews.llvm.org/D24024 Files: zorg/buildbot/builders/SphinxDocsBuild

Re: [PATCH] D23787: Add builder for clang extra tools Sphinx docs

alexfh added a comment. In https://reviews.llvm.org/D23787#527369, @gribozavr wrote: > Here's the new builder: > http://lab.llvm.org:8011/builders/clang-tools-sphinx-docs > > Fails with `ninja: error: unknown target 'docs-clang-tools-html'`. I hope, https://reviews.llvm.org/D24024 should fix t

Re: [PATCH] D24024: Checkout cfe when building clang-tools-extra docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280354: Checkout cfe when building clang-tools-extra docs. (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D24024?vs=69667&id=69984#toc Repository: rL LLVM https://reviews.ll

Re: [PATCH] D24201: [Clang-tools-extra] Fix links in release notes

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Repository: rL LLVM https://reviews.llvm.org/D24201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

alexfh added inline comments. Comment at: include/clang/Analysis/CFG.h:526 @@ -524,1 +525,3 @@ typedef AdjacentBlocks::const_reverse_iterator const_pred_reverse_iterator; + typedef llvm::iterator_range pred_range; + typedef llvm::iterator_range

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFindingAction.cpp:49 @@ -47,4 +48,3 @@ public: - explicit AdditionalUSRFinder(const Decl *FoundDecl, ASTContext &Context, - std::ve

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

alexfh added a comment. Kirill, first, thank you for working on this! As discussed offline, the RefactoringModule interface should explicitly define: - separation of execution stages for each check: 1. preparation or execution planning - should figure out the set of affected translation units

Re: [PATCH] D24192: [clang-refactor] introducing clang-refactor

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-refactor/driver/Driver.cpp:41 @@ +40,3 @@ +Command = argv[1]; +std::string Invocation = std::string(argv[0]) + " " + argv[1]; +argv[1] = Invocation.c_str();

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFindingAction.cpp:158 @@ +157,3 @@ + +FoundDecl = QualifiedName.empty() ? getNamedDeclAt(Context, Point) + : getNamedDeclF

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. A few late comments. Looks good overall. Comment at: clang-tidy-vs/ClangTidy/CategoryVerb.cs:52 @@ +51,3 @@ +{ +if (value.GetType() == typeof(CategoryVerb)

Re: [PATCH] D23848: Add a clang-tidy Visual Studio extension

alexfh added inline comments. Comment at: clang-tidy-vs/ClangTidy/ClangTidyPackage.cs:53 @@ +52,3 @@ +private void MenuItemCallback(object sender, EventArgs args) +{ +} Add a FIXME to actually implement this. https://reviews.llvm.org/D238

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Please ensure it works reasonably on LLVM code before submitting. Sorry for the delay. Feel free to ping earlier. https://reviews.llvm.org/D21134 _

Re: [PATCH] D22507: Clang-tidy - Enum misuse check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Close, but still a bunch of comments in the docs and a suggestion to fix a class of false positives. Comment at: clang-tidy/misc/EnumMisuseCheck.cpp:210 @@ +209,3 @

Re: [PATCH] D23353: [clang-tidy] Add check 'misc-use-after-move'

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:30 @@ +29,3 @@ +/// a `CFGBlock`. +/// +/// While a `CFGBlock` does contain individual `CFGElement`s for some

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-rename/USRFindingAction.cpp:157 @@ +156,3 @@ +if (!Point.isValid()) { + ErrorOccurred = true; + return false; Should we emit a diagnostic in t

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

alexfh added a comment. Thank you for the patch! In https://reviews.llvm.org/D24349#537500, @aaron.ballman wrote: > In https://reviews.llvm.org/D24349#537350, @Eugene.Zelenko wrote: > > > Probably check should have options to extend list of containers and also to > > assume all classes with int

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D24349#538102, @aaron.ballman wrote: > In https://reviews.llvm.org/D24349#538098, @alexfh wrote: > > > Thank you for the patch! > > > > In https://reviews.

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/readability/ContainerSizeEmptyCheck.cpp:35 @@ +34,3 @@ + hasName("size"), returns(isInteger()), +

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: docs/ReleaseNotes.rst:94 @@ +93,3 @@ + `_ check + supports

Re: [PATCH] D24518: Correct assert text in DeclGroup::getSingleDecl()

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D24518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D24500: [clang-tidy] Bugfix for readability-redundant-control-flow check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. If there's a related buganizer item, please mention it in the commit message. https://reviews.llvm.org/D24500 ___ cfe-commits mailing list c

Re: [PATCH] D24339: [clang-tidy] Add check 'readability-redundant-member-init'

alexfh added a comment. In https://reviews.llvm.org/D24339#537488, @malcolm.parsons wrote: > How do I add FixIt hints? > They should be simple removals, but how do I decide whether to remove the > following comma, preceding comma or preceding colon? Just remove the entry and leave the comma a

Re: [PATCH] D24224: [clang-rename] Merge rename-{ at | all } and optimise USRFindingAction.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang-rename/USRFindingAction.cpp:182 @@ -161,1 +181,3 @@ +return false; } else { +unsigned CouldNotFindSymbolNamed = Engine.

[PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

alexfh created this revision. alexfh added reviewers: ioeric, hokein. alexfh added a subscriber: cfe-commits. Remove empty namespaces and initializer list commas / colons in affected ranges. A strawman patch: proper options for enabling the cleanup and specifying the format style are needed. http

[clang-tools-extra] r298052 - [clang-tidy] Ignore deleted members in google-explicit-constructor.

Author: alexfh Date: Fri Mar 17 03:40:07 2017 New Revision: 298052 URL: http://llvm.org/viewvc/llvm-project?rev=298052&view=rev Log: [clang-tidy] Ignore deleted members in google-explicit-constructor. This fixes http://llvm.org/PR32221. Modified: clang-tools-extra/trunk/clang-tidy/google/Exp

[clang-tools-extra] r298057 - [clang-tidy] Verify some conditions in a matcher instead of check(). NFC

Author: alexfh Date: Fri Mar 17 04:47:05 2017 New Revision: 298057 URL: http://llvm.org/viewvc/llvm-project?rev=298057&view=rev Log: [clang-tidy] Verify some conditions in a matcher instead of check(). NFC Modified: clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp Modif

[clang-tools-extra] r298059 - [clang-tidy] readability-misleading-indentation: fix chained if

Author: alexfh Date: Fri Mar 17 04:58:30 2017 New Revision: 298059 URL: http://llvm.org/viewvc/llvm-project?rev=298059&view=rev Log: [clang-tidy] readability-misleading-indentation: fix chained if Summary: Fixed erroneously flagging of chained if statements when styled like this: ``` if (cond) {

[clang-tools-extra] r298060 - [clang-tidy] Added a test with a different format.

Author: alexfh Date: Fri Mar 17 05:05:49 2017 New Revision: 298060 URL: http://llvm.org/viewvc/llvm-project?rev=298060&view=rev Log: [clang-tidy] Added a test with a different format. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-misleading-indentation.cpp Modified: clang-t

[clang-tools-extra] r298101 - [Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted declarations

Author: alexfh Date: Fri Mar 17 11:40:34 2017 New Revision: 298101 URL: http://llvm.org/viewvc/llvm-project?rev=298101&view=rev Log: [Clang-tidy] Fix for misc-noexcept-move-constructor false triggers on defaulted declarations Summary: There is no need for triggering warning when noexcept specifi

[clang-tools-extra] r298315 - [clang-tidy] Small cleanup. NFC.

Author: alexfh Date: Mon Mar 20 17:15:19 2017 New Revision: 298315 URL: http://llvm.org/viewvc/llvm-project?rev=298315&view=rev Log: [clang-tidy] Small cleanup. NFC. Modified: clang-tools-extra/trunk/clang-tidy/readability/DeleteNullPointerCheck.cpp Modified: clang-tools-extra/trunk/clang-t

[clang-tools-extra] r298316 - [clang-tidy] readability-container-size-empty fix for (*x).size()

Author: alexfh Date: Mon Mar 20 17:15:27 2017 New Revision: 298316 URL: http://llvm.org/viewvc/llvm-project?rev=298316&view=rev Log: [clang-tidy] readability-container-size-empty fix for (*x).size() Modified: clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp clang

[clang-tools-extra] r298499 - [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style

Author: alexfh Date: Wed Mar 22 07:49:58 2017 New Revision: 298499 URL: http://llvm.org/viewvc/llvm-project?rev=298499&view=rev Log: [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style Summary: Using CaseType::CT_AnyCase for selected identifier results in inher

[clang-tools-extra] r298501 - [clang-tidy] Tests should not rely on STL headers being available.

Author: alexfh Date: Wed Mar 22 07:50:10 2017 New Revision: 298501 URL: http://llvm.org/viewvc/llvm-project?rev=298501&view=rev Log: [clang-tidy] Tests should not rely on STL headers being available. Modified: clang-tools-extra/trunk/test/clang-tidy/check_clang_tidy.py Modified: clang-tools-

[clang-tools-extra] r298500 - [clang-tidy] clang-format the last patch. NFC

Author: alexfh Date: Wed Mar 22 07:50:05 2017 New Revision: 298500 URL: http://llvm.org/viewvc/llvm-project?rev=298500&view=rev Log: [clang-tidy] clang-format the last patch. NFC Modified: clang-tools-extra/trunk/clang-tidy/readability/IdentifierNamingCheck.cpp clang-tools-extra/trunk/cla

Re: [clang-tools-extra] r298499 - [clang-tidy] modified identifier naming case to use CT_AnyCase for ignoring case style

Forgot to mention: patch by Juliusz Toczydłowski! On Wed, Mar 22, 2017 at 1:49 PM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Wed Mar 22 07:49:58 2017 > New Revision: 298499 > > URL: http://llvm.org/viewvc/llvm-projec

[clang-tools-extra] r298607 - [clang-tidy] Catch trivially true statements like a != 1 || a != 3

Author: alexfh Date: Thu Mar 23 10:13:54 2017 New Revision: 298607 URL: http://llvm.org/viewvc/llvm-project?rev=298607&view=rev Log: [clang-tidy] Catch trivially true statements like a != 1 || a != 3 Catch trivially true statements of the form a != 1 || a != 3. Statements like these are likely er

[clang-tools-extra] r298608 - [clang-tidy] Fix diag message for catch-by-value

Author: alexfh Date: Thu Mar 23 10:17:44 2017 New Revision: 298608 URL: http://llvm.org/viewvc/llvm-project?rev=298608&view=rev Log: [clang-tidy] Fix diag message for catch-by-value Summary: ``` catch (std::exception ex) { } ``` Was flagged with "catch handler catches a pointer value". Reviewer

[clang-tools-extra] r298619 - [clang-tidy] Don't use groups in the big regexy filter

Author: alexfh Date: Thu Mar 23 11:29:39 2017 New Revision: 298619 URL: http://llvm.org/viewvc/llvm-project?rev=298619&view=rev Log: [clang-tidy] Don't use groups in the big regexy filter Fixes https://bugs.llvm.org/show_bug.cgi?id=27641. Modified: clang-tools-extra/trunk/clang-tidy/tool/run

[clang-tools-extra] r299649 - [clang-tidy] Add FormatStyle configuration option.

Author: alexfh Date: Thu Apr 6 08:41:29 2017 New Revision: 299649 URL: http://llvm.org/viewvc/llvm-project?rev=299649&view=rev Log: [clang-tidy] Add FormatStyle configuration option. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/clang-tidy/ClangTidy.h

[clang-tools-extra] r299651 - [clang-tidy] Update docs and help message

Author: alexfh Date: Thu Apr 6 09:27:00 2017 New Revision: 299651 URL: http://llvm.org/viewvc/llvm-project?rev=299651&view=rev Log: [clang-tidy] Update docs and help message Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp clang-tools-extra/trunk/docs/clang-tidy/index.

[clang-tools-extra] r299752 - [clang-tidy] A couple of minor fixes in modernize-use-using tests

Author: alexfh Date: Fri Apr 7 04:41:27 2017 New Revision: 299752 URL: http://llvm.org/viewvc/llvm-project?rev=299752&view=rev Log: [clang-tidy] A couple of minor fixes in modernize-use-using tests Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-using-macros.cpp clang-too

r299927 - [clang-format] Handle NSString literals by merging tokens.

Author: alexfh Date: Tue Apr 11 04:55:00 2017 New Revision: 299927 URL: http://llvm.org/viewvc/llvm-project?rev=299927&view=rev Log: [clang-format] Handle NSString literals by merging tokens. Summary: This fixes a few outstanding bugs: * incorrect breaking of NSString literals containing double

[clang-tools-extra] r300569 - [clang-tidy] Fix google-explicit-constructor issue with out-of-line conversions

Author: alexfh Date: Tue Apr 18 12:26:00 2017 New Revision: 300569 URL: http://llvm.org/viewvc/llvm-project?rev=300569&view=rev Log: [clang-tidy] Fix google-explicit-constructor issue with out-of-line conversions Modified: clang-tools-extra/trunk/clang-tidy/google/ExplicitConstructorCheck.cpp

Re: [clang-tools-extra] r300588 - [clang-tidy] Address a few late comments.

Thanks! One nit: StringRef doesn't need to be qualified. On Apr 18, 2017 11:00 PM, "Haojian Wu via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: hokein Date: Tue Apr 18 15:47:34 2017 New Revision: 300588 URL: http://llvm.org/viewvc/llvm-project?rev=300588&view=rev Log: [clang-tidy] A

[clang-tools-extra] r291767 - Correctly classify main file includes if there is a prefix added

Author: alexfh Date: Thu Jan 12 09:31:50 2017 New Revision: 291767 URL: http://llvm.org/viewvc/llvm-project?rev=291767&view=rev Log: Correctly classify main file includes if there is a prefix added Summary: Prevents misclassifying includes based on the command-line filename (e.g. if a project is

[clang-tools-extra] r292229 - [clang-tidy] Fix crash in modernize-use-using (http://llvm.org/PR29135)

Author: alexfh Date: Tue Jan 17 10:14:03 2017 New Revision: 292229 URL: http://llvm.org/viewvc/llvm-project?rev=292229&view=rev Log: [clang-tidy] Fix crash in modernize-use-using (http://llvm.org/PR29135) Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseUsingCheck.cpp clang-tools

[clang-tools-extra] r292917 - [clang-tidy] Add more tests for modernize-use-using.

Author: alexfh Date: Tue Jan 24 05:40:23 2017 New Revision: 292917 URL: http://llvm.org/viewvc/llvm-project?rev=292917&view=rev Log: [clang-tidy] Add more tests for modernize-use-using. Modified: clang-tools-extra/trunk/test/clang-tidy/modernize-use-using.cpp Modified: clang-tools-extra/trun

[clang-tools-extra] r292918 - [clang-tidy] Avoid incorrect fixes in modernize-use-using

Author: alexfh Date: Tue Jan 24 05:41:02 2017 New Revision: 292918 URL: http://llvm.org/viewvc/llvm-project?rev=292918&view=rev Log: [clang-tidy] Avoid incorrect fixes in modernize-use-using Avoid fixes for typedefs with multiple types and for typedefs with struct definitions. Partially addresses

[clang-tools-extra] r292926 - [clang-tidy] Fix NOLINT test

Author: alexfh Date: Tue Jan 24 06:42:26 2017 New Revision: 292926 URL: http://llvm.org/viewvc/llvm-project?rev=292926&view=rev Log: [clang-tidy] Fix NOLINT test Summary: Test cases I've added in review D26218 were too brittle and weren't working properly. This patch fixes this. Reviewers: alex

[clang-tools-extra] r293763 - [clang-tidy] Remove debug logging.

Author: alexfh Date: Wed Feb 1 06:41:34 2017 New Revision: 293763 URL: http://llvm.org/viewvc/llvm-project?rev=293763&view=rev Log: [clang-tidy] Remove debug logging. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseUsingCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/modern

[clang-tools-extra] r293771 - [clang-tidy] misc-argument-comment: ignore comments after arguments

Author: alexfh Date: Wed Feb 1 09:28:25 2017 New Revision: 293771 URL: http://llvm.org/viewvc/llvm-project?rev=293771&view=rev Log: [clang-tidy] misc-argument-comment: ignore comments after arguments Modified: clang-tools-extra/trunk/clang-tidy/misc/ArgumentCommentCheck.cpp clang-tools-e

[clang-tools-extra] r293845 - [clang-tidy] misc-argument-comment support for gmock

Author: alexfh Date: Wed Feb 1 18:37:08 2017 New Revision: 293845 URL: http://llvm.org/viewvc/llvm-project?rev=293845&view=rev Log: [clang-tidy] misc-argument-comment support for gmock Modified: clang-tools-extra/trunk/clang-tidy/misc/ArgumentCommentCheck.cpp clang-tools-extra/trunk/test

[clang-tools-extra] r294192 - [clang-tidy] getPreviousNonCommentToken -> getPreviousToken

Author: alexfh Date: Mon Feb 6 09:46:33 2017 New Revision: 294192 URL: http://llvm.org/viewvc/llvm-project?rev=294192&view=rev Log: [clang-tidy] getPreviousNonCommentToken -> getPreviousToken Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang

[clang-tools-extra] r294193 - [clang-tidy] misc-argument-comment support for gmock

Author: alexfh Date: Mon Feb 6 09:47:17 2017 New Revision: 294193 URL: http://llvm.org/viewvc/llvm-project?rev=294193&view=rev Log: [clang-tidy] misc-argument-comment support for gmock Now for real. The use case supported previously is used by approximately nobody. What's needed is support for m

[clang-tools-extra] r294293 - [clang-tidy] misc-argument-comment - extended gmock support

Author: alexfh Date: Tue Feb 7 05:39:56 2017 New Revision: 294293 URL: http://llvm.org/viewvc/llvm-project?rev=294293&view=rev Log: [clang-tidy] misc-argument-comment - extended gmock support It looks like direct calls to mocked methods happen in the wild. This patch add support for these as wel

[clang-tools-extra] r294459 - [clang-tidy] Supresses misc-move-constructor-init warning for const fields.

Author: alexfh Date: Wed Feb 8 08:56:16 2017 New Revision: 294459 URL: http://llvm.org/viewvc/llvm-project?rev=294459&view=rev Log: [clang-tidy] Supresses misc-move-constructor-init warning for const fields. Patch by CJ DiMeglio! Differential revision: https://reviews.llvm.org/D28973 Modified:

[clang-tools-extra] r294467 - [clang-tidy] hasErrorOccurred() -> hasUncompilableErrorOccurred()

Author: alexfh Date: Wed Feb 8 10:11:22 2017 New Revision: 294467 URL: http://llvm.org/viewvc/llvm-project?rev=294467&view=rev Log: [clang-tidy] hasErrorOccurred() -> hasUncompilableErrorOccurred() hasErrorOccurred() -> hasUncompilableErrorOccurred(), since we only care about errors that lead to

[clang-tools-extra] r294578 - [clang-tidy] Fix misc-unused-using-decls false positives in presence of compile errors

Author: alexfh Date: Thu Feb 9 04:41:27 2017 New Revision: 294578 URL: http://llvm.org/viewvc/llvm-project?rev=294578&view=rev Log: [clang-tidy] Fix misc-unused-using-decls false positives in presence of compile errors Added: clang-tools-extra/trunk/test/clang-tidy/misc-unused-using-decls-e

r307143 - Add const to reference arguments of Diagnostic ctor

Author: alexfh Date: Wed Jul 5 04:45:09 2017 New Revision: 307143 URL: http://llvm.org/viewvc/llvm-project?rev=307143&view=rev Log: Add const to reference arguments of Diagnostic ctor Modified: cfe/trunk/include/clang/Tooling/Core/Diagnostic.h cfe/trunk/lib/Tooling/Core/Diagnostic.cpp M

[clang-tools-extra] r307379 - [clang-tidy] Fix modernize-use-override incorrect replacement

Author: alexfh Date: Fri Jul 7 03:15:24 2017 New Revision: 307379 URL: http://llvm.org/viewvc/llvm-project?rev=307379&view=rev Log: [clang-tidy] Fix modernize-use-override incorrect replacement Summary: For the following code: `modernize-use-override` generates a replacement with incorrect loca

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

Sorry, missed this thread somehow. So, the behavior itself seems incorrect. Clang tools should not be trying to find a compilation database in case the command line has a `--`, but the driver fails to parse it. It should be a hard failure. We also need a reliable test for this behavior (with a comp

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

Benjamin has actually fixed the issue by reverting to the old behavior in r306822. I'll add a test for this behavior anyway. On Mon, Jul 10, 2017 at 11:47 AM, Alexander Kornienko wrote: > Sorry, missed this thread somehow. So, the behavior itself seems > incorrect. Clang tools should not be tryi

[clang-tools-extra] r307661 - [clang-tidy] Extend diagnostics test.

Author: alexfh Date: Tue Jul 11 08:23:05 2017 New Revision: 307661 URL: http://llvm.org/viewvc/llvm-project?rev=307661&view=rev Log: [clang-tidy] Extend diagnostics test. * test that no diagnostics are redirected to stderr * test that a file-based compilation database is not picked up when th

[clang-tools-extra] r307787 - [clang-tidy] add_new_check.py updates ReleaseNotes.rst now

Author: alexfh Date: Wed Jul 12 06:13:41 2017 New Revision: 307787 URL: http://llvm.org/viewvc/llvm-project?rev=307787&view=rev Log: [clang-tidy] add_new_check.py updates ReleaseNotes.rst now Modified: clang-tools-extra/trunk/clang-tidy/add_new_check.py Modified: clang-tools-extra/trunk/clan

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

Done in r307661. On Mon, Jul 10, 2017 at 2:08 PM, Alexander Kornienko wrote: > Benjamin has actually fixed the issue by reverting to the old behavior in > r306822. > I'll add a test for this behavior anyway. > > On Mon, Jul 10, 2017 at 11:47 AM, Alexander Kornienko > wrote: > >> Sorry, missed

Re: [clang-tools-extra] r307701 - Fix clang-tidy diagnostic.cpp test on Windows

Thank you! On Tue, Jul 11, 2017 at 10:22 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Tue Jul 11 13:22:17 2017 > New Revision: 307701 > > URL: http://llvm.org/viewvc/llvm-project?rev=307701&view=rev > Log: > Fix clang-tidy diagnostic.cpp test on Win

r308014 - [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

Author: alexfh Date: Fri Jul 14 03:37:44 2017 New Revision: 308014 URL: http://llvm.org/viewvc/llvm-project?rev=308014&view=rev Log: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output Summary: To get properly integration Clang-Tidy with CLion IDE, next things were impl

[clang-tools-extra] r308015 - [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

Author: alexfh Date: Fri Jul 14 03:37:46 2017 New Revision: 308015 URL: http://llvm.org/viewvc/llvm-project?rev=308015&view=rev Log: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output Summary: To get properly integration Clang-Tidy with CLion IDE, next things were impl

[clang-tools-extra] r308181 - [clang-tidy] Add modernize-use-bool-literals.IgnoreMacros option

Author: alexfh Date: Mon Jul 17 07:43:06 2017 New Revision: 308181 URL: http://llvm.org/viewvc/llvm-project?rev=308181&view=rev Log: [clang-tidy] Add modernize-use-bool-literals.IgnoreMacros option Added: clang-tools-extra/trunk/test/clang-tidy/modernize-use-bool-literals-ignore-macros.cpp

[clang-tools-extra] r308605 - [clang-tidy] Unify the way IncludeStyle and HeaderFileExtesions options are used

Author: alexfh Date: Thu Jul 20 05:02:03 2017 New Revision: 308605 URL: http://llvm.org/viewvc/llvm-project?rev=308605&view=rev Log: [clang-tidy] Unify the way IncludeStyle and HeaderFileExtesions options are used Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProBoundsConsta

[clang-tools-extra] r308621 - [clang-tidy] s/1/true/, NFC

Author: alexfh Date: Thu Jul 20 07:56:52 2017 New Revision: 308621 URL: http://llvm.org/viewvc/llvm-project?rev=308621&view=rev Log: [clang-tidy] s/1/true/, NFC Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/

[clang-tools-extra] r308726 - [clang-tidy] Add option to export fixes to run-clang-tidy.py

Author: alexfh Date: Fri Jul 21 03:31:26 2017 New Revision: 308726 URL: http://llvm.org/viewvc/llvm-project?rev=308726&view=rev Log: [clang-tidy] Add option to export fixes to run-clang-tidy.py This patch adds the option to keep the list of proposed fixes even though they should not be applied.

Re: r308965 - This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements.

FTR, this was reverted in r309004. On Tue, Jul 25, 2017 at 12:43 PM, Matan Haroush via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mharoush > Date: Tue Jul 25 03:43:43 2017 > New Revision: 308965 > > URL: http://llvm.org/viewvc/llvm-project?rev=308965&view=rev > Log: > This patch e

[clang-tools-extra] r323431 - Removed Unicode BOM.

Author: alexfh Date: Thu Jan 25 07:09:33 2018 New Revision: 323431 URL: http://llvm.org/viewvc/llvm-project?rev=323431&view=rev Log: Removed Unicode BOM. Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguide

[clang-tools-extra] r323765 - [clang-tidy] Use a more specific regex

Author: alexfh Date: Tue Jan 30 06:55:39 2018 New Revision: 323765 URL: http://llvm.org/viewvc/llvm-project?rev=323765&view=rev Log: [clang-tidy] Use a more specific regex Modified: clang-tools-extra/trunk/clang-tidy/rename_check.py Modified: clang-tools-extra/trunk/clang-tidy/rename_check.p

[clang-tools-extra] r323766 - clang-tidy/rename_check.py misc-string-compare readability-string-compare

Author: alexfh Date: Tue Jan 30 06:55:50 2018 New Revision: 323766 URL: http://llvm.org/viewvc/llvm-project?rev=323766&view=rev Log: clang-tidy/rename_check.py misc-string-compare readability-string-compare Added: clang-tools-extra/trunk/clang-tidy/readability/StringCompareCheck.cpp - c

[clang-tools-extra] r323768 - clang-tidy/rename_check.py misc-incorrect-roundings bugprone-incorrect-roundings

Author: alexfh Date: Tue Jan 30 07:12:24 2018 New Revision: 323768 URL: http://llvm.org/viewvc/llvm-project?rev=323768&view=rev Log: clang-tidy/rename_check.py misc-incorrect-roundings bugprone-incorrect-roundings More specifically, clang-tidy/rename_check.py misc-incorrect-roundings \ bugprone

<    1   2   3   4   5   6   7   8   9   10   >