alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
A few late comments. Looks good overall.
================
Comment at: clang-tidy-vs/ClangTidy/CategoryVerb.cs:52
@@ +51,3 @@
+ {
+ if (value.GetType() == typeof(CategoryVerb) && destinationType ==
typeof(string))
+ {
----------------
Should this be `value is CategoryVerb`?
================
Comment at: clang-tidy-vs/ClangTidy/ClangTidyConfigurationPage.cs:11
@@ +10,3 @@
+using System.Linq;
+using System.Runtime.InteropServices;
+using System.Text;
----------------
Is this addressed?
================
Comment at: clang-tidy-vs/ClangTidy/ClangTidyPropertyGrid.cs:176
@@ +175,3 @@
+
+ private void ClangTidyPropertyGrid_Load(object sender, EventArgs e)
+ {
----------------
I guess, this handler is not needed, since it's empty.
================
Comment at: clang-tidy-vs/ClangTidy/Guids.cs:13
@@ +12,1 @@
+}
\ No newline at end of file
----------------
Could you fix the No newline at end of file?
================
Comment at: clang-tidy-vs/ClangTidy/PkgCmdID.cs:8
@@ +7,1 @@
+}
\ No newline at end of file
----------------
Could you fix the `No newline at end of file`?
================
Comment at: clang-tidy-vs/ClangTidy/Resources/ClangTidyChecks.yaml:1
@@ +1,2 @@
+---
+Checks:
----------------
Does YAML support comments? If yes, I'd add a not that this file should be
updated when new checks are added and a TODO to add a generator from .rst.
https://reviews.llvm.org/D23848
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
