[PATCH] D100499: [AArch64] Neon Polynomial vadd Intrinsic Fix

DavidSpickett added a comment. Ok, it's behind the aarch64 guard because there's a giant #ifdef around it that I didn't see. If you move it in `arm_neon.td` down to outside that #ifdef you get the definitions. Next problem is that the `poly128_t` type isn't implemented for AArch32. Not sure why

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

DavidSpickett added a comment. This LGTM with the comment reworded. Thanks! Comment at: clang/test/Misc/target-invalid-cpu-note.c:1 +// Use CHECK-NEXT instead of CHECK-SAME: ensure outputs between different lines of CHECK-SAME not missing checked. // RUN: not %clang_cc1 -trip

[PATCH] D110798: [NFC] Use CHECK-NEXT instead of CHECK-SAME in target-invalid-cpu-note.c

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Forgot to accept, looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798

<    1   2   3   4