DavidSpickett added a comment. This LGTM with the comment reworded. Thanks!
================ Comment at: clang/test/Misc/target-invalid-cpu-note.c:1 +// Use CHECK-NEXT instead of CHECK-SAME: ensure outputs between different lines of CHECK-SAME not missing checked. // RUN: not %clang_cc1 -triple armv5--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix ARM ---------------- This wording is a bit confusing, how about: // Use CHECK-NEXT instead of multiple CHECK-SAME to ensure we will fail if there is anything extra in the output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110798/new/ https://reviews.llvm.org/D110798 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits