https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/143032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 150cb66b9e440d9ed2019b5ceb9a26ed8c21942b Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
AaronBallman wrote:
CC @llvm/infrastructure-area-team -- I'm not certain who is the best person to
review `lit` work; that's sort of the confluence between infraustructure and
the rest of the project. Do you have any good suggestions? (We don't have a
maintainer listed for it that I could find
https://github.com/alexey-bataev closed
https://github.com/llvm/llvm-project/pull/141250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/carlosgalvezp approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DeinAlptraum commented:
Thank you for the PR, imo this is a much better approach than the previous one.
As I mentioned before, I'm not familiar with the testing infrastructure, but
insofar as it works, this looks good to me.
Do note that the libclang CI should also be adapte
@@ -3986,256 +3987,588 @@ def set_property(self, property, value):
# Now comes the plumbing to hook up the C library.
# Register callback types
-translation_unit_includes_callback = CFUNCTYPE(
+translation_unit_includes_callback: TypeAlias = CFUNCTYPE( # type: ignore
[valid-
vbvictor wrote:
Please add entry in ReleaseNotes.rst (should be in alphabetical order by check
name) and fix carlosgalvezp's final comment. After that should be ready for
merge
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing
flovent wrote:
@vbvictor, thanks for the reminder, i think that's okay.
https://github.com/llvm/llvm-project/pull/141345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: flovent
Date: 2025-06-05T15:18:01+03:00
New Revision: a12f4f0031c5448df1563a499d6295fd06b979ff
URL:
https://github.com/llvm/llvm-project/commit/a12f4f0031c5448df1563a499d6295fd06b979ff
DIFF:
https://github.com/llvm/llvm-project/commit/a12f4f0031c5448df1563a499d6295fd06b979ff.diff
LOG:
https://github.com/vbvictor closed
https://github.com/llvm/llvm-project/pull/141345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
melver wrote:
@aaronpuchert - RFC regarding basic capability alias analysis.
For the bare minimum this would work, and likely covers 90% of the cases I
worry about. I believe later enhancements could be built on top.
There might be something I'm missing though. Kindly take a look.
Many thanks!
https://github.com/alexey-bataev approved this pull request.
https://github.com/llvm/llvm-project/pull/141250
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -187,6 +187,11 @@ Changes in existing checks
` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`google-readability-namespace-comments
vbvictor wrote:
Could we add also an entry for `llvm-readability-namesp
jmmartinez wrote:
Hello ! I’m still exploring possible alternatives to this PR but I haven't
found anything satisfying yet. If you have some suggestions don't hesitate.
Thanks !
https://github.com/llvm/llvm-project/pull/137665
___
cfe-commits maili
dmpolukhin wrote:
> I have a mixed feeling about whether we should always exclude all coroutines
> by default or not. When a coroutine has only one `co-operator` and nothing
> else should be safe to use a reference parameter? Am I wrong?
No, it may not be safe even in case of single co_return
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/142313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thorsten-klein edited
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -187,6 +187,11 @@ Changes in existing checks
` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`google-readability-namespace-comments
thorsten-klein wrote:
I will add another ReleaseNotes entry.
Shall I ru
https://github.com/AaronBallman commented:
This has been in the tree for less than a month and we've not had a release out
to the public with it yet, right? That seems a bit premature if we were waiting
for some user experience before flipping the switch. I don't have a good
intuition for how
vbvictor wrote:
I think the default behavior of the option should be to ignore all coroutines -
that will be to make ordinary users safe.
https://github.com/llvm/llvm-project/pull/140912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From a683a7b33fe9b2e06e5116261b8decf233d72d67 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
@@ -187,6 +187,11 @@ Changes in existing checks
` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`google-readability-namespace-comments
vbvictor wrote:
No need for new tests, I can see that previously tests
AaronBallman wrote:
I think that having such a check is a reasonable idea, but yeah, I doubt we
could turn it on in CI without limiting to just new code. But it would be a
handy tool when writing new code, so I think it's probably worth it.
https://github.com/llvm/llvm-project/pull/142839
https://github.com/vbvictor approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/to268 updated
https://github.com/llvm/llvm-project/pull/140911
>From 11832e8337e6785f887a8fafad7af558ff701f71 Mon Sep 17 00:00:00 2001
From: Guillot Tony
Date: Wed, 21 May 2025 16:58:31 +0200
Subject: [PATCH 1/2] Documented N3006 feature
---
clang/docs/LanguageExtensions.rs
@@ -187,6 +187,11 @@ Changes in existing checks
` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`google-readability-namespace-comments
thorsten-klein wrote:
> Shall I run the tests for this llvm-namespace-c
dobbelaj-snps wrote:
Next builds seem to succeed. Looks like an instability of the lldb buildbot ?
https://github.com/llvm/llvm-project/pull/137719
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
501 - 530 of 530 matches
Mail list logo