[clang] [clang-tools-extra] [clang-include-cleaner] Make cleanup attr report expr location (PR #140233)

2025-05-19 Thread Daan De Meyer via cfe-commits
@@ -1351,7 +1352,8 @@ def OSConsumesThis : InheritableAttr { def Cleanup : InheritableAttr { let Spellings = [GCC<"cleanup">]; - let Args = [DeclArgument]; + let Args = [DeclArgument, + ExprArgument<"Expr", /*opt=*/0, /*fake=*/1>]; DaanDeMeyer

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -74,7 +75,51 @@ static std::unique_ptr NamespaceTemplate = nullptr; static std::unique_ptr RecordTemplate = nullptr; +static Error +setupTemplate(std::unique_ptr &Template, + StringRef TemplatePath, + std::vector> Partials) { + auto T = Mustache

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -6,4 +6,6 @@ set(LLVM_LINK_COMPONENTS add_clang_library(clangDocSupport STATIC File.cpp - ) \ No newline at end of file + Utils.cpp + ) + ilovepi wrote: one would hope `git calng-format would catch this...`. Will fix. https://github.com/llvm/llvm-pro

[clang] [CIR][NFC] Eliminate ArgInfo structure (PR #140612)

2025-05-19 Thread Andy Kaylor via cfe-commits
andykaylor wrote: This corresponds to the incubator PR at https://github.com/llvm/clangir/pull/1629 https://github.com/llvm/llvm-project/pull/140612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,61 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [CIR][NFC] Eliminate ArgInfo structure (PR #140612)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/140612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-19 Thread Paul Kirth via cfe-commits
@@ -6,4 +6,6 @@ set(LLVM_LINK_COMPONENTS add_clang_library(clangDocSupport STATIC File.cpp - ) \ No newline at end of file + Utils.cpp + ) + ilovepi wrote: oh, CMake file ... 🤦 https://github.com/llvm/llvm-project/pull/138062 __

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-05-19 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: > Looks like a bug to me. This warning presumably ought to be checking whether > it's valid to read / write to the given location using something like > [`isUserWritingOffTheEnd`](https://github.com/llvm/llvm-project/blob/b2e2ae8702e9fbbe0ef0eb5929aa2d5dc867b1c5/clang/lib/AST/Ex

[clang] clang-format: Add IncludeSortKey option (PR #137840)

2025-05-19 Thread Daan De Meyer via cfe-commits
https://github.com/DaanDeMeyer updated https://github.com/llvm/llvm-project/pull/137840 >From 6a3e7f091fbb8bc7117f5ef1d2803e73b8c6f061 Mon Sep 17 00:00:00 2001 From: Daan De Meyer Date: Tue, 29 Apr 2025 18:26:36 +0200 Subject: [PATCH] clang-format: Add IgnoreExtension option to SortIncludesOpt

[clang] [CIR][NFC] Eliminate ArgInfo structure (PR #140612)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -542,8 +542,15 @@ CIRGenTypes::arrangeCIRFunctionInfo(CanQualType returnType, void *insertPos = nullptr; CIRGenFunctionInfo *fi = functionInfos.FindNodeOrInsertPos(id, insertPos); - if (fi) + if (fi) { +// We found a matching function info based on id. These asser

[clang] 114e450 - [CIR] Remove the empty verifier in cir.ifOp (#140457)

2025-05-19 Thread via cfe-commits
Author: Andres-Salamanca Date: 2025-05-19T13:52:21-07:00 New Revision: 114e4508b2fd8df34740572383e749f3184a2a89 URL: https://github.com/llvm/llvm-project/commit/114e4508b2fd8df34740572383e749f3184a2a89 DIFF: https://github.com/llvm/llvm-project/commit/114e4508b2fd8df34740572383e749f3184a2a89.di

[clang] [CIR] Remove the empty verifier in cir.ifOp (PR #140457)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/140457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Qinkun Bao via cfe-commits
qinkunbao wrote: > This patch should be "[NFC] Precommit test for src:*=sanitize for UBSan" (or > similar), have the test output "passing" for the current build of clang > (i.e., probably "incorrect" output), reviewed and then merged. Thank you for your feedback. However, I recommend against m

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-05-19 Thread via cfe-commits
sivadeilra wrote: I've updated the PR so that the COFF debugging tests pass. I had to run the hot-patching pass a little earlier, so that it ran before the CodeViewDebug pass. https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing

[clang] [Clang][NFC] Use `llvm::sort()` (PR #140337)

2025-05-19 Thread Ziqing Luo via cfe-commits
ziqingluo-90 wrote: hi, what is the motivation of changing `std::sort` to `llvm:sort`? https://github.com/llvm/llvm-project/pull/140337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Profile singly-resolved UnresolvedLookupExpr with the declaration (PR #140029)

2025-05-19 Thread Jordan Rupprecht via cfe-commits
rupprecht wrote: This PR seems to regress this test case: ```c++ template void f(T&) noexcept; template void f(T (&arr)[N]) noexcept(noexcept(f(*arr))); template inline void f(T&) noexcept {} template inline void f(T (&arr)[N]) noexcept(noexcept(f(*arr))) {} void g() { int x[1];

[clang] [CIR] Upstream support for lowering cir.switch to LLVM (PR #140425)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -1038,6 +1038,37 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( return mlir::success(); } +mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite( +cir::SwitchFlatOp op, OpAdaptor adaptor, +mlir::ConversionPatternRewriter &rewriter

[clang] [CIR] Upstream support for lowering cir.switch to LLVM (PR #140425)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -1038,6 +1038,37 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( return mlir::success(); } +mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite( +cir::SwitchFlatOp op, OpAdaptor adaptor, +mlir::ConversionPatternRewriter &rewriter

[clang] [CIR] Upstream support for lowering cir.switch to LLVM (PR #140425)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/140425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for lowering cir.switch to LLVM (PR #140425)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor commented: Looks good. Just a few nits. https://github.com/llvm/llvm-project/pull/140425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream support for lowering cir.switch to LLVM (PR #140425)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -1038,6 +1038,37 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( return mlir::success(); } +mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite( +cir::SwitchFlatOp op, OpAdaptor adaptor, +mlir::ConversionPatternRewriter &rewriter

[clang] [CIR] Upstream support for lowering cir.switch to LLVM (PR #140425)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -1038,6 +1038,37 @@ mlir::LogicalResult CIRToLLVMGlobalOpLowering::matchAndRewrite( return mlir::success(); } +mlir::LogicalResult CIRToLLVMSwitchFlatOpLowering::matchAndRewrite( +cir::SwitchFlatOp op, OpAdaptor adaptor, +mlir::ConversionPatternRewriter &rewriter

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2025-05-19 Thread Richard Smith via cfe-commits
zygoloid wrote: > Should `foo` in the following code return 4 when `-fstrict-flex-arrays` is 2 > or 3 (but not when it's 0 or 1) only when the target is `-std=c++23` or > newer? Or should it return 4 for older standards too? We evaluate the operand of `__builtin_object_size` in `EM_IgnoreSideE

[clang] [CIR] Add support for indirect calls (PR #139748)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -1500,6 +1507,14 @@ static void prepareTypeConverter(mlir::LLVMTypeConverter &converter, converter.addConversion([&](cir::BF16Type type) -> mlir::Type { return mlir::BFloat16Type::get(type.getContext()); }); + converter.addConversion([&](cir::FuncType type) -> mlir

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Thurston Dang via cfe-commits
thurstond wrote: > The linked pull request (#140529) introduces a new feature rather than > correcting a bug. I would argue that since the `src:*=sanitize` syntax could reasonably be expected to work, but it did not work, then that is both a missing feature and a bug (not working as intended)

[clang] [HLSL] Move where ZExt happens in 'EmitStoreThroughExtVectorComponentLValue' to handle bug with hlsl boolean vector swizzles (PR #140627)

2025-05-19 Thread Sarah Spall via cfe-commits
https://github.com/spall created https://github.com/llvm/llvm-project/pull/140627 In 'EmitStoreThroughExtVectorComponentLValue', move the code which ZExts in the case the Destination Scalar Type is larger than the Source Scalar Type, to the top of the function, to ensure each condition is hand

[clang] [HLSL] Move where ZExt happens in 'EmitStoreThroughExtVectorComponentLValue' to handle bug with hlsl boolean vector swizzles (PR #140627)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Sarah Spall (spall) Changes In 'EmitStoreThroughExtVectorComponentLValue', move the code which ZExts in the case the Destination Scalar Type is larger than the Source Scalar Type, to the top of the function, to ensure each condition is han

[clang] [HLSL] Move where ZExt happens in 'EmitStoreThroughExtVectorComponentLValue' to handle bug with hlsl boolean vector swizzles (PR #140627)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Sarah Spall (spall) Changes In 'EmitStoreThroughExtVectorComponentLValue', move the code which ZExts in the case the Destination Scalar Type is larger than the Source Scalar Type, to the top of the function, to ensure each conditi

[clang] [CIR] Upstream comparion ops for VectorType (PR #140597)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -587,3 +587,118 @@ void foo11() { // OGCG: %[[TMP_B:.*]] = load <4 x i32>, ptr %[[VEC_B]], align 16 // OGCG: %[[XOR:.*]] = xor <4 x i32> %[[TMP_A]], %[[TMP_B]] // OGCG: store <4 x i32> %[[XOR]], ptr {{.*}}, align 16 + +void foo12() { andykaylor wrote: Can y

[clang] [CIR] Upstream comparion ops for VectorType (PR #140597)

2025-05-19 Thread Andy Kaylor via cfe-commits
@@ -2083,4 +2083,33 @@ def VecExtractOp : CIR_Op<"vec.extract", [Pure, let hasFolder = 1; } +//===--===// +// VecCmpOp +//===--===// + +def

[clang] [CIR] Upstream comparion ops for VectorType (PR #140597)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor commented: This looks OK, but I have a basic question about whether we need a dedicated vector operation here. https://github.com/llvm/llvm-project/pull/140597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [CIR] Upstream comparion ops for VectorType (PR #140597)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/140597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a0c515a - [CIR] Upstream support for C++ member function calls (#140290)

2025-05-19 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-05-19T14:42:50-07:00 New Revision: a0c515a9ef3be780e2dfd64d86de9e401b137b28 URL: https://github.com/llvm/llvm-project/commit/a0c515a9ef3be780e2dfd64d86de9e401b137b28 DIFF: https://github.com/llvm/llvm-project/commit/a0c515a9ef3be780e2dfd64d86de9e401b137b28.diff L

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/140290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-19 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: @arsenm You're right that it might be better to emit the offset, but all the existing intrinsics that I'm abstracting over _do_ have such a field. If you want to add new intrinsics that don't have the offset and that pattern-match instead, I'd be more than happy to review that

[clang] [HLSL] Move where ZExt happens in 'EmitStoreThroughExtVectorComponentLValue' to handle bug with hlsl boolean vector swizzles (PR #140627)

2025-05-19 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/140627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140602 >From 210f005ecccbbd4fed439d3e156d5e0146807bed Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 19:49:33 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?U

[clang] [Clang] add typo correction for unknown attribute names (PR #140629)

2025-05-19 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/140629 This patch enhances Clang's diagnosis for unknown attributes by providing typo correction suggestions for known attributes. ```cpp [[gmu::deprected]] // expected-warning {{unknown attribute 'gmu::deprected'

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s -check-prefix=CHECK-ALLOWLIST vitalybu

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s -check-prefix=CHECK-ALLOWLIST +// RUN: %clang_cc1 -trip

[clang] [Clang] add typo correction for unknown attribute names (PR #140629)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes This patch enhances Clang's diagnosis for unknown attributes by providing typo correction suggestions for known attributes. ```cpp [[gmu::deprected]] // expected-warning {{unknown attribute 'gmu::deprecte

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s --check-prefixes=CHECK1,IGNORE

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s --check-prefixes=CHECK1,IGNORE +// RUN: %cl

[clang] [Clang] add typo correction for unknown attribute names (PR #140629)

2025-05-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp,c -- clang/include/clang/Basic/SimpleTypoCorrection.h

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > The linked pull request (#140529) introduces a new feature rather than > > correcting a bug. > > I would argue that since the `src:*=sanitize` syntax could reasonably be > expected to work, but it did not work, then that is both a missing feature > and a bug (not working

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t vitalybuka wrote: THe point of SPR to have stacked PR, so this one will already be rebased on #140602 https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list

[clang] [Clang] add typo correction for unknown attribute names (PR #140629)

2025-05-19 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/140629 >From 5b8f0635fdddc87ea326a3b1b47191ab9bf23c0f Mon Sep 17 00:00:00 2001 From: Oleksandr Tarasiuk Date: Tue, 20 May 2025 00:38:43 +0300 Subject: [PATCH 1/2] [Clang] add typo correction for unknown attribute na

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140602 >From 210f005ecccbbd4fed439d3e156d5e0146807bed Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 19:49:33 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?U

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t vitalybuka wrote: But in this case we failed to do so, if reordering of patches is needed, SPR often fails. https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-19 Thread Matt Arsenault via cfe-commits
arsenm wrote: > If you want to add new intrinsics that don't have the offset and that > pattern-match instead, I'd be more than happy to review that - or if we want > to break back-compat by getting rid of the offset. I don't think we need to worry about compatibility with an intrinsic that's

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140602 >From 210f005ecccbbd4fed439d3e156d5e0146807bed Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 19:49:33 + Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [CIR] Add support for indirect calls (PR #139748)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. I think this looks good once the error handling on the type conversion is fixed. https://github.com/llvm/llvm-project/pull/139748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [llvm] [NVPTX] Add errors for incorrect CUDA addrpaces (PR #138706)

2025-05-19 Thread Artem Belevich via cfe-commits
@@ -2927,6 +2928,20 @@ void Verifier::visitFunction(const Function &F) { "Calling convention does not support varargs or " "perfect forwarding!", &F); +if (F.getCallingConv() == CallingConv::PTX_Kernel && +TT.getOS() == Triple::CUDA) {

[clang] [llvm] [NVPTX] Add errors for incorrect CUDA addrpaces (PR #138706)

2025-05-19 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/138706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add resource name argument to resource class constructors (PR #139985)

2025-05-19 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/139985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Thurston Dang via cfe-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 91a45a3 - [NFC] Pre-commit UBSAN src:*=sanitize test (#140602)

2025-05-19 Thread via cfe-commits
Author: Qinkun Bao Date: 2025-05-19T15:22:13-07:00 New Revision: 91a45a33fca6f372933c6c796e0cc40f82d4 URL: https://github.com/llvm/llvm-project/commit/91a45a33fca6f372933c6c796e0cc40f82d4 DIFF: https://github.com/llvm/llvm-project/commit/91a45a33fca6f372933c6c796e0cc40f82d4.diff LO

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -44,6 +44,12 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask, bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName, StringRef Category) const { + unsigned NoSanLine = SSCL->inSectionBlame(Mask, "src", FileNa

[clang] [CIR] Upstream support for iterator-based range for loops (PR #140636)

2025-05-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/140636 This change adds handling for C++ member operator calls, implicit no-op casts, and l-value call expressions. Together, these changes enable handling of range for loops based on iterators. >From 58b8700c4b43

[clang] [CIR] Upstream support for iterator-based range for loops (PR #140636)

2025-05-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change adds handling for C++ member operator calls, implicit no-op casts, and l-value call expressions. Together, these changes enable handling of range for loops based on iterators. --- Full diff: h

[clang] [NFC][OpenACC] Refactor clause emission- (PR #140586)

2025-05-19 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. Great, thanks! https://github.com/llvm/llvm-project/pull/140586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -1,17 +1,16 @@ // RUN: rm -rf %t // RUN: split-file %s %t -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s --check-prefixes=CHECK1,IGNORE +// RUN: %c

[clang] [HLSL] Add resource name argument to resource class constructors (PR #139985)

2025-05-19 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/139985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for indirect calls (PR #139748)

2025-05-19 Thread Bruno Cardoso Lopes via cfe-commits
@@ -1500,6 +1507,14 @@ static void prepareTypeConverter(mlir::LLVMTypeConverter &converter, converter.addConversion([&](cir::BF16Type type) -> mlir::Type { return mlir::BFloat16Type::get(type.getContext()); }); + converter.addConversion([&](cir::FuncType type) -> mlir

[clang] [CIR] Add support for indirect calls (PR #139748)

2025-05-19 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM (pending error propagation) https://github.com/llvm/llvm-project/pull/139748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-19 Thread Bruno Cardoso Lopes via cfe-commits
@@ -135,4 +135,38 @@ cir.func @vector_insert_element_test() { // CHECK:cir.return // CHECK: } +cir.func @vector_splat_test() { +%0 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["a", init] +%1 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["shl", init] +

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: llvm-project/clang/docs/SanitizerSpecialCaseList.rst needs to be updated And nice to mention in llvm-project/clang/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.

[clang-tools-extra] Follow style configuration in clangd when inserting missing includes (PR #140594)

2025-05-19 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > @kleinesfilmroellchen @HighCommander4 would it be possible to take a look > when you have some time? Many thanks! Yep, will do. Added myself as reviewer. https://github.com/llvm/llvm-project/pull/140594 ___ cfe-commits mailing

[clang] [RISCV] Implement intrinsics for XAndesVPackFPH (PR #140007)

2025-05-19 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/140007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b93bc77 - [NFC] Extend ubsan-src-ignorelist-category.test

2025-05-19 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2025-05-19T15:42:59-07:00 New Revision: b93bc773f86b3746f8023c5dda9a8ab892fa0499 URL: https://github.com/llvm/llvm-project/commit/b93bc773f86b3746f8023c5dda9a8ab892fa0499 DIFF: https://github.com/llvm/llvm-project/commit/b93bc773f86b3746f8023c5dda9a8ab892fa0499.diff L

[clang] 5db4aea - [NFC] Extend ubsan-src-ignorelist-category.test

2025-05-19 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2025-05-19T15:45:43-07:00 New Revision: 5db4aeae3c413d586faed03771626818d6a807a9 URL: https://github.com/llvm/llvm-project/commit/5db4aeae3c413d586faed03771626818d6a807a9 DIFF: https://github.com/llvm/llvm-project/commit/5db4aeae3c413d586faed03771626818d6a807a9.diff L

[clang] f171e05 - [NFC][OpenACC] Refactor clause emission- (#140586)

2025-05-19 Thread via cfe-commits
Author: Erich Keane Date: 2025-05-19T15:47:26-07:00 New Revision: f171e050411efbed46c483db6d4dff7814e2d3e4 URL: https://github.com/llvm/llvm-project/commit/f171e050411efbed46c483db6d4dff7814e2d3e4 DIFF: https://github.com/llvm/llvm-project/commit/f171e050411efbed46c483db6d4dff7814e2d3e4.diff L

[clang] [NFC][OpenACC] Refactor clause emission- (PR #140586)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/140586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [CIR] Upstream support for iterator-based range for loops (PR #140636)

2025-05-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I don't see anything of concern, lgtm! https://github.com/llvm/llvm-project/pull/140636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -3,11 +3,11 @@ // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test2.c -o - | FileCheck %s --check-prefixes=CHECK2 -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=sig

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -3,11 +3,11 @@ // RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test2.c -o - | FileCheck %s --check-prefixes=CHECK2 -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=sig

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Note: Use to download my updates `spr patch 140529` https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Also I don't mind we fix multifile and sections in followup patches. But this one needs at least documentation update. https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-19 Thread via cfe-commits
https://github.com/jeremyd2019 reopened https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add resource name argument to resource class constructors (PR #139985)

2025-05-19 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/139985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-19 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/140169 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/2] [Cygwin][MinGW] Internal class in explicitly-instantiation-

[clang] [CIR] Upstream support for lowering cir.switch to LLVM (PR #140425)

2025-05-19 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM after you address Andy's nits. https://github.com/llvm/llvm-project/pull/140425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [llvm] [mlir] [NVPTX] Unify and extend barrier{.cta} intrinsic support (PR #140615)

2025-05-19 Thread Alex MacLean via cfe-commits
https://github.com/AlexMaclean updated https://github.com/llvm/llvm-project/pull/140615 >From babb28ef1c935f0d0cfb3b40f62be860be027010 Mon Sep 17 00:00:00 2001 From: Alex Maclean Date: Thu, 15 May 2025 18:12:11 + Subject: [PATCH 1/3] [NVPTX] Unify and extend barrier{.cta} intrinsic support

[clang] [llvm] [mlir] [NVPTX] Unify and extend barrier{.cta} intrinsic support (PR #140615)

2025-05-19 Thread Alex MacLean via cfe-commits
@@ -1349,6 +1349,10 @@ static bool upgradeIntrinsicFunction1(Function *F, Function *&NewFn, else if (Name == "clz.ll" || Name == "popc.ll" || Name == "h2f" || Name == "swap.lo.hi.b64") Expand = true; + else if (Name == "barrier0" || Name == "b

[clang] [llvm] [mlir] [NVPTX] Unify and extend barrier{.cta} intrinsic support (PR #140615)

2025-05-19 Thread Alex MacLean via cfe-commits
@@ -240,6 +240,34 @@ def BF16RT : RegTyInfo; def F16X2RT : RegTyInfo; def BF16X2RT : RegTyInfo; +// This class provides a basic wrapper around an NVPTXInst that abstracts the +// specific syntax of most PTX instructions. It automatically handles the +// construction of the

[clang] [NVPTX] Support the OpenCL generic addrspace feature by default (PR #137940)

2025-05-19 Thread Artem Belevich via cfe-commits
@@ -170,6 +170,8 @@ class LLVM_LIBRARY_VISIBILITY NVPTXTargetInfo : public TargetInfo { Opts["cl_khr_global_int32_extended_atomics"] = true; Opts["cl_khr_local_int32_base_atomics"] = true; Opts["cl_khr_local_int32_extended_atomics"] = true; + +Opts["__opencl_c_

[clang] [llvm] [mlir] [NVPTX] Unify and extend barrier{.cta} intrinsic support (PR #140615)

2025-05-19 Thread Alex MacLean via cfe-commits
@@ -6,13 +7,15 @@ ; Use bar.sync to arrive at a pre-computed barrier number and ; wait for all threads in CTA to also arrive: define ptx_device void @test_barrier_named_cta() { -; CHECK: mov.b32 %r[[REG0:[0-9]+]], 0; -; CHECK: bar.sync %r[[REG0]]; -; CHECK: mov.b32 %r[[REG1:[

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-19 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/140169 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/2] [Cygwin][MinGW] Internal class in explicitly-instantiation-

<    1   2   3   4   5   6   >