[clang] 24171f4 - [NFC][CFI] Add test to check for '-flto' and '-fvisibility=' flags (#135892)

2025-04-16 Thread via cfe-commits
Author: Vitaly Buka Date: 2025-04-16T09:29:28-07:00 New Revision: 24171f4d12a02b49de1cc7a1beb2dc19c740a9f1 URL: https://github.com/llvm/llvm-project/commit/24171f4d12a02b49de1cc7a1beb2dc19c740a9f1 DIFF: https://github.com/llvm/llvm-project/commit/24171f4d12a02b49de1cc7a1beb2dc19c740a9f1.diff L

[clang] [NFC][CFI] Avoid clang error in CFI tests (PR #135981)

2025-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/135981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CFI] Avoid failing CFI tests (PR #135981)

2025-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/135981 >From d5d323647b5890ac83fd4676399fae15e4242bb8 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 16 Apr 2025 09:08:49 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?= =?

[clang] [clang-tools-extra] [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #135808)

2025-04-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang-tools-extra,clang` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/24869 Here is the

[clang] Disable -fdollars-in-identifiers by default (PR #135407)

2025-04-16 Thread via cfe-commits
R-Goc wrote: Doesn't the Linux kernel use it for syscall names? https://github.com/llvm/llvm-project/pull/135407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-16 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/135552 >From cf894c58a8058956b296e499c84ccd528121addf Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Sun, 13 Apr 2025 23:34:21 +0800 Subject: [PATCH] [CIR] cir.call with scalar return type This patch introduces support

[libclc] [libclc] only check filename part of the source for avoiding duplication (PR #135710)

2025-04-16 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/135710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] de90487 - [AARCH64] Add FEAT_SSVE_FEXPA and fix unsupported features list (#134368)

2025-04-16 Thread via cfe-commits
Author: Lukacma Date: 2025-04-16T15:20:05+01:00 New Revision: de90487fc17fb928de7d0cd75d47a44db5181c14 URL: https://github.com/llvm/llvm-project/commit/de90487fc17fb928de7d0cd75d47a44db5181c14 DIFF: https://github.com/llvm/llvm-project/commit/de90487fc17fb928de7d0cd75d47a44db5181c14.diff LOG:

[clang] [llvm] [AARCH64] Add FEAT_SSVE_FEXPA and fix unsupported features list (PR #134368)

2025-04-16 Thread via cfe-commits
https://github.com/Lukacma closed https://github.com/llvm/llvm-project/pull/134368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-04-16 Thread via cfe-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/123609 >From 7b8cde7a99dddcca04921a5e15dc7f1e4793928b Mon Sep 17 00:00:00 2001 From: jofernau Date: Mon, 20 Jan 2025 04:51:26 -0800 Subject: [PATCH 1/3] [TargetVerifier][AMDGPU] Add TargetVerifier. This pass verifies th

[clang] [clang] Fix elaborated keyword canonicalization (PR #135916)

2025-04-16 Thread Erich Keane via cfe-commits
@@ -2838,6 +2838,18 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { /// immediately following this class. template const T *getAs() const; + /// Look through sugar for an instance of TemplateSpecializationType which + /// is not a type alias. +

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-16 Thread Erich Keane via cfe-commits
@@ -14,9 +14,14 @@ using namespace clang::CIRGen; CIRGenTypes::CIRGenTypes(CIRGenModule &genModule) : cgm(genModule), astContext(genModule.getASTContext()), - builder(cgm.getBuilder()) {} + builder(cgm.getBuilder()), + theABIInfo(cgm.getTargetCIRGenInfo().ge

[clang] [CIR] cir.call with scalar return type (PR #135552)

2025-04-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. This is probably ok now? I'd still love it if we could get one of the Code gen owners to let us know what is going on with this/see if this is somethign they want for classic codegen, but they can RAC. https://github.com/llvm/llvm-proj

[clang] 6cfec29 - [Offload][SYCL] Refactor OffloadKind implementation (#135809)

2025-04-16 Thread via cfe-commits
Author: Arvind Sudarsanam Date: 2025-04-16T14:13:30Z New Revision: 6cfec29cb9bc44ec907eeda99df508985ecbd49b URL: https://github.com/llvm/llvm-project/commit/6cfec29cb9bc44ec907eeda99df508985ecbd49b DIFF: https://github.com/llvm/llvm-project/commit/6cfec29cb9bc44ec907eeda99df508985ecbd49b.diff

[clang] [llvm] [Offload][SYCL] Refactor OffloadKind implementation (PR #135809)

2025-04-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex approved this pull request. https://github.com/llvm/llvm-project/pull/135809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload][SYCL] Refactor OffloadKind implementation (PR #135809)

2025-04-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/135809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Constant-evaluate format strings as last resort (PR #135864)

2025-04-16 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast edited https://github.com/llvm/llvm-project/pull/135864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema][SYCL] Fix MSVC STL usage on AMDGPU (PR #135979)

2025-04-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions hpp,cpp -- clang/test/SemaSYCL/Inputs/vectorcall.hpp clang/

[clang] [clang][Sema][SYCL] Fix MSVC STL usage on AMDGPU (PR #135979)

2025-04-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/135979 >From 2dfcad244b496c404ecf67a82c152d90591ec9ae Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Wed, 16 Apr 2025 08:39:24 -0700 Subject: [PATCH] [clang][Sema][SYCL] Fix MSVC STL usage on AMDGPU Signed-off-by:

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-04-16 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > > You could default the warning to an error to make it more visible to the > user. Not certain if that's a bad idea or not though. > Possibly. I had to drop this for a bit so circling around again, so apologies for the late reply. In the meanwhile, @epilk pointed out somethi

[clang] [clang-tools-extra] [clang] Fix elaborated keyword canonicalization (PR #135916)

2025-04-16 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/135916 >From 0bdab9c8e1093eaa80bae640385e4ad7714e4a95 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Tue, 15 Apr 2025 02:55:50 -0300 Subject: [PATCH 1/2] [clang] preserve sugar on initializer_list deduction ---

[clang] [llvm] [NVPTX] Cleanup and document nvvm.fabs intrinsics, adding f16 support (PR #135644)

2025-04-16 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/135644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Fix elaborated keyword canonicalization (PR #135916)

2025-04-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/135916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang][RFC] Bypass TAD during overload resolution if a perfect match exists" (PR #135993)

2025-04-16 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/135993 Reverts llvm/llvm-project#133426 This is failing on some bots https://lab.llvm.org/buildbot/#/builders/163/builds/17265 >From 2586e26ebaaf967c441651a736b740bc2113ecc1 Mon Sep 17 00:00:00 2001 From: cor3ntin

[clang] Revert "[Clang][RFC] Bypass TAD during overload resolution if a perfect match exists" (PR #135993)

2025-04-16 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/135993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6ccc928 - Revert "[Clang][RFC] Bypass TAD during overload resolution if a perfect match exists" (#135993)

2025-04-16 Thread via cfe-commits
Author: cor3ntin Date: 2025-04-16T19:40:28+02:00 New Revision: 6ccc9280ba891bbea349c12a064bf23bdf9000e7 URL: https://github.com/llvm/llvm-project/commit/6ccc9280ba891bbea349c12a064bf23bdf9000e7 DIFF: https://github.com/llvm/llvm-project/commit/6ccc9280ba891bbea349c12a064bf23bdf9000e7.diff LOG:

[clang] [Serialization] Use llvm::map_range (NFC) (PR #135990)

2025-04-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/135990 >From 65ea8b9f426b37d62a9178f1b076b723471afe88 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 15 Apr 2025 03:20:39 -0700 Subject: [PATCH 1/2] [Serialization] Use llvm::map_range (NFC) --- clang/l

[clang] [Serialization] Use llvm::map_range (NFC) (PR #135990)

2025-04-16 Thread Kazu Hirata via cfe-commits
@@ -103,11 +103,9 @@ template class MultiOnDiskHashTable { /// The current set of on-disk tables. table_range tables() { -auto Begin = Tables.begin(), End = Tables.end(); -if (getMergedTable()) - ++Begin; -return llvm::make_range(llvm::map_iterator(Begin,

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-16 Thread Finn Plummer via cfe-commits
@@ -137,6 +137,42 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned BuiltinID, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_faceforward: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +// check if all arguments h

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-16 Thread Finn Plummer via cfe-commits
@@ -137,6 +137,42 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned BuiltinID, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_faceforward: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +// check if all arguments h

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic commented: Just a collection of nits. LGTM https://github.com/llvm/llvm-project/pull/135878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang] Fix dependent local class instantiation bugs" (PR #135914)

2025-04-16 Thread Matheus Izvekov via cfe-commits
@@ -347,7 +347,7 @@ ParsedType Sema::getDestructorName(const IdentifierInfo &II, QualType T = CheckTypenameType(ElaboratedTypeKeyword::None, SourceLocation(), SS.getWithLocInContext(Context), II, NameLoc); -return ParsedType::make(T); +

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/135878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Fix elaborated keyword canonicalization (PR #135916)

2025-04-16 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/135916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Dependency Scanning] Adding an API to Diagnose Invalid Negative Stat Cache Entries (PR #135703)

2025-04-16 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: I don't think workers need to be involved at all - we just need to pass the same VFS to this function that we use to instantiate all workers. For example, downstream `clang_experimental_DependencyScannerWorker_create_v0()` always uses `llvm::vfs::createPhysicalFileSystem()`

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-04-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux` running on `ppc64le-sanitizer` while building `clang,compiler-rt,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/10239 Here is the relev

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-04-16 Thread Tom Honermann via cfe-commits
tahonermann wrote: > I can't find our conversation again and firefox crashed before I could > submit, but PLEASE make sure the mangling tests cover the examples we put > together. I absolutely will. > ALSO, we don't always mangle the types of lambdas, we sometimes do $_0 and > $_1 (source of

[clang] 80c19b3 - [CIR] Upstream initial support for complete record types (#135844)

2025-04-16 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-04-16T10:33:09-07:00 New Revision: 80c19b3b1d59294be63d8b55fedc317305abbdbe URL: https://github.com/llvm/llvm-project/commit/80c19b3b1d59294be63d8b55fedc317305abbdbe DIFF: https://github.com/llvm/llvm-project/commit/80c19b3b1d59294be63d8b55fedc317305abbdbe.diff L

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-04-16 Thread Erich Keane via cfe-commits
erichkeane wrote: I can't find our conversation again and firefox crashed before I could submit, but PLEASE make sure the mangling tests cover the examples we put together. ALSO, we don't always mangle the types of lambdas, we sometimes do $_0 and $_1 (source of another bug) for ones without

[clang] [clang][Dependency Scanning] Adding an API to Diagnose Invalid Negative Stat Cache Entries (PR #135703)

2025-04-16 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: (To be frank, I think it would be better to enforce the consistency of VFSs by having the service own one and the workers just applying overlays as needed, but that's definitely out of scope for this patch.) https://github.com/llvm/llvm-project/pull/135703 _

[clang] [NFC][CFI] Dump test output to debug llvm-clang-win-x-aarch64 failure (PR #136002)

2025-04-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: We have output here: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8717401398964307329/+/u/clang/tests/stdout?format=raw https://github.com/llvm/llvm-project/pull/136002 ___ cfe-commits mailing list cfe-commits@li

[clang] Revert "[NFC][CFI] Dump test output to debug llvm-clang-win-x-aarch64 failure" (PR #136029)

2025-04-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/16310 Her

[clang] [NFC][CFI] Remove unnecessary -rtlib=platform from tests (PR #136032)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136032.diff 1 Files Affected: - (modified) clang/test/Driver/sanitizer-ld.c (+2-2) ``diff diff --git a/clang/test/Driver/sanitizer-ld.

[clang] [CIR] Upstream support for record packing and padding (PR #136036)

2025-04-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/136036 This change adds support for packing and padding record types in ClangIR and introduces some infrastructure needed for this computation. Although union support has not been upstreamed yet, there is no good w

[clang] [CIR] Upstream support for record packing and padding (PR #136036)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change adds support for packing and padding record types in ClangIR and introduces some infrastructure needed for this computation. Although union support has not been upstreamed yet, there is no good

[clang] [NFC][CFI] Avoid clang error in CFI tests (PR #135981)

2025-04-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > This is causing a test failure in our clang CI bots: > https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-host-linux-x64/b8717414717471782065/overview > > It doesn't seem that any error output is produced for the test though; do you > have an intuition f

[clang] [Modules] Fix the inconsistency of which `Decl` should be serialized for an identifier. (PR #135887)

2025-04-16 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai updated https://github.com/llvm/llvm-project/pull/135887 >From d944252ce2f08d1522f7297e4d7f9a7b730db180 Mon Sep 17 00:00:00 2001 From: Volodymyr Sapsai Date: Tue, 15 Apr 2025 16:34:47 -0700 Subject: [PATCH 1/2] [Modules] Fix the inconsistency of which `Decl` should be

[clang] Revert "[Clang][RFC] Bypass TAD during overload resolution if a perfect match exists" (PR #135993)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Reverts llvm/llvm-project#133426 This is failing on some bots https://lab.llvm.org/buildbot/#/builders/163/builds/17265 --- Patch is 74.56 KiB, truncated to 20.00 KiB below, full version: https://github.com/

[clang] [HLSL] Add a warning for implicit bindings (PR #135909)

2025-04-16 Thread Justin Bogner via cfe-commits
@@ -3278,6 +3284,9 @@ void SemaHLSL::processExplicitBindingsOnDecl(VarDecl *VD) { << static_cast(RT); } } + + if (!HasBinding && VD->getType()->isHLSLResourceRecord()) +SemaRef.Diag(VD->getLocation(), diag::warn_hlsl_implicit_binding); bog

[clang] [HLSL] Add a warning for implicit bindings (PR #135909)

2025-04-16 Thread Finn Plummer via cfe-commits
@@ -3278,6 +3284,9 @@ void SemaHLSL::processExplicitBindingsOnDecl(VarDecl *VD) { << static_cast(RT); } } + + if (!HasBinding && VD->getType()->isHLSLResourceRecord()) inbelic wrote: I do also see the function `isResourceRecordTypeOrArrayOf`

[clang] [NFC][CFI] Dump test output to debug llvm-clang-win-x-aarch64 failure (PR #136002)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136002.diff 1 Files Affected: - (modified) clang/test/Driver/sanitizer-ld.c (+8) ``diff diff --git a/clang/test/Driver/sanitizer-ld.c

[clang] [llvm] [SYCL] Add clang-linker-wrapper changes to call clang-sycl-linker for SYCL offloads (PR #135683)

2025-04-16 Thread Joseph Huber via cfe-commits
@@ -988,6 +1038,11 @@ Expected> linkAndWrapDeviceFiles( A.StringData["arch"] > B.StringData["arch"] || A.TheOffloadKind < B.TheOffloadKind; }); +if (Kind == OFK_SYCL) { + // TODO: Update once SYCL offload wrapping logic is available. -

[clang] [llvm] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-16 Thread Erich Keane via cfe-commits
erichkeane wrote: > > Updated list: > > ``` > > Disagreements on 'num_gangs' appearing >1x on kernels/kernels-loop > > (justification for kernels-loop should apply to kernels as well?) (UNK way > > forward right now) > > Clang :: SemaOpenACC/compute-construct-num_gangs-clause.c > > > > F

[clang] Disable -fdollars-in-identifiers by default (PR #135407)

2025-04-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > We should disable the warning if we're preprocessing asm, which should mostly > solve the issue with warnings. Effectively checking for `LangOpts.DollarIdents || LangOpts.AsmPreprocessor`? Or do you think `DollarIdents` should be true if `AsmPreprocessor` is true? https:

[clang] [llvm] [OpenACC] Switch Clang to use the Flang 'appertainment' rules for cla… (PR #135372)

2025-04-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/135372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SYCL] Add clang-linker-wrapper changes to call clang-sycl-linker for SYCL offloads (PR #135683)

2025-04-16 Thread Arvind Sudarsanam via cfe-commits
asudarsa wrote: Marking this as a draft to attempt refactoring of clang-linker-wrapper changes based on offline discussions with @jhuber6 Thanks much https://github.com/llvm/llvm-project/pull/135683 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [HLSL][SPIR-V] Add hlsl_private address space for HLSL/SPIR-V (PR #122103)

2025-04-16 Thread Steven Perron via cfe-commits
Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= Message-ID: In-Reply-To: s-perron wrote: This PR is superseded by #133464 https://github.com/llvm/llvm-project/pull/122103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [HLSL][SPIR-V] Add hlsl_private address space for HLSL/SPIR-V (PR #122103)

2025-04-16 Thread Steven Perron via cfe-commits
Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= Message-ID: In-Reply-To: https://github.com/s-perron closed https://github.com/llvm/llvm-project/pull/122103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] Revert "[NFC][CFI] Avoid clang error in CFI tests" (PR #136030)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Vitaly Buka (vitalybuka) Changes Reverts llvm/llvm-project#135981 Fails with 'clang: error: --rtlib=libgcc requires --unwindlib=libgcc' on some bots. --- Full diff: https://github.com/llvm/llvm-project/pull/136030.diff 1 Files A

[clang] Revert "[NFC][CFI] Avoid clang error in CFI tests" (PR #136030)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes Reverts llvm/llvm-project#135981 Fails with 'clang: error: --rtlib=libgcc requires --unwindlib=libgcc' on some bots. --- Full diff: https://github.com/llvm/llvm-project/pull/136030.diff 1 Files Affected

[clang] [Clang] Bypass TAD during overload resolution if a perfect match exists (PR #136018)

2025-04-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Accepted once you get the asserts requested. https://github.com/llvm/llvm-project/pull/136018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [Clang] Bypass TAD during overload resolution if a perfect match exists (PR #136018)

2025-04-16 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Discussed elsewhere, but in a touch of "lets leave it better than we found it", can we make an `assert(HasFinalConversion)` everywhere else we access `FinalConversion`? https://github.com/llvm/llvm-project/pull/136018 __

[clang] 6b0c8c4 - Revert "[NFC][CFI] Avoid clang error in CFI tests" (#136030)

2025-04-16 Thread via cfe-commits
Author: Vitaly Buka Date: 2025-04-16T13:56:38-07:00 New Revision: 6b0c8c4acd31eba83bf20ab1cf8729b2153e383c URL: https://github.com/llvm/llvm-project/commit/6b0c8c4acd31eba83bf20ab1cf8729b2153e383c DIFF: https://github.com/llvm/llvm-project/commit/6b0c8c4acd31eba83bf20ab1cf8729b2153e383c.diff L

[clang] [llvm] [HLSL] Implement the `faceforward` intrinsic (PR #135878)

2025-04-16 Thread Kaitlin Peng via cfe-commits
@@ -214,6 +214,53 @@ const inline double4 dst(double4 Src0, double4 Src1) { return __detail::dst_impl(Src0, Src1); } +//===--===// +// faceforward builtin +//===--

[clang] Revert "[NFC][CFI] Avoid clang error in CFI tests" (PR #136030)

2025-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/136030 Reverts llvm/llvm-project#135981 Fails with 'clang: error: --rtlib=libgcc requires --unwindlib=libgcc' on some bots. >From b315dee6cd4f67532a53a850cd8f6d461d95ad4d Mon Sep 17 00:00:00 2001 From: Vitaly Buka

[clang] Revert "[NFC][CFI] Avoid clang error in CFI tests" (PR #136030)

2025-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/136030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2025-04-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a9672515ce6b8b1bc6976ed1225f4fb4d53fa381 4d6e6c31ad5f6067d56729d3d5ec91f544d84534 --e

[clang] [NFC][CFI] Remove unnecessary -rtlib=platform from tests (PR #136032)

2025-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/136032 None >From 8cd6cbfb324f3e61359c3a4959d8499ce39abcc1 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 16 Apr 2025 14:08:30 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia

[clang] [NFC][CFI] Remove unnecessary -rtlib=platform from tests (PR #136032)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136032.diff 1 Files Affected: - (modified) clang/test/Driver/sanitizer-ld.c (+2-2) ``diff diff --git a/clang/test/Driver/saniti

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-16 Thread via cfe-commits
jeremyd2019 wrote: Ooh, I just noticed the "hack-cygwin-use-proper-EH-model.patch" patch would also be properly situated in the ToolChains/Cygwin.cpp file. https://github.com/llvm/llvm-project/pull/135691 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-16 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/135691 >From de135831a6c21ae48863f8867107753f865f29f2 Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Mon, 14 Apr 2025 10:37:59 -0700 Subject: [PATCH] [Clang] [Driver] add a Cygwin ToolChain Add a new Cygwin too

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-16 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/135691 >From 95196a22017a40fb3392661a0d0635bab81c825e Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Mon, 14 Apr 2025 10:37:59 -0700 Subject: [PATCH] [Clang] [Driver] add a Cygwin ToolChain Add a new Cygwin too

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. This looks reasonable to me. https://github.com/llvm/llvm-project/pull/136038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-16 Thread Andy Kaylor via cfe-commits
@@ -2088,13 +2085,22 @@ llvm::Value *CodeGenFunction::EmitToMemory(llvm::Value *Value, QualType Ty) { Value = Builder.CreateBitCast(Value, StoreTy); } + if (Ty->hasBooleanRepresentation() || Ty->isBitIntType()) { andykaylor wrote: Is `isExtVectorBoolT

[clang] [llvm] [clang][OpenMP][SPIR-V] Fix addrspace of global constants (PR #134399)

2025-04-16 Thread Alexander Kornienko via cfe-commits
alexfh wrote: This is being looked into. If this turns out to be a problem in LLVM rather than in the SPIRV-LLVM-Translator, I'll let you know here. https://github.com/llvm/llvm-project/pull/134399 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] d35bf17 - [HLSL] Add a warning for implicit bindings (#135909)

2025-04-16 Thread via cfe-commits
Author: Justin Bogner Date: 2025-04-16T15:45:18-07:00 New Revision: d35bf17e8a0cf37959149257c0eda7b9f912390e URL: https://github.com/llvm/llvm-project/commit/d35bf17e8a0cf37959149257c0eda7b9f912390e DIFF: https://github.com/llvm/llvm-project/commit/d35bf17e8a0cf37959149257c0eda7b9f912390e.diff

[clang] [llvm] [MTE] decide whether to tag global in AsmPrinter (PR #135891)

2025-04-16 Thread Peter Collingbourne via cfe-commits
pcc wrote: Should we add AsmPrinter tests to replace the ones we're removing from Clang? https://github.com/llvm/llvm-project/pull/135891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang] [Driver] add a Cygwin ToolChain (PR #135691)

2025-04-16 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/135691 >From 949ec2a683faf53652b21a4c90206befa498bf4e Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Mon, 14 Apr 2025 10:37:59 -0700 Subject: [PATCH] [Clang] [Driver] add a Cygwin ToolChain Add a new Cygwin too

[clang] de528d6 - [Clang] Handle default template arguments for alias CTAD guides (#134807)

2025-04-16 Thread via cfe-commits
Author: Younan Zhang Date: 2025-04-17T10:08:50+08:00 New Revision: de528d689f3a2305c051528993fe30295f2a0cd9 URL: https://github.com/llvm/llvm-project/commit/de528d689f3a2305c051528993fe30295f2a0cd9 DIFF: https://github.com/llvm/llvm-project/commit/de528d689f3a2305c051528993fe30295f2a0cd9.diff

[clang] [Clang] Handle default template arguments for alias CTAD guides (PR #134807)

2025-04-16 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/134807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-16 Thread Michele Scandale via cfe-commits
@@ -8623,6 +8624,13 @@ inline bool Type::isIntegralOrEnumerationType() const { inline bool Type::isBooleanType() const { if (const auto *BT = dyn_cast(CanonicalType)) return BT->getKind() == BuiltinType::Bool; + if (const EnumType *ET = dyn_cast(CanonicalType)) { ---

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michele Scandale (michele-scandale) Changes This is a follow-up of 13aac46332f607a38067b5ddd466071683b8c255. This commit adjusts the implementation of `hasBooleanRepresentation` to have a similar behavior as the one of `hasIntegerRepresen

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangyi Zhou (fangyi-zhou) Changes As reported in #135665, C++20 parenthesis initializer list expressions are not handled correctly and were causing crashes. This commit attempts to fix the issue by handing parenthesis initializer lists al

[clang] [clang][analyzer] Handle CXXParenInitListExpr alongside InitListExpr (PR #136041)

2025-04-16 Thread Fangyi Zhou via cfe-commits
https://github.com/fangyi-zhou ready_for_review https://github.com/llvm/llvm-project/pull/136041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [NVPTX] Add support for Shared Cluster Memory address space. (PR #135444)

2025-04-16 Thread via cfe-commits
@@ -982,8 +982,9 @@ void NVPTXDAGToDAGISel::SelectAddrSpaceCast(SDNode *N) { case ADDRESS_SPACE_SHARED: Opc = TM.is64Bit() ? NVPTX::cvta_shared_64 : NVPTX::cvta_shared; break; -case ADDRESS_SPACE_DSHARED: - Opc = TM.is64Bit() ? NVPTX::cvta_dshared_64 :

[clang] [clang] convergent attribute does not require "all threads" (PR #135803)

2025-04-16 Thread Sameer Sahasrabuddhe via cfe-commits
ssahasra wrote: Taking the liberty to commit this change without waiting for a review. The change is self-contained, and actually does eliminate a legacy description that is best left to each language spec. https://github.com/llvm/llvm-project/pull/135803 _

[clang] [llvm] [RISCV] Add processor definition for XiangShan-KunMingHu-V2R2 (PR #123193)

2025-04-16 Thread Tang Haojin via cfe-commits
@@ -553,6 +553,37 @@ def XIANGSHAN_NANHU : RISCVProcessorModel<"xiangshan-nanhu", TuneZExtWFusion, TuneShiftedZExtWFusion]>; +def XIANGSHAN_KUNMINGHU : RISCVProcessorModel<"xiangshan-kunmi

[clang] [clang] Rework `hasBooleanRepresentation`. (PR #136038)

2025-04-16 Thread Michele Scandale via cfe-commits
https://github.com/michele-scandale edited https://github.com/llvm/llvm-project/pull/136038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CFI] Remove unnecessary -rtlib=platform from tests (PR #136032)

2025-04-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/136032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bc1725e - [clang] convergent attribute does not require "all threads" (#135803)

2025-04-16 Thread via cfe-commits
Author: Sameer Sahasrabuddhe Date: 2025-04-17T05:13:54Z New Revision: bc1725ef3a2707c244d8c2a401d7545755f96cbd URL: https://github.com/llvm/llvm-project/commit/bc1725ef3a2707c244d8c2a401d7545755f96cbd DIFF: https://github.com/llvm/llvm-project/commit/bc1725ef3a2707c244d8c2a401d7545755f96cbd.dif

[clang] [llvm] [SYCL] Add clang-linker-wrapper changes to call clang-sycl-linker for SYCL offloads (PR #135683)

2025-04-16 Thread Arvind Sudarsanam via cfe-commits
https://github.com/asudarsa updated https://github.com/llvm/llvm-project/pull/135683 >From 597fda606efbcf10304fed4adc5dd85da34b3de3 Mon Sep 17 00:00:00 2001 From: Arvind Sudarsanam Date: Mon, 14 Apr 2025 14:16:05 -0700 Subject: [PATCH 1/5] [SYCL] Add clang-linker-wrapper changes to call clang-

[clang] [clang-format] Fix a bug in annotating TT_PointerOrReference (PR #136073)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #135972 --- Full diff: https://github.com/llvm/llvm-project/pull/136073.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+1-1) - (modified) clang/unittests/Format/TokenAnnota

[clang-tools-extra] [clang-tidy] Switch misc-confusable-identifiers check to a faster algorithm. (PR #130369)

2025-04-16 Thread Richard Smith via cfe-commits
zygoloid wrote: Ping x4. https://github.com/llvm/llvm-project/pull/130369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: None (yronglin) Changes This PR reland https://github.com/llvm/llvm-project/pull/135808, fixed some missed changes in LLDB. I found this issue when I working on https://github.com/llvm/llvm-project/pull/107168. Currently we have many simi

[clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-arm Author: None (yronglin) Changes This PR reland https://github.com/llvm/llvm-project/pull/135808, fixed some missed changes in LLDB. I found this issue when I working on https://github.com/llvm/llvm-project/pull/10

[clang] [clang][bytecode] Fix subtracting zero-sized pointers (PR #135929)

2025-04-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/135929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 559df83 - [clang][bytecode] Fix subtracting zero-sized pointers (#135929)

2025-04-16 Thread via cfe-commits
Author: Timm Baeder Date: 2025-04-16T10:48:42+02:00 New Revision: 559df834df4c5653227cb85129904004164e4c4f URL: https://github.com/llvm/llvm-project/commit/559df834df4c5653227cb85129904004164e4c4f DIFF: https://github.com/llvm/llvm-project/commit/559df834df4c5653227cb85129904004164e4c4f.diff L

[clang] [clang][bytecode] Fix subtracting zero-sized pointers (PR #135929)

2025-04-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/135929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Diagnose ptr subs with non-zero offset (PR #135938)

2025-04-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/135938 >From 2a868984cb5964fa48b041ca59ccc71cde420f51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 16 Apr 2025 10:34:33 +0200 Subject: [PATCH] [clang][ExprConst] Diagnose ptr subs with non-z

[clang] [llvm] [AArch64][clang][llvm] Add structured sparsity outer product (TMOP) intrinsics (PR #135145)

2025-04-16 Thread Jonathan Thackray via cfe-commits
@@ -0,0 +1,162 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc -force-streaming -verify-machineinstrs < %s | FileCheck %s + +target triple = "aarch64-linux" + +define void @stmopa_za32_s8( %zn1, %zn2, %zm, %z

<    1   2   3   4   5   >