[clang] [Clang] Fixed invalid virtual copy constructor assertion (PR #124819)

2025-02-09 Thread via cfe-commits
@@ -6697,6 +6697,10 @@ static bool canPassInRegisters(Sema &S, CXXRecordDecl *D, if (D->isDependentType() || D->isInvalidDecl()) return false; + for (const CXXMethodDecl *MD : D->methods()) { vortex73 wrote: I see two potential alternative approaches w

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,30 @@ +; We use llc for this test so that we don't abort after the first error. +; RUN: not llc %s -o /dev/null 2>&1 | FileCheck %s + +target triple = "dxil-pc-shadermodel6.3-library" + +; DXIL operation UAddc only supports i32. Other integer types are unsupported. +; C

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,40 @@ +; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s + +; CHECK: %dx.types.i32c = type { i32, i1 } farzonl wrote: We need a vec2, and vec4 test that uses the vector scalarizer pass. What you will find is we ca

[clang] [Clang][NFC] Add test for CWG2285 "Issues with structured bindings" (PR #126421)

2025-02-09 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis created https://github.com/llvm/llvm-project/pull/126421 The resolution of [CWG2285](https://wg21.link/cwg2285) adds the point of declaration of a structured binding, and was implemented in https://github.com/llvm/llvm-project/commit/bdb84f374cde7736ca68d5db2c2ecf54683

[clang] [Clang][NFC] Add test for CWG2285 "Issues with structured bindings" (PR #126421)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yanzuo Liu (zwuis) Changes The resolution of [CWG2285](https://wg21.link/cwg2285) adds the point of declaration of a structured binding, and was implemented in https://github.com/llvm/llvm-project/commit/bdb84f374cde7736ca68d5db2c2ecf5468

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
@@ -50,6 +50,7 @@ def HandleTy : DXILOpParamType; def ResBindTy : DXILOpParamType; def ResPropsTy : DXILOpParamType; def SplitDoubleTy : DXILOpParamType; +def BinaryWithCarryTy : DXILOpParamType; farzonl wrote: This is reminding me how much I didn't like how s

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl requested changes to this pull request. needs `DirectXTargetTransformInfo.cpp` change and coresponding vector to scalarization tests before I can sign off. but this is very close. https://github.com/llvm/llvm-project/pull/125319 ___

[clang] [AST] Avoid repeated hash lookups (NFC) (PR #126400)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/126400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6444ed5 - [AST] Avoid repeated hash lookups (NFC) (#126400)

2025-02-09 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-02-09T08:55:31-08:00 New Revision: 6444ed53658354efb8fc126f93281bc13f1d6300 URL: https://github.com/llvm/llvm-project/commit/6444ed53658354efb8fc126f93281bc13f1d6300 DIFF: https://github.com/llvm/llvm-project/commit/6444ed53658354efb8fc126f93281bc13f1d6300.diff L

[clang] [clang] Force AttributedStmtClass to not be scope parents (PR #125370)

2025-02-09 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/125370 >From 380ae2020f71cc5006db2e29b0a69f61297f585c Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sat, 1 Feb 2025 20:09:13 -0500 Subject: [PATCH 1/2] Force AttributedStmtClass to not be scope parents --- clang

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe created https://github.com/llvm/llvm-project/pull/126425 Add check to convert nlohmann/json implicit conversions to explicit calls to the templated get() method with an explicit type. >From fe370ac53ccf8c59ebda21a89a4e60e1441b7916 Mon Sep 17 00:00:00 2001 From: Mik

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-09 Thread Anton Korobeynikov via cfe-commits
@@ -12,7 +12,8 @@ The LLVM C Library LLVM-libc is not fully complete right now. Some programs may fail to build due to missing functions. If you would like to help us finish LLVM-libc, check out "`Contributing to the libc project `__" in the sidebar - or ask on `discord

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Mike Crowe (mikecrowe) Changes Add check to convert nlohmann/json implicit conversions to explicit calls to the templated get() method with an explicit type. --- Full diff: https://github.com/llvm/llvm-project/pull/126425.diff

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Mike Crowe (mikecrowe) Changes Add check to convert nlohmann/json implicit conversions to explicit calls to the templated get() method with an explicit type. --- Full diff: https://github.com/llvm/llvm-project/pull/126425.diff 8 Fi

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126428)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126428.diff 1 Files Affected: - (modified) clang/lib/Sema/JumpDiagnostics.cpp (+1-2) ``diff diff --git a/clang/lib/Sema/JumpDiagno

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126428)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126428 None >From cc8c559955ba689c7278b1e18118170fb6edf027 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 9 Feb 2025 09:17:07 -0800 Subject: [PATCH] [Sema] Avoid repeated hash lookups (NFC) --- clang/l

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126429 None >From becef8506667f2434f5e5cbbeee493870cff799c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 9 Feb 2025 11:18:38 -0800 Subject: [PATCH] [Serialization] Avoid repeated hash lookups (NFC) ---

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126429.diff 1 Files Affected: - (modified) clang/lib/Serialization/ASTReader.cpp (+6-4) ``diff diff --git a/clang/lib/Serializatio

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126429.diff 1 Files Affected: - (modified) clang/lib/Serialization/ASTReader.cpp (+6-4) ``diff diff --git a/clang/lib/Seri

<    1   2