[clang] [clang] Recover necessary AddrSpaceCast (PR #119246)

2024-12-16 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 updated https://github.com/llvm/llvm-project/pull/119246 >From 9dbcf65775a979553bee2c95b16e3e2328e957a1 Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Mon, 9 Dec 2024 10:33:18 -0600 Subject: [PATCH 1/4] [clang] Recover necessary AddrSpaceCast A necessary AddrSpace

[clang] [clang] Recover necessary AddrSpaceCast (PR #119246)

2024-12-16 Thread Youngsuk Kim via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-cpu x86-64 -disable-llvm-passes -fopenmp-targets=amdgcn-amd-amdhsa -x c++ -emit-llvm-bc %s -o %t-x86-host.bc +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -aux-triple x86_64-unknown-linux-gnu -target-

[clang] [llvm] [RISCV] Add scheduling model for mips p8700 CPU (PR #119885)

2024-12-16 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,290 @@ +//===-- RISCVSchedMIPSP8700.td - MIPS RISC-V Processor -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-16 Thread Nikita Popov via cfe-commits
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?= Message-ID: In-Reply-To: nikic wrote: This is an ABI-breaking fix, so it cannot be backported in this form. https://github.com/llvm/llvm-project/pull/118288 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: @b-sumner has useful context on this. I won't paraphrase, but it sounds like the block deleted here has the right semantics for opencl, where "seqcst" has some special meaning and generally the semantics don't totally make sense to me. Suggest we amend this to "if opencl

[clang] [flang] [flang] Add -f[no-]vectorize flags (PR #119718)

2024-12-16 Thread David Truby via cfe-commits
@@ -6980,3 +6980,37 @@ void driver::applyOverrideOptions(SmallVectorImpl &Args, ++S; } } + +/// Vectorize at all optimization levels greater than 1 except for -Oz. +/// For -Oz the loop vectorizer is disabled, while the slp vectorizer is +/// enabled. +bool driver::shou

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-16 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/119922 >From e235c1175aee293be30d3fc478d83c9b130e3452 Mon Sep 17 00:00:00 2001 From: Jonathan Thackray Date: Fri, 13 Dec 2024 20:07:37 + Subject: [PATCH 1/2] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and

[clang] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-16 Thread Congcong Cai via cfe-commits
@@ -1826,6 +1826,14 @@ TEST_P(ASTMatchersTest, IsStaticStorageClass) { EXPECT_TRUE(notMatches("int i = 1;", varDecl(isStaticStorageClass(; EXPECT_TRUE(notMatches("extern int i;", varDecl(isStaticStorageClass(; EXPECT_TRUE(notMatches("void f() {}", functionDecl(isS

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread via cfe-commits
https://github.com/easyonaadit updated https://github.com/llvm/llvm-project/pull/120063 >From be3f799f85d6cbe981b15fcad5f4d6f8ece82593 Mon Sep 17 00:00:00 2001 From: easyonaadit Date: Mon, 16 Dec 2024 15:25:07 +0530 Subject: [PATCH] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic all

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread via cfe-commits
https://github.com/easyonaadit updated https://github.com/llvm/llvm-project/pull/120063 >From 999d6ffbc6adffcb499842467bec8d07b881af46 Mon Sep 17 00:00:00 2001 From: easyonaadit Date: Mon, 16 Dec 2024 15:25:07 +0530 Subject: [PATCH] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic all

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2024-12-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/120055 >From 8b2dc9adf4fae2065823e5beb3a1cd851686913c Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Mon, 16 Dec 2024 08:24:14 +0100 Subject: [PATCH 1/2] [clang-tidy] Add readability-string-view-substr check

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread via cfe-commits
https://github.com/easyonaadit ready_for_review https://github.com/llvm/llvm-project/pull/120063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-globalisel Author: Aaditya (easyonaadit) Changes For #119822 --- Patch is 39.13 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/120063.diff 4 Files Affected: - (added) clang/test/CodeGenHIP/dynamic-a

[clang] 1ab81f8 - [OpenACC] Implement 'delete' AST/Sema for 'exit data' construct

2024-12-16 Thread via cfe-commits
Author: erichkeane Date: 2024-12-16T06:44:53-08:00 New Revision: 1ab81f8e7f77110c4a752dd7d2cc39fb5148760c URL: https://github.com/llvm/llvm-project/commit/1ab81f8e7f77110c4a752dd7d2cc39fb5148760c DIFF: https://github.com/llvm/llvm-project/commit/1ab81f8e7f77110c4a752dd7d2cc39fb5148760c.diff LO

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 FMLAL/FMLALL (Indexed) (PR #118549)

2024-12-16 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. Thank you Spencer. LGTM! https://github.com/llvm/llvm-project/pull/118549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] Added options to readability-implicit-bool-conversion (PR #120087)

2024-12-16 Thread via cfe-commits
https://github.com/4m4n-x-B4w4ne updated https://github.com/llvm/llvm-project/pull/120087 >From 03f536888ddc5b7be2514c2d880c6d3119b7f4ee Mon Sep 17 00:00:00 2001 From: 4m4n-x-B4w4ne <125849251+4m4n-x-b4w...@users.noreply.github.com> Date: Mon, 16 Dec 2024 19:43:42 +0530 Subject: [PATCH 1/3] Upda

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwind/tes

[clang-tools-extra] [clang-tidy] use specified type verbatim in modernize-use-using fix (PR #113837)

2024-12-16 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The documentation at https://llvm.org/docs/AMDGPUUsage.html#memory-scopes states that these 'one-as' modifiers are more specific versions of the scopes that only apply to a specific address space. Thi

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-16 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu approved this pull request. Thanks for adding the test as well. LGTM. https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: I would say this change is obviously correct, but I can't see why it was introduced and vaguely fear tripping over abhorrent behaviour in the backend. Can you send this down the internal CI pipeline to pick up some more runtime testing (unless amd-stg-open is already def

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Jon Chesterfield via cfe-commits
https://github.com/JonChesterfield approved this pull request. Explicitly marking green, even if this commit upsets something else in the backend having the concurrency primitives default to racy is clearly bad. https://github.com/llvm/llvm-project/pull/120095 __

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot7` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/7753 Here is the relevant piece o

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Jon Chesterfield via cfe-commits
https://github.com/JonChesterfield edited https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix non-deterministic infinite recursion... (PR #118288)

2024-12-16 Thread via cfe-commits
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: lbonn wrote: Given that the original report is a regression that prevents using the current version of mp-units, I would advocate for a backport. As I understand, the procedure is to send the cherry-pick command that will be picked

[clang] 38b3d87 - [C++20][Modules] Load function body from the module that gives canonical decl (#111992)

2024-12-16 Thread via cfe-commits
Author: Dmitry Polukhin Date: 2024-12-16T12:22:43Z New Revision: 38b3d87bd384a469a6618ec6a971352cb4f813ba URL: https://github.com/llvm/llvm-project/commit/38b3d87bd384a469a6618ec6a971352cb4f813ba DIFF: https://github.com/llvm/llvm-project/commit/38b3d87bd384a469a6618ec6a971352cb4f813ba.diff LO

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-16 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Fix triple config loading for clang-cl (PR #111397)

2024-12-16 Thread Hans Wennborg via cfe-commits
zmodem wrote: Looks like I was wrong. clang-cl does support `--config` since daebf2c13ce27ac6a7403525cc7fcbc063eb892e, so I suppose we can't just ignore these files. Your change to update the triple based on clang-cl mode earlier makes sense to me. I'm less sure about manually inspecting the

[clang] ef4b597 - [AArch64] Add intrinsics for SME FP8 FDOT single and multi instructions (#119845)

2024-12-16 Thread via cfe-commits
Author: Jonathan Thackray Date: 2024-12-16T13:14:40Z New Revision: ef4b597015db0e558f3a75f2f75d471a1cabe0b6 URL: https://github.com/llvm/llvm-project/commit/ef4b597015db0e558f3a75f2f75d471a1cabe0b6 DIFF: https://github.com/llvm/llvm-project/commit/ef4b597015db0e558f3a75f2f75d471a1cabe0b6.diff

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FDOT single and multi instructions (PR #119845)

2024-12-16 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/119845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Avoid re-evaluating field bitwidth (PR #117732)

2024-12-16 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/117732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Add diagnostics for invalid binary arithmetic (PR #118475)

2024-12-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/118475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FDOT single and multi instructions (PR #119845)

2024-12-16 Thread via cfe-commits
@@ -3874,11 +3874,47 @@ class SME2_FP8_FDOT_LANE_VG1x4 : llvm_i32_ty], [IntrInaccessibleMemOnly, IntrHasSideEffects, ImmArg>]>; +class SME2_FP8_FDOT_SINGLE_VG1x2 : CarolineConcatto wrote: I have notice

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FDOT single and multi instructions (PR #119845)

2024-12-16 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. https://github.com/llvm/llvm-project/pull/119845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Don't require -fno-integrated-as when using -save-temps (PR #119624)

2024-12-16 Thread David Truby via cfe-commits
DavidTruby wrote: That's interesting, there _is_ an external assembler on Windows; in fact, LLVM itself builds one (llvm-ml.exe) as well as MSVC providing one (ml.exe). I wonder why we can't just use llvm-ml here, since we know it must be available? I can have a look if this works for clang. I

[clang] [llvm] [RISCV] Add MIPS P8700 processor (PR #119882)

2024-12-16 Thread Djordje Todorovic via cfe-commits
@@ -1477,6 +1477,10 @@ def TuneConditionalCompressedMoveFusion def HasConditionalMoveFusion : Predicate<"Subtarget->hasConditionalMoveFusion()">; def NoConditionalMoveFusion : Predicate<"!Subtarget->hasConditionalMoveFusion()">; +def TuneMIPSP8700 +: SubtargetFeature<"m

[clang] [clang] Add sincos builtin using `llvm.sincos` intrinsic (PR #114086)

2024-12-16 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue updated https://github.com/llvm/llvm-project/pull/114086 >From 5e6e49cf8bceed6d137ea67abe81a8a425d5aed8 Mon Sep 17 00:00:00 2001 From: Benjamin Maxwell Date: Mon, 9 Sep 2024 10:15:20 + Subject: [PATCH 1/3] [clang] Add sincos builtin using `llvm.sincos` intrinsic T

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,llvm` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/10397 Here is

[clang] [ASTMatchers] fix `isStaticStorageClass` not matching definitions of forward declared functions (PR #120027)

2024-12-16 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Another solution would be to explicitly document the definition is not matching with `isStaticStorageClass`, and we add `hasCanonicalDecl`. That solution would do less behind the scenes at the cost of potentially tripping poeple up (though documenting this for `isStaticStorageC

[clang] dd6f6a0 - [clang][bytecode] Handle builtin_wmemcmp (#120070)

2024-12-16 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-16T13:41:14+01:00 New Revision: dd6f6a096a59892ce1f9c454461aa5ed4c2aa971 URL: https://github.com/llvm/llvm-project/commit/dd6f6a096a59892ce1f9c454461aa5ed4c2aa971 DIFF: https://github.com/llvm/llvm-project/commit/dd6f6a096a59892ce1f9c454461aa5ed4c2aa971.diff L

[clang] [clang][bytecode] Handle builtin_wmemcmp (PR #120070)

2024-12-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/120070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-12-16 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts approved this pull request. LGTM on the SPIR-V side. Just a superfluous loop thing. For the structurizer, seems like this is OK, worst case we might end-up with a new condition which has no Flatten/Dontflatten attachment but should be fine. https://github.com/llvm/llv

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-12-16 Thread Nathan Gauër via cfe-commits
@@ -2776,19 +2776,35 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, } return MIB.constrainAllUses(TII, TRI, RBI); } - case Intrinsic::spv_loop_merge: - case Intrinsic::spv_selection_merge: { -const auto Opcode = IID == Intrinsic::spv_select

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-12-16 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts edited https://github.com/llvm/llvm-project/pull/116331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Handle builtin_wmemcmp (PR #120070)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/120070.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/InterpBuiltin.cpp (+49-22) - (modified) clang/test/AST/ByteCode/builtin-function

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-16 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: @ilya-biryukov and @ChuanqiXu9 thank you for your help with the review, testing and reproducers. Very appreciated! https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] 9096879 - [X86] Add missing feature USERMSR to DiamondRapids (#120061)

2024-12-16 Thread via cfe-commits
Author: Phoebe Wang Date: 2024-12-16T20:29:26+08:00 New Revision: 90968794e26709957d49dd660e4e453235d393e8 URL: https://github.com/llvm/llvm-project/commit/90968794e26709957d49dd660e4e453235d393e8 DIFF: https://github.com/llvm/llvm-project/commit/90968794e26709957d49dd660e4e453235d393e8.diff L

[clang] [llvm] [X86] Add missing feature USERMSR to DiamondRapids (PR #120061)

2024-12-16 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/120061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] FunctionDecl::getFunctionTypeLoc: ignore function type attributes (PR #118420)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Robert Dazi (v01dXYZ) Changes Related to #118290. --- Full diff: https://github.com/llvm/llvm-project/pull/118420.diff 3 Files Affected: - (modified) clang-tools-extra/clangd/unittests/InlayHintTests.cpp (+8-6) - (modified) clang/lib/A

[clang] [clang-tools-extra] FunctionDecl::getFunctionTypeLoc: ignore function type attributes (PR #118420)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Robert Dazi (v01dXYZ) Changes Related to #118290. --- Full diff: https://github.com/llvm/llvm-project/pull/118420.diff 3 Files Affected: - (modified) clang-tools-extra/clangd/unittests/InlayHintTests.cpp (+8-6) - (modified)

[clang] [clang-tools-extra] FunctionDecl::getFunctionTypeLoc: ignore function type attributes (PR #118420)

2024-12-16 Thread Robert Dazi via cfe-commits
https://github.com/v01dXYZ ready_for_review https://github.com/llvm/llvm-project/pull/118420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread Pravin Jagtap via cfe-commits
@@ -0,0 +1,532 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -o - %s | FileCheck %s pravinjagtap wrote: are you referring

[clang] [clang-tools-extra] FunctionDecl::getFunctionTypeLoc: ignore function type attributes (PR #118420)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Robert Dazi (v01dXYZ) Changes Related to #118290. --- Full diff: https://github.com/llvm/llvm-project/pull/118420.diff 3 Files Affected: - (modified) clang-tools-extra/clangd/unittests/InlayHintTests.cpp (+8-6) - (modified) clang/lib/

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120013 >From 51c5f794e4c3253675f83821fd58bdefdfcf0c67 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwind/test/

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-16 Thread Erich Keane via cfe-commits
@@ -434,8 +434,11 @@ CheckExtVectorComponent(Sema &S, QualType baseType, ExprValueKind &VK, if (!HalvingSwizzle && *compStr) { // We didn't get to the end of the string. This means the component names // didn't come from the same set *or* we encountered an illegal na

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-16 Thread Peng Huang via cfe-commits
phuang wrote: > are there any prerequisite changes elsewhere that I need to port to it? HI @nico, how to repro the problem locally? Is there a doc for it? or could you please share steps? thanks https://github.com/llvm/llvm-project/pull/118192 ___ cf

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -5,8 +5,46 @@ target datalayout = "A5" ; CHECK: in function test_dynamic_stackalloc{{.*}}: unsupported dynamic alloca -define amdgpu_kernel void @test_dynamic_stackalloc(ptr addrspace(1) %out, i32 %n) { +define amdgpu_kernel void @test_dynamic_stackalloc(i32 %n) { %all

[clang] [HLSL][NFC] Fix static analyzer concerns (PR #120090)

2024-12-16 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/120090 Class BuiltinTypeMethodBuilder has a user-defined destructor so likely compiler generated special functions may behave incorrectly. Delete explicitly copy constructor and copy assignment operator to avoid pot

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-16 Thread William Tran-Viet via cfe-commits
@@ -434,8 +434,11 @@ CheckExtVectorComponent(Sema &S, QualType baseType, ExprValueKind &VK, if (!HalvingSwizzle && *compStr) { // We didn't get to the end of the string. This means the component names // didn't come from the same set *or* we encountered an illegal na

[clang] [HLSL][NFC] Fix static analyzer concerns (PR #120090)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Mariya Podchishchaeva (Fznamznon) Changes Class BuiltinTypeMethodBuilder has a user-defined destructor so likely compiler generated special functions may behave incorrectly. Delete explicitly copy constructor and copy assignment operator t

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap edited https://github.com/llvm/llvm-project/pull/120063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread Pravin Jagtap via cfe-commits
https://github.com/pravinjagtap edited https://github.com/llvm/llvm-project/pull/120063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-12-16 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/112304 >From d41e927e0f437e09cb320b4594f958cb18e30116 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 15 Oct 2024 04:42:35 +0100 Subject: [PATCH 1/2] [clangd] Update clangDaemonTweaks to set symbol visibility

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-16 Thread William Tran-Viet via cfe-commits
https://github.com/smallp-o-p edited https://github.com/llvm/llvm-project/pull/118186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,532 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -x hip -emit-llvm -fcuda-is-device -o - %s | FileCheck %s arsenm wrote: I think there are alread

[clang] 8380baf - [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (#119922)

2024-12-16 Thread via cfe-commits
Author: Jonathan Thackray Date: 2024-12-16T14:42:45Z New Revision: 8380bafaed84cb5799feef70bf34387d6f15acff URL: https://github.com/llvm/llvm-project/commit/8380bafaed84cb5799feef70bf34387d6f15acff DIFF: https://github.com/llvm/llvm-project/commit/8380bafaed84cb5799feef70bf34387d6f15acff.diff

[clang] [llvm] [AArch64] Add intrinsics for SME FP8 FVDOT, FVDOTB and FVDOTT intrinsics (PR #119922)

2024-12-16 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/119922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland - [Driver][SYCL] Add initial SYCL offload compilation support … (PR #117268)

2024-12-16 Thread Tom Honermann via cfe-commits
tahonermann wrote: @MaskRay, could you please take a look at this PR and give it your stamp of approval if you have no concerns? https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan --- libunwind/test/

[clang] [llvm] [RISCV] Add scheduling model for mips p8700 CPU (PR #119885)

2024-12-16 Thread Djordje Todorovic via cfe-commits
@@ -0,0 +1,290 @@ +//===-- RISCVSchedMIPSP8700.td - MIPS RISC-V Processor -*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-16 Thread Bevin Hansson via cfe-commits
https://github.com/bevin-hansson created https://github.com/llvm/llvm-project/pull/120099 When looking up code completions from Sema, there is no associated documentation. This is due to crash issues with stale preambles. However, this also means that code completion results from other than the

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-16 Thread Bevin Hansson via cfe-commits
bevin-hansson wrote: I'm not entirely sure how to add to the tests for clangd. Any advice? https://github.com/llvm/llvm-project/pull/120099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd @llvm/pr-subscribers-clang-tools-extra Author: Bevin Hansson (bevin-hansson) Changes When looking up code completions from Sema, there is no associated documentation. This is due to crash issues with stale preambles. However, this also means that

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-16 Thread William Tran-Viet via cfe-commits
https://github.com/smallp-o-p edited https://github.com/llvm/llvm-project/pull/118186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: This one-as business seems like it's cruft from before MMRAs. Can we rip them out and replace them with MMRAs for OpenCL? https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@l

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Matt Arsenault via cfe-commits
arsenm wrote: > @b-sumner has useful context on this. I'll try not to speak for him but it > sounds like the block deleted here has the right semantics for opencl, where > "seqcst" has some special meaning and generally the semantics don't totally > make sense to me. Suggest we amend this to "

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
jhuber6 wrote: If that's the case then we should be able to use the `LangOpts` to change it. https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2024-12-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka created https://github.com/llvm/llvm-project/pull/120055 Add a new check that suggests using `string_view::remove_prefix()` and `remove_suffix()` instead of `substr()` when the intent is to remove characters from either end of a string_view. >From 16a98e0d99cc

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2024-12-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/120055 >From 16a98e0d99ccee0c2bb6bad51c27c67c5c43d747 Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Mon, 16 Dec 2024 08:24:14 +0100 Subject: [PATCH] [clang-tidy] Add readability-string-view-substr check Add

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2024-12-16 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka updated https://github.com/llvm/llvm-project/pull/120055 >From bcee24de45d955760257bb0b1825e3e59bf7a28c Mon Sep 17 00:00:00 2001 From: Helmut Januschka Date: Mon, 16 Dec 2024 08:24:14 +0100 Subject: [PATCH] [clang-tidy] Add readability-string-view-substr check Add

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2024-12-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a35db2880a488b62a16f269972ad885fd58033f7 ea6d39ab0f32e81e7633b69648b30f782272ec59 --e

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-16 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: The latest version works like a charm for us, there aren't any bugs. I'll let @ChuanqiXu9 stamp the final approval for the code. Let me know if you'll need more testing. https://github.com/llvm/llvm-project/pull/111992 ___ cfe-com

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-16 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: ping @MaskRay https://github.com/llvm/llvm-project/pull/118640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2503a66 - Reapply "[clang][bytecode] Fix some shift edge cases (#119895)"

2024-12-16 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-12-16T10:01:46+01:00 New Revision: 2503a6659621e27e6b4c5946c3acff7a5b9dadca URL: https://github.com/llvm/llvm-project/commit/2503a6659621e27e6b4c5946c3acff7a5b9dadca DIFF: https://github.com/llvm/llvm-project/commit/2503a6659621e27e6b4c5946c3acff7a5b9dadca.diff LO

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-16 Thread Shao-Ce SUN via cfe-commits
@@ -12,21 +12,32 @@ // Subclass of SubtargetFeature to be used when the feature is also a RISC-V // extension. Extensions have a version and may be experimental. +// NOTE: The extension name must start with +// - "FeatureStdExt" for standard extensions +// - "Featu

[clang] [clang-format] Fix crashes when the macro expansion is empty (PR #119428)

2024-12-16 Thread via cfe-commits
https://github.com/amane-ame updated https://github.com/llvm/llvm-project/pull/119428 From 3a4c1a924faef3a7a09126694fcb943bd7083451 Mon Sep 17 00:00:00 2001 From: amane-ame Date: Wed, 11 Dec 2024 02:13:43 +0800 Subject: [PATCH 1/3] Fix crashes when the macro expansion is empty --- clang/lib/F

[clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

2024-12-16 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113150 >From 8384b1df4f7bbf454580b7486988e1808df9825d Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 10:58:04 +0300 Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI Enable init/fi

[clang] [llvm] [Clang][OpenMP] Support for dispatch construct (Sema & Codegen) support (PR #117904)

2024-12-16 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/117904 >From 1703aa62cfe35538aedbacb28e907535e838248c Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Fri, 20 Sep 2024 01:41:29 -0500 Subject: [PATCH 1/8] Support for dispatch construct (Sema & Codegen)

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-16 Thread Pengcheng Wang via cfe-commits
@@ -12,21 +12,32 @@ // Subclass of SubtargetFeature to be used when the feature is also a RISC-V // extension. Extensions have a version and may be experimental. +// NOTE: The extension name must start with +// - "FeatureStdExt" for standard extensions +// - "Featu

[clang] [llvm] [NFC] [RISCV] Refactor class RISCVExtension (PR #120040)

2024-12-16 Thread Pengcheng Wang via cfe-commits
@@ -12,21 +12,32 @@ // Subclass of SubtargetFeature to be used when the feature is also a RISC-V // extension. Extensions have a version and may be experimental. +// NOTE: The extension name must start with +// - "FeatureStdExt" for standard extensions +// - "Featu

[libunwind] [Libunwind] Don't XFAIL tests with msan (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
chestnykh wrote: All CI failures look unrelated https://github.com/llvm/llvm-project/pull/120013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/118186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-16 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin edited https://github.com/llvm/llvm-project/pull/111992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-12-16 Thread via cfe-commits
@@ -16694,7 +16694,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2813.html";>2813 DR Class member access with prvalues -Unknown +Clang 20 cor3ntin wrote: Yeah, if @MitalAshok can't push that through th

[clang] [clang-tools-extra] [llvm] [MTE] Apply alignment / size in AsmPrinter rather than IR (PR #111918)

2024-12-16 Thread Florian Mayer via cfe-commits
https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/111918 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-16 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/111992 >From 3eaaa7d70f4b57cc13bd00bd3a3a921f7914d599 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 11 Oct 2024 05:35:18 -0700 Subject: [PATCH 1/9] [C++20][Modules] Load function body from the module tha

[clang] [llvm] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic allocas (PR #120063)

2024-12-16 Thread via cfe-commits
https://github.com/easyonaadit updated https://github.com/llvm/llvm-project/pull/120063 >From 9ebbeba8d54853687f7b992be6b359d3836798a7 Mon Sep 17 00:00:00 2001 From: easyonaadit Date: Mon, 16 Dec 2024 15:25:07 +0530 Subject: [PATCH] [NFC][AMDGPU] Pre-commit clang and llvm tests for dynamic all

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-12-16 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/111992 >From d71fb50ca68448578b797bb85f3a607dc9739d45 Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 11 Oct 2024 05:35:18 -0700 Subject: [PATCH 1/9] [C++20][Modules] Load function body from the module tha

[clang] [llvm] [X86] Add missing feature USERMSR to DiamondRapids (PR #120061)

2024-12-16 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. https://github.com/llvm/llvm-project/pull/120061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-12-16 Thread via cfe-commits
@@ -16694,7 +16694,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2813.html";>2813 DR Class member access with prvalues -Unknown +Clang 20 h-vetinari wrote: Given the lack of activity here, this looks t

<    1   2   3   4   >