llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Zahira Ammarguellat (zahiraam)
Changes
Provide, where missing, a copy constructor, a copy assignment operator or a
destructor to prevent potential issues that can arise.
---
Full diff: https://github.com/llvm/llvm-project/pull/11865
https://github.com/mshockwave updated
https://github.com/llvm/llvm-project/pull/117368
>From 599370a06008092f6aa883bf11600d0b66707bc0 Mon Sep 17 00:00:00 2001
From: Min-Yih Hsu
Date: Wed, 20 Nov 2024 14:37:57 -0800
Subject: [PATCH 1/5] [XRay][RISCV] RISCV support for XRay
Add RISC-V support fo
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
@llvm/pr-subscribers-clangd
Author: Zahira Ammarguellat (zahiraam)
Changes
Provide, where missing, a copy constructor, a copy assignment operator or a
destructor to prevent potential issues that can arise.
---
Full diff: https://gith
https://github.com/yuxuanchen1997 updated
https://github.com/llvm/llvm-project/pull/118522
>From 5860f5f25e04930c72dcdb9f0ee4d7386cbcb3d3 Mon Sep 17 00:00:00 2001
From: Yuxuan Chen
Date: Mon, 2 Dec 2024 15:15:30 -0800
Subject: [PATCH 01/11] start working on the new tool
---
.../clang-read-dia
zahiraam wrote:
@HighCommander4 Is that good as a change? Do you still want an issue to be
opened?
@tahonermann can you please review? Thanks.
https://github.com/llvm/llvm-project/pull/118324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -0,0 +1,87 @@
+//===-- xray_trampoline_riscv32.s --*- ASM
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
zygoloid wrote:
Looks like the tests in #110102 are named `extend-liveness-*.cpp`. Perhaps
`-fextend-liveness` would be a good name for this flag?
https://github.com/llvm/llvm-project/pull/11
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/118528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> _ No description provided. _
https://github.com/llvm/llvm-project/pull/118528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -58,10 +58,10 @@ getDerivedParameter(const ClassTemplateSpecializationDecl
*CRTP,
Arg.getAsType()->getAsCXXRecordDecl() == Derived;
});
- return AnyOf ? CRTP->getSpecializedTemplate()
- ->getTemplateParameters()
-
@@ -58,10 +58,10 @@ getDerivedParameter(const ClassTemplateSpecializationDecl
*CRTP,
Arg.getAsType()->getAsCXXRecordDecl() == Derived;
});
- return AnyOf ? CRTP->getSpecializedTemplate()
- ->getTemplateParameters()
-
yuxuanchen1997 wrote:
> > Looking at the test failure, it appears that when only building
> > `check-clang-tools`, no `clang` binary was built. So the test driver cannot
> > find `clang`. Maybe this diagnostics binary file should be checked in for
> > the test? That will not catch future error
@@ -674,6 +700,34 @@
BuiltinTypeDeclBuilder::addHandleAccessFunction(DeclarationName &Name,
.finalizeMethod();
}
+BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addAppendMethod() {
+ using PH = BuiltinTypeMethodBuilder::PlaceHolder;
+ ASTContext &AST = SemaRef.getAST
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/118536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic commented:
I was able to follow the logic and it LGTM
https://github.com/llvm/llvm-project/pull/118536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Bo98 wrote:
> I don't think it's deprecated in the sense we have plans to drop support for
> it. The problem here seems more like when those values conflict what should
> be expected?
>
> Today it seems expected that `sysroot` will be used for library search but
> not header search, which also
@@ -430,12 +432,20 @@ struct BuiltinTypeMethodBuilder {
// Argument placeholders, inspired by std::placeholder. These are the indices
// of arguments to forward to `callBuiltin`, and additionally `Handle` which
// refers to the resource handle.
inbelic wr
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/118674
Summary:
This is consistent with other intrinsic headers like the SSE/AVX
intrinsics. I don't think function names need to be specificlaly
reserved because we are not natively including this into any TUs. The
mai
https://github.com/zygoloid edited
https://github.com/llvm/llvm-project/pull/11
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,266 @@
+//===-- xray_riscv.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/topperc edited
https://github.com/llvm/llvm-project/pull/117368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,266 @@
+//===-- xray_riscv.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -70,6 +70,11 @@ class FileEntryRef {
const FileEntry &getFileEntry() const {
return *getBaseMapEntry().second->V.get();
}
+#ifdef __MVS__
abhina-sree wrote:
There are a lot of uses of the const function so we would hit a lot of errors
if we got rid
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -49,3 +49,28 @@ void CSMain3_GID(uint3 : SV_GroupID) {
// CHECK-NEXT: ParmVarDecl 0x{{[0-9a-fA-F]+}} <{{.*}}> col:24 'uint3'
// CHECK-NEXT: HLSLSV_GroupIDAttr
}
+
+[numthreads(8,8,1)]
+void CSMain_GThreadID(uint ID : SV_GroupThreadID) {
+// CHECK: FunctionDecl 0x{{[0-9a-fA-F
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/117781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic commented:
Do we need to consider how spirv handles this? Otherwise, LGTM
https://github.com/llvm/llvm-project/pull/117781
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-armv7-global-isel`
running on `linaro-clang-armv7-global-isel` while building `clang` at step 7
"ninja check 1".
Full details are available at:
@@ -674,6 +700,34 @@
BuiltinTypeDeclBuilder::addHandleAccessFunction(DeclarationName &Name,
.finalizeMethod();
}
+BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addAppendMethod() {
+ using PH = BuiltinTypeMethodBuilder::PlaceHolder;
+ ASTContext &AST = SemaRef.getAST
@@ -0,0 +1,266 @@
+//===-- xray_riscv.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -0,0 +1,266 @@
+//===-- xray_riscv.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,96 @@
+//===-- xray_trampoline_riscv_common.s --*- ASM
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,96 @@
+//===-- xray_trampoline_riscv_common.s --*- ASM
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/118687
Given a `noexcept` operator with an operand that calls `delete`, Clang was not
considering whether the selected `operator delete` function was a destroying
delete or not when inspecting whether the deleted
@@ -0,0 +1,96 @@
+//===-- xray_trampoline_riscv_common.s --*- ASM
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/trcrsired created
https://github.com/llvm/llvm-project/pull/118688
None
>From 72bc42bdb9a1ad5959655aa194093411a2f372e2 Mon Sep 17 00:00:00 2001
From: trcrsired
Date: Wed, 4 Dec 2024 14:31:24 -0500
Subject: [PATCH] [clang] enable mingw fuzzer support
---
clang/lib/Driver/To
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cqwrteur (trcrsired)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/118688.diff
1 Files Affected:
- (modified) clang/lib/Driver/ToolChains/MinGW.cpp (+7)
``diff
diff --git a/clang/lib/Driver/ToolChains/MinG
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/118687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/118687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -58,10 +58,10 @@ getDerivedParameter(const ClassTemplateSpecializationDecl
*CRTP,
Arg.getAsType()->getAsCXXRecordDecl() == Derived;
});
- return AnyOf ? CRTP->getSpecializedTemplate()
- ->getTemplateParameters()
-
@@ -52,3 +52,37 @@ void constant_id_string(unsigned idx) {
unsafe_char = ""[1]; //expected-warning{{unsafe buffer access}}
unsafe_char = ""[idx]; //expected-warning{{unsafe buffer access}}
}
+
+typedef float Float4x4[4][4];
+
+// expected-warning@+1 {{'matrix' is an unsafe
@@ -8,6 +8,5 @@
// main function
int main(int argc, char *argv[]) { // expected-warning{{'argv' is an unsafe
pointer used for buffer access}}
char tmp;
- tmp = argv[5][5];// expected-note{{used in buffer access
here}} \
-
@@ -453,11 +475,71 @@ bool
RISCVAsmPrinter::runOnMachineFunction(MachineFunction &MF) {
SetupMachineFunction(MF);
emitFunctionBody();
+ // Emit the XRay table
+ emitXRayTable();
+
if (EmittedOptionArch)
RTS.emitDirectiveOptionPop();
return false;
}
+void R
@@ -0,0 +1,21 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -fcxx-exceptions
-Wno-unevaluated-expression -std=c++20 %s
shafik wrote:
We already have
https://github.com/llvm/llvm-project/blob/main/clang/test/CXX/expr/expr.unary/expr.unary.noexcept/sema.cpp
mayb
@@ -233,10 +233,13 @@ bool
XRayInstrumentation::runOnMachineFunction(MachineFunction &MF) {
case Triple::ArchType::mips:
case Triple::ArchType::mipsel:
case Triple::ArchType::mips64:
-case Triple::ArchType::mips64el: {
+case Triple::ArchType::mips64el:
+
@@ -654,6 +654,9 @@ Bug Fixes in This Version
- Fixed a crash when GNU statement expression contains invalid statement
(#GH113468).
- Fixed a failed assertion when using ``__attribute__((noderef))`` on an
``_Atomic``-qualified type (#GH116124).
+- No longer return ``false``
@@ -674,6 +700,34 @@
BuiltinTypeDeclBuilder::addHandleAccessFunction(DeclarationName &Name,
.finalizeMethod();
}
+BuiltinTypeDeclBuilder &BuiltinTypeDeclBuilder::addAppendMethod() {
+ using PH = BuiltinTypeMethodBuilder::PlaceHolder;
+ ASTContext &AST = SemaRef.getAST
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
Given a `noexcept` operator with an operand that calls `delete`, Clang was not
considering whether the selected `operator delete` function was a destroying
delete or not when inspecting whether the del
https://github.com/mshockwave updated
https://github.com/llvm/llvm-project/pull/117368
>From 599370a06008092f6aa883bf11600d0b66707bc0 Mon Sep 17 00:00:00 2001
From: Min-Yih Hsu
Date: Wed, 20 Nov 2024 14:37:57 -0800
Subject: [PATCH 1/4] [XRay][RISCV] RISCV support for XRay
Add RISC-V support fo
@@ -1205,11 +1205,12 @@ CanThrowResult Sema::canThrow(const Stmt *S) {
if (DTy.isNull() || DTy->isDependentType()) {
CT = CT_Dependent;
} else {
- CT = canCalleeThrow(*this, DE, DE->getOperatorDelete());
+ const FunctionDecl *OperatorDelete = DE->getOper
@@ -92,6 +98,63 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T,
const Triple &TT,
setRequiresStructuredCFG(false);
}
+enum AddressSpace {
+ Function = storageClassToAddressSpace(SPIRV::StorageClass::Function),
+ CrossWorkgroup =
+ storageClassToAddressSpac
https://github.com/DanAlbert approved this pull request.
https://github.com/llvm/llvm-project/pull/117624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/118674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -654,6 +654,9 @@ Bug Fixes in This Version
- Fixed a crash when GNU statement expression contains invalid statement
(#GH113468).
- Fixed a failed assertion when using ``__attribute__((noderef))`` on an
``_Atomic``-qualified type (#GH116124).
+- No longer return ``false``
@@ -91,6 +94,18 @@ struct BuiltinTypeDeclBuilder {
HLSLNamespace->addDecl(Record);
}
+ CXXRecordDecl *finalizeForwardDeclaration() {
+// Force the QualType to be generated for the record declaration. In most
inbelic wrote:
Which of the added test
https://github.com/inbelic edited
https://github.com/llvm/llvm-project/pull/117245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,21 @@
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - |
FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o -
-filetype=obj | spirv-val %}
+
+; CHECK-DAG: %[[#bool:]] = OpTypeBool
+; CHECK-DAG: %[[#uint:]]
https://github.com/inbelic approved this pull request.
LGTM, just a nit and your self-review
https://github.com/llvm/llvm-project/pull/117245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/118687
>From 10985bcd5ae13f4533a9df4fa3035bd49e49af15 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Wed, 4 Dec 2024 14:31:48 -0500
Subject: [PATCH 1/2] [C++20] Deleting destructors can be noexcept
Given a `n
@@ -91,6 +94,18 @@ struct BuiltinTypeDeclBuilder {
HLSLNamespace->addDecl(Record);
}
+ CXXRecordDecl *finalizeForwardDeclaration() {
+// Force the QualType to be generated for the record declaration. In most
joaosaffran wrote:
There are some exis
llvmbot wrote:
@llvm/pr-subscribers-libc
Author: Petr Hosek (petrhosek)
Changes
We have users that target baremetal aarch64.
---
Full diff: https://github.com/llvm/llvm-project/pull/118691.diff
3 Files Affected:
- (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+13-7)
- (added) li
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/118691
We have users that target baremetal aarch64.
>From b9a09c6a5b4966ff7e614ace8a0e6a5a6a1916f4 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Wed, 4 Dec 2024 00:47:10 -0800
Subject: [PATCH] [Fuchsia] Enable bar
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/118674
>From 7e28f1039a0443baea8bca7c994bb85429730674 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Wed, 4 Dec 2024 11:55:07 -0600
Subject: [PATCH] [Clang] Rename GPU intrinsic functions from `__gpu_` to
`_gpu_`
@@ -1206,15 +1206,16 @@ CanThrowResult Sema::canThrow(const Stmt *S) {
CT = CT_Dependent;
} else {
const FunctionDecl *OperatorDelete = DE->getOperatorDelete();
- CT = canCalleeThrow(*this, DE, OperatorDelete);
- if (const RecordType *RT = DTy->getAs()
jhuber6 wrote:
I'm fine with this solution, but I'll sit on it for a bit to see if
@AaronBallman has an opinion or if the `clangd` people get back to me on
https://github.com/llvm/llvm-project/issues/118684.
https://github.com/llvm/llvm-project/pull/118674
_
@@ -0,0 +1,21 @@
+// RUN: %clang_cc1 -fsyntax-only -verify -fcxx-exceptions
-Wno-unevaluated-expression -std=c++20 %s
AaronBallman wrote:
That test file has a lot of dynamic exception specification code in it, so it's
leaning heavily on `-std=c++11`.
https://g
cachemeifyoucan wrote:
> DEFAULT_SYSROOT was expected by some users to support setting a default SDK.
> Maybe this wasn't actually intended, but it came common enough knowledge to
> eventually be explicitly recommended in parts of LLVM documentation:
That is flang document, which is not endors
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/118687
>From 10985bcd5ae13f4533a9df4fa3035bd49e49af15 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Wed, 4 Dec 2024 14:31:48 -0500
Subject: [PATCH 1/3] [C++20] Deleting destructors can be noexcept
Given a `n
efriedma-quic wrote:
> I thought that this fix will automatically pull from main to other branch at
> some tiime
main is the basis for all future release branches (20.x and later), but we
don't automatically pull fixes into release branches that are already created
(19.x).
See https://llvm.o
bazuzi wrote:
Anything else I should add before merging this?
https://github.com/llvm/llvm-project/pull/117548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/abhina-sree edited
https://github.com/llvm/llvm-project/pull/98652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -49,3 +49,28 @@ void CSMain3_GID(uint3 : SV_GroupID) {
// CHECK-NEXT: ParmVarDecl 0x{{[0-9a-fA-F]+}} <{{.*}}> col:24 'uint3'
// CHECK-NEXT: HLSLSV_GroupIDAttr
}
+
+[numthreads(8,8,1)]
+void CSMain_GThreadID(uint ID : SV_GroupThreadID) {
+// CHECK: FunctionDecl 0x{{[0-9a-fA-F
https://github.com/chomosuke updated
https://github.com/llvm/llvm-project/pull/118569
>From efc17a803c9c22543de7d5f9e960a7267ade1f2e Mon Sep 17 00:00:00 2001
From: chomosuke
Date: Wed, 4 Dec 2024 14:42:24 +
Subject: [PATCH 1/2] [clangd][clang-tidy] Make clangd run
`format::cleanupAroundRep
lizhengxing wrote:
> Do we need to consider how spirv handles this? Otherwise, LGTM
This PR is similar to the one for SV_GroupID. We don't consider the spirv part
for both PRs.
https://github.com/llvm/llvm-project/pull/117781
___
cfe-commits mailing
chomosuke wrote:
@EugeneZelenko Mentioned in ReleaseNotes in #118569, since the ReleaseNotes of
#118569 would include the changes in this PR. Please let me know if more
details are required in the ReleaseNotes.
https://github.com/llvm/llvm-project/pull/118568
__
https://github.com/chomosuke updated
https://github.com/llvm/llvm-project/pull/118569
>From efc17a803c9c22543de7d5f9e960a7267ade1f2e Mon Sep 17 00:00:00 2001
From: chomosuke
Date: Wed, 4 Dec 2024 14:42:24 +
Subject: [PATCH 1/2] [clangd][clang-tidy] Make clangd run
`format::cleanupAroundRep
https://github.com/chomosuke updated
https://github.com/llvm/llvm-project/pull/118569
>From efc17a803c9c22543de7d5f9e960a7267ade1f2e Mon Sep 17 00:00:00 2001
From: chomosuke
Date: Wed, 4 Dec 2024 14:42:24 +
Subject: [PATCH 1/2] [clangd][clang-tidy] Make clangd run
`format::cleanupAroundRep
https://github.com/nickdesaulniers approved this pull request.
https://github.com/llvm/llvm-project/pull/118691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -750,6 +750,19 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
if (Field->hasInClassInitializer()) {
if (VerifyOnly)
return;
+
+ // We do not want to aggressively set the hadError flag and cutoff
+ // parsing. Tr
Bo98 wrote:
> There is no standard location for macOS SDK, and it can be anywhere you want.
> DEFAULT_SYSROOT can't fix any problem for distribution.
To be clear: the build I talked about there required the CLT where the SDK
location is standardised, so this isn't entirely true for the use cas
@@ -453,11 +475,71 @@ bool
RISCVAsmPrinter::runOnMachineFunction(MachineFunction &MF) {
SetupMachineFunction(MF);
emitFunctionBody();
+ // Emit the XRay table
+ emitXRayTable();
+
if (EmittedOptionArch)
RTS.emitDirectiveOptionPop();
return false;
}
+void R
https://github.com/hjanuschka updated
https://github.com/llvm/llvm-project/pull/118074
>From cb748c34d35b8c0c9ca93a67b111dcf5d7665b34 Mon Sep 17 00:00:00 2001
From: Helmut Januschka
Date: Fri, 29 Nov 2024 10:17:49 +0100
Subject: [PATCH 01/23] [clang-tidy] Add modernize-use-span-first-last check
carlosgalvezp wrote:
You have duplicated `readability` when referring to the document:
```
- 'clang-tidy/checks/readability/readability-use-span-first-last'
+ 'clang-tidy/checks/readability/use-span-first-last'
```
You can build them with: `ninja docs-clang-tools-html`, with following CMake
co
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c3d15188cfe243900895a4f2c4f36b84e14928b7
c21e665617d588ae26b394deb0420969a4a263a5 --e
cachemeifyoucan wrote:
Ah, I see. I think `--sysroot` is not even involved when you use
`DEFAULT_SYSROOT`, it is injected here:
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/Driver.cpp#L205
Maybe instead of, the logic in the patch should be setting `-syslibroot` for
linker in
fhahn wrote:
> I think this is a strict improvement over the general 'fstrict-aliasing' mode
> we already have, and I see little value in maintaining separate levels of
> strict aliasing conformance long term.
>
> I think it would not be a good situation for users to rely on some level of
> s
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/117244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/118699
None
>From 440554df79ebc7c8971c4af928f623b13c95c6ee Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 4 Dec 2024 12:54:41 -0800
Subject: [PATCH] [NFC] Use a move instead of a copy to optimize perfo
Bo98 wrote:
That proposal makes sense to me.
https://github.com/llvm/llvm-project/pull/115993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/117645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,266 @@
+//===-- xray_riscv.cpp *- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/118699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti commented:
> With current implementation you may run into issue where when setting custom
> smart ptr, you won't have anymore support for shared_ptr.
Other option would be to add "make-custom" check, and leave it unconfigured.
Supporting multiple `make_x` would be be
@@ -22,7 +22,8 @@ namespace clang::tidy::modernize {
class MakeSmartPtrCheck : public ClangTidyCheck {
public:
MakeSmartPtrCheck(StringRef Name, ClangTidyContext *Context,
-StringRef MakeSmartPtrFunctionName);
+StringRef MakeSmartPtrFun
oskarwirga wrote:
Sorry for the lack of review, I was sick but I just wanted to express my
gratitude for fixing this hacky approach :)
https://github.com/llvm/llvm-project/pull/117651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/117529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
whiteio wrote:
@Maetveis Thanks for letting me know, I'll resolve the conflicts and let you
know once they're resolved.
https://github.com/llvm/llvm-project/pull/116871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
301 - 400 of 489 matches
Mail list logo
