[clang] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the implementation of it is known (PR #85465)

2024-10-28 Thread via cfe-commits
https://github.com/AreaZR updated https://github.com/llvm/llvm-project/pull/85465 >From 5872f59e60b294414ff5c74f7917b4e7ae64dfc5 Mon Sep 17 00:00:00 2001 From: Rose Date: Fri, 15 Mar 2024 16:43:10 -0400 Subject: [PATCH] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-10-28 Thread via cfe-commits
@@ -0,0 +1,544 @@ + +Function Effect Analysis + + +.. contents:: + :depth: 3 + :local: + + +Introduction + + +Clang Function Effect Analysis is a language extension which can warn about "unsafe" +constructs. The featur

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-10-28 Thread Chris Apple via cfe-commits
cjappl wrote: Happy to help. I'll merge this afternoon after the checks are green. Excited to have these docs up, had many conversations where I've wanted to refer people to them! https://github.com/llvm/llvm-project/pull/109855 ___ cfe-commits mail

[clang] [clang][analyzer] Bring checker 'alpha.unix.cstring.NotNullTerminated' out of alpha (PR #113899)

2024-10-28 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/113899 From 9cf4203652f06a140288a5c1ab6d14bcc3612380 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Mon, 28 Oct 2024 11:23:55 +0100 Subject: [PATCH 1/2] [clang][analyzer] Bring checker 'alph

[clang] [Clang] Add __ugly__ spelling for the msvc attribute scope (PR #113765)

2024-10-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/113765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add __ugly__ spelling for the msvc attribute scope (PR #113765)

2024-10-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: My only hold up is that we don't really own the design space. If @StephanTLavavej /Microsoft can assert us that this is the spelling they are going with, I'm all for it. https://github.com/llvm/llvm-project/pull/113765 _

[clang] [clang][modules] Optimize construction and usage of the submodule index (PR #113391)

2024-10-28 Thread Ben Langmuir via cfe-commits
@@ -541,11 +541,11 @@ class ModuleMap { /// /// \param IsExplicit Whether this is an explicit submodule. /// - /// \returns The found or newly-created module, along with a boolean value - /// that will be true if the module is newly-created. - std::pair findOrCreateMod

[clang] [Clang] Add __ugly__ spelling for the msvc attribute scope (PR #113765)

2024-10-28 Thread Erich Keane via cfe-commits
@@ -23,6 +23,30 @@ int hasAttribute(AttributeCommonInfo::Syntax Syntax, const IdentifierInfo *Scope, const IdentifierInfo *Attr, const TargetInfo &Target, const LangOptions &LangOpts); +inline const char* deuglifyAttrScope(StringRef Scope) { -

[clang] [Clang] Add __ugly__ spelling for the msvc attribute scope (PR #113765)

2024-10-28 Thread Erich Keane via cfe-commits
@@ -23,6 +23,30 @@ int hasAttribute(AttributeCommonInfo::Syntax Syntax, const IdentifierInfo *Scope, const IdentifierInfo *Attr, const TargetInfo &Target, const LangOptions &LangOpts); +inline const char* deuglifyAttrScope(StringRef Scope) { +

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

2024-10-28 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/113645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use StringRef::str() instead of std::string() cast (PR #113645)

2024-10-28 Thread Rahul Joshi via cfe-commits
jurahul wrote: Thanks. I'll queue this behind https://github.com/llvm/llvm-project/pull/113809. https://github.com/llvm/llvm-project/pull/113645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [llvm] InstCombine: Order shufflevector operands by complexity (PR #113212)

2024-10-28 Thread Matthias Braun via cfe-commits
MatzeB wrote: > I have always expected shuffles to be canonicalized to make the lowest mask > lane the first operand. I believe the AArch64 and Arm matching functions rely > on that at the moment. https://godbolt.org/z/1rr1E8v1K Thanks for pointing this out! So definitely cannot land the chang

[clang] [Clang] Add __ugly__ spelling for the msvc attribute scope (PR #113765)

2024-10-28 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: In principle, I'm not opposed, but if cl.exe doesn't support the syntax for their vendor string, I don't know that we should support it ourselves. The signal of support from @StephanTLavavej is definitely a point in favor of going this route, but I'd feel most comfortable i

[clang] [llvm] [RFC][RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-10-28 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113942 Stacks on top of #113918. RVA22 has retroactively been defined as including 'B' (as it's a shorthand for Zba+Zbb+Zbs, which were previously explicitly enumerated) and RV{A,B,M}23 are defined featuring B. We don't cur

[clang] [llvm] [RFC][RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-10-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Alex Bradbury (asb) Changes Stacks on top of #113918. RVA22 has retroactively been defined as including 'B' (as it's a shorthand for Zba+Zbb+Zbs, which were previously explicitly enumerated) and RV{A,B,M}23 are defined featuring B.

[clang] [rtsan][asan] NFC Fix hyperlink to CMake doc (PR #113931)

2024-10-28 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/113931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

2024-10-28 Thread Aaron Ballman via cfe-commits
@@ -49,40 +49,38 @@ using namespace llvm; namespace { class FlattenedSpelling { - std::string V, N, NS; + StringRef V, N, NS; bool K = false; const Record &OriginalSpelling; public: - FlattenedSpelling(const std::string &Variety, const std::string &Name, -

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

2024-10-28 Thread Aaron Ballman via cfe-commits
@@ -49,40 +49,38 @@ using namespace llvm; namespace { class FlattenedSpelling { - std::string V, N, NS; + StringRef V, N, NS; AaronBallman wrote: I'm not keen on this change; it may be correct, but it's pretty dangerous too because this now requires `Flatt

[clang] [clang][modules] Preserve the module map that allowed inferring (PR #113389)

2024-10-28 Thread Ben Langmuir via cfe-commits
@@ -3018,13 +3019,19 @@ void ASTWriter::WriteSubmodules(Module *WritingModule) { SourceLocationEncoding::RawLocEncoding DefinitionLoc = getRawSourceLocationEncoding(getAdjustedLocation(Mod->DefinitionLoc)); +ModuleMap &ModMap = PP->getHeaderSearchInfo().getModu

[clang] [Clang][TableGen] Use StringRef in FlattenedSpelling (PR #113809)

2024-10-28 Thread Rahul Joshi via cfe-commits
@@ -49,40 +49,38 @@ using namespace llvm; namespace { class FlattenedSpelling { - std::string V, N, NS; + StringRef V, N, NS; jurahul wrote: In all these instances, the strings are derived from TableGen Records, so they do outlive. I do agree that TG is no

[clang] 66bbbf2 - [clang][dataflow] Cache accessors returning pointers in bugprone-unchecked-optional-access (#113922)

2024-10-28 Thread via cfe-commits
Author: Jan Voung Date: 2024-10-28T15:13:29-04:00 New Revision: 66bbbf2e951a486f972a5a54378e6791193ade60 URL: https://github.com/llvm/llvm-project/commit/66bbbf2e951a486f972a5a54378e6791193ade60 DIFF: https://github.com/llvm/llvm-project/commit/66bbbf2e951a486f972a5a54378e6791193ade60.diff LOG

[clang] [clang][dataflow] Cache accessors returning pointers in bugprone-unchecked-optional-access (PR #113922)

2024-10-28 Thread Jan Voung via cfe-commits
https://github.com/jvoung closed https://github.com/llvm/llvm-project/pull/113922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Improve timing output (PR #113726)

2024-10-28 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/113726 >From 58056a40734ee2a64dca37f7669f77f2447f492c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 25 Oct 2024 11:42:58 -0700 Subject: [PATCH 1/2] [clang][deps] Improve timing output This patch adds the

[clang] [clang][deps] Improve timing output (PR #113726)

2024-10-28 Thread Jan Svoboda via cfe-commits
@@ -34,6 +34,7 @@ def deprecated_driver_command : F<"deprecated-driver-command", "use a single dri defm resource_dir_recipe : Eq<"resource-dir-recipe", "How to produce missing '-resource-dir' argument">; def print_timing : F<"print-timing", "Print timing information">; +def

[clang] [clang][modules] Optimize construction and usage of the submodule index (PR #113391)

2024-10-28 Thread Jorge Gorbe Moya via cfe-commits
@@ -541,11 +541,14 @@ class ModuleMap { /// /// \param IsExplicit Whether this is an explicit submodule. /// - /// \returns The found or newly-created module, along with a boolean value - /// that will be true if the module is newly-created. - std::pair findOrCreateMod

[clang-tools-extra] [clangd] [Modules] Use ASTReader directly in IsModuleFileUpToDate (PR #113879)

2024-10-28 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > if you think that's fine, i think we can always create that astreader > directly here, without a compilerinstance as well. I like the idea more. (so I typed 'updated too quickly') The most important reason I did the previous change is, I think the compiler invocation and

[clang] [Driver] Remove ignored Flag form of -fauto-profile/-fprofile-sample-use (PR #113528)

2024-10-28 Thread Mikołaj Piróg via cfe-commits
mikolaj-pirog wrote: Regarding the default filename extension, it doesn't have to be `.profdata` for `fprofile-sample-use`, it can be the `.afdo`, or any other extension deemed proper. `fprofile-sample-use` and `fprofile-use` would behave similarly then: they would look for a `default` file w

[clang] 1df5c94 - [AArch64] Implement FP8 floating-point mode helper intrinsics (#100608)

2024-10-28 Thread via cfe-commits
Author: Momchil Velikov Date: 2024-10-28T11:22:38Z New Revision: 1df5c943439b050dbc34e7a1c88c4d8ec90d26b5 URL: https://github.com/llvm/llvm-project/commit/1df5c943439b050dbc34e7a1c88c4d8ec90d26b5 DIFF: https://github.com/llvm/llvm-project/commit/1df5c943439b050dbc34e7a1c88c4d8ec90d26b5.diff LO

[clang] [AArch64] Implement FP8 floating-point mode helper intrinsics (PR #100608)

2024-10-28 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov closed https://github.com/llvm/llvm-project/pull/100608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f5ff3a5 - [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (#112496)

2024-10-28 Thread via cfe-commits
Author: Discookie Date: 2024-10-28T11:19:22Z New Revision: f5ff3a560fe247206814792a7f8efef8215f7689 URL: https://github.com/llvm/llvm-project/commit/f5ff3a560fe247206814792a7f8efef8215f7689 DIFF: https://github.com/llvm/llvm-project/commit/f5ff3a560fe247206814792a7f8efef8215f7689.diff LOG: [cl

[clang-tools-extra] [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (PR #112496)

2024-10-28 Thread via cfe-commits
https://github.com/Discookie closed https://github.com/llvm/llvm-project/pull/112496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (PR #112496)

2024-10-28 Thread via cfe-commits
Discookie wrote: Removed a leftover PrintingPolicy call before merging. https://github.com/llvm/llvm-project/pull/112496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-28 Thread kadir çetinkaya via cfe-commits
@@ -85,19 +85,20 @@ class PrerequisiteModules { /// different versions and different source files. class ModulesBuilder { public: - ModulesBuilder(const GlobalCompilationDatabase &CDB) : CDB(CDB) {} + ModulesBuilder() = default; + virtual ~ModulesBuilder() = default; Mo

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-28 Thread Simon Pilgrim via cfe-commits
@@ -705,66 +705,74 @@ float4 cosh(float4); #ifdef __HLSL_ENABLE_16_BIT _HLSL_AVAILABILITY(shadermodel, 6.2) -_HLSL_BUILTIN_ALIAS(__builtin_elementwise_popcount) -int16_t countbits(int16_t); +constexpr uint countbits(int16_t x) { + return __builtin_elementwise_popcount(x); ---

[clang-tools-extra] Extend call hierarchy for field and non-local variables (PR #113900)

2024-10-28 Thread via cfe-commits
https://github.com/timon-ul created https://github.com/llvm/llvm-project/pull/113900 None >From 96c759835b798b8f002adb4835db08b8de5da97a Mon Sep 17 00:00:00 2001 From: Timon Ulrich Date: Mon, 28 Oct 2024 11:03:10 +0100 Subject: [PATCH 1/2] Added call hierarchy for Field and non-local variables

[clang] [AArch64] Implement FP8 floating-point mode helper intrinsics (PR #100608)

2024-10-28 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/100608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet commented: thanks for the review @bricknerb, this is ready for next round https://github.com/llvm/llvm-project/pull/112517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [AArch64] Implement FP8 floating-point mode helper intrinsics (PR #100608)

2024-10-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-qemu` running on `sanitizer-buildbot4` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/139/builds/5486 Here is the relevant piece o

[clang] [clang][NFC] Add test for CWG issues about linkage in cross-TU context (PR #113736)

2024-10-28 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/113736 >From b23ce76d3db79eab6433bef1bd3fc9d26bcb3309 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Fri, 25 Oct 2024 23:05:06 +0300 Subject: [PATCH 1/5] [clang][NFC] Add test for CWG issues about linkage in

[clang] Remove optimization flags from clang codegen tests (PR #113714)

2024-10-28 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon edited https://github.com/llvm/llvm-project/pull/113714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Remove check::BranchCondition from debug.DumpTraversal (PR #113906)

2024-10-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Donát Nagy (NagyDonat) Changes This commit removes the `check::BranchCondition` callback of the debug checker `debug.DumpTraversal` (in `TraversalChecker.cpp`) and the single broken testcase that was referring to it. Th

[clang] [llvm] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental (PR #113826)

2024-10-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-windows` running on `premerge-windows-1` while building `clang,llvm` at step 8 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/3114

[clang] [clang][dataflow] Cache accessors returning pointers in bugprone-unchecked-optional-access (PR #113922)

2024-10-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Jan Voung (jvoung) Changes Previously, we covered returning refs, or copies of optional, and bools. Now cover returning pointers (to any type). This is useful for cases like operator-> of smart pointers. Addresses more of issue llv

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-28 Thread kadir çetinkaya via cfe-commits
@@ -85,19 +85,20 @@ class PrerequisiteModules { /// different versions and different source files. class ModulesBuilder { kadircet wrote: > I was told we don't like forward declaration in clangd Yes in theory this is also a forward declaration, but it's not in

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -477,6 +486,109 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -477,6 +485,100 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread kadir çetinkaya via cfe-commits
@@ -477,6 +485,100 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-10-28 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 7ea9d3dbb6ff74ca3f7f9b9a0c589e4a0a3366f2 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH 1/3] Add Clang attribute to ensure that fields are

[clang] [clang][dataflow] Cache accessors returning pointers in bugprone-unchecked-optional-access (PR #113922)

2024-10-28 Thread Jan Voung via cfe-commits
https://github.com/jvoung created https://github.com/llvm/llvm-project/pull/113922 Previously, we covered returning refs, or copies of optional, and bools. Now cover returning pointers (to any type). This is useful for cases like operator-> of smart pointers. Addresses more of issue llvm#58510

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-28 Thread Erich Keane via cfe-commits
@@ -407,7 +407,8 @@ def MicrosoftExt : LangOpt<"MicrosoftExt">; def Borland : LangOpt<"Borland">; def CUDA : LangOpt<"CUDA">; def HIP : LangOpt<"HIP">; -def SYCL : LangOpt<"SYCLIsDevice">; +def SYCLHost : LangOpt<"SYCLIsHost">; erichkeane wrote: Is the `Is` we

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -477,6 +486,109 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

[clang] [HLSL][SPIRV] Add convergence tokens to entry point wrapper (PR #112757)

2024-10-28 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts approved this pull request. https://github.com/llvm/llvm-project/pull/112757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/111389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/111391 >From 54ee2e5d83a940b113f0fc326c511322605bfb78 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Tue, 15 Oct 2024 09:48:09 + Subject: [PATCH 1/3] [clang][LLVM Demangler] Add a diagnostic that validates

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
@@ -1967,6 +1967,10 @@ def fclang_abi_compat_EQ : Joined<["-"], "fclang-abi-compat=">, Group, MetaVarName<"">, Values<".,latest">, HelpText<"Attempt to match the ABI of Clang ">; +def fdemangling_failures: Flag<["-"], "fdemangling-failures">, Group, VitaNu

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
@@ -462,6 +462,9 @@ ENUM_CODEGENOPT(ZeroCallUsedRegs, llvm::ZeroCallUsedRegs::ZeroCallUsedRegsKind, /// non-deleting destructors. (No effect on Microsoft ABI.) CODEGENOPT(CtorDtorReturnThis, 1, 0) +/// Whether to issue a diagnostic if a produced mangled name can not be deman

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb edited https://github.com/llvm/llvm-project/pull/112517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-28 Thread Aaron Ballman via cfe-commits
@@ -795,6 +795,10 @@ def warn_cstruct_memaccess : Warning< "%1 call is a pointer to record %2 that is not trivial to " "%select{primitive-default-initialize|primitive-copy}3">, InGroup; +def warn_cxxstruct_memaccess : Warning< + "%select{destination for|source of|first o

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
@@ -41,7 +41,9 @@ #include "clang/Basic/CharInfo.h" #include "clang/Basic/CodeGenOptions.h" #include "clang/Basic/Diagnostic.h" +#include "clang/Basic/DiagnosticFrontend.h" VitaNuo wrote: Sorry, most of those are a result of multiple iterations of this patch.

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
@@ -384,4 +384,8 @@ def warn_hlsl_langstd_minimal : Warning<"support for HLSL language version %0 is incomplete, " "recommend using %1 instead">, InGroup; + +def warn_name_cannot_be_demangled : Warning< + "cannot demangle the name '%0'">, + InGroup;

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
@@ -1967,6 +1967,10 @@ def fclang_abi_compat_EQ : Joined<["-"], "fclang-abi-compat=">, Group, MetaVarName<"">, Values<".,latest">, HelpText<"Attempt to match the ABI of Clang ">; +def fno_demangling_failures: Flag<["-"], "fno-demangling-failures">, Group,

[clang] [llvm] [RISCV] Add the Sha extension (PR #113820)

2024-10-28 Thread Sam Elliott via cfe-commits
lenary wrote: > I haven't made it so if you enable all extensions that constitute Sha, Sha is > implied. Great! I think it's most clear if we have "extensions only require things they are made up of" (i.e. all the implications/requirements point to earlier/lesser extensions) and "profiles are

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo edited https://github.com/llvm/llvm-project/pull/111391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo edited https://github.com/llvm/llvm-project/pull/111391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
VitaNuo wrote: > Close for me, jsut a couple of small requests. > > Thanks for your patience on this response, I've been at LLVMDev all week. Thanks Erich for the approval. I will publish an RFC for this in the coming days as well, still gathering some data from test runs. https://github.com

[clang] [libcxx] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-28 Thread Aaron Ballman via cfe-commits
@@ -102,7 +102,7 @@ struct __aliasing_iterator_wrapper { _LIBCPP_HIDE_FROM_ABI _Alias operator*() const _NOEXCEPT { _Alias __val; - __builtin_memcpy(&__val, std::__to_address(__base_), sizeof(value_type)); + __builtin_memcpy(&__val, static_cast(std::__to_ad

[clang] [LinkerWrapper] Remove in-house handling of LTO (PR #113715)

2024-10-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/113715 >From 8042f288085188695b220460551b71a503e6cfa1 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 25 Oct 2024 12:23:15 -0500 Subject: [PATCH] [LinkerWrapper] Remove in-house handling of LTO Summary: This sh

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Erich Keane via cfe-commits
@@ -462,6 +462,9 @@ ENUM_CODEGENOPT(ZeroCallUsedRegs, llvm::ZeroCallUsedRegs::ZeroCallUsedRegsKind, /// non-deleting destructors. (No effect on Microsoft ABI.) CODEGENOPT(CtorDtorReturnThis, 1, 0) +/// Whether to validate if a produced mangled name can be demangled with LLVM

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Erich Keane via cfe-commits
@@ -41,7 +41,9 @@ #include "clang/Basic/CharInfo.h" #include "clang/Basic/CodeGenOptions.h" #include "clang/Basic/Diagnostic.h" +#include "clang/Basic/DiagnosticFrontend.h" erichkeane wrote: Ok,just the 1 is fine then. https://github.com/llvm/llvm-project/pul

[clang] [llvm] [Clang] Put offloading globals in the `.llvm.rodata.offloading` section (PR #111890)

2024-10-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add a flag to include GPU startup files (PR #112025)

2024-10-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/112025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -477,6 +485,100 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-10-28 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > We still want the final OK from Aaron, but he's at 35k feet right now on the > way back from LLVM-Dev, so hopefully he'll have time to do a pass next week. I'm back in the office now and digging out from under last week. I plan to call consensus (for or against) on the RF

[clang] [flang] Revert "[flang] Integrate the option -flang-experimental-integer-overflow into -fno-wrapv" (PR #113901)

2024-10-28 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/113901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] Revert "[flang] Integrate the option -flang-experimental-integer-overflow into -fno-wrapv" (PR #113901)

2024-10-28 Thread Tom Eccles via cfe-commits
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/113901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bd6ab32 - Revert "[flang] Integrate the option -flang-experimental-integer-overflow into -fno-wrapv" (#113901)

2024-10-28 Thread via cfe-commits
Author: Yusuke MINATO Date: 2024-10-28T14:19:20Z New Revision: bd6ab32e6eb642f2b0b15be8c7c2a668192f07d8 URL: https://github.com/llvm/llvm-project/commit/bd6ab32e6eb642f2b0b15be8c7c2a668192f07d8 DIFF: https://github.com/llvm/llvm-project/commit/bd6ab32e6eb642f2b0b15be8c7c2a668192f07d8.diff LOG:

[clang] 1f6741c - [clang][dataflow] Don't clear cached field state if field is const (#113698)

2024-10-28 Thread via cfe-commits
Author: Jan Voung Date: 2024-10-28T10:28:02-04:00 New Revision: 1f6741c1645954b1f4b2fbca470a20081f5e75af URL: https://github.com/llvm/llvm-project/commit/1f6741c1645954b1f4b2fbca470a20081f5e75af DIFF: https://github.com/llvm/llvm-project/commit/1f6741c1645954b1f4b2fbca470a20081f5e75af.diff LOG

[clang] [clang][dataflow] Don't clear cached field state if field is const (PR #113698)

2024-10-28 Thread Jan Voung via cfe-commits
https://github.com/jvoung closed https://github.com/llvm/llvm-project/pull/113698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -477,6 +485,100 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { bricknerb wrote: Do we need to keep all implementation deta

[clang] [llvm] [RISCV] Add the Sha extension (PR #113820)

2024-10-28 Thread Alex Bradbury via cfe-commits
asb wrote: > > I haven't made it so if you enable all extensions that constitute Sha, Sha > > is implied. > > Great! I think it's most clear if we have "extensions only require things > they are made up of" (i.e. all the implications/requirements point to > earlier/lesser extensions) and "pro

[clang] [HLSL][SPIRV] Add convergence tokens to entry point wrapper (PR #112757)

2024-10-28 Thread Steven Perron via cfe-commits
@@ -0,0 +1,11 @@ +// RUN: %clang_cc1 -triple spirv-pc-vulkan-compute -finclude-default-header -fnative-half-type -disable-llvm-passes -emit-llvm -o - %s | FileCheck %s s-perron wrote: I copied from another test. I have removed it. https://github.com/llvm/llvm-p

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
@@ -41,7 +41,9 @@ #include "clang/Basic/CharInfo.h" #include "clang/Basic/CodeGenOptions.h" #include "clang/Basic/Diagnostic.h" +#include "clang/Basic/DiagnosticFrontend.h" VitaNuo wrote: Thanks! https://github.com/llvm/llvm-project/pull/111391 __

[clang] [HLSL][SPIRV] Add convergence tokens to entry point wrapper (PR #112757)

2024-10-28 Thread Steven Perron via cfe-commits
@@ -469,14 +479,22 @@ void CGHLSLRuntime::generateGlobalCtorDtorCalls() { for (auto &F : M.functions()) { if (!F.hasFnAttribute("hlsl.shader")) continue; -IRBuilder<> B(&F.getEntryBlock(), F.getEntryBlock().begin()); +auto *Token = getConvergenceToken(F.getE

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -477,6 +485,100 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -575,25 +575,42 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, DiagID != diag::fatal_too_many_errors && Diag.FatalsAsError) Result = diag::Severity::Error; + // Rest of the mappings are only applicable for diagnostics associated wit

[clang] [HLSL][SPIRV] Add convergence tokens to entry point wrapper (PR #112757)

2024-10-28 Thread Steven Perron via cfe-commits
https://github.com/s-perron updated https://github.com/llvm/llvm-project/pull/112757 >From 24e84865fe8cd9684c6e5b2763970ba278038039 Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Wed, 16 Oct 2024 13:20:29 -0400 Subject: [PATCH 1/6] [HLSL][SPIRV] Add convergence tokens to entry point wrappe

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] [RISCV] Mark RVB23U64 and RVB23S64 as non-experimental (PR #113918)

2024-10-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Bradbury (asb) Changes The specification was recently ratified ;. --- Full diff: https://github.com/llvm/llvm-project/pull/113918.diff 7 Files Affected: - (m

[clang] [llvm] [RISCV] Mark RVB23U64 and RVB23S64 as non-experimental (PR #113918)

2024-10-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Alex Bradbury (asb) Changes The specification was recently ratified ;. --- Full diff: https://github.com/llvm/llvm-project/pull/113918.diff 7 Files Affected

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -41,8 +46,10 @@ static void EmitUnknownDiagWarning(DiagnosticsEngine &Diags, << (Prefix.str() += std::string(Suggestion)); } + bricknerb wrote: Remove extra blank line? https://github.com/llvm/llvm-project/pull/112517 ___

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -575,25 +575,42 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, DiagID != diag::fatal_too_many_errors && Diag.FatalsAsError) Result = diag::Severity::Error; + // Rest of the mappings are only applicable for diagnostics associated wit

[clang] [clang][NFC] Add test for CWG issues about linkage in cross-TU context (PR #113736)

2024-10-28 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/113736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][LLVM Demangler] Add a diagnostic that validates that all mang… (PR #111391)

2024-10-28 Thread Viktoriia Bakalova via cfe-commits
@@ -462,6 +462,9 @@ ENUM_CODEGENOPT(ZeroCallUsedRegs, llvm::ZeroCallUsedRegs::ZeroCallUsedRegsKind, /// non-deleting destructors. (No effect on Microsoft ABI.) CODEGENOPT(CtorDtorReturnThis, 1, 0) +/// Whether to validate if a produced mangled name can be demangled with LLVM

[clang] [X86] Don't allow '+f' as an inline asm constraint. (PR #113871)

2024-10-28 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. https://github.com/llvm/llvm-project/pull/113871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Add test for CWG issues about linkage in cross-TU context (PR #113736)

2024-10-28 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/113736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d83485a - [clang][NFC] Add test for CWG issues about linkage in cross-TU context (#113736)

2024-10-28 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-10-28T18:48:23+04:00 New Revision: d83485a080341688cbb9d5c07a3839bd97f9001e URL: https://github.com/llvm/llvm-project/commit/d83485a080341688cbb9d5c07a3839bd97f9001e DIFF: https://github.com/llvm/llvm-project/commit/d83485a080341688cbb9d5c07a3839bd97f9001e.

[clang] [clang][NFC] Add test for CWG issues about linkage in cross-TU context (PR #113736)

2024-10-28 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/113736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-28 Thread Boaz Brickner via cfe-commits
@@ -477,6 +486,109 @@ void DiagnosticsEngine::setSeverityForAll(diag::Flavor Flavor, setSeverity(Diag, Map, Loc); } +namespace { +class WarningsSpecialCaseList : public llvm::SpecialCaseList { +public: + static std::unique_ptr + create(const llvm::MemoryBuffer &MB, st

<    1   2   3   4   5   6   >