[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-18 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Ping https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Joshua Batista via cfe-commits
@@ -483,10 +573,103 @@ static BuiltinTypeDeclBuilder setupBufferType(CXXRecordDecl *Decl, Sema &S, .addDefaultHandleConstructor(S, RC); } +BinaryOperator *getSizeOfLEQ16Expr(clang::ASTContext &context, + SourceLocation NameLoc, +

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 76196998e25b98d81abc437708622261810782ca ab7c20059e5fafd33624ed166e747ee473248551 --e

[clang] [clang-format] Fix a bug that always returns error for JSON (PR #112839)

2024-10-18 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/112839 >From 9eb81c845aa102e28c87eeefe82fac3f029ae29e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 17 Oct 2024 21:52:16 -0700 Subject: [PATCH 1/3] [clang-format] Fix a bug that always returns error for JSON Fixe

[clang] Remove support for RenderScript (PR #112916)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Aaron Ballman (AaronBallman) Changes See https://discourse.llvm.org/t/rfc-deprecate-and-eventually-remove-renderscript-support/81284 for the RFC --- Patch is 33.64 KiB, truncated to 20.00 KiB below, full version: https://gith

[clang] Remove support for RenderScript (PR #112916)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-backend-arm Author: Aaron Ballman (AaronBallman) Changes See https://discourse.llvm.org/t/rfc-deprecate-and-eventually-remove-renderscript-support/81284 for the RFC --- Patch is 33.64 K

[clang] [llvm] [mlir] [LLVM][TableGen] Change all `Init` pointers to const (PR #112705)

2024-10-18 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/112705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove support for RenderScript (PR #112916)

2024-10-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/112916 See https://discourse.llvm.org/t/rfc-deprecate-and-eventually-remove-renderscript-support/81284 for the RFC >From bb479e3a3d3b5181495fa5dc61ec61cb61b59b46 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Dat

[clang] [llvm] [mlir] [LLVM][TableGen] Change all `Init` pointers to const (PR #112705)

2024-10-18 Thread Rahul Joshi via cfe-commits
@@ -551,18 +552,18 @@ std::string BitsInit::getAsString() const { // resolveReferences - If there are any field references that refer to fields // that have been filled in, we can propagate the values now. -Init *BitsInit::resolveReferences(Resolver &R) const { +const Init *Bi

[clang] 922992a - Fix typo "instrinsic" (#112899)

2024-10-18 Thread via cfe-commits
Author: Jay Foad Date: 2024-10-18T15:58:33+01:00 New Revision: 922992a22f7c87c192cf96606038df3cf20d6404 URL: https://github.com/llvm/llvm-project/commit/922992a22f7c87c192cf96606038df3cf20d6404 DIFF: https://github.com/llvm/llvm-project/commit/922992a22f7c87c192cf96606038df3cf20d6404.diff LOG:

[clang] [NFC][Clang] Fix enumerated mismatch warning (PR #112816)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816 >From 3eabcb305e4c666b897a084615e4d53fc8052020 Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 05:03:22 +0200 Subject: [PATCH 1/3] [NFC][Clang] Fix enumerated mismatch warning MIME-Version: 1.0 Cont

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/112899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Fix enumerated mismatch warning (PR #112816)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816 >From 3eabcb305e4c666b897a084615e4d53fc8052020 Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 05:03:22 +0200 Subject: [PATCH 1/4] [NFC][Clang] Fix enumerated mismatch warning MIME-Version: 1.0 Cont

[clang] [NFC] add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Fix whatever clang-format hates about this, and please add a detailed comment explaining why we are doing this, else LGTM. https://github.com/llvm/llvm-project/pull/112820 ___ cfe-commits maili

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-18 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue updated https://github.com/llvm/llvm-project/pull/112580 >From d8ac47d27ad860a8b11424621ab88cd9267cf866 Mon Sep 17 00:00:00 2001 From: Benjamin Maxwell Date: Wed, 2 Oct 2024 10:28:29 + Subject: [PATCH 1/6] [clang] Make -fveclib={ArmPL,SLEEF} imply -fno-math-errno

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -18957,6 +18957,134 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -18957,6 +18957,134 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-18 Thread Krystian Stasiowski via cfe-commits
@@ -501,6 +519,89 @@ bool Sema::CheckEquivalentExceptionSpec( return Result; } +static const Expr *SubstituteExceptionSpecWithoutEvaluation( +Sema &S, const Sema::TemplateCompareNewDeclInfo &DeclInfo, +const Expr *ExceptionSpec) { + MultiLevelTemplateArgumentList ML

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-18 Thread Richard Smith via cfe-commits
zygoloid wrote: > But yes, the short answer is that the code as written should work on Morello > and CHERI-RISC-V. Great, thanks. > > > The std::launder may be unnecessary > > > > > > Formally I think it's correct and necessary for the pointer and integer > > case because an array element a

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112814 >From d37014d8da13a3de36a7aaa0ed9a6f72c72d155d Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 04:56:17 +0200 Subject: [PATCH 1/2] [NFC] Fix c++ style comment in c file This is one of the many PRs

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-18 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue updated https://github.com/llvm/llvm-project/pull/112580 >From e59c67a0fb40f1a0de96a626bf4f4fa9291436ec Mon Sep 17 00:00:00 2001 From: Benjamin Maxwell Date: Wed, 2 Oct 2024 10:28:29 + Subject: [PATCH 1/6] [clang] Make -fveclib={ArmPL,SLEEF} imply -fno-math-errno

[clang] [analyzer] Add alpha.cplusplus.BoundsInformation checker (PR #112784)

2024-10-18 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: > but not to replace it And it doesn't necessarily need it in the first place! I think it's most likely going to be useful as a standalone checker even when you never needed `-Wunsafe-buffer-usage`. It's a bit coding-convention-y: roughly on the same level of "speculative" as t

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello closed https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
farzonl wrote: PR looks good. CGBuiltin.cpp were minor fix requests. If we are going to revisit the DXILOpLowering.cpp I'd like to see an issue number to track the work. https://github.com/llvm/llvm-project/pull/109331 ___ cfe-commits mailing list c

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-18 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/111561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-18 Thread Matheus Izvekov via cfe-commits
@@ -314,6 +316,22 @@ bool Sema::CheckEquivalentExceptionSpec(FunctionDecl *Old, FunctionDecl *New) { return false; } + if (Old->getExceptionSpecType() == EST_DependentNoexcept && + New->getExceptionSpecType() == EST_DependentNoexcept) { +const auto *OldType =

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-18 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/111561 >From dd1095566251508aae4009a626774413eb8dc7a1 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 8 Oct 2024 12:54:26 -0400 Subject: [PATCH 1/4] [Clang][Sema] Fix exception specification comparison

[clang] [NFC] add DiagnosticsTestHelper decl (PR #112820)

2024-10-18 Thread Jinsong Ji via cfe-commits
jsji wrote: CI failures are irrelvant. https://github.com/llvm/llvm-project/pull/112820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9120ade - Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (#112767)

2024-10-18 Thread via cfe-commits
Author: Daniel Paoliello Date: 2024-10-18T10:19:48-07:00 New Revision: 9120adea504981dfd55ace25825f84018543d6f2 URL: https://github.com/llvm/llvm-project/commit/9120adea504981dfd55ace25825f84018543d6f2 DIFF: https://github.com/llvm/llvm-project/commit/9120adea504981dfd55ace25825f84018543d6f2.di

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Damyan Pepper via cfe-commits
@@ -483,10 +573,103 @@ static BuiltinTypeDeclBuilder setupBufferType(CXXRecordDecl *Decl, Sema &S, .addDefaultHandleConstructor(S, RC); } +BinaryOperator *getSizeOfLEQ16Expr(clang::ASTContext &context, + SourceLocation NameLoc, +

[clang] [NFC][Sema][OpenMP] Fix free-nonheap-object warning (PR #112942)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji created https://github.com/llvm/llvm-project/pull/112942 This is one of the many PRs to fix errors with LLVM_ENABLE_WERROR=on. Built by GCC 11. Fix warning In destructor ‘llvm::APInt::~APInt()’, inlined from ‘llvm::APInt::~APInt()’ at llvm-project/llvm/include/llvm

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/109331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -0,0 +1,50 @@ +; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} + +; Make sure lowering is correctly generating spirv code. ---

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -18952,6 +18955,142 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -0,0 +1,50 @@ +; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} + +; Make sure lowering is correctly generating spirv code. ---

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Tex Riddell via cfe-commits
@@ -1698,18 +1698,27 @@ static bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { return true; } -static bool CheckArgsTypesAreCorrect( +bool CheckArgTypeIsIncorrect( tex3d wrote: This switches the naming pattern from the existing convention. W

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-18 Thread Erich Keane via cfe-commits
erichkeane wrote: > @erichkeane, I think I have addressed or replied to all of your comments. > Another round of review feedback would be much appreciated! > > @bader, as SYCL code maintainer, I would appreciate if you can take a look. I didnt get a chance to get back to this during the week,

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

2024-10-18 Thread Matt Arsenault via cfe-commits
@@ -337,9 +337,12 @@ void AMDGPUTargetInfo::getTargetDefines(const LangOptions &Opts, if (hasFastFMA()) Builder.defineMacro("FP_FAST_FMA"); - Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize)); - // ToDo: deprecate this macro for naming consistency

[clang] [Clang][HIP] Deprecate the AMDGCN_WAVEFRONT_SIZE macros (PR #112849)

2024-10-18 Thread Matt Arsenault via cfe-commits
@@ -26,8 +27,14 @@ class MacroBuilder { MacroBuilder(raw_ostream &Output) : Out(Output) {} /// Append a \#define line for macro of the form "\#define Name Value\n". - void defineMacro(const Twine &Name, const Twine &Value = "1") { + /// If DeprecationMsg is provided, als

[clang] [llvm] [RISCV] Inline Assembly Support for GPR Pairs ('Pr') (PR #112983)

2024-10-18 Thread Sam Elliott via cfe-commits
https://github.com/lenary created https://github.com/llvm/llvm-project/pull/112983 I wanted to push up this draft, to check that I was going a reasonable direction with this work. It's still at an early stage. I tried just adding the double-wide VTs to the GPRPair register class, but that cau

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-spir-v Author: Finn Plummer (inbelic) Changes ``` - add clang builtin to Builtins.td - link builtin in hlsl_intrinsics - add codegen for spirv intrinsic and two directx intrinsics to retain signedness information of the operands in CGBu

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Finn Plummer (inbelic) Changes ``` - add clang builtin to Builtins.td - link builtin in hlsl_intrinsics - add codegen for spirv intrinsic and two directx intrinsics to retain signedness information of the operands in CGBuiltin.cpp

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic ready_for_review https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Finn Plummer (inbelic) Changes ``` - add clang builtin to Builtins.td - link builtin in hlsl_intrinsics - add codegen for spirv intrinsic and two directx intrinsics to retain signedness information of the operands in CGBuiltin.cpp

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Finn Plummer (inbelic) Changes ``` - add clang builtin to Builtins.td - link builtin in hlsl_intrinsics - add codegen for spirv intrinsic and two directx intrinsics to retain signedness information of the operands in CGBuilt

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 closed https://github.com/llvm/llvm-project/pull/112927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-18 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/112400 >From 0bdb522d97752859b0b09c3ba7c815865b87 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Fri, 18 Oct 2024 10:49:18 -0700 Subject: [PATCH 1/2] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic - add cl

[clang] 416731b - [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (#111712)

2024-10-18 Thread via cfe-commits
Author: Joseph Huber Date: 2024-10-18T17:32:23-05:00 New Revision: 416731bf7fe4c44437765a467267a9cdff75bfcf URL: https://github.com/llvm/llvm-project/commit/416731bf7fe4c44437765a467267a9cdff75bfcf DIFF: https://github.com/llvm/llvm-project/commit/416731bf7fe4c44437765a467267a9cdff75bfcf.diff

[clang] [clang][modules] Timestamp PCM files when writing (PR #112452)

2024-10-18 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: > > Have you checked the performance for incremental builds? > > I haven't, since I believe this change doesn't affect incremental builds at > all. Fair enough. I was thinking that you can achieve the same improvement by using some contentionless-update-mtime function. But I ha

[clang] [NvlinkWrapper] Use `-plugin-opt=mattr=` instead of a custom feature (PR #111712)

2024-10-18 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/111712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-18 Thread Tom Honermann via cfe-commits
tahonermann wrote: @erichkeane, I think I have addressed or replied to all of your comments. Another round of review feedback would be much appreciated! @bader, as SYCL code maintainer, I would appreciate if you can take a look. https://github.com/llvm/llvm-project/pull/111389

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-18 Thread Oleksandr T. via cfe-commits
@@ -9827,6 +9827,9 @@ static IntRange GetExprRange(ASTContext &C, const Expr *E, unsigned MaxWidth, return IntRange(BitField->getBitWidthValue(C), BitField->getType()->isUnsignedIntegerOrEnumerationType()); + if (GetExprType(E)->isVoidType()) +ret

[clang] [Clang] Provide default value for -fprofile-sample-use, -fprofile-auto (PR #112750)

2024-10-18 Thread Mikołaj Piróg via cfe-commits
mikolaj-pirog wrote: Pinging @MaskRay for review, I can't add reviewers in the dedicated gh section yet https://github.com/llvm/llvm-project/pull/112750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-18 Thread Joshua Batista via cfe-commits
@@ -1,64 +1,64 @@ -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump -DEMPTY %s | FileCheck -check-prefix=EMPTY %s bob80905 wrote: Fixed! https://github.com/llvm/llvm-project/pull/112600 ___

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveMax` intrinsic (PR #112991)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/112991 >From b18e40978cae2c0d9ba9aeb61cf7294809b75012 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Fri, 18 Oct 2024 14:41:57 -0700 Subject: [PATCH 1/2] [HLSL][SPIRV] Implement `WaveActiveMax` intrinsic - add cl

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112081 >From 67c41612085489a2a17eec49f98dbfa0e5bb97cf Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sat, 12 Oct 2024 08:27:51 +0300 Subject: [PATCH 1/2] [Clang] fix range calculation for conditionals with throw

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveMax` intrinsic (PR #112991)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic created https://github.com/llvm/llvm-project/pull/112991 - add clang builtin to Builtins.td - link builtin in hlsl_intrinsics - add codegen for spirv intrinsic and two directx intrinsics to retain signedness information of the operands in CGBuiltin.cpp - add s

[clang] [llvm] [llvm][NVPTX] Strip unneeded '+0' in PTX load/store (PR #113017)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-nvptx Author: Youngsuk Kim (JOE1994) Changes Remove the extraneous '+0' immediate offset part in PTX load/stores, to improve readability of output PTX code. --- Patch is 474.34 KiB, truncated to 20.00 KiB below, full version: https://github.c

[clang] [llvm] [llvm][NVPTX] Strip unneeded '+0' in PTX load/store (PR #113017)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Youngsuk Kim (JOE1994) Changes Remove the extraneous '+0' immediate offset part in PTX load/stores, to improve readability of output PTX code. --- Patch is 474.34 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/

[clang] [Clang][perf-training] Do build of libLLVMSupport for perf training (PR #111625)

2024-10-18 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. LGTM. Adding this to the default perf training I think makes quite a bit of sense given the numbers reported. Not sure what thoughts others have on that though. https://github.com/llvm/llvm-project/pull/111625 __

[clang] Draft (PR #113020)

2024-10-18 Thread via cfe-commits
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/113020 None >From 93c625ad60fc834e72df667addc6eec83247fc8c Mon Sep 17 00:00:00 2001 From: c8ef Date: Sat, 19 Oct 2024 03:45:17 + Subject: [PATCH] constexpr fma --- clang/docs/ReleaseNotes.rst | 1

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-18 Thread Oleksandr T. via cfe-commits
@@ -39,7 +39,8 @@ bool Sema::SetMemberAccessSpecifier(NamedDecl *MemberDecl, AccessSpecifier LexicalAS) { if (!PrevMemberDecl) { // Use the lexical access specifier. -MemberDecl->setAccess(LexicalAS); a-tarasyuk wro

[clang] [analyzer][Solver][NFC] Cleanup const-correctness inside range-based solver (PR #112891)

2024-10-18 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/112891 None >From e380dd4572c8914fbd87a812e74addba1f24304d Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 16 Oct 2024 15:53:20 +0200 Subject: [PATCH 1/2] [analyzer][Solver] Teach SymbolicRangeInferrer about

[clang] [analyzer][Solver] Improve getSymVal and friends (1/2) (PR #112583)

2024-10-18 Thread Balazs Benics via cfe-commits
@@ -2883,22 +2883,16 @@ const llvm::APSInt *RangeConstraintManager::getSymVal(ProgramStateRef St, const llvm::APSInt *RangeConstraintManager::getSymMinVal(ProgramStateRef St, SymbolRef Sym) const { - // TODO: Use `getR

[clang] [Clang] prevent assertion failure in value-dependent initializer expressions (PR #112612)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112612 >From 6112d12f757cce0214132e9201dc2a434e40e0c7 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 16 Oct 2024 23:42:05 +0300 Subject: [PATCH 1/2] [Clang] prevent assertion failure in value-dependent initi

[clang] [Clang] Provide default value for -fprofile-sample-use, -fprofile-auto (PR #112750)

2024-10-18 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog converted_to_draft https://github.com/llvm/llvm-project/pull/112750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-18 Thread Carlos Galvez via cfe-commits
@@ -102,7 +102,7 @@ struct __aliasing_iterator_wrapper { _LIBCPP_HIDE_FROM_ABI _Alias operator*() const _NOEXCEPT { _Alias __val; - __builtin_memcpy(&__val, std::__to_address(__base_), sizeof(value_type)); + __builtin_memcpy(&__val, static_cast(std::__to_ad

[clang] [flang] [lldb] [llvm] [mlir] Fix typo "instrinsic" (PR #112899)

2024-10-18 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. cute typo :) https://github.com/llvm/llvm-project/pull/112899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Handle uninitialized type constraints (PR #110496)

2024-10-18 Thread via cfe-commits
vient wrote: Bump, it would be nice to have this or that fix backported to 19.x https://github.com/llvm/llvm-project/pull/110496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" abhina-sree wrote: Inside that header we guard the C++ code inside an `#ifdef __cplusplus` so it should work

[clang] [NFC][Clang] Fix enumerated mismatch warning (PR #112816)

2024-10-18 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/112816 >From 3eabcb305e4c666b897a084615e4d53fc8052020 Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Fri, 18 Oct 2024 05:03:22 +0200 Subject: [PATCH 1/2] [NFC][Clang] Fix enumerated mismatch warning MIME-Version: 1.0 Cont

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-18 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: This breaks a number of tests on Windows. Previously, to have tests working on Windows, one would do `git config --global core.autocrlf false` or similar, before checking out llvm-project - a number of test input files _need_ to be in LF form to work. This was brought up earlie

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/112424 >From a22c6bae4f42f42e67f8e0c2b1f914e50d140099 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 15 Oct 2024 22:43:24 +0300 Subject: [PATCH 1/2] [Clang] prevent setting default lexical access specifier f

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][Solver] Teach SymbolicRangeInferrer about commutativity (2/2) (PR #112887)

2024-10-18 Thread Balazs Benics via cfe-commits
steakhal wrote: This was already reviewed in the linked PR. I just need a separate PR to merge multiple commits, as rebase-merges are not allowed on llvm. https://github.com/llvm/llvm-project/pull/112887 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-18 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: > > > > #112806 should address this without narrowing the field to 32 bits. > > > > > > > > > As does [#111995 > > > (comment)](https://github.com/llvm/llvm-project/pull/111995#discussion_r1805329590), > > > with less code and more generality > > > > > > I prefer this solution

[clang] [Clang] Provide default value for -fprofile-sample-use, -fprofile-auto (PR #112750)

2024-10-18 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog updated https://github.com/llvm/llvm-project/pull/112750 From 642f7ac9b1e999d8adb690b67c6303139794379d Mon Sep 17 00:00:00 2001 From: "Pirog, Mikolaj Maciej" Date: Thu, 17 Oct 2024 10:17:09 -0700 Subject: [PATCH 1/2] Provide default value for -fprofile-sample-us

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-18 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/112081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-18 Thread Momchil Velikov via cfe-commits
@@ -533,11 +638,158 @@ bool AArch64ABIInfo::isZeroLengthBitfieldPermittedInHomogeneousAggregate() return true; } +// Check if a type is a Pure Scalable Type as defined by AAPCS64. Return the +// number of data vectors and the number of predicate vectors in the types, into

[clang] [compiler-rt] Reapply " [XRay] Add support for instrumentation of DSOs on x86_64 (#90959)" (PR #112930)

2024-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Sebastian Kreutzer (sebastiankreutzer) Changes This fixes remaining issues in my previous PR #90959. Changes: - Removed dependency on LLVM header in `xray_interface.cpp` - Fixed XRay patching for some targets due to missing changes

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-18 Thread Benjamin Maxwell via cfe-commits
@@ -502,6 +502,10 @@ def err_sls_hardening_arm_not_supported : Error< def warn_drv_large_data_threshold_invalid_code_model: Warning< "'%0' only applies to medium and large code models">, InGroup; +def warn_drv_math_errno_reenabled_after_veclib: Warning< + "math errno re-en

[clang] [clang] Make LazyOffsetPtr more portable (PR #112927)

2024-10-18 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 created https://github.com/llvm/llvm-project/pull/112927 LazyOffsetPtr currently relies on uint64_t being able to store a pointer and, unless sizeof(uint64_t) == sizeof(void *), little endianness, since getAddressOfPointer reinterprets the memory as a pointer. This also

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -18957,6 +18957,134 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Daniel Paoliello via cfe-commits
@@ -102,6 +102,7 @@ static ResourceClass getResourceClass(RegisterType RT) { return ResourceClass::Sampler; case RegisterType::C: case RegisterType::I: + default: llvm_unreachable("unexpected RegisterType value"); } dpaoliello wrote: > It soun

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-18 Thread Sebastian Kreutzer via cfe-commits
sebastiankreutzer wrote: Buildbot failures are addressed in the follow-up PR #112930 https://github.com/llvm/llvm-project/pull/90959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Reapply " [XRay] Add support for instrumentation of DSOs on x86_64 (#90959)" (PR #112930)

2024-10-18 Thread Sebastian Kreutzer via cfe-commits
sebastiankreutzer wrote: @jplehr https://github.com/llvm/llvm-project/pull/112930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Reapply " [XRay] Add support for instrumentation of DSOs on x86_64 (#90959)" (PR #112930)

2024-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dbe47c2a06e0928edde802d062ecf1a0ce45fbb9 90aa32cfaac5274d7f1604baa4d5316401385f4c --e

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Aaron Ballman via cfe-commits
@@ -102,6 +102,7 @@ static ResourceClass getResourceClass(RegisterType RT) { return ResourceClass::Sampler; case RegisterType::C: case RegisterType::I: + default: llvm_unreachable("unexpected RegisterType value"); } AaronBallman wrote: > As a

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Farzon Lotfi via cfe-commits
@@ -102,6 +102,7 @@ static ResourceClass getResourceClass(RegisterType RT) { return ResourceClass::Sampler; case RegisterType::C: case RegisterType::I: + default: llvm_unreachable("unexpected RegisterType value"); } farzonl wrote: I'm fine wit

[clang] [Clang] Don't assert on substituted-but-yet-expanded packs for nested lambdas (PR #112896)

2024-10-18 Thread via cfe-commits
@@ -94,3 +94,45 @@ template void g2(Ts... p1s) { void f1() { g(); } } // namespace GH61460 + +namespace GH112352 { + +template +constexpr bool foo = false; + +template +constexpr bool bar = false; + +template class> +constexpr bool baz = false; + +struct S { + template v

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't assert on substituted-but-yet-expanded packs for nested lambdas (PR #112896)

2024-10-18 Thread via cfe-commits
@@ -8385,14 +8385,19 @@ TreeTransform::TransformDeclStmt(DeclStmt *S) { if (Transformed != D) DeclChanged = true; -if (LSI && isa(Transformed)) - LSI->ContainsUnexpandedParameterPack |= - getSema() - .getASTContext() - .get

[clang] [Clang] Don't assert on substituted-but-yet-expanded packs for nested lambdas (PR #112896)

2024-10-18 Thread via cfe-commits
@@ -94,3 +94,45 @@ template void g2(Ts... p1s) { void f1() { g(); } } // namespace GH61460 + +namespace GH112352 { + +template +constexpr bool foo = false; + +template +constexpr bool bar = false; + +template class> +constexpr bool baz = false; + +struct S { + template v

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-18 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/112767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of immediate escalation for inherited constructors (PR #112860)

2024-10-18 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Consider the following testcase: ``` struct ConstEval { consteval ConstEval(int) {} }; struct SimpleCtor { constexpr SimpleCtor(int) {}}; struct TemplateCtor { template constexpr TemplateCtor (int arg) {} }; struct ConstEvalMember1 : SimpleCtor { int y = 10; C

[clang] [llvm] [HLSL] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/112400 >From aa2ae997f66bf6cd43fc36cbe69c6731914ce9f0 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Fri, 18 Oct 2024 10:49:18 -0700 Subject: [PATCH] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic - add clang

[clang] [llvm] [HLSL][SPIRV] Implement `WaveActiveSum` intrinsic (PR #112400)

2024-10-18 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/112400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >