[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Jack Styles via cfe-commits
Stylie777 wrote: It might be worth splitting each feature into its own commit rather than one big commit, it makes the review easier. Currently it's difficult to determine which section belongs to which feature. https://github.com/llvm/llvm-project/pull/112341 _

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 closed https://github.com/llvm/llvm-project/pull/112341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 reopened https://github.com/llvm/llvm-project/pull/112341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Jonathan Thackray via cfe-commits
jthackray wrote: > It might be worth splitting each feature into its own commit rather than one > big commit, it makes the review easier. Currently it's difficult to determine > which section belongs to which feature. Hmm, yeah possible. https://github.com/llvm/llvm-project/pull/112341 __

[libunwind] [llvm] [AArch64][Libunwind] Add Support for FEAT_PAuthLR DWARF Instruction (PR #112171)

2024-10-16 Thread Jack Styles via cfe-commits
https://github.com/Stylie777 updated https://github.com/llvm/llvm-project/pull/112171 >From a702473aacc6a9c47eb80b204ee3200c2ff2eb26 Mon Sep 17 00:00:00 2001 From: Jack Styles Date: Thu, 3 Oct 2024 14:20:10 +0100 Subject: [PATCH 1/6] [PAuthLR] Add support for FEAT_PAuth_LR to libunwind This in

[clang] [clang-format] Handle template opener/closer in braced list (PR #112494)

2024-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #112487. --- Full diff: https://github.com/llvm/llvm-project/pull/112494.diff 2 Files Affected: - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+5) - (modified) clang/unittests/Format/Token

[clang] [clang-format] Handle template opener/closer in braced list (PR #112494)

2024-10-16 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/112494 Fixes #112487. >From f4e0c6554ed63bfb2a1fd17411090ac06038ebc5 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 16 Oct 2024 01:07:14 -0700 Subject: [PATCH] [clang-format] Handle template opener/closer in braced

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > I also bisected errors on Windows, down to this commit. > > The errors show up when running the compiler-rt testsuite, like this: > https://github.com/mstorsjo/llvm-mingw/actions/runs/1135672/job/31598676534 > A number of tests fail, where `llvm-cov` errors out with `prof

[clang] [clang][OpenCL][CodeGen][AMDGPU] Do not use `private` as the default AS for when `generic` is available (PR #112442)

2024-10-16 Thread Alex Voicu via cfe-commits
@@ -5903,7 +5904,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, auto Call = RValue::get( EmitRuntimeCall(CGM.CreateRuntimeFunction(FTy, Name), Args)); if (TmpSize) -EmitLifetimeEnd(TmpSize, TmpPtr); +

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
https://github.com/CarolineConcatto edited https://github.com/llvm/llvm-project/pull/112341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-16 Thread Yuta Saito via cfe-commits
kateinoigakukun wrote: Thank you for your detail report and sorry for your inconvenience. I opened a PR to revert the root cause: https://github.com/llvm/llvm-project/pull/112520 https://github.com/llvm/llvm-project/pull/111332 ___ cfe-commits mailing

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-16 Thread Yihe Li via cfe-commits
https://github.com/Mick235711 created https://github.com/llvm/llvm-project/pull/112521 A follow-up and alternative proposal to #112289. In this PR, no new notes are added to avoid noise. Instead, originally, every `[[nodiscard]]` trigger, regardless of whether it is on function declaration or

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yihe Li (Mick235711) Changes A follow-up and alternative proposal to #112289. In this PR, no new notes are added to avoid noise. Instead, originally, every `[[nodiscard]]` trigger, regardless of whether it is on function declaration or r

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
@@ -4020,6 +4079,33 @@ defm STNPD : StorePairNoAlloc<0b01, 1, FPR64Op, simm7s8, "stnp">; defm STNPQ : StorePairNoAlloc<0b10, 1, FPR128Op, simm7s16, "stnp">; } +// Armv9.6-a Load/store no-allocate pair (FEAT_LSUI) +let Predicates = [HasLSUI] in { + defm LDTP: LoadPairOffs

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-16 Thread Yihe Li via cfe-commits
Mick235711 wrote: CC @Sirraide @erichkeane. (Sorry, I do not have permission to request reviewers, so instead used ping) https://github.com/llvm/llvm-project/pull/112521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/112514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Matt Arsenault via cfe-commits
@@ -1,69 +1,67 @@ -// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm -cl-ext=+cl_khr_subgroups -O0 -cl-std=clc++ -o - %s | FileCheck %s -// FIXME: Add MS ABI manglings of OpenCL things and remove %itanium_abi_triple arsenm wrote: It's 2 different paths t

[clang] [clang-tools-extra] [llvm] [clang] Introduce diagnostics suppression mappings (PR #112517)

2024-10-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 15d85769f119061fbfcae6e9de43982b534ef724 01a538fbbd93a7f26e1309c9c95d5be0c8500402 --e

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
@@ -2568,12 +2580,59 @@ defm CASPA : CompareAndSwapPair<1, 0, "a">; defm CASPL : CompareAndSwapPair<0, 1, "l">; defm CASPAL : CompareAndSwapPair<1, 1, "al">; +// v9.6-a atomic CAST CarolineConcatto wrote: I believe that these CAS and CASP have alias too ht

[clang] [compiler-rt] [lld] [llvm] [Coverage][WebAssembly] Add initial support for WebAssembly/WASI (PR #111332)

2024-10-16 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: I also bisected errors on Windows, down to this commit. The errors show up when running the compiler-rt testsuite, like this: https://github.com/mstorsjo/llvm-mingw/actions/runs/1135672/job/31598676534 A number of tests fail, where `llvm-cov` errors out with `profile uses zl

[clang] [clang] LazyOffsetPtr: Use native pointer width (PR #111995)

2024-10-16 Thread John Paul Adrian Glaubitz via cfe-commits
glaubitz wrote: Btw, if you submit a fix, it would be great if it could be backported to the 18 and 19 branches. https://github.com/llvm/llvm-project/pull/111995 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for C++23 (PR #112378)

2024-10-16 Thread via cfe-commits
https://github.com/zmodem updated https://github.com/llvm/llvm-project/pull/112378 >From f44ba22a8e5232b3f1e4a680565acd5604a7016c Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: Tue, 15 Oct 2024 17:18:45 +0200 Subject: [PATCH 1/3] [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for

[clang] [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for C++23 (PR #112378)

2024-10-16 Thread via cfe-commits
zmodem wrote: > LGTM! Can you also add a release note to clang/docs/ReleaseNotes.rst so users > know about the new flag? Sure, will do. https://github.com/llvm/llvm-project/pull/112378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for C++23 (PR #112378)

2024-10-16 Thread via cfe-commits
https://github.com/zmodem closed https://github.com/llvm/llvm-project/pull/112378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4ddea29 - [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for C++23 (#112378)

2024-10-16 Thread via cfe-commits
Author: Hans Date: 2024-10-16T10:06:43+02:00 New Revision: 4ddea298e60c31d0995c06189a592895d2ad512b URL: https://github.com/llvm/llvm-project/commit/4ddea298e60c31d0995c06189a592895d2ad512b DIFF: https://github.com/llvm/llvm-project/commit/4ddea298e60c31d0995c06189a592895d2ad512b.diff LOG: [cl

[clang] [clang] When checking for covariant return types, make sure the pointers or references are to *classes* (PR #111856)

2024-10-16 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1549291 - [clang] Implement constexpr __builtin_bit_cast for complex types (#109981)

2024-10-16 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-16T10:47:12+02:00 New Revision: 154929169ab460b6b135103208e7fecd3cfa58f0 URL: https://github.com/llvm/llvm-project/commit/154929169ab460b6b135103208e7fecd3cfa58f0 DIFF: https://github.com/llvm/llvm-project/commit/154929169ab460b6b135103208e7fecd3cfa58f0.diff L

[clang] [clang] Implement constexpr __builtin_bit_cast for complex types (PR #109981)

2024-10-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/109981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules][NFC] Rewrite friend-definition-2.cpp with split-file (PR #112380)

2024-10-16 Thread Dmitry Polukhin via cfe-commits
@@ -1,32 +1,53 @@ -// RUN: %clang_cc1 -std=c++14 -fmodules %s -verify -// RUN: %clang_cc1 -std=c++14 -fmodules %s -verify -triple i686-windows -// expected-no-diagnostics -#pragma clang module build A -module A {} -#pragma clang module contents -#pragma clang module begin A +// RU

[clang] [clang] Support `#pragma clang loop pipeline(enable)` (PR #112501)

2024-10-16 Thread Ryotaro Kasuga via cfe-commits
https://github.com/kasuga-fj created https://github.com/llvm/llvm-project/pull/112501 Previously `#pragma clang loop pipeline` only accepted `disable`. This patch adds `enable` as a valid argument for this pragma. This allows Software Pipelining optimization to be applied to some loops instead

[clang] [clang] When checking for covariant return types, make sure the pointers or references are to *classes* (PR #111856)

2024-10-16 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb updated https://github.com/llvm/llvm-project/pull/111856 >From 786d31e2657964e578cd1fdf2006b0fb3b19fab6 Mon Sep 17 00:00:00 2001 From: Boaz Brickner Date: Thu, 10 Oct 2024 15:15:23 + Subject: [PATCH 1/5] [clang] When checking for covariant return types, make su

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-16 Thread Yihe Li via cfe-commits
@@ -115,20 +115,20 @@ void usage() { S('A'); // expected-warning {{ignoring temporary created by a constructor declared with 'nodiscard' attribute: Don't let that S-Char go!}} S(1); S(2.2); - Y(); // expected-warning {{ignoring temporary created by a constructor declar

[clang] [clang-tools-extra] [analyzer][clang-tidy][NFC] Clean up eagerly-assume handling (PR #112209)

2024-10-16 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -3767,28 +3764,26 @@ void ExprEngine::evalEagerlyAssumeBinOpBifurcation(ExplodedNodeSet &Dst, continue; } -ProgramStateRef state = Pr

[clang] [clang][OpenCL][CodeGen][AMDGPU] Do not use `private` as the default AS for when `generic` is available (PR #112442)

2024-10-16 Thread Matt Arsenault via cfe-commits
@@ -5903,7 +5904,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, auto Call = RValue::get( EmitRuntimeCall(CGM.CreateRuntimeFunction(FTy, Name), Args)); if (TmpSize) -EmitLifetimeEnd(TmpSize, TmpPtr); +

[clang] [clang-tools-extra] [analyzer][clang-tidy][NFC] Clean up eagerly-assume handling (PR #112209)

2024-10-16 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -299,13 +299,12 @@ ANALYZER_OPTION( ANALYZER_OPTION( bool, ShouldEagerlyAssume, "eagerly-assume", -"Whether we should eagerly assume evaluat

[clang] [clang-tools-extra] [analyzer][clang-tidy][NFC] Clean up eagerly-assume handling (PR #112209)

2024-10-16 Thread Balazs Benics via cfe-commits
=?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy , =?utf-8?q?Don=C3=A1t?= Nagy Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. LGTM, modulo single inline unresolved comment thread. https://github.com/llvm/llvm-project/pul

[clang] [clang][bytecode] Implement the constexpr built-in abs function. (PR #112459)

2024-10-16 Thread via cfe-commits
https://github.com/c8ef converted_to_draft https://github.com/llvm/llvm-project/pull/112459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
@@ -833,8 +841,8 @@ def HasV9_5aOps : Architecture64<9, 5, "a", "v9.5a", [HasV9_4aOps, FeatureCPA], !listconcat(HasV9_4aOps.DefaultExts, [FeatureCPA, FeatureLUT, FeatureFAMINMAX])>; def HasV9_6aOps : Architecture64<9, 6, "a", "v9.6a", - [HasV9_5aOps], - !listconcat(HasV

[clang] [clang][bytecode] Implement the constexpr built-in abs function. (PR #112459)

2024-10-16 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/112459 >From dfa1585af3f080987cbd15830c45c34bfecc1fca Mon Sep 17 00:00:00 2001 From: c8ef Date: Wed, 16 Oct 2024 01:18:13 + Subject: [PATCH 1/6] implement constexpr builtin {l}abs --- clang/include/clang/Basic/Builti

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Jack Styles via cfe-commits
@@ -833,8 +841,8 @@ def HasV9_5aOps : Architecture64<9, 5, "a", "v9.5a", [HasV9_4aOps, FeatureCPA], !listconcat(HasV9_4aOps.DefaultExts, [FeatureCPA, FeatureLUT, FeatureFAMINMAX])>; def HasV9_6aOps : Architecture64<9, 6, "a", "v9.6a", - [HasV9_5aOps], - !listconcat(HasV

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang] [clang][bytecode] Start implementing __builtin_bit_cast (PR #112126)

2024-10-16 Thread Timm Baeder via cfe-commits
tbaederr wrote: Victory! 1) Iterate composite fields backwards for big-endian targets 2) Fix `BitcatBuffer::data()` pointing to the wrong byte if the number of bytes in the buffer is not a multiple of `sizeof(uint64_t)` (which is what `llvm::BitBuffer` uses internally) and we're on a big-end

[clang] [clang][bytecode] Start implementing __builtin_bit_cast (PR #112126)

2024-10-16 Thread Timm Baeder via cfe-commits
tbaederr wrote: Also, I've removed the logic for tracking uninitialized/indeterminate bits for now since it can be added later. https://github.com/llvm/llvm-project/pull/112126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 96795194fc79359363bac0423516da2a06733047 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH 1/5] apint only --- clang/lib/AST/ByteCode/IntegralAP.h |

[clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via cfe-commits
@@ -3600,8 +3600,11 @@ ExprResult Sema::ActOnCharacterConstant(const Token &Tok, Scope *UDLScope) { ExprResult Sema::ActOnIntegerConstant(SourceLocation Loc, uint64_t Val) { unsigned IntSize = Context.getTargetInfo().getIntWidth(); - return IntegerLiteral::Create(Context,

[clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via cfe-commits
@@ -437,7 +437,9 @@ ExprResult Parser::createEmbedExpr() { SourceLocation StartLoc = ConsumeAnnotationToken(); if (Data->BinaryData.size() == 1) { Res = IntegerLiteral::Create(Context, - llvm::APInt(CHAR_BIT, Data->BinaryData.back()), +

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-10-16 Thread via cfe-commits
@@ -446,8 +474,10 @@ define amdgpu_kernel void @add_i32_uniform(ptr addrspace(1) %out, ptr addrspace( ; GFX11W64-NEXT:; implicit-def: $vgpr1 ; GFX11W64-NEXT:s_delay_alu instid0(VALU_DEP_1) | instskip(NEXT) | instid1(VALU_DEP_1) ; GFX11W64-NEXT:v_mbcnt_hi_u32_b32 v

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang] [llvm] [NFC] Replace more DenseMaps with SmallDenseMaps (PR #111836)

2024-10-16 Thread Nikita Popov via cfe-commits
@@ -268,7 +268,7 @@ struct UniqueVirtualMethod { /// subobject in which that virtual function occurs). class OverridingMethods { using ValuesT = SmallVector; - using MapType = llvm::MapVector; + using MapType = llvm::SmallMapVector; nikic wrote: It looks l

[clang] [llvm] [NFC] Replace more DenseMaps with SmallDenseMaps (PR #111836)

2024-10-16 Thread Nikita Popov via cfe-commits
@@ -51,7 +51,7 @@ class ConstraintSystem { /// A map of variables (IR values) to their corresponding index in the /// constraint system. - DenseMap Value2Index; + SmallDenseMap Value2Index; nikic wrote: I'd add a using/typedef for this one, especially a

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Jonathan Thackray via cfe-commits
@@ -0,0 +1,14 @@ +# NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py +// RUN: llvm-mc -triple aarch64-none-linux-gnu -show-encoding -mattr=+occmo -mattr=+mte < %s | FileCheck %s jthackray wrote: I think these tests should also check in

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Jonathan Thackray via cfe-commits
@@ -0,0 +1,12 @@ +# NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py +// RUN: llvm-mc -triple aarch64 -show-encoding -mattr=+pcdphint %s | FileCheck %s jthackray wrote: I think these tests should also check the instructions are rejecte

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-10-16 Thread via cfe-commits
@@ -936,19 +978,20 @@ define amdgpu_kernel void @add_i32_varying_vdata(ptr addrspace(1) %out, ptr addr ; GFX12W32-NEXT:s_cbranch_scc1 .LBB2_1 ; GFX12W32-NEXT: ; %bb.2: ; %ComputeEnd ; GFX12W32-NEXT:v_mbcnt_lo_u32_b32 v1, exec_lo, 0 -; GFX12W32-NEXT:s_delay_alu ins

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh created https://github.com/llvm/llvm-project/pull/112514 Commit 84ee629bc515 ("clang: Remove some pointer bitcasts (#112324)", 2024-10-15) triggered some "Call parameter type does not match function signature!" errors when using the OpenCL pipe builtin functions under

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Sven van Haastregt (svenvh) Changes Commit 84ee629bc515 ("clang: Remove some pointer bitcasts (#112324)", 2024-10-15) triggered some "Call parameter type does not match function signature!" errors when u

[clang] [clang][bytecode] Implement the constexpr built-in abs function. (PR #112459)

2024-10-16 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/112459 >From dfa1585af3f080987cbd15830c45c34bfecc1fca Mon Sep 17 00:00:00 2001 From: c8ef Date: Wed, 16 Oct 2024 01:18:13 + Subject: [PATCH 1/7] implement constexpr builtin {l}abs --- clang/include/clang/Basic/Builti

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Matt Arsenault via cfe-commits
@@ -1,69 +1,67 @@ -// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm -cl-ext=+cl_khr_subgroups -O0 -cl-std=clc++ -o - %s | FileCheck %s -// FIXME: Add MS ABI manglings of OpenCL things and remove %itanium_abi_triple arsenm wrote: Test both run lines? ht

[clang] [lldb] [llvm] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-10-16 Thread Nikita Popov via cfe-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 96795194fc79359363bac0423516da2a06733047 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH 1/6] apint only --- clang/lib/AST/ByteCode/IntegralAP.h |

[clang] [llvm] [AMDGPU] Change CF intrinsics lowering to reconverge on predecessors (PR #108596)

2024-10-16 Thread via cfe-commits
alex-t wrote: > > Although, revisiting this now, I still don't understand why they decided to > > include ALL spill opcodes in the prologue, but not only the SGPR spills? > > Clearly, none of the VGPR reloads really belong to the prologue. > > At a first glance, changing the isSpill(opcode) to

[clang] [OpenCL] Restore addrspacecast for pipe builtins and update test (PR #112514)

2024-10-16 Thread Sven van Haastregt via cfe-commits
@@ -1,69 +1,67 @@ -// RUN: %clang_cc1 -triple %itanium_abi_triple -emit-llvm -cl-ext=+cl_khr_subgroups -O0 -cl-std=clc++ -o - %s | FileCheck %s -// FIXME: Add MS ABI manglings of OpenCL things and remove %itanium_abi_triple svenvh wrote: Surely I can add the old

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Alexandros Lamprineas (labrinea) Changes If we split these features in the compiler (see relevant pull request https://github.com/llvm/llvm-project/pull/109299), we would only be able to hand-write a 'memtag2' version using inli

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes If we split these features in the compiler (see relevant pull request https://github.com/llvm/llvm-project/pull/109299), we would only be able to hand-write a 'memtag2' version using inline assembl

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-16 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/112511 If we split these features in the compiler (see relevant pull request https://github.com/llvm/llvm-project/pull/109299), we would only be able to hand-write a 'memtag2' version using inline assembly since the

[clang] [clang-cl]: Add /std:c++23preview and update _MSVC_LANG for C++23 (PR #112378)

2024-10-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/8330 Here is the relevan

[clang-tools-extra] [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (PR #112496)

2024-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Discookie (Discookie) Changes Previously the name of anonymous enums in the check were `enum 'enum (unnamed at /full/path/to/file.c:1:1)'`, which breaks reproducibility of clang-tidy reports when the analyzed project is in a d

[clang-tools-extra] [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (PR #112496)

2024-10-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Discookie (Discookie) Changes Previously the name of anonymous enums in the check were `enum 'enum (unnamed at /full/path/to/file.c:1:1)'`, which breaks reproducibility of clang-tidy reports when the analyzed project is in a differen

[clang-tools-extra] [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (PR #112496)

2024-10-16 Thread via cfe-commits
https://github.com/Discookie created https://github.com/llvm/llvm-project/pull/112496 Previously the name of anonymous enums in the check were `enum 'enum (unnamed at /full/path/to/file.c:1:1)'`, which breaks reproducibility of clang-tidy reports when the analyzed project is in a different fol

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-16 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 7d8b69eeb92c87d4aff4cbcd8c0f432d37c2b1e3 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] 9df8d8d - [clang][analyzer] Improve test and documentation in cstring NotNullTerminated checker (#112019)

2024-10-16 Thread via cfe-commits
Author: Balázs Kéri Date: 2024-10-16T10:17:34+02:00 New Revision: 9df8d8d05c2650b51bd4233e1759206d163f3133 URL: https://github.com/llvm/llvm-project/commit/9df8d8d05c2650b51bd4233e1759206d163f3133 DIFF: https://github.com/llvm/llvm-project/commit/9df8d8d05c2650b51bd4233e1759206d163f3133.diff L

[clang] [clang][analyzer] Improve test and documentation in cstring NotNullTerminated checker (PR #112019)

2024-10-16 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/112019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-16 Thread Budimir Aranđelović via cfe-commits
@@ -0,0 +1,251 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=expected,c_diagnostics -Wmissing-format-attribute %s +// RUN: %clang_cc1 -fsyntax-only -Wmissing-format-attribute -fdiagnostics-parseable-fixits %s 2>&1 | FileCheck %s +// RUN: %clang_cc1 -fsyntax-only -x c++ -verify=ex

[clang-tools-extra] [clang-tidy] Do not emit file path for anonymous enums in `readability-enum-initial-value` check (PR #112496)

2024-10-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4ddea298e60c31d0995c06189a592895d2ad512b be0bee7948a8a6394ba93df619d76048847c1ca8 --e

[clang] [Modules][NFC] Rewrite friend-definition-2.cpp with split-file (PR #112380)

2024-10-16 Thread Ilya Biryukov via cfe-commits
@@ -1,32 +1,53 @@ -// RUN: %clang_cc1 -std=c++14 -fmodules %s -verify -// RUN: %clang_cc1 -std=c++14 -fmodules %s -verify -triple i686-windows -// expected-no-diagnostics -#pragma clang module build A -module A {} -#pragma clang module contents -#pragma clang module begin A +// RU

[clang] [Sema] Fix warning in SemaOpenACC.cpp (PR #112481)

2024-10-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/112481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Ilya Biryukov via cfe-commits
@@ -1183,7 +1181,7 @@ class Sema final : public SemaBase { std::optional> CachedDarwinSDKInfo; bool WarnedDarwinSDKInfoMissing = false; - bool WarnedStackExhausted = false; + SingleWarningStackAwareExecutor StackAwareExecutor; ilya-biryukov wrote: Shoul

[clang] [clang] Support `#pragma clang loop pipeline(enable)` (PR #112501)

2024-10-16 Thread Ryotaro Kasuga via cfe-commits
https://github.com/kasuga-fj edited https://github.com/llvm/llvm-project/pull/112501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Different info in docs in AST methods (PR #112190)

2024-10-16 Thread Mikhnenko Sasha via cfe-commits
4JustMe4 wrote: The suggestions have been applied. The document re-generation script has been launched. https://github.com/llvm/llvm-project/pull/112190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang][bytecode] Start implementing __builtin_bit_cast (PR #112126)

2024-10-16 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/112126 >From 1cf8a3bd76adfd5595c000e2ad86fb1db5b96a8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 13 Oct 2024 08:57:48 +0200 Subject: [PAT

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-16 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,217 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// This function is called only if function call is not inside template body. +// TODO: Add call

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Boaz Brickner via cfe-commits
@@ -1183,7 +1181,7 @@ class Sema final : public SemaBase { std::optional> CachedDarwinSDKInfo; bool WarnedDarwinSDKInfoMissing = false; - bool WarnedStackExhausted = false; + SingleWarningStackAwareExecutor StackAwareExecutor; bricknerb wrote: Yes, I co

[clang] [Sema] Fix warning in SemaOpenACC.cpp (PR #112481)

2024-10-16 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 closed https://github.com/llvm/llvm-project/pull/112481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7c5d5c0 - [Sema] Fix warning in SemaOpenACC.cpp (#112481)

2024-10-16 Thread via cfe-commits
Author: Karl-Johan Karlsson Date: 2024-10-16T11:01:33+02:00 New Revision: 7c5d5c08181f399858d918d6910c021af4ec36c0 URL: https://github.com/llvm/llvm-project/commit/7c5d5c08181f399858d918d6910c021af4ec36c0 DIFF: https://github.com/llvm/llvm-project/commit/7c5d5c08181f399858d918d6910c021af4ec36c0

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Ilya Biryukov via cfe-commits
@@ -16,6 +16,8 @@ #include +#include "clang/Basic/Diagnostic.h" ilya-biryukov wrote: This dependency seems unnecessary in this file, the other functions are lower-level (don't depend on SourceLocations, etc). There are a few files that depend on it for th

[clang] [llvm] [Clang] Fix argument extensions in CGBlocks.cpp (PR #111740)

2024-10-16 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: gentle ping... @efriedma-quic @nikic https://github.com/llvm/llvm-project/pull/111740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [analyzer][clang-tidy][NFC] Clean up eagerly-assume handling (PR #112209)

2024-10-16 Thread Donát Nagy via cfe-commits
NagyDonat wrote: @steakhal May I merge this commit? https://github.com/llvm/llvm-project/pull/112209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Ilya Biryukov via cfe-commits
@@ -1183,7 +1181,7 @@ class Sema final : public SemaBase { std::optional> CachedDarwinSDKInfo; bool WarnedDarwinSDKInfoMissing = false; - bool WarnedStackExhausted = false; + SingleWarningStackAwareExecutor StackAwareExecutor; ilya-biryukov wrote: Makes

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: Adding @ChuanqiXu9 to get another pair of eyes on it (for naming, code structure, etc). I believe he was involved in reviewing some changes touching `runWithSufficientStackSpace` I've previously sent. Please give him a chance to review this. https://github.com/llvm/llvm-p

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/112371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: Took a pretty quick scanning and this looks good to me. https://github.com/llvm/llvm-project/pull/112371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [clang] Deduplicate the logic that only warns once when stack is almost full (PR #112371)

2024-10-16 Thread Chuanqi Xu via cfe-commits
@@ -1183,7 +1181,7 @@ class Sema final : public SemaBase { std::optional> CachedDarwinSDKInfo; bool WarnedDarwinSDKInfoMissing = false; - bool WarnedStackExhausted = false; + SingleWarningStackAwareExecutor StackAwareExecutor; ChuanqiXu9 wrote: Abstract

[clang] [clang][bytecode] Start implementing __builtin_bit_cast (PR #112126)

2024-10-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/112126 >From 1cf8a3bd76adfd5595c000e2ad86fb1db5b96a8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 13 Oct 2024 08:57:48 +0200 Subject: [PATCH] [clang][bytecode] Start implementing __builtin_

[clang] [clang][bytecode] Start implementing __builtin_bit_cast (PR #112126)

2024-10-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr ready_for_review https://github.com/llvm/llvm-project/pull/112126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-16 Thread Budimir Aranđelović via cfe-commits
@@ -5335,6 +5335,217 @@ static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) PreferredTypeAttr(S.Context, AL, ParmTSI)); } +// This function is called only if function call is not inside template body. +// TODO: Add call

[clang] [clang] Implement constexpr __builtin_bit_cast for complex types (PR #109981)

2024-10-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/109981 >From 8a987510829abcba7bdb3572db418f71f33bbd69 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 25 Sep 2024 15:45:06 +0200 Subject: [PATCH] [clang] Implement constexpr __builtin_bit_cast

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-16 Thread Nashe Mncube via cfe-commits
@@ -4769,6 +4843,109 @@ class LoadExclusivePair sz, bit o2, bit L, bit o1, bit o0, let PostEncoderMethod = "fixLoadStoreExclusive<0,1>"; } +// Armv9.6-a load-store exclusive instructions +let hasSideEffects = 1, mayLoad = 1, mayStore = 1 in +class BaseLoadStoreExclusiveLSUI

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-16 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 3f46179ecdb0097313c0249c1f4ff0c33eb21772 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [llvm] [RISCV] Inline Assembly: RVC constraint and N modifier (PR #112561)

2024-10-16 Thread Sam Elliott via cfe-commits
https://github.com/lenary created https://github.com/llvm/llvm-project/pull/112561 This change implements support for the `cr` and `cf` register constraints (which allocate a RVC GPR or RVC FPR respectively), and the `N` modifier (which prints the raw encoding of a register rather than the nam

  1   2   3   4   5   >