================
@@ -1183,7 +1181,7 @@ class Sema final : public SemaBase {
   std::optional<std::unique_ptr<DarwinSDKInfo>> CachedDarwinSDKInfo;
   bool WarnedDarwinSDKInfoMissing = false;
 
-  bool WarnedStackExhausted = false;
+  SingleWarningStackAwareExecutor StackAwareExecutor;
----------------
ilya-biryukov wrote:

Should we share the state between Sema and CodeGen?
It's not unusual for deeply nested ASTs to cause the limits to be hit in both 
and it would make sense to only diagnose once globally.

I am not sure which class would be a good fit to hold that state as CodeGen 
does not have a reference to Sema and vice versa, so maybe it needs too much 
plumbing and isn't worth it. But I wanted to throw this idea out and hear what 
people think.

https://github.com/llvm/llvm-project/pull/112371
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to