[clang] 52a9ba7 - [clang][DebugInfo] Revert to printing canonical typenames for template aliases (#110767)

2024-10-02 Thread via cfe-commits
Author: Michael Buch Date: 2024-10-02T19:38:51+01:00 New Revision: 52a9ba7ca4fb9427706c28bb3ca15f7a56eecf3f URL: https://github.com/llvm/llvm-project/commit/52a9ba7ca4fb9427706c28bb3ca15f7a56eecf3f DIFF: https://github.com/llvm/llvm-project/commit/52a9ba7ca4fb9427706c28bb3ca15f7a56eecf3f.diff

[clang] [llvm] riscv: Support -mstack-protector-guard=tls (PR #108942)

2024-10-02 Thread Keith Packard via cfe-commits
https://github.com/keith-packard updated https://github.com/llvm/llvm-project/pull/108942 >From 1ca3c96bc0e07a2fdae982736017f1d31147e4e4 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Mon, 16 Sep 2024 15:41:38 +0200 Subject: [PATCH 1/4] riscv: Support -mstack-protector-guard=tls Add suppor

[clang] [Clang][HIP] Warn when __AMDGCN_WAVEFRONT_SIZE is used in host code without relying on target-dependent overload resolution (PR #109663)

2024-10-02 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: One drawback of not defining `__AMDGCN_WAVEFRONT_SIZE__` in host compilation is the impairment of uniformity of source code across host and device sides. Users have to put `#if __HIP_DEVICE_COMPILE__` anywhere they use `__AMDGCN_WAVEFRONT_SIZE__`. Previous experience tells us t

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-02 Thread Mircea Trofin via cfe-commits
@@ -1784,6 +1784,12 @@ defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling", PosFlag, NegFlag>; +def fprofile_generate_cold_function_coverage : Flag<["-"], "fprofile-generate-cold-function-coverage">, mtrofin wrote: Why would incompatib

[clang] 87a2413 - [AST] Fix a warning

2024-10-02 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-10-02T12:21:23-07:00 New Revision: 87a24136140496e30aa867074bdee1be1f3b3294 URL: https://github.com/llvm/llvm-project/commit/87a24136140496e30aa867074bdee1be1f3b3294 DIFF: https://github.com/llvm/llvm-project/commit/87a24136140496e30aa867074bdee1be1f3b3294.diff L

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2024-10-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97443 >From 3a718c75d0458b7aece72f2ba8e5aa5a68815237 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 2 Jul 2024 18:43:34 +0200 Subject: [PATCH 1/6] [clang][RecordLayoutBuilder] Be stricter about inferring pa

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2024-10-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97443 >From 3a718c75d0458b7aece72f2ba8e5aa5a68815237 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 2 Jul 2024 18:43:34 +0200 Subject: [PATCH 1/2] [clang][RecordLayoutBuilder] Be stricter about inferring pa

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2024-10-02 Thread Michael Buch via cfe-commits
Michael137 wrote: > If I'm understanding correctly, the way this currently works is that you do > normal field layout, then if you discover that the actual offset of a field > is less than the offset normal field layout would produce, you assume the > struct is packed. This misses cases where

[clang] [clang-format] Fix a bug in annotating angles containing FatArrow (PR #108671)

2024-10-02 Thread via cfe-commits
@@ -243,14 +244,16 @@ class AnnotatingParser { // operator that was misinterpreted because we are parsing template // parameters. // FIXME: This is getting out of hand, write a decent parser. - if (InExpr && !Line.startsWith(tok::kw_template) && + if

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Viktoriia Bakalova via cfe-commits
@@ -693,14 +693,13 @@ ItaniumMangleContextImpl::getEffectiveDeclContext(const Decl *D) { if (VD->isExternC()) return getASTContext().getTranslationUnitDecl(); - if (const auto *FD = D->getAsFunction()) { -if (FD->isExternC()) VitaNuo wrote: It

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo edited https://github.com/llvm/llvm-project/pull/110503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Viktoriia Bakalova via cfe-commits
@@ -693,14 +693,13 @@ ItaniumMangleContextImpl::getEffectiveDeclContext(const Decl *D) { if (VD->isExternC()) return getASTContext().getTranslationUnitDecl(); - if (const auto *FD = D->getAsFunction()) { -if (FD->isExternC()) - return getASTContext().getTr

[clang] [clang-format] Fix a bug in annotating angles containing FatArrow (PR #108671)

2024-10-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/108671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support BasedOnStyle referencing an arbitrary file (PR #110634)

2024-10-02 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. Can this have some unit test? https://github.com/llvm/llvm-project/pull/110634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/110503 >From 927a40fc58018f61eaf008672039faa233a6ce50 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Mon, 30 Sep 2024 12:50:09 + Subject: [PATCH] [clang][Itanium Mangle] Enable mangling of enclosing class

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-02 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > Let me clarify myself, _BitInt(N) will work with the change, I have no > doubts. But I can imagine a SPIR-V extension to appear that would add support > for 4-bit integers. And I can imagine that we would want to not only be able > to emit 4-bit integers in the frontend, but a

[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-10-02 Thread via cfe-commits
mydeveloperday wrote: Looking at Format.h (the only file I'm interested in), there feels to me to be things in the ABI that I wouldn't expect to be called externally, I don't know enough about what's involved in creating a DLL ABI but I wouldn't want some of the clang-format functions to be i

[clang] [clang-format] Correctly annotate */& in if condition with braced init (PR #109505)

2024-10-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/109505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Annotate the l_paren of function pointer types (PR #109229)

2024-10-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/109229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: LGTM otherwise https://github.com/llvm/llvm-project/pull/110842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/110842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Vlad Serebrennikov via cfe-commits
@@ -29,6 +29,35 @@ namespace std { #endif } // namespace std +namespace cwg2707 { // cwg2707: 20 + +#if __cplusplus >= 202002L + +template struct A { // #cwg2707-A + T value[N]; +}; + +template +A(T...) -> A requires (sizeof...(T) == 2); // #cwg2707-guide-A + +// Brace eli

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Vlad Serebrennikov via cfe-commits
@@ -29,6 +29,35 @@ namespace std { #endif } // namespace std +namespace cwg2707 { // cwg2707: 20 + +#if __cplusplus >= 202002L + +template struct A { // #cwg2707-A + T value[N]; +}; + +template +A(T...) -> A requires (sizeof...(T) == 2); // #cwg2707-guide-A + +// Brace eli

[clang] [llvm] [ARM][AArch64] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray edited https://github.com/llvm/llvm-project/pull/110825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM[AArch64] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray edited https://github.com/llvm/llvm-project/pull/110825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [TableGen] Change `DefInit::Def` to a const Record pointer (PR #110747)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes This change undoes a const_cast<> introduced in an earlier change to help transition to const pointers. It is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.or

[clang] [clang][frontend] Add support for attribute plugins for statement attributes (PR #110334)

2024-10-02 Thread Erich Keane via cfe-commits
erichkeane wrote: > > So the problem with statement attributes is that we don't really have a > > good way to do instantiation of them on a template, which is why we held > > off on this in the first place. The infrastructure for instantiation DOES > > happen on decl attributes automatically a

[clang] [clang][frontend] Add support for attribute plugins for statement attributes (PR #110334)

2024-10-02 Thread Eric Astor via cfe-commits
ericastor wrote: > So the problem with statement attributes is that we don't really have a good > way to do instantiation of them on a template, which is why we held off on > this in the first place. The infrastructure for instantiation DOES happen on > decl attributes automatically anyway, so

[clang] [llvm] [mlir] [TableGen] Change `DefInit::Def` to a const Record pointer (PR #110747)

2024-10-02 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/110747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-10-02 Thread Iuri Chaer via cfe-commits
ichaer wrote: @mydeveloperday? https://github.com/llvm/llvm-project/pull/96804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

2024-10-02 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/110845 >From fe014ebcc74ca32fc5dddea31589473126b5c766 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 2 Oct 2024 07:01:40 -0700 Subject: [PATCH] [NFC][TableGen] Change `Record::getSuperClasses` to use const Reco

[clang] 9b53a6e - [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (#110842)

2024-10-02 Thread via cfe-commits
Author: Younan Zhang Date: 2024-10-02T23:15:38+08:00 New Revision: 9b53a6e7e5310e56c404766bf1cf3f21bff59229 URL: https://github.com/llvm/llvm-project/commit/9b53a6e7e5310e56c404766bf1cf3f21bff59229 DIFF: https://github.com/llvm/llvm-project/commit/9b53a6e7e5310e56c404766bf1cf3f21bff59229.diff

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/110842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

2024-10-02 Thread Joel E. Denny via cfe-commits
@@ -1,12 +1,17 @@ -// RUN: %libomptarget-compile-generic -fprofile-instr-generate \ -// RUN: -Xclang "-fprofile-instrument=clang" -// RUN: %libomptarget-run-generic 2>&1 | %fcheck-generic \ -// RUN: --check-prefix="CLANG-PGO" // RUN: %libomptarget-compile-generic -fprofil

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-10-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I have no further comments here, this looks good to me. https://github.com/llvm/llvm-project/pull/99656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] Allow tag-based API notes on anonymous tag decls with typedef names (PR #110768)

2024-10-02 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan approved this pull request. https://github.com/llvm/llvm-project/pull/110768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [TableGen] Change `DefInit::Def` to a const Record pointer (PR #110747)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -1660,7 +1660,7 @@ class Record { // this record. SmallVector Locs; SmallVector ForwardDeclarationLocs; - SmallVector ReferenceLocs; + mutable SmallVector ReferenceLocs; arsenm wrote: You have the const_cast on the addition, so this is unnecessary?

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-02 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/19] Made MMIW

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-02 Thread Matin Raayai via cfe-commits
@@ -0,0 +1,102 @@ +//===-- LLVMTargetMachineC.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-02 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/20] Made MMIW

[clang] [clang][dataflow] Add a test demonstrating an issue in unchecked-optional-access-check (PR #110870)

2024-10-02 Thread Jan Voung via cfe-commits
https://github.com/jvoung ready_for_review https://github.com/llvm/llvm-project/pull/110870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Add a test demonstrating an issue in unchecked-optional-access-check (PR #110870)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Voung (jvoung) Changes createStorageLocation used in transferCallReturningOptional: https://github.com/llvm/llvm-project/blob/09ba83be0ac178851e3c9c9c8fefddbdd4d8353f/clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-02 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/19] Made MMIW

[clang] [llvm] [ARM][AArch64] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread David Green via cfe-commits
https://github.com/davemgreen approved this pull request. This LGTM if there are no other comments. https://github.com/llvm/llvm-project/pull/110825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] [ARM][AArch64] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread David Green via cfe-commits
@@ -118,9 +118,9 @@ struct ArchInfo { // Defines the following partial order, indicating when an architecture is // a superset of another: // - // v9.5a > v9.4a > v9.3a > v9.2a > v9.1a > v9a; - // v v v v v - // v8.9a > v

[clang] [llvm] [ARM][AArch64] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread David Green via cfe-commits
https://github.com/davemgreen edited https://github.com/llvm/llvm-project/pull/110825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-02 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/21] Made MMIW

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110767 >From 53bfa785514f9811952aa5122f60d16129136285 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Oct 2024 00:42:35 +0100 Subject: [PATCH 1/2] [clang][DebugInfo] Revert to printing canonical typenames

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-02 Thread David Blaikie via cfe-commits
dwblaikie wrote: Not quite sure how we get to caching and template specializations and pretty printers. If we're still producing the typedef-style DWARF for these alias template specializations - perhaps lldb could not cache pretty printers for typedefs? (I guess the pretty printers shouldn't

[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-10-02 Thread Saleem Abdulrasool via cfe-commits
compnerd wrote: > Looking at Format.h (the only file I'm interested in), there feels to me to > be things in the ABI that I wouldn't expect to be called externally, I don't > know enough about what's involved in creating a DLL ABI but I wouldn't want > some of the clang-format functions to be

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-02 Thread via cfe-commits
cor3ntin wrote: > sorry this is same as #107906 (with a bigger impact radius, as you're also > changing getBufferForFile) and doesn't address any of the issues mention > about explaining the semantics of `IsText` or justification for changing the > core VFS interfaces, for an operation that's

[clang] d256b9e - [TableGen] Change `DefInit::Def` to a const Record pointer (#110747)

2024-10-02 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-10-02T09:48:26-07:00 New Revision: d256b9e88b7aa9155380a4e70d39a2a0121ff917 URL: https://github.com/llvm/llvm-project/commit/d256b9e88b7aa9155380a4e70d39a2a0121ff917 DIFF: https://github.com/llvm/llvm-project/commit/d256b9e88b7aa9155380a4e70d39a2a0121ff917.diff L

[clang] [llvm] [mlir] [TableGen] Change `DefInit::Def` to a const Record pointer (PR #110747)

2024-10-02 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/110747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Bump the instantiated index when skipping past non-init-captures (PR #110887)

2024-10-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/110887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Bump the instantiated index when skipping past non-init-captures (PR #110887)

2024-10-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/110887 Otherwise, we would probably have an unmatched instantiated declaration for init-captures when they come after a non-init capture. No release note because the bug only affects the trunk. Fixes #110721 >From 0

[clang] [Clang][Sema] Bump the instantiated index when skipping past non-init-captures (PR #110887)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes Otherwise, we would probably have an unmatched instantiated declaration for init-captures when they come after a non-init capture. No release note because the bug only affects the trunk so far. Fixes #11072

[clang] [clang][RISC-V] fixed fp calling convention for fpcc eligible structs for risc-v (PR #110690)

2024-10-02 Thread Craig Topper via cfe-commits
@@ -251,6 +251,13 @@ bool RISCVABIInfo::detectFPCCEligibleStructHelper(QualType Ty, CharUnits CurOff, // bitwidth is XLen or less. if (getContext().getTypeSize(QTy) > XLen && BitWidth <= XLen) QTy = getContext().getIntTypeForBitwidth(XLen, false); +

[clang] [Clang][Sema] Bump the instantiated index when skipping past non-init-captures (PR #110887)

2024-10-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/110887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-02 Thread Michael Buch via cfe-commits
Michael137 wrote: > If we're still producing the typedef-style DWARF for these alias template > specializations - perhaps lldb could not cache pretty printers for typedefs? > (I guess the pretty printers shouldn't be typedef-specific, right, since > typedefs are transparent anyway - but I gues

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-02 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/110767 >From 53bfa785514f9811952aa5122f60d16129136285 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 2 Oct 2024 00:42:35 +0100 Subject: [PATCH 1/3] [clang][DebugInfo] Revert to printing canonical typenames

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

2024-10-02 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/110845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

2024-10-02 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/110845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-tablegen Author: Rahul Joshi (jurahul) Changes Change `Record::getSuperClasses` to return a const pointer to the superclass records. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-plann

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change `Record::getSuperClasses` to return a const pointer to the superclass records. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-02 Thread John McCall via cfe-commits
rjmccall wrote: I don't think there's a deep reason blocks and lambdas don't use quite the same scope mechanics in the compiler, so if you wanted to pursue that, it seems reasonable. But this approach also seems viable. I agree that removing the assertion would be the wrong thing to do, and

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110497)

2024-10-02 Thread Jan Hendrik Farr via cfe-commits
https://github.com/Cydox updated https://github.com/llvm/llvm-project/pull/110497 >From 15b69329a97706ada7d5e8cbeb76508aa55b418f Mon Sep 17 00:00:00 2001 From: Jan Hendrik Farr Date: Sun, 29 Sep 2024 21:38:13 +0200 Subject: [PATCH 1/4] [Clang] Fix 'counted_by' for nested struct pointers Fixes

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110497)

2024-10-02 Thread Jan Hendrik Farr via cfe-commits
@@ -1164,15 +1163,15 @@ llvm::Value *CodeGenFunction::EmitLoadOfCountedByField( return nullptr; llvm::Value *Res = nullptr; - if (StructBase->isLValue()) { -LValue LV = EmitLValue(StructBase); -Address Addr = LV.getAddress(); -Res = Addr.emitRawPointer(*this

[clang] 6ae14c0 - [clang-format] Annotate the l_paren of function pointer types (#109229)

2024-10-02 Thread via cfe-commits
Author: Owen Pan Date: 2024-10-02T18:01:25-07:00 New Revision: 6ae14c0505e92cceefc1757467e4a2eb797429e6 URL: https://github.com/llvm/llvm-project/commit/6ae14c0505e92cceefc1757467e4a2eb797429e6 DIFF: https://github.com/llvm/llvm-project/commit/6ae14c0505e92cceefc1757467e4a2eb797429e6.diff LOG:

[clang] [clang-format] Annotate the l_paren of function pointer types (PR #109229)

2024-10-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/109229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110497)

2024-10-02 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: So, this doesn't fully work yet. When compiling the kernel it seems like there are cases were `StructBase` is now both an LValue and a pointer. Still investigating. https://github.com/llvm/llvm-project/pull/110497 ___ cfe-commits mailing

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-10-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/4846 Here is the relevant piece of the build log

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110497)

2024-10-02 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: Yeah so the problem is if you do `__builtin_dynamic_object_size(v, 0)` In that case it's a `DeclRefExpr`, a pointer, and an `LValue`. Easy fix is to check if `StructBase` is a pointer instead of checking for LValue, but then I don't really see the point of this change vs my origin

[clang] 98281da - [clang-format] Correctly annotate */& in if condition with braced init (#109505)

2024-10-02 Thread via cfe-commits
Author: Owen Pan Date: 2024-10-02T18:07:57-07:00 New Revision: 98281da29f7e36e22ff1e20b9cfefda8c31dbe56 URL: https://github.com/llvm/llvm-project/commit/98281da29f7e36e22ff1e20b9cfefda8c31dbe56 DIFF: https://github.com/llvm/llvm-project/commit/98281da29f7e36e22ff1e20b9cfefda8c31dbe56.diff LOG:

[clang] [clang-format] Correctly annotate */& in if condition with braced init (PR #109505)

2024-10-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/109505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add TemplateNames option to help parse C++ angles (PR #109916)

2024-10-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/109916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 688bc95 - [clang-format] Add TemplateNames option to help parse C++ angles (#109916)

2024-10-02 Thread via cfe-commits
Author: Owen Pan Date: 2024-10-02T18:10:56-07:00 New Revision: 688bc958bd4167512f0d45e1fd008c9551de1c75 URL: https://github.com/llvm/llvm-project/commit/688bc958bd4167512f0d45e1fd008c9551de1c75 DIFF: https://github.com/llvm/llvm-project/commit/688bc958bd4167512f0d45e1fd008c9551de1c75.diff LOG:

[clang] [clang-format] Handle template closer followed by empty paretheses (PR #110408)

2024-10-02 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/110408 >From 27135c008868cc4f17b7ca5ff9c2af9c2fc02135 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 28 Sep 2024 22:42:56 -0700 Subject: [PATCH 1/2] [clang-format] Handle template closer followed by empty parethese

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-02 Thread Peilin Ye via cfe-commits
@@ -522,6 +526,28 @@ let Predicates = [BPFNoALU32] in { } def STD : STOREi64; +class relaxed_store + : PatFrag<(ops node:$val, node:$ptr), (base node:$val, node:$ptr)> { + let IsAtomic = 1; + let IsAtomicOrderingReleaseOrStronger = 0; +} + +class releasing_store + : PatFra

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110497)

2024-10-02 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: Now this passes all tests again, also compiles the kernel without issue. https://github.com/llvm/llvm-project/pull/110497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-02 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/110762 >From a471d32c94bfcbd10291053bb6ce0541ea2e626c Mon Sep 17 00:00:00 2001 From: Sirraide Date: Wed, 2 Oct 2024 00:59:37 +0200 Subject: [PATCH 1/4] [Clang] [Sema] Don't crash on unexpanded pack in invalid block l

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-10-02 Thread via cfe-commits
Sirraide wrote: > LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` Looks like the failure is somewhere in an LLDB test, so I think we can ignore this because that’s completely unrelated. https://github.com/llvm/llvm-project/pull/99656 ___

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110497)

2024-10-02 Thread Jan Hendrik Farr via cfe-commits
https://github.com/Cydox updated https://github.com/llvm/llvm-project/pull/110497 >From 15b69329a97706ada7d5e8cbeb76508aa55b418f Mon Sep 17 00:00:00 2001 From: Jan Hendrik Farr Date: Sun, 29 Sep 2024 21:38:13 +0200 Subject: [PATCH 1/5] [Clang] Fix 'counted_by' for nested struct pointers Fixes

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110497)

2024-10-02 Thread Jan Hendrik Farr via cfe-commits
@@ -1164,15 +1163,15 @@ llvm::Value *CodeGenFunction::EmitLoadOfCountedByField( return nullptr; llvm::Value *Res = nullptr; - if (StructBase->isLValue()) { -LValue LV = EmitLValue(StructBase); -Address Addr = LV.getAddress(); -Res = Addr.emitRawPointer(*this

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/110503 >From 927a40fc58018f61eaf008672039faa233a6ce50 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Mon, 30 Sep 2024 12:50:09 + Subject: [PATCH] [clang][Itanium Mangle] Enable mangling of enclosing class

[clang] [llvm] [mlir] [TableGen] Change `DefInit::Def` to a const Record pointer (PR #110747)

2024-10-02 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/110747 >From 4983aef1a62d9f3611e4ae8ed2feeb77d8729d98 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 1 Oct 2024 12:05:15 -0700 Subject: [PATCH] [TableGen] Change `DefInit::Def` to a const Record pointer --- ..

[clang] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2024-10-02 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: Patch updated after some progress... With this version, the fp16 values are passed to conversion functions as integer, which seems to be the default. It is however a bit tricky to do this and at the same time pass half values in FP registers. At this point I wonder for one th

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-10-02 Thread via cfe-commits
@@ -164,6 +164,40 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, DoubleAsterisk) { + EXPECT_TRUE(match("a/b/c/d.cpp", "**b**")); + EXPECT_TRUE(match("a/b/c/d.cpp", "**/b/**")); + EXPECT_TRUE(match("a/b/c/d_e.cpp

[clang] [clang-format] Handle template closer followed by empty paretheses (PR #110408)

2024-10-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/110408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] clang-format-ignore: Add support for double asterisk patterns (PR #110560)

2024-10-02 Thread via cfe-commits
@@ -164,6 +164,40 @@ TEST_F(MatchFilePathTest, Path) { EXPECT_FALSE(match("foo\\", R"(foo*\)")); } +TEST_F(MatchFilePathTest, DoubleAsterisk) { + EXPECT_TRUE(match("a/b/c/d.cpp", "**b**")); + EXPECT_TRUE(match("a/b/c/d.cpp", "**/b/**")); + EXPECT_TRUE(match("a/b/c/d_e.cpp

[clang] [clang-format] Add TemplateNames option to help parse C++ angles (PR #109916)

2024-10-02 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. I like this as a "Get our of jail free card", we've seen enough ambiguous cases for this to need to be a thing for those who face challenges https://github.com/llvm/llvm-project/pull/109916 __

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-02 Thread Dmitry Sidorov via cfe-commits
MrSidims wrote: > You want spirv, not spir Thanks! Yet the result is the same. > Do you plan to go over LLVM passes adding this check? So guess answer to my question would be: "no" :) https://github.com/llvm/llvm-project/pull/110695 ___ cfe-commits

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This addresses comments from @Endilll in the post commit review of #110473. --- Full diff: https://github.com/llvm/llvm-project/pull/110842.diff 1 Files Affected: - (modified) clang/test/CXX/drs/cwg27xx.

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/110842 This addresses comments from @Endilll in the post commit review of #110473. >From 5660d1ee7f5b815061f04e2f77eb1abced041ea6 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 2 Oct 2024 21:41:53 +0800 Subje

[clang] [Clang] Implement CWG 2707 "Deduction guides cannot have a trailing requires-clause" (PR #110473)

2024-10-02 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @Endilll Filed https://github.com/llvm/llvm-project/pull/110842 for your comments. PTAL, thanks! https://github.com/llvm/llvm-project/pull/110473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Younan Zhang via cfe-commits
@@ -29,6 +29,35 @@ namespace std { #endif } // namespace std +namespace cwg2707 { // cwg2707: 20 + +#if __cplusplus >= 202002L + +template struct A { // #cwg2707-A + T value[N]; +}; + +template +A(T...) -> A requires (sizeof...(T) == 2); // #cwg2707-guide-A + +// Brace eli

[clang] [clang] Detect dangling assignment for "Container" case. (PR #108205)

2024-10-02 Thread Haojian Wu via cfe-commits
@@ -601,17 +601,23 @@ void test() { std::optional o4 = std::optional(s); // FIXME: should work for assignment cases hokein wrote: Done. https://github.com/llvm/llvm-project/pull/108205 ___ cfe-commits mailing

[clang] [clang] Detect dangling assignment for "Container" case. (PR #108205)

2024-10-02 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/108205 >From ff2f955965fd5f8f17ae76a11e495217aa4f02fd Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Wed, 2 Oct 2024 13:26:44 +0200 Subject: [PATCH] [clang] Detect dangling assignment for "Container" case. --- clang

[clang] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 (PR #110842)

2024-10-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/110842 >From 5660d1ee7f5b815061f04e2f77eb1abced041ea6 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 2 Oct 2024 21:41:53 +0800 Subject: [PATCH 1/2] [Clang][NFC] Rearrange tests for CWG 2707 after #110473 ---

[clang] [clang] Detect dangling assignment for "Container" case. (PR #108205)

2024-10-02 Thread Haojian Wu via cfe-commits
@@ -601,17 +601,23 @@ void test() { std::optional o4 = std::optional(s); // FIXME: should work for assignment cases - v1 = {std::string()}; - o1 = std::string(); + v1 = {std::string()}; // expected-warning {{object backing the pointer}} + o1 = std::string(); // expect

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,102 @@ +//===-- LLVMTargetMachineC.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

<    1   2   3   4   5   >