[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
@@ -54,14 +54,14 @@ static std::string computeDataLayout(const Triple &TT) { // memory model used for graphics: PhysicalStorageBuffer64. But it shouldn't // mean anything. if (Arch == Triple::spirv32) -return "e-p:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-" -

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-10-01 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson commented: I started reviewing this but all the unrelated formatting changes made this quite difficult. Would appreciate a minimal diff with just the changes that are needed for WASM. https://github.com/llvm/llvm-project/pull/79667 ___

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-10-01 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/110188 >From a28f8e716a7efe356e0088c00257edfc15132cb7 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Mar 2023 14:01:36 -0700 Subject: [PATCH] [clang] Add "debug_transparent" attribute The `debug_tran

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-01 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/18] Made MMIW

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Francis Visoiu Mistrih via cfe-commits
https://github.com/francisvm updated https://github.com/llvm/llvm-project/pull/110198 >From a97d39c9e3f609eb8087be80accd48f2070ad103 Mon Sep 17 00:00:00 2001 From: Francis Visoiu Mistrih Date: Thu, 26 Sep 2024 18:05:09 -0700 Subject: [PATCH] [Clang] Add __builtin_elementwise|reduce_max|minimum

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-10-01 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 updated https://github.com/llvm/llvm-project/pull/110188 >From 807fc9a690555930ef0c047f0c4253c6204376a9 Mon Sep 17 00:00:00 2001 From: Augusto Noronha Date: Thu, 30 Mar 2023 14:01:36 -0700 Subject: [PATCH] [clang] Add "debug_transparent" attribute The `debug_tran

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-10-01 Thread Alexander Richardson via cfe-commits
@@ -12,7 +12,7 @@ // functions. We need to ensure that the return value is sign-extended in the // same way as GCC expects (since otherwise GCC-generated __builtin_isinf // returns true for finite 128-bit floating-point numbers). -#ifdef __aarch64__ +#if defined(__aarch64__) ||

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-10-01 Thread Shilei Tian via cfe-commits
shiltian wrote: > > > I would like to avoid adding additional special properties to AS0, or > > > defining the flat concept. > > > > > > How can we add a new specification w/o defining it? > > By not defining it in terms of flat addressing. Just make it the undesirable > address space But t

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 commented: CGDebugInfo related changes LGTM, I'll let the others comment on the rest https://github.com/llvm/llvm-project/pull/110188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-10-01 Thread Matin Raayai via cfe-commits
matinraayai wrote: @MatzeB @arsenm in the latest commit I had to fix the issue you ran into in the following links @arsenm mentioned earlier: https://lists.llvm.org/pipermail/llvm-dev/2017-October/117907.html https://reviews.llvm.org/D38482 https://reviews.llvm.org/D38489 I can live with `Targ

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-10-01 Thread Keith Smiley via cfe-commits
keith wrote: the latest commit seems to have fixed it! https://github.com/llvm/llvm-project/pull/109909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsics (PR #110739)

2024-10-01 Thread Finn Plummer via cfe-commits
https://github.com/inbelic created https://github.com/llvm/llvm-project/pull/110739 - create a clang built-in - add mapping to dxil opcode - add lowering to SPIR-V GroupNonUniformShuffle with Scope = 2 (Group) - add sema checks - add related tests Resolves #70104 >Fr

[clang] [Clang][Driver][AArch64] Add support for aarch64-amazon-linux triple (PR #109263)

2024-10-01 Thread Stewart Smith via cfe-commits
stewartsmith wrote: For context and history on Amazon Linux and triplets: Amazon Linux 1 (otherwise known as Amazon Linux AMI / al-ami) is (was?) the now End-of-Life first Amazon Linux version. It was only ever built for x86 and x86-64, and used the $ARCH-amazon-linux triplet. The [last 32bit

[clang] [llvm] Add cross builtins and cross HLSL function to DirectX and SPIR-V backend (PR #109180)

2024-10-01 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/109180 >From 3c58861f3e8c2f1333d0b36c6f5b7ba7f3d9e187 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 18 Sep 2024 12:20:19 -0700 Subject: [PATCH 1/8] add cross hlsl function --- clang/include/clang/Basic/Bu

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsics (PR #110739)

2024-10-01 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/110739 >From cb3467d7395f7a1a0d0acdaee305f8c3c41892b1 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Wed, 25 Sep 2024 15:09:48 -0700 Subject: [PATCH] [HLSL] Implement `WaveReadLaneAt` intrinsics - create a clan

[clang] [libc] [llvm] [mlir] [TableGen] Change `getValueAsListOfDefs` return const pointer vector (PR #110713)

2024-10-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/110713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [mlir] [TableGen] Change `getValueAsListOfDefs` return const pointer vector (PR #110713)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-globalisel @llvm/pr-subscribers-backend-directx Author: Rahul Joshi (jurahul) Changes Change `getValueAsListOfDefs` to return a vector of const Record pointer, and remove `getValueAsListOfConstDefs` that was added as a transition aid. --- Patch i

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsics (PR #110739)

2024-10-01 Thread Finn Plummer via cfe-commits
@@ -2653,6 +2653,21 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, .addUse(GR.getSPIRVTypeID(ResType)) .addUse(GR.getOrCreateConstInt(3, I, IntTy, TII)); } + case Intrinsic::spv_wave_read_lane_at: { +assert(I.getNumOperands() == 4);

[clang] [libc] [llvm] [mlir] [TableGen] Change `getValueAsListOfDefs` to return const pointer vector (PR #110713)

2024-10-01 Thread Rahul Joshi via cfe-commits
jurahul wrote: Thanks @River707 https://github.com/llvm/llvm-project/pull/110713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsics (PR #110739)

2024-10-01 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/110739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-10-01 Thread Louis Dionne via cfe-commits
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG) # required during compilation (which has the -nostdlib++ or -nodefaultlibs). libc is # required for the link to go through. We remove sanitizers from the # configuration checks to avoid spurious link

[clang] a140931 - [TableGen] Change `getValueAsListOfDefs` to return const pointer vector (#110713)

2024-10-01 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-10-01T14:30:38-07:00 New Revision: a140931be5080543372ed833aea4e8f9c96bc4b5 URL: https://github.com/llvm/llvm-project/commit/a140931be5080543372ed833aea4e8f9c96bc4b5 DIFF: https://github.com/llvm/llvm-project/commit/a140931be5080543372ed833aea4e8f9c96bc4b5.diff L

[clang] [libc] [llvm] [mlir] [TableGen] Change `getValueAsListOfDefs` to return const pointer vector (PR #110713)

2024-10-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/110713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Ellis Hoag via cfe-commits
ellishg wrote: Why not use the existing `-pgo-function-entry-coverage` (https://discourse.llvm.org/t/instrprofiling-lightweight-instrumentation/59113/14?u=ellishg) LLVM flag? It takes advantage of the `llvm.instrprof.cover` intrinsic which has less size and runtime overhead than `llvm.instrpro

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsics (PR #110739)

2024-10-01 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/110739 >From 0320a5acec2565608cb91b271f6cda49fc364bb7 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Wed, 25 Sep 2024 15:09:48 -0700 Subject: [PATCH] [HLSL] Implement `WaveReadLaneAt` intrinsics - create a clan

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsics (PR #110739)

2024-10-01 Thread Finn Plummer via cfe-commits
@@ -414,13 +434,15 @@ Expected DXILOpBuilder::tryCreateOp(dxil::OpCode OpCode, uint16_t ValidTyMask = Prop->Overloads[*OlIndexOrErr].ValidTys; - OverloadKind Kind = getOverloadKind(OverloadTy); + OverloadKind Kind = getOverloadKind(OverloadTy, Prop->AllowVectorOverloads)

[clang] [llvm] [HLSL] Implement `WaveReadLaneAt` intrinsics (PR #110739)

2024-10-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f3c408d1726f6a921212faf68085f68bf8533f0c 0320a5acec2565608cb91b271f6cda49fc364bb7 --e

[clang] [libc] [llvm] [mlir] [TableGen] Change `getValueAsListOfDefs` to return const pointer vector (PR #110713)

2024-10-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/110713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [mlir] [TableGen] Change `getValueAsListOfDefs` return const pointer vector (PR #110713)

2024-10-01 Thread River Riddle via cfe-commits
https://github.com/River707 approved this pull request. https://github.com/llvm/llvm-project/pull/110713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [llvm] [mlir] [TableGen] Change `getValueAsListOfDefs` return const pointer vector (PR #110713)

2024-10-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/110713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [IR] Introduce `T` to `DataLayout` to represent flat address space if a target supports it (PR #108786)

2024-10-01 Thread Matt Arsenault via cfe-commits
arsenm wrote: > > I would like to avoid adding additional special properties to AS0, or > > defining the flat concept. > > How can we add a new specification w/o defining it? By not defining it in terms of flat addressing. Just make it the undesirable address space https://github.com/llvm/ll

[clang] isUncountedPtr should take QualType as an argument. (PR #110213)

2024-10-01 Thread Artem Dergachev via cfe-commits
@@ -190,11 +190,7 @@ class UncountedLocalVarsChecker if (shouldSkipVarDecl(V)) return; -const auto *ArgType = V->getType().getTypePtr(); -if (!ArgType) haoNoQ wrote: Some of these null checks may still be necessary (with `QualType.isNull()`)

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-01 Thread Brad Richardson via cfe-commits
everythingfunctional wrote: Sounds like I should just add the warning to OpenMP for now. I'll work on getting that added and then figure out why the CI is failing. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commi

[clang] b70d327 - [HLSL][clang] Add elementwise builtin for atan2 (p3) (#110187)

2024-10-01 Thread via cfe-commits
Author: Tex Riddell Date: 2024-10-01T14:41:43-07:00 New Revision: b70d32789c9463d49b46b4e57c44607d1c956e4c URL: https://github.com/llvm/llvm-project/commit/b70d32789c9463d49b46b4e57c44607d1c956e4c DIFF: https://github.com/llvm/llvm-project/commit/b70d32789c9463d49b46b4e57c44607d1c956e4c.diff L

[clang] [HLSL][clang] Add elementwise builtin for atan2 (p3) (PR #110187)

2024-10-01 Thread Tex Riddell via cfe-commits
https://github.com/tex3d closed https://github.com/llvm/llvm-project/pull/110187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [TableGen] Change `DefInit::Def` to a const Record pointer (PR #110747)

2024-10-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/110747 None >From 81a1ee1b8d09f22a4700b8e5dd59278759f59f8f Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Tue, 1 Oct 2024 12:05:15 -0700 Subject: [PATCH] [TableGen] Change `DefInit::Def` to a const Record pointer -

[clang] [llvm] [mlir] [TableGen] Change `DefInit::Def` to a const Record pointer (PR #110747)

2024-10-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/110747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

2024-10-01 Thread Reid Kleckner via cfe-commits
rnk wrote: > If the function-local types should not be ODR-uniqued, then dropping the > identifier field sounds correct. I can't speak to the complexities of the alternative, but I'm immediately suspicious of this direction. We have stable manglings for static locals in inline functions and s

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Ellis Hoag via cfe-commits
ellishg wrote: > > Why not use the existing `-pgo-function-entry-coverage` > > (https://discourse.llvm.org/t/instrprofiling-lightweight-instrumentation/59113/14?u=ellishg) > > LLVM flag? It takes advantage of the `llvm.instrprof.cover` intrinsic > > which has less size and runtime overhead tha

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/110767 This was originally added in https://reviews.llvm.org/D142268 have LLDB display variable typenames that benefit from suppressing defaulted template arguments. We currently represent template aliases as `DW_A

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes This was originally added in https://reviews.llvm.org/D142268 have LLDB display variable typenames that benefit from suppressing defaulted template arguments. We currently represent template aliases as `D

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Michael Buch (Michael137) Changes This was originally added in https://reviews.llvm.org/D142268 have LLDB display variable typenames that benefit from suppressing defaulted template arguments. We currently represent template alias

[clang] [clang] Improve deduction of reference typed NTTP (PR #110393)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/110393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d214bec - [clang] Improve deduction of reference typed NTTP (#110393)

2024-10-01 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-10-01T20:57:47-03:00 New Revision: d214bec5161e9e6fd9e4c024f6068597822b1d4e URL: https://github.com/llvm/llvm-project/commit/d214bec5161e9e6fd9e4c024f6068597822b1d4e DIFF: https://github.com/llvm/llvm-project/commit/d214bec5161e9e6fd9e4c024f6068597822b1d4e.dif

[clang] [clang][frontend] Add support for attribute plugins for statement attributes (PR #110334)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide commented: Looks ok to me, but I’ll leave it to @erichkeane to approve this as he’s the attributes code owner. https://github.com/llvm/llvm-project/pull/110334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] Allow tag-based API notes on anonymous tag decls with typedef names (PR #110768)

2024-10-01 Thread Doug Gregor via cfe-commits
https://github.com/DougGregor created https://github.com/llvm/llvm-project/pull/110768 It is common practice in C to declare anonymous tags that are immediately given a typedef name, e.g., typedef enum { ... } MyType; At present, one can only express API notes on the typedef. However, tha

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
@@ -314,51 +314,91 @@ class APValue { DataType Data; public: + /// Creates an empty APValue of type None. APValue() : Kind(None) {} + /// Creates an integer APValue holding the given value. explicit APValue(APSInt I) : Kind(None) { MakeInt(); setInt(std::move(I)

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
@@ -314,51 +314,91 @@ class APValue { DataType Data; public: + /// Creates an empty APValue of type None. APValue() : Kind(None) {} + /// Creates an integer APValue holding the given value. explicit APValue(APSInt I) : Kind(None) { MakeInt(); setInt(std::move(I)

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
@@ -314,51 +314,91 @@ class APValue { DataType Data; public: + /// Creates an empty APValue of type None. APValue() : Kind(None) {} + /// Creates an integer APValue holding the given value. explicit APValue(APSInt I) : Kind(None) { MakeInt(); setInt(std::move(I)

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread via cfe-commits
@@ -314,51 +314,91 @@ class APValue { DataType Data; public: + /// Creates an empty APValue of type None. APValue() : Kind(None) {} + /// Creates an integer APValue holding the given value. explicit APValue(APSInt I) : Kind(None) { MakeInt(); setInt(std::move(I)

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-10-01 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/91101 >From 74e64cd80956d599548041d25e4fdfd1cd1c8d68 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Sat, 4 May 2024 18:12:34 -0500 Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter attrib

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: You should be able to re-land your change if you add the test fix to it. https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
https://github.com/zeroomega created https://github.com/llvm/llvm-project/pull/110777 This patch fixes an issue when test runner cannot find libwind library when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used. >From c8d071ba2bc9dae14676304dc6a221319527ffe0 Mon Sep 17 00:00:00 2001 From: Haowei Wu

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Haowei (zeroomega) Changes This patch fixes an issue when test runner cannot find libwind library when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is used. --- Full diff: https://github.com/llvm/llvm-project/pull/110777.diff 1 Files Affected

[libunwind] [libunwind] Fix libunwind library path for runtime test (PR #110777)

2024-10-01 Thread via cfe-commits
zeroomega wrote: Test run on our downstream bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/clang-linux-x64/b8735236964550803665/overview This patch should address the build failure introduced in PR #110171 https://github.com/llvm/llvm-project/pull/110777 ___

[clang] Draft (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110773 >From 59c8706f4bb83228fb476d3205d96f767080a0fc Mon Sep 17 00:00:00 2001 From: c8ef Date: Wed, 2 Oct 2024 08:54:59 +0800 Subject: [PATCH 1/2] this diagose --- clang/lib/Parse/ParseDecl.cpp | 15 +-- cl

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: I just pushed a fix for the test: https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765 https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread via cfe-commits
zeroomega wrote: > Oh dang. That's why I didn't see an update. Because the revert wasn't pushed > to llvm/main, it was a revert on another repo. Looks like I could re-apply > the test fix again unless you're planning on doing a revert on llvm/main. Yes, I was testing the revert by pushing int

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Tex Riddell via cfe-commits
tex3d wrote: Oh dang. That's why I didn't see an update. Because the revert wasn't pushed to llvm/main, it was a revert on another repo. Looks like I could re-apply the test fix again unless you're planning on doing a revert on llvm/main. https://github.com/llvm/llvm-project/pull/110198 ___

[clang] [Clang][Sema] Fix templated array size calculation. (PR #96464)

2024-10-01 Thread via cfe-commits
https://github.com/awson updated https://github.com/llvm/llvm-project/pull/96464 >From 096b999120cc28844d780acbc16f8308b3a54160 Mon Sep 17 00:00:00 2001 From: awson Date: Mon, 24 Jun 2024 10:34:51 +0300 Subject: [PATCH 1/3] [Clang][Sema] don't handle ArraySize/AllocType early. --- clang/lib/Se

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/109994 >From 012465670c63c3283a42a275cf3e5be0c5ffe9f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Wed, 25 Sep 2024 16:42:55 +0200 Subject: [PATCH] [clang][docs] Add documentation for APValue con

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-10-01 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 7ea9d3dbb6ff74ca3f7f9b9a0c589e4a0a3366f2 Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH 1/2] Add Clang attribute to ensure that fields are

[clang] [clang][docs] Add documentation for APValue constructors (PR #109994)

2024-10-01 Thread Timm Baeder via cfe-commits
@@ -314,51 +314,91 @@ class APValue { DataType Data; public: + /// Creates an empty APValue of type None. APValue() : Kind(None) {} + /// Creates an integer APValue holding the given value. explicit APValue(APSInt I) : Kind(None) { MakeInt(); setInt(std::move(I)

[clang] e1e788f - [clang][bytecode] Protect ia32_{lzcnt,tzcnt} against non-integers (#110699)

2024-10-01 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-02T05:44:54+02:00 New Revision: e1e788f423b5c780c40912ab102b0a3c4b92b9de URL: https://github.com/llvm/llvm-project/commit/e1e788f423b5c780c40912ab102b0a3c4b92b9de DIFF: https://github.com/llvm/llvm-project/commit/e1e788f423b5c780c40912ab102b0a3c4b92b9de.diff L

[clang] [clang][bytecode] Protect ia32_{lzcnt,tzcnt} against non-integers (PR #110699)

2024-10-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-01 Thread via cfe-commits
yonghong-song wrote: @peilin-ye Sorry for late review. A few general observations below: 1. I think -mcpu=v5 can be avoided. We really want to accumulate quite some insns before increasing cpu version. Otherwise, we may quickly reach v7/v8/... which people will lose check which version support

[libcxx] [libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-10-01 Thread Louis Dionne via cfe-commits
ldionne wrote: Thanks for the analysis. Per-target runtime dir strikes again! That setting keeps on creating issues (by no fault of its own) because it's not the default. Can we do something like this instead, then? ``` config.substitutions.append(('%{lib}', '@LIBUNWIND_TESTING_INSTALL_PREFIX

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Francis Visoiu Mistrih via cfe-commits
https://github.com/francisvm updated https://github.com/llvm/llvm-project/pull/110198 >From 4813faaa689e1db144988fdb6312b7497ac9717e Mon Sep 17 00:00:00 2001 From: Francis Visoiu Mistrih Date: Thu, 26 Sep 2024 18:05:09 -0700 Subject: [PATCH] [Clang] Add __builtin_elementwise|reduce_max|minimum

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-10-01 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,25 @@ + ldionne wrote: Ack. Just be aware that so long as there's no CI job, the platform is not officially supported so it may happen that we'll make changes that will make your life harder. We won't do it on purpose, of course, but it could happen

[clang] [compiler-rt] [libcxx] [cmake] Add hexagon-linux cmake cache files (PR #98712)

2024-10-01 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/98712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9440420 - [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (#110198)

2024-10-01 Thread via cfe-commits
Author: Francis Visoiu Mistrih Date: 2024-10-01T15:39:23-07:00 New Revision: 9440420f63b791126a13426b94339aeac575b50f URL: https://github.com/llvm/llvm-project/commit/9440420f63b791126a13426b94339aeac575b50f DIFF: https://github.com/llvm/llvm-project/commit/9440420f63b791126a13426b94339aeac575b

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Francis Visoiu Mistrih via cfe-commits
https://github.com/francisvm closed https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Ellis Hoag via cfe-commits
@@ -0,0 +1,12 @@ +// Test -fprofile-generate-cold-function-coverage +// RUN: %clang -O2 -fprofile-generate-cold-function-coverage=/xxx/yyy/ -fprofile-sample-accurate -fprofile-sample-use=%S/Inputs/pgo-cold-func.prof -S -emit-llvm -o - %s | FileCheck %s ellishg

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes Consider #109148: ```c++ template void f() { [] { (^Ts); }; } ``` When we encounter `^Ts`, we try to parse a block and subsequently call `DiagnoseUnexpandedParameterPack()` (in `Act

[clang] Draft (PR #110773)

2024-10-01 Thread via cfe-commits
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/110773 None >From 59c8706f4bb83228fb476d3205d96f767080a0fc Mon Sep 17 00:00:00 2001 From: c8ef Date: Wed, 2 Oct 2024 08:54:59 +0800 Subject: [PATCH] this diagose --- clang/lib/Parse/ParseDecl.cpp | 15 +--

[clang] 793ded7 - Fix failing test caused by b70d327

2024-10-01 Thread Tex Riddell via cfe-commits
Author: Tex Riddell Date: 2024-10-01T18:05:05-07:00 New Revision: 793ded7d0b7f1407636a98007f83074b8dd5f765 URL: https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765 DIFF: https://github.com/llvm/llvm-project/commit/793ded7d0b7f1407636a98007f83074b8dd5f765.diff L

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-01 Thread Francis Visoiu Mistrih via cfe-commits
francisvm wrote: Thank you @tex3d, sorry about that! https://github.com/llvm/llvm-project/pull/110198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v5 (PR #108636)

2024-10-01 Thread Peilin Ye via cfe-commits
@@ -522,6 +526,28 @@ let Predicates = [BPFNoALU32] in { } def STD : STOREi64; +class relaxed_store + : PatFrag<(ops node:$val, node:$ptr), (base node:$val, node:$ptr)> { + let IsAtomic = 1; + let IsAtomicOrderingReleaseOrStronger = 0; +} + +class releasing_store + : PatFra

[clang] 5d308af - Revert "Fix failing test caused by b70d327"

2024-10-01 Thread Tex Riddell via cfe-commits
Author: Tex Riddell Date: 2024-10-01T18:11:20-07:00 New Revision: 5d308af894ccc3f7a288d6abd6f9097b4cbc8cf4 URL: https://github.com/llvm/llvm-project/commit/5d308af894ccc3f7a288d6abd6f9097b4cbc8cf4 DIFF: https://github.com/llvm/llvm-project/commit/5d308af894ccc3f7a288d6abd6f9097b4cbc8cf4.diff L

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/110695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
arsenm wrote: > 1. Usually (or at least AFAIK) optimization passes won't consider datalayout > automatically, The datalayout is a widely used global constant. There's no option of "not considering it" > Do you plan to go over LLVM passes adding this check? There's nothing new to do here. T

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-01 Thread Matt Arsenault via cfe-commits
@@ -1,56 +0,0 @@ -; This test aims to check ability to support "Arithmetic with Overflow" intrinsics arsenm wrote: > Right but it's relying on a non-guaranteed maybe-optimisation firing, as far > as I can tell. The point is to test the optimization does work.

[clang] [Clang] [NFC] Introduce `DynamicRecursiveASTVisitor` (PR #110040)

2024-10-01 Thread via cfe-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/110040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

2024-10-01 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/110761 Fixes #101863 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH] [Clang] omit parentheses in fold expressions with

[clang] [Clang] [Sema] Don't crash on unexpanded pack in invalid block literal (PR #110762)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/110762 Consider #109148: ```c++ template void f() { [] { (^Ts); }; } ``` When we encounter `^Ts`, we try to parse a block and subsequently call `DiagnoseUnexpandedParameterPack()` (in `ActOnBlockArgu

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-10-01 Thread via cfe-commits
goldsteinn wrote: > It looks like this change causes regressions in sinking/hoisting, because we > currently can't handle identical calls with different call site attributes. > Basic example: https://llvm.godbolt.org/z/5dTcTfs1x > > We need to extend the attribute intersection support to call

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide commented: This is still missing a release note, and adding the source range too would be nice. https://github.com/llvm/llvm-project/pull/110239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/110239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-01 Thread via cfe-commits
@@ -7949,7 +7949,8 @@ NamedDecl *Sema::ActOnVariableDeclarator( } if (!R->isIntegralType(Context) && !R->isPointerType()) { -Diag(D.getBeginLoc(), diag::err_asm_bad_register_type); +Diag(TInfo->getTypeLoc().getBeginLoc(), + diag::err_asm

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-01 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm edited https://github.com/llvm/llvm-project/pull/109837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-10-01 Thread via cfe-commits
Sirraide wrote: > I also think that "bad" is a confusing word to use here, "unsupported" would > be better but I will address that in a follow up PR. I don’t have a problem w/ ‘bad’, but ‘unsupported’ is clearer, yeah https://github.com/llvm/llvm-project/pull/110239 ___

[clang] [clang] Finish implementation of P0522 (PR #96023)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/96023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] CWG2398: improve overload resolution backwards compat (PR #107350)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/107350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6afe567 - [clang] Finish implementation of P0522 (#96023)

2024-10-01 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-10-01T20:50:26-03:00 New Revision: 6afe56732a172d3f2cbd0330b1fcb34bbfd002a9 URL: https://github.com/llvm/llvm-project/commit/6afe56732a172d3f2cbd0330b1fcb34bbfd002a9 DIFF: https://github.com/llvm/llvm-project/commit/6afe56732a172d3f2cbd0330b1fcb34bbfd002a9.dif

[clang] [clang] Improve deduction of reference typed NTTP (PR #110393)

2024-10-01 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/110393 >From a06cdbc7a2d010a3f3081b7eb53326aeb7a702b1 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 28 Sep 2024 21:40:54 -0300 Subject: [PATCH] [clang] Improve deduction of reference typed NTTP This impro

[clang] b38b34c - [clang] Remove 'PCH' from more diagnostics that were wrong or misleading NFC (#110724)

2024-10-01 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-10-01T16:52:02-07:00 New Revision: b38b34c51a115982912256dd940f2e1b794b7d3a URL: https://github.com/llvm/llvm-project/commit/b38b34c51a115982912256dd940f2e1b794b7d3a DIFF: https://github.com/llvm/llvm-project/commit/b38b34c51a115982912256dd940f2e1b794b7d3a.diff

[clang] [clang] Remove 'PCH' from more diagnostics that were wrong or misleading NFC (PR #110724)

2024-10-01 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/110724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix eager skipping on new with unknown type and no new-initializer (PR #110133)

2024-10-01 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM. `ParseExpressionList()` is used in a lot of places, but given that almost all the other tests seem to have no problem with this change (which honestly surprises me a bit), I feel like this is reasonable (in the tests that are affec

[clang] [Clang][CodeGen] Emit load of GEP after EmitMemberExpr (PR #110487)

2024-10-01 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: > I reverted my last commit. This leaves the original patch, which seems to > work. @efriedma-quic, would you be okay with this patch while I work to > improve the code in follow-up? The original (and current) patch in this PR still introduces a regression. So it should not be me

[clang] 4bd81c5 - [Clang] Fix eager skipping in `ParseExpressionList()` (#110133)

2024-10-01 Thread via cfe-commits
Author: Alejandro Álvarez Ayllón Date: 2024-10-02T01:54:29+02:00 New Revision: 4bd81c5738d00c9111fc11cb9990a9377d33eaf3 URL: https://github.com/llvm/llvm-project/commit/4bd81c5738d00c9111fc11cb9990a9377d33eaf3 DIFF: https://github.com/llvm/llvm-project/commit/4bd81c5738d00c9111fc11cb9990a9377d3

<    1   2   3   4   5   >