[clang-tools-extra] [clang-tidy][NFC] optimize unused using decls performance (PR #110200)

2024-09-28 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/110200 >From aee3cc16d9c36d2cc56247ec14f72730c7b65e80 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 26 Sep 2024 17:48:48 +0800 Subject: [PATCH 1/2] [clang-tidy][NFC] optimize unused using decls performance

[clang] [clang][bytecode] Implement (N)EQ between fixed point and integral (PR #110358)

2024-09-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/2903 Here is the relevant piece of the build log fo

[clang] [clang][bytecode] Implement floating-to-fixed-point casts (PR #110361)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/110361 None >From 7583fed959318e8f0e01957d7e278998510d9b0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 28 Sep 2024 15:50:04 +0200 Subject: [PATCH] [clang][bytecode] Implement floating-to-f

[clang] [clang][bytecode] Implement floating-to-fixed-point casts (PR #110361)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110361.diff 4 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+9) - (modified) clang/lib/AST/ByteCode/Interp.h (+31-4) - (modif

[clang] [clang][CGOpenMPRuntimeGPU] Avoid llvm::Type::getPointerTo() (NFC) (PR #110357)

2024-09-28 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/110357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Concepts] Normalize SizeOfPackExpr's pack declaration (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/110238 >From 23a765ac6d8e455121346405332d2066dcc0861e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 27 Sep 2024 18:23:47 +0800 Subject: [PATCH 1/7] [Clang] GH93099 --- clang/include/clang/Sema/Sema.h

[clang] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

2024-09-28 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza created https://github.com/llvm/llvm-project/pull/110366 Closes #107445 From 4fb69942effb3cf34d07f33a14a95757b6ca5ee0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= Date: Sat, 28 Sep 2024 17:05

[clang] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Зишан Мирза (zimirza) Changes Closes #107445 --- Full diff: https://github.com/llvm/llvm-project/pull/110366.diff 5 Files Affected: - (modified) clang/docs/tools/clang-formatted-files.txt (+8) - (modified) clang/lib/StaticAnalyzer/Chec

[clang] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Зишан Мирза (zimirza) Changes Closes #107445 --- Full diff: https://github.com/llvm/llvm-project/pull/110366.diff 5 Files Affected: - (modified) clang/docs/tools/clang-formatted-files.txt (+8) - (modified) clang/lib/S

[clang] [clang-tools-extra] [clang-tidy] add `ctime` and `localtime` to `clang-tidy` (PR #110366)

2024-09-28 Thread Зишан Мирза via cfe-commits
https://github.com/zimirza updated https://github.com/llvm/llvm-project/pull/110366 From 4fb69942effb3cf34d07f33a14a95757b6ca5ee0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=97=D0=B8=D1=88=D0=B0=D0=BD=20=D0=9C=D0=B8=D1=80=D0=B7?= =?UTF-8?q?=D0=B0?= Date: Sat, 28 Sep 2024 17:05:42 +0200 Subjec

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-28 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > Therefore, I recommend adding the void parameter check directly into > SemaExprCXX for an immediate fix. If there's a future need to consolidate the > checks, we can consider refactoring later. That works for me if it turns out to take much more effort than our anticipation,

[clang] 6cbd8a3 - [clang][bytecode] Implement floating-to-fixed-point casts (#110361)

2024-09-28 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-28T17:24:28+02:00 New Revision: 6cbd8a309485329a4fbfe7abf7b85e0b8f154561 URL: https://github.com/llvm/llvm-project/commit/6cbd8a309485329a4fbfe7abf7b85e0b8f154561 DIFF: https://github.com/llvm/llvm-project/commit/6cbd8a309485329a4fbfe7abf7b85e0b8f154561.diff L

[clang] [clang][bytecode] Implement fixed-point-to-float casts (PR #110369)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/110369 None >From af2fe551a5324cd1274e1da8d6a14303646ae5b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 28 Sep 2024 16:02:56 +0200 Subject: [PATCH] [clang][bytecode] Implement fixed-point-t

[clang] [clang][bytecode] Implement floating-to-fixed-point casts (PR #110361)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement fixed-point-to-float casts (PR #110369)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110369.diff 5 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+6) - (modified) clang/lib/AST/ByteCode/FixedPoint.h (+4) - (modi

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-09-28 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] 1c2ed36 - [clang][x86] Add constexpr support for BMI/TBM BEXTR intrinsics (#109577)

2024-09-28 Thread via cfe-commits
Author: Simon Pilgrim Date: 2024-09-28T17:52:54+01:00 New Revision: 1c2ed36741c6bc3921d2566123019079c4249c1a URL: https://github.com/llvm/llvm-project/commit/1c2ed36741c6bc3921d2566123019079c4249c1a DIFF: https://github.com/llvm/llvm-project/commit/1c2ed36741c6bc3921d2566123019079c4249c1a.diff

[clang] [clang][x86] Add constexpr support for BMI/TBM BEXTR intrinsics (PR #109577)

2024-09-28 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon closed https://github.com/llvm/llvm-project/pull/109577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3a5b9da - [clang][bytecode] Implement fixed-point-to-float casts (#110369)

2024-09-28 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-28T19:11:49+02:00 New Revision: 3a5b9da11598e714890f4e9f37f894fc2c7287c2 URL: https://github.com/llvm/llvm-project/commit/3a5b9da11598e714890f4e9f37f894fc2c7287c2 DIFF: https://github.com/llvm/llvm-project/commit/3a5b9da11598e714890f4e9f37f894fc2c7287c2.diff L

[clang] [clang][bytecode] Implement fixed-point-to-float casts (PR #110369)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-28 Thread Chris B via cfe-commits
@@ -422,6 +422,55 @@ template constexpr uint asuint(T F) { return __detail::bit_cast(F); } +//===--===// +// asuint splitdouble builtins +//===---

[clang] [RISCV][FMV] Support target_version (PR #99040)

2024-09-28 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/99040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-28 Thread Chris B via cfe-commits
@@ -438,6 +438,55 @@ template constexpr uint asuint(T F) { return __detail::bit_cast(F); } +//===--===// +// asuint splitdouble builtins +//===---

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-28 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod updated https://github.com/llvm/llvm-project/pull/110154 >From e58b244f90c0d9863a41721b7c981d5d853b3d38 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 18:59:33 +0100 Subject: [PATCH] [Clang] Update Interpreter tests to use clang_target_link_libra

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-28 Thread Chris B via cfe-commits
@@ -3,12 +3,12 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-compute %s -S -o /dev/null 2>&1 | FileCheck --allow-empty --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-vulkan-compute %s -S -o /dev/null 2>&1 | FileCheck --al

[clang] [llvm] [cuda][HIP] `__constant__` should imply constant (PR #110182)

2024-09-28 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/110182 >From af1adfafaa09bc7992cf9aaf34a6121cf2d56d5b Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Thu, 26 Sep 2024 04:16:52 +0100 Subject: [PATCH 1/3] Mark globals as `constant` if they have been annotated with `_

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-28 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/109331 >From ef969c536d700a8585f0892952fae49cdd9c42d1 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Thu, 19 Sep 2024 00:13:51 + Subject: [PATCH 01/10] Codegen builtin --- clang/include/clang/Basic/Builtin

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-28 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/109331 >From ef969c536d700a8585f0892952fae49cdd9c42d1 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Thu, 19 Sep 2024 00:13:51 + Subject: [PATCH 01/10] Codegen builtin --- clang/include/clang/Basic/Builtin

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-28 Thread via cfe-commits
@@ -438,6 +438,55 @@ template constexpr uint asuint(T F) { return __detail::bit_cast(F); } +//===--===// +// asuint splitdouble builtins +//===---

[clang] [clang-format] Add an option to control indentation of `export { ... }` (PR #110381)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: None (Sirraide) Changes `export { ... }` blocks can get a bit long, so I thought it would make sense to have an option that makes it so their contents are not indented (basically the same argument as for namespaces). This is my fir

[clang] [clang-format] Add an option to control indentation of `export { ... }` (PR #110381)

2024-09-28 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/110381 `export { ... }` blocks can get a bit long, so I thought it would make sense to have an option that makes it so their contents are not indented (basically the same argument as for namespaces). This is my first

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-28 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/109331 >From ef969c536d700a8585f0892952fae49cdd9c42d1 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Thu, 19 Sep 2024 00:13:51 + Subject: [PATCH 01/10] Codegen builtin --- clang/include/clang/Basic/Builtin

[clang] [clang-format] Add an option to control indentation of `export { ... }` (PR #110381)

2024-09-28 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/110381 >From 570aff7459311a43cd9c9139de05dc2ab4cf762c Mon Sep 17 00:00:00 2001 From: Sirraide Date: Sat, 28 Sep 2024 20:36:38 +0200 Subject: [PATCH 1/3] [clang-format] Add an option to control indentation of `export

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-09-28 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd edited https://github.com/llvm/llvm-project/pull/95712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add inlay hints for default function arguments (PR #95712)

2024-09-28 Thread Tor Shepherd via cfe-commits
https://github.com/torshepherd edited https://github.com/llvm/llvm-project/pull/95712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-09-28 Thread Mehdi Amini via cfe-commits
@@ -231,6 +245,10 @@ linux_projects_to_test=$(exclude-linux $(compute-projects-to-test ${modified_pro linux_check_targets=$(check-targets ${linux_projects_to_test} | sort | uniq) linux_projects=$(add-dependencies ${linux_projects_to_test} | sort | uniq) +linux_runtimes_to_tes

[clang] [llvm] [Utils] Add new --update-tests flag to llvm-lit (PR #108425)

2024-09-28 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn updated https://github.com/llvm/llvm-project/pull/108425 >From 6cdb6bec945725d69d1073deeb53b7485c7e40cd Mon Sep 17 00:00:00 2001 From: "Henrik G. Olsson" Date: Wed, 28 Aug 2024 23:30:49 -0700 Subject: [PATCH 1/3] [Utils] Add --update-tests to lit This adds a flag to

[clang] [llvm] [Utils] Add new --update-tests flag to llvm-lit (PR #108425)

2024-09-28 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: > Thank you. This pretty much LGTM, but it just occurred to me that there's a > docs/CommandGuide/lit.rst which should be updated to document the new option. Done > As update-verify-tests was reverted, can you rebase this to just the > update_test_checks support? On the LLVM s

[clang] [llvm] [Utils] Add new --update-tests flag to llvm-lit (PR #108425)

2024-09-28 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn updated https://github.com/llvm/llvm-project/pull/108425 >From 6cdb6bec945725d69d1073deeb53b7485c7e40cd Mon Sep 17 00:00:00 2001 From: "Henrik G. Olsson" Date: Wed, 28 Aug 2024 23:30:49 -0700 Subject: [PATCH 1/2] [Utils] Add --update-tests to lit This adds a flag to

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank commented: IMO no need to update release notes: > Improved `readability-container-contains` check to let it work on any class > that has a contains method. But I think an example should be added to [the check documentation](https://github.com/llvm/llvm-project/blob

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
@@ -51,6 +53,12 @@ void ContainerContainsCheck::registerMatchers(MatchFinder *Finder) { const auto Literal0 = integerLiteral(equals(0)); const auto Literal1 = integerLiteral(equals(1)); + const auto StringLikeClass = cxxRecordDecl( + hasAnyName("::std::basic_string"

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
@@ -29,6 +29,43 @@ struct multimap { bool contains(const Key &K) const; }; +using size_t = decltype(sizeof(int)); + +// Lightweight standin for std::string_view. +template +class basic_string_view { +public: + basic_string_view(); + basic_string_view(const basic_string_vi

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
@@ -453,3 +490,15 @@ void testOperandPermutations(std::map& Map) { // CHECK-MESSAGES: :[[@LINE-1]]:{{[0-9]+}}: warning: use 'contains' to check for membership [readability-container-contains] // CHECK-FIXES: if (!Map.contains(0)) {}; } + +void testStringNops(std::string St

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
@@ -94,12 +102,14 @@ void ContainerContainsCheck::registerMatchers(MatchFinder *Finder) { binaryOperator(hasLHS(Literal1), hasOperatorName(">"), hasRHS(CountCall)) .bind("negativeComparison")); - // Find membership tests based on `find() == end()`. + // Find

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/110351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
@@ -32,7 +33,8 @@ void ContainerContainsCheck::registerMatchers(MatchFinder *Finder) { const auto FindCall = cxxMemberCallExpr( - argumentCountIs(1), + anyOf(argumentCountIs(1), +allOf(argumentCountIs(2), hasArgument(1, cxxDefaultArg

[clang-tools-extra] [clang-tidy][readability-container-contains] Fix matching of non-binaryOperator cases (PR #110386)

2024-09-28 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank created https://github.com/llvm/llvm-project/pull/110386 Fix #79437. It works with non-mock `std::map`: ``` # All cases detailed in #79437. > cat tmp.cpp #include bool a(std::map &m, int key) { return m.find(key) != m.end(); } bool b(std::map &m, int key) { return

[clang-tools-extra] [clang-tidy][readability-container-contains] Fix matching of non-binaryOperator cases (PR #110386)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy @llvm/pr-subscribers-clang-tools-extra Author: Nicolas van Kempen (nicovank) Changes Fix #79437. It works with non-mock `std::map`: ``` # All cases detailed in #79437. > cat tmp.cpp #include bool a(std::map &m, int key) { ret

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-28 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Same then, go ahead, but please make sure the error handling strategies don't diverge unnecessarily. https://github.com/llvm/llvm-project/pull/109831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-28 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/110387 This fixes handling of friend function templates instances when their template context changes, such as when a new friend declaration is introduced after an instance was already created from a previous declara

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes This fixes handling of friend function templates instances when their template context changes, such as when a new friend declaration is introduced after an instance was already created from a previous d

[clang] [Clang] GH93099 (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/110238 >From 23a765ac6d8e455121346405332d2066dcc0861e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 27 Sep 2024 18:23:47 +0800 Subject: [PATCH 1/4] [Clang] GH93099 --- clang/include/clang/Sema/Sema.h

[clang] 29d0a84 - [clang][CGOpenMPRuntimeGPU] Avoid llvm::Type::getPointerTo() (NFC) (#110357)

2024-09-28 Thread via cfe-commits
Author: Youngsuk Kim Date: 2024-09-28T09:57:20-04:00 New Revision: 29d0a8470426a8518da28c3e90ef884ad07f200a URL: https://github.com/llvm/llvm-project/commit/29d0a8470426a8518da28c3e90ef884ad07f200a DIFF: https://github.com/llvm/llvm-project/commit/29d0a8470426a8518da28c3e90ef884ad07f200a.diff

[clang] [clang][CGOpenMPRuntimeGPU] Avoid llvm::Type::getPointerTo() (NFC) (PR #110357)

2024-09-28 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 closed https://github.com/llvm/llvm-project/pull/110357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] GH93099 (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/110238 >From 23a765ac6d8e455121346405332d2066dcc0861e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 27 Sep 2024 18:23:47 +0800 Subject: [PATCH 1/5] [Clang] GH93099 --- clang/include/clang/Sema/Sema.h

[clang] [NFC] Correct the misuse of the API in the Clang test-report script. (PR #108725)

2024-09-28 Thread Tobias Hieta via cfe-commits
https://github.com/tru approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-09-28 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: gentle ping https://github.com/llvm/llvm-project/pull/102602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6b62e04 - [clang][bytecode] Implement (N)EQ between fixed point and integral (#110358)

2024-09-28 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-28T15:38:33+02:00 New Revision: 6b62e04e3045e5d8f4361afc100a460622266f82 URL: https://github.com/llvm/llvm-project/commit/6b62e04e3045e5d8f4361afc100a460622266f82 DIFF: https://github.com/llvm/llvm-project/commit/6b62e04e3045e5d8f4361afc100a460622266f82.diff L

[clang] [clang][bytecode] Implement (N)EQ between fixed point and integral (PR #110358)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] optimize unused using decls performance (PR #110200)

2024-09-28 Thread Congcong Cai via cfe-commits
@@ -25,6 +25,13 @@ AST_MATCHER_P(DeducedTemplateSpecializationType, refsToTemplatedDecl, return false; } +AST_MATCHER_P(Type, getTagDecl, clang::ast_matchers::internal::Matcher, + DeclMatcher) { + if (const auto *ND = Node.getAsTagDecl()) Her

[clang] [clang][CGOpenMPRuntimeGPU] Avoid llvm::Type::getPointerTo() (NFC) (PR #110357)

2024-09-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/6298 Here is the r

[clang] [Clang] GH93099 (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/110238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] GH93099 (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
zyn0217 wrote: The CI failure looks unrelated - it also *failed* in other PRs e.g. https://buildkite.com/llvm-project/github-pull-requests/builds/104957#019238e6-fd32-40a1-987a-4cd1c539926a (Which happens to fail in `std::common_type` that might have connections with the `sizeof...` expression

[clang] [Clang] GH93099 (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/110238 >From 23a765ac6d8e455121346405332d2066dcc0861e Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 27 Sep 2024 18:23:47 +0800 Subject: [PATCH 1/6] [Clang] GH93099 --- clang/include/clang/Sema/Sema.h

[clang] [Clang][Concepts] Normalize SizeOfPackExpr's pack declaration (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/110238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Concepts] Normalize SizeOfPackExpr's pack declaration (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/110238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Concepts] Normalize SizeOfPackExpr's pack declaration (PR #110238)

2024-09-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/110238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Concepts] Normalize SizeOfPackExpr's pack declaration (PR #110238)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes SizeOfPackExpr has a pointer to the referenced pack declaration, which is left as-is during the transformation process. The situation could be subtle when a friend class template declaration comes into play

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-28 Thread Keith Smiley via cfe-commits
https://github.com/keith updated https://github.com/llvm/llvm-project/pull/109909 >From 4676d022d971ef1623b83a2731ce94572905d6ad Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Wed, 25 Sep 2024 05:38:04 + Subject: [PATCH 1/2] workflows/release-binaries: Use static ZSTD on macOS On macOS

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-28 Thread Keith Smiley via cfe-commits
@@ -126,7 +126,7 @@ jobs: # add extra CMake args to disable them. # See https://github.com/llvm/llvm-project/issues/99767 if [ "${{ runner.os }}" = "macOS" ]; then - target_cmake_flags="$target_cmake_flags -DBOOTSTRAP_COMPILER_RT_ENABLE_IOS=OFF

[clang] [libcxx] Revert "[libc++][modules] Rewrite the modulemap to have fewer top-level modules (#107638)" (PR #110384)

2024-09-28 Thread Aiden Grossman via cfe-commits
https://github.com/boomanaiden154 approved this pull request. LGTM, assuming precommit CI passes. https://github.com/llvm/llvm-project/pull/110384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-28 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. This looks good to me. It looks like we need to add the Release.cmake file to the list of files that trigger the release-binaries-all test, but that can be done in another PR. https://github.com/llvm/llvm-project/pull/109909

[clang] e203a67 - [cuda][HIP] `__constant__` should imply constant (#110182)

2024-09-28 Thread via cfe-commits
Author: Alex Voicu Date: 2024-09-29T01:22:52+01:00 New Revision: e203a67f4cef5844877f6a5720e659ea09729e9a URL: https://github.com/llvm/llvm-project/commit/e203a67f4cef5844877f6a5720e659ea09729e9a DIFF: https://github.com/llvm/llvm-project/commit/e203a67f4cef5844877f6a5720e659ea09729e9a.diff LO

[clang] [llvm] [cuda][HIP] `__constant__` should imply constant (PR #110182)

2024-09-28 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/110182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-28 Thread via cfe-commits
c8ef wrote: After spending the entire afternoon attempting to streamline the parameter check process, I still haven't found an elegant solution to consolidate it into a single location. I explored how GCC approaches this issue and discovered that while GCC does utilize a single parameter check

[clang] [clang][CGOpenMPRuntimeGPU] Avoid llvm::Type::getPointerTo() (NFC) (PR #110357)

2024-09-28 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 created https://github.com/llvm/llvm-project/pull/110357 `llvm::Type::getPointerTo()` is to be removed soon. >From 360e288e2ab89b050d5e9b4ea98bb3b33e72e64e Mon Sep 17 00:00:00 2001 From: Youngsuk Kim Date: Sat, 28 Sep 2024 05:59:30 -0500 Subject: [PATCH] [clang][CGOp

[clang] [clang][CGOpenMPRuntimeGPU] Avoid llvm::Type::getPointerTo() (NFC) (PR #110357)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Youngsuk Kim (JOE1994) Changes `llvm::Type::getPointerTo()` is to be removed soon. --- Full diff: https://github.com/llvm/llvm-project/pull/110357.diff 1 Files Affected: - (modified) clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp (+5-

[clang] 641b4d5 - [clang][bytecode] Implement integral-to-fixed-point casts (#110350)

2024-09-28 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-28T13:10:23+02:00 New Revision: 641b4d5370f1ce2f5d448cf63519f391be1cf263 URL: https://github.com/llvm/llvm-project/commit/641b4d5370f1ce2f5d448cf63519f391be1cf263 DIFF: https://github.com/llvm/llvm-project/commit/641b4d5370f1ce2f5d448cf63519f391be1cf263.diff L

[clang] [clang][bytecode] Implement integral-to-fixed-point casts (PR #110350)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement (N)EQ between fixed point and integral (PR #110358)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Convert the non-fixed-point side to a fixed-point type before doing the comparison. --- Full diff: https://github.com/llvm/llvm-project/pull/110358.diff 3 Files Affected: - (modified) clang/lib/AST/ByteCo

[clang] [clang][bytecode] Implement (N)EQ between fixed point and integral (PR #110358)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/110358 Convert the non-fixed-point side to a fixed-point type before doing the comparison. >From a00e1ed99bd3f02af5131e2cf32c665608650a0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 28 Se

[clang] [clang] Lifetime of locals must end before musttail call (PR #109255)

2024-09-28 Thread via cfe-commits
stefson wrote: @ostannard can you please backport this patch into the 19.x branch, and also other relevant changes to the musttail issue? clang-19.1.0 was released very broken on arm due to this. https://github.com/llvm/llvm-project/pull/109255 ___

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread Tommy Chen via cfe-commits
https://github.com/dl8sd11 created https://github.com/llvm/llvm-project/pull/110351 Starting from c++23, we can replace `std::string::find() == std::string::npos` with `std::string.contains()` . #109327 Currently, this is WIP because there are two limitations: 1. False positive: SubStr type i

[clang-tools-extra] [clang-tidy] support string::contains (PR #110351)

2024-09-28 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-28 Thread via cfe-commits
@@ -0,0 +1,15 @@ +// RUN: %clang -fsyntax-only -std=c++2a -Xclang -verify %s c8ef wrote: I will do it later :) https://github.com/llvm/llvm-project/pull/109831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] Revert "[clang][test] add testing for the AST matcher reference" (PR #110354)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Julian Schmidt (5chmidti) Changes Reverts llvm/llvm-project#110258 The commit caused a timeout for clang-arm64-windows-msvc: https://lab.llvm.org/buildbot/#/builders/161/builds/2385 and it looks like my commit is at fault. --- Patch is

[clang] Revert "[clang][test] add testing for the AST matcher reference" (PR #110354)

2024-09-28 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/110354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-09-28 Thread via cfe-commits
stefson wrote: so, it seems I've hit one of these in compiling firefox at src/gl.cc https://github.com/llvm/llvm-project/pull/109943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating StartOfName (PR #99791)

2024-09-28 Thread Alexander Lohnau via cfe-commits
alex1701c wrote: I think it would be normal for distros to backport bugfixes. Thus, users should get the new version rather soonish. https://github.com/llvm/llvm-project/pull/99791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [cuda][HIP] `__constant__` should imply constant (PR #110182)

2024-09-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang,llvm` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/2915 Here is the relevant piece of the build l

[clang] [clang] Improve deduction of reference typed NTTP (PR #110393)

2024-09-28 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/110393 This improves the existing workaround for a core issue introduced in CWG1770. When performing template argument deduction for an NNTP which the parameter side is a reference, instead of dropping the references

[clang] [clang] Improve deduction of reference typed NTTP (PR #110393)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes This improves the existing workaround for a core issue introduced in CWG1770. When performing template argument deduction for an NNTP which the parameter side is a reference, instead of dropping the refe

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-28 Thread Keith Smiley via cfe-commits
keith wrote: I pushed a dummy change to that just to verify so we don't have to go back and forth on it again. I put up the PR for the path changes here https://github.com/llvm/llvm-project/pull/110394, I was surprised to see this file is in the clang/ specific subdir, but also didn't see any

[clang] [libcxx] Revert "[libc++][modules] Rewrite the modulemap to have fewer top-level modules (#107638)" (PR #110384)

2024-09-28 Thread Anton Korobeynikov via cfe-commits
asl wrote: @llvm-beanz The changes to clang/include/clang/AST/Expr.h seems to be unrelated, no? https://github.com/llvm/llvm-project/pull/110384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [clang-format] Handle template closer followed by empty paretheses (PR #110408)

2024-09-28 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/110408 Fixes #109925. >From 27135c008868cc4f17b7ca5ff9c2af9c2fc02135 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 28 Sep 2024 22:42:56 -0700 Subject: [PATCH] [clang-format] Handle template closer followed by empt

[clang] [clang-format] Handle template closer followed by empty paretheses (PR #110408)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #109925. --- Full diff: https://github.com/llvm/llvm-project/pull/110408.diff 3 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+23-19) - (modified) clang/lib/Format/UnwrappedLin

[clang] [llvm] [clang][ci] Move libc++ testing into the main PR pipeline (PR #93318)

2024-09-28 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/93318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement fixed point casts (PR #110409)

2024-09-28 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/110409 None >From 591335042fa3d0bb0fa732ece33a29e2b3565530 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 29 Sep 2024 07:52:29 +0200 Subject: [PATCH] [clang][bytecode] Implement fixed point c

[clang] [clang][bytecode] Implement fixed point casts (PR #110409)

2024-09-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110409.diff 5 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+8) - (modified) clang/lib/AST/ByteCode/FixedPoint.h (+5) - (modi

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-28 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > ``` > static_assert(requires(this int) { true; }); > ``` The grammar doesn't appear to disallow the explicit object parameter in a requires expression, see https://eel.is/c++draft/expr.prim.req#nt:requirement-parameter-list. But the usage is indeed suspicious to me. We probab

  1   2   >