[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-09-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/110179 Summary: All GPU based languages provide some way to access things like the thread ID or other resources. However, this is spread between many different languages and it varies between targets. The goal here is t

[libunwind] [libunwind] Introduce LIBUNWIND_LIBRARY_VERSION and drop outdated Apple flags (PR #110178)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110178 This patch introduces the LIBUNWIND_LIBRARY_VERSION setting to control the dylib version of libunwind. This allows expressing the dylib version in CMake instead of adding custom compiler flags. As a drive-by,

[libunwind] [libunwind] Introduce LIBUNWIND_LIBRARY_VERSION and drop outdated Apple flags (PR #110178)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Louis Dionne (ldionne) Changes This patch introduces the LIBUNWIND_LIBRARY_VERSION setting to control the dylib version of libunwind. This allows expressing the dylib version in CMake instead of adding custom compiler flags. As a dri

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM minus the other comments https://github.com/llvm/llvm-project/pull/94869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-09-26 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 created https://github.com/llvm/llvm-project/pull/110188 The `debug_transparent` attribute is intended as a hint for debuggers that this function itself is not interesting, but it calls a function that might be. So, when stepping in arrives at a function with th

[clang] [HLSL][clang] Add elementwise builtin for atan2 (p3) (PR #110187)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Tex Riddell (tex3d) Changes This change is part of this proposal: https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294 - Add HLSL frontend for atan2 - Add clang Builtin, map to new llvm.atan2 - SemaChecking restrict to floating p

[clang-tools-extra] [clang-tidy][bugprone-posix-return] support integer literals as LHS (PR #109302)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][bugprone-posix-return] support integer literals as LHS (PR #109302)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/109302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-26 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/110079 >From 970aab0a930e38dfd266c01065112602bb274a5e Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 25 Sep 2024 15:48:18 -0700 Subject: [PATCH 1/5] [HLSL] Allow resource type attributes only on __hlsl_resource

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #109490)

2024-09-26 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: I accidentally rebased on top of the wrong branch which tagged a lot of people as reviewers, I'm going to close this PR and open a new one as to not spam a ton of people. https://github.com/llvm/llvm-project/pull/109490 ___ cfe-com

[clang] [HLSL][clang] Add elementwise builtin for atan2 (p3) (PR #110187)

2024-09-26 Thread Tex Riddell via cfe-commits
https://github.com/tex3d created https://github.com/llvm/llvm-project/pull/110187 This change is part of this proposal: https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294 - Add HLSL frontend for atan2 - Add clang Builtin, map to new llvm.atan2 - SemaChecking restrict to floating po

[clang] [HLSL][clang] Add elementwise builtin for atan2 (p3) (PR #110187)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Tex Riddell (tex3d) Changes This change is part of this proposal: https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294 - Add HLSL frontend for atan2 - Add clang Builtin, map to new llvm.atan2 - SemaChecking restrict to

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/110099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -104,6 +104,11 @@ New check aliases Changes in existing checks ^^ +- Improved :doc:`bugprone-use-after-move + ` check to handle smart pointers + like any other objects allowing to detect more cases, previous behavior can + be restored by setting `

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-09-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 139688a699f6db784bd559b147334f1d51314f9c 09940c37f0b9075b4a2c06e39932f1f772a2a13f --e

[clang-tools-extra] [clang-tidy][bugprone-posix-return] support integer literals as LHS (PR #109302)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -61,23 +67,26 @@ void PosixReturnCheck::check(const MatchFinder::MatchResult &Result) { if (const auto *LessThanZeroOp = Result.Nodes.getNodeAs("ltzop")) { SourceLocation OperatorLoc = LessThanZeroOp->getOperatorLoc(); +const char NewBinOp = +Les

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/110099 >From 9cdba3e947705053b14f8eeca39c281fd18e21ce Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 26 Sep 2024 11:43:10 +0200 Subject: [PATCH 1/3] [clang-tidy] Port

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-09-26 Thread Matt Arsenault via cfe-commits
@@ -706,6 +706,12 @@ Unless specified otherwise operation(±0) = ±0 and operation(±infinity) = ±in representable values for the signed/unsigned integer type. T __builtin_elementwise_sub_sat(T x, T y) return the difference of x and

[clang] [llvm] [BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-26 Thread via cfe-commits
yonghong-song wrote: > Looks like the new test case is failing on SystemZ: > https://lab.llvm.org/buildbot/#/builders/42/builds/1192 > > ``` > struct.error: unpack_from requires a buffer of at least 402653196 bytes for > unpacking 12 bytes at offset 402653184 (actual buffer size is 479) > ```

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Francis Visoiu Mistrih (francisvm) Changes We have the LLVM intrinsics, and we're missing the clang builtins to be used directly in code that needs to make the distinction in NaN semantics. --- Patch is 22.92 KiB, truncated to 20.00 KiB

[clang] [clang][bytecode] Refuse to contruct objects with virtual bases (PR #110142)

2024-09-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][RISCV] Add __riscv_feature_bits.length check (PR #110098)

2024-09-26 Thread Piyou Chen via cfe-commits
BeMg wrote: There is misunderstand here. Close it now and reopen when it ready. https://github.com/llvm/llvm-project/pull/110098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV][RISCV] Add __riscv_feature_bits.length check (PR #110098)

2024-09-26 Thread Piyou Chen via cfe-commits
https://github.com/BeMg closed https://github.com/llvm/llvm-project/pull/110098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 09cd5a8 - [clang][bytecode] Refuse to contruct objects with virtual bases (#110142)

2024-09-26 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-27T05:56:12+02:00 New Revision: 09cd5a86733a362f12542a11ffd834cac885eb32 URL: https://github.com/llvm/llvm-project/commit/09cd5a86733a362f12542a11ffd834cac885eb32 DIFF: https://github.com/llvm/llvm-project/commit/09cd5a86733a362f12542a11ffd834cac885eb32.diff L

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/110154 >From 5658a272777a2e399dec39e7ad412bcb68d3090d Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 18:59:33 +0100 Subject: [PATCH] [Clang] Update Interpreter tests to use clang_target_link_

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-26 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/110079 >From 970aab0a930e38dfd266c01065112602bb274a5e Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 25 Sep 2024 15:48:18 -0700 Subject: [PATCH 1/5] [HLSL] Allow resource type attributes only on __hlsl_resource

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Alex Voicu (AlexVlx) Changes Currently, `__constant__` variables do not get unconditionally marked as `constant` in IR, which seems a bit odd given their definition. This is generally inconsequential for NVPTX/AMDGPU, since said

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Alex Voicu (AlexVlx) Changes Currently, `__constant__` variables do not get unconditionally marked as `constant` in IR, which seems a bit odd given their definition. This is generally inconsequential for NVPTX/AMDGPU, since said v

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Voicu (AlexVlx) Changes Currently, `__constant__` variables do not get unconditionally marked as `constant` in IR, which seems a bit odd given their definition. This is generally inconsequential for NVPTX/AMDGPU, since said variables

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/110182 Currently, `__constant__` variables do not get unconditionally marked as `constant` in IR, which seems a bit odd given their definition. This is generally inconsequential for NVPTX/AMDGPU, since said variables

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-09-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/110179 >From f5a8afe139a25f13989556d40e29b98788934dd9 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 26 Sep 2024 16:47:14 -0500 Subject: [PATCH] [Clang] Implement resource directory headers for common GPU intr

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #108659)

2024-09-26 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/108659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > `__constant__` may not necessarily be `const` for IR purposes. I.e. IR may > not rely on the 'known' values, as seen in IR, as the data may actually be > populated by the host via CUDA API calls `cudaMemcpyToSymbol` before the GPU > kernel launch. But since this is marked `ex

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #108659)

2024-09-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/8070

[clang] [HLSL][clang] Add elementwise builtin for atan2 (p3) (PR #110187)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tex Riddell (tex3d) Changes This change is part of this proposal: https://discourse.llvm.org/t/rfc-all-the-math-intrinsics/78294 - Add HLSL frontend for atan2 - Add clang Builtin, map to new llvm.atan2 - SemaChecking restrict to floating

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > > `__constant__` may not necessarily be `const` for IR purposes. I.e. IR may > > not rely on the 'known' values, as seen in IR, as the data may actually be > > populated by the host via CUDA API calls `cudaMemcpyToSymbol` before the > > GPU kernel launch. > > But since this i

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/94869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e82b26a - [HLSL] Vector Usual Arithmetic Conversions (#108659)

2024-09-26 Thread via cfe-commits
Author: Chris B Date: 2024-09-26T18:57:57-05:00 New Revision: e82b26a3d388594a8af5640cd8aa570f7ecda469 URL: https://github.com/llvm/llvm-project/commit/e82b26a3d388594a8af5640cd8aa570f7ecda469 DIFF: https://github.com/llvm/llvm-project/commit/e82b26a3d388594a8af5640cd8aa570f7ecda469.diff LOG:

[clang] [ItaniumMangle] Use mangleType instead of mangleNameOrStandardSubstitution in mangleCXXCtorVTable function (PR #109970)

2024-09-26 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Do we need an ABI flag guarding against the change as well? https://github.com/llvm/llvm-project/pull/109970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #108659)

2024-09-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `clang` at step 6 "Add check check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/7568 Here is t

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #108659)

2024-09-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/6604 Here is the

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/110099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 91ec9cb - [alpha.webkit.UncountedCallArgsChecker] Use canonical type (#109393)

2024-09-26 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-09-26T22:18:07-07:00 New Revision: 91ec9cb96051e4c9044fc47c42732a5f5528e6c8 URL: https://github.com/llvm/llvm-project/commit/91ec9cb96051e4c9044fc47c42732a5f5528e6c8 DIFF: https://github.com/llvm/llvm-project/commit/91ec9cb96051e4c9044fc47c42732a5f5528e6c8.diff

[clang] [alpha.webkit.UncountedCallArgsChecker] Use canonical type (PR #109393)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/109393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-26 Thread Craig Topper via cfe-commits
@@ -123,6 +123,7 @@ set(riscv_files riscv_crypto.h riscv_ntlh.h sifive_vector.h + riscv_corev_alu.h topperc wrote: this list is alphabetized https://github.com/llvm/llvm-project/pull/100684 ___ cfe-commits ma

[clang] [llvm] [RISCV] Implement Clang Builtins for XCValu Extension in CV32E40P (PR #100684)

2024-09-26 Thread Craig Topper via cfe-commits
@@ -0,0 +1,434 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -triple riscv32 -target-feature +xcvalu -emit-llvm %s -o - \ +// RUN: | FileCheck %s + +#include +#include + +// CHECK-LABEL: @test_alu_slet( +// CHECK-NEXT:

[clang] WebKit Checkers should set DeclWithIssue. (PR #109389)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -134,18 +135,25 @@ class UncountedLocalVarsChecker bool shouldVisitTemplateInstantiations() const { return true; } bool shouldVisitImplicitCode() const { return false; } + bool TraverseDecl(Decl *D) { +llvm::SaveAndRestore SavedDecl(DeclWithIssue);

[clang] [alpha.webkit.UncountedCallArgsChecker] Use canonical type (PR #109393)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -102,12 +102,13 @@ class UncountedCallArgsChecker // if ((*P)->hasAttr()) // continue; -const auto *ArgType = (*P)->getType().getTypePtrOrNull(); -if (!ArgType) +QualType ArgType = (*P)->getType().getCanonicalType(); +const a

[clang] WebKit Checkers should set DeclWithIssue. (PR #109389)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -56,12 +62,16 @@ class UncountedCallArgsChecker bool TraverseClassTemplateDecl(ClassTemplateDecl *Decl) { if (isRefType(safeGetName(Decl))) return true; -return RecursiveASTVisitor::TraverseClassTemplateDecl( -Decl); +retur

[clang-tools-extra] d9853a8 - [clang-tidy][bugprone-posix-return] support integer literals as LHS (#109302)

2024-09-26 Thread via cfe-commits
Author: Congcong Cai Date: 2024-09-27T10:05:37+08:00 New Revision: d9853a8a101a9ec2d2199c6124d1fa826a84336c URL: https://github.com/llvm/llvm-project/commit/d9853a8a101a9ec2d2199c6124d1fa826a84336c DIFF: https://github.com/llvm/llvm-project/commit/d9853a8a101a9ec2d2199c6124d1fa826a84336c.diff

[clang] 1d8fad9 - [HLSL] Allow resource type attributes only on `__hlsl_resource_t` (#110143)

2024-09-26 Thread via cfe-commits
Author: Helena Kotas Date: 2024-09-26T14:45:50-07:00 New Revision: 1d8fad9fef4b2f1637498a017c44f0e8ebac20f8 URL: https://github.com/llvm/llvm-project/commit/1d8fad9fef4b2f1637498a017c44f0e8ebac20f8 DIFF: https://github.com/llvm/llvm-project/commit/1d8fad9fef4b2f1637498a017c44f0e8ebac20f8.diff

[clang] [HLSL] Allow resource type attributes only on `__hlsl_resource_t` (PR #110143)

2024-09-26 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/110143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-26 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/110079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Artem Belevich via cfe-commits
Artem-B wrote: `__constant__` may not necessarily be `const` for IR purposes. I.e. IR may not rely on the 'known' values, as seen in IR, as the data may actually be populated by the host via CUDA API calls `cudaMemcpyToSymbol` before the GPU kernel launch. https://github.com/llvm/llvm-project

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,45 @@ +//===--- BitCastPointersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,45 @@ +//===--- BitCastPointersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: > It now comes to mind that we probably also want to check `memcpy(ptr, ptr)`, > which is equivalent to `bit_cast`. In that case I wonder if the check name > still holds or it should be named something else? Yeah, with the addition of `memcpy`, the `bit`

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,45 @@ +//===--- BitCastPointersCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] Use std::optional::value_or (NFC) (PR #109894)

2024-09-26 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Next time please provide a better summary for your PR. This is super important for downstream folks debugging build breaks. In general this is important for reviews to compare what they expect with the actual diff. In this case something like "replace the use of conditional opera

[clang] [clang] Use std::optional::value_or (NFC) (PR #109894)

2024-09-26 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > Next time please provide a better summary for your PR. This is super > important for downstream folks debugging build breaks. In general this is > important for reviews to compare what they expect with the actual diff. > > > > In this case something like "replace the

[clang-tools-extra] [clang-tidy][bugprone-posix-return] support integer literals as LHS (PR #109302)

2024-09-26 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/109302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #108659)

2024-09-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/10210 Here is

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/110083 >From e35e600159c99736de7d2bc735c738002f592988 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Sep 2024 13:43:51 +0800 Subject: [PATCH 1/2] [clangd] [C++20] [Modules] Support code complete for C++20

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-26 Thread Chuanqi Xu via cfe-commits
@@ -402,6 +402,46 @@ import A; EXPECT_TRUE(D.isFromASTFile()); } +// An end to end test for code complete in modules +TEST_F(PrerequisiteModulesTests, CodeCompleteTest) { ChuanqiXu9 wrote: Done https://github.com/llvm/llvm-project/pull/110083 _

[clang] [clang] fix assert in ADL finding entity in the implicit global module (PR #109882)

2024-09-26 Thread Shafik Yaghmour via cfe-commits
@@ -115,7 +115,7 @@ C++ Language Changes - Allow single element access of GCC vector/ext_vector_type object to be constant expression. Supports the `V.xyzw` syntax and other tidbits as seen in OpenCL. Selecting multiple elements is left as a future work. -- Implement `CWG18

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Artem Belevich via cfe-commits
Artem-B wrote: It has nothing to do with writing to those arrays while the kernel is running. That would indeed be UB. > both would still work just the same even with this change, No, they will not. Here's the demonstration of the behavior change that `const` brings to the table: https://cuda

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-26 Thread Chuanqi Xu via cfe-commits
@@ -2108,7 +2116,7 @@ class CodeCompleteFlow { } // namespace -clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const { +clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts(bool ForceLoadExternal) const { ChuanqiXu9 wro

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -134,10 +137,10 @@ class NoUncountedMemberChecker Os << " in "; printQuotedQualifiedName(Os, ClassCXXRD); Os << " is a " - << (isa(MemberType) ? "raw pointer" : "reference") - << " to ref-countable type "; + << (isa(MemberType) ? "raw pointer" :

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -0,0 +1,53 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.NoUncheckedPtrMemberChecker -verify %s + +#include "mock-types.h" +#include "mock-system-header.h" rniwa wrote: Yeah, I guess we don't need to include "mock-system-header.h" here. https

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/108352 >From ac0447762c98da3cfb41a6b462034e3ab410bc33 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Thu, 12 Sep 2024 02:13:12 -0700 Subject: [PATCH 1/6] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member va

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/108352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/108352 >From ac0447762c98da3cfb41a6b462034e3ab410bc33 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Thu, 12 Sep 2024 02:13:12 -0700 Subject: [PATCH 1/7] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member va

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-26 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/110079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-26 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/110079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-26 Thread Joshua Batista via cfe-commits
@@ -3,12 +3,12 @@ // Supported targets // -// RUN: %clang -target dxil-unknown-shadermodel6.2-compute %s -S -o /dev/null 2>&1 | FileCheck --allow-empty --check-prefix=CHECK-VALID %s -// RUN: %clang -target spirv-unknown-vulkan-compute %s -S -o /dev/null 2>&1 | FileCheck --al

[libunwind] [libunwind][CMake] Remove LIBUNWIND_BUILD_32_BITS which has been an error for 3 years (PR #110175)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110175 None >From 77b8da53c769106ac75e818c4ea8a37b6e927a4f Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 26 Sep 2024 17:48:24 -0400 Subject: [PATCH] [libunwind][CMake] Remove LIBUNWIND_BUILD_32_BITS which has

[libunwind] [libunwind][CMake] Remove LIBUNWIND_BUILD_32_BITS which has been an error for 3 years (PR #110175)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Louis Dionne (ldionne) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110175.diff 1 Files Affected: - (modified) libunwind/CMakeLists.txt (-5) ``diff diff --git a/libunwind/CMakeLists.txt b/libunwind/CM

[clang] Revert "[HLSL] Vector Usual Arithmetic Conversions" (PR #110191)

2024-09-26 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/110191 Reverts llvm/llvm-project#108659 >From d5ee252c6bddcd27210e3a031cef8065679c8da5 Mon Sep 17 00:00:00 2001 From: Chris B Date: Thu, 26 Sep 2024 19:34:17 -0500 Subject: [PATCH] Revert "[HLSL] Vector Usual Arith

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Artem Belevich via cfe-commits
Artem-B wrote: I'm not 100% sure that `externally_initialized` is sufficient to deal with this use pattern. IR manual says: https://llvm.org/docs/LangRef.html#global-variables > By default, global initializers are optimized by assuming that global > variables defined within the module are not

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/110099 >From 9cdba3e947705053b14f8eeca39c281fd18e21ce Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 26 Sep 2024 11:43:10 +0200 Subject: [PATCH 1/4] [clang-tidy] Port

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Matt Arsenault via cfe-commits
arsenm wrote: If it's not legal for it to be marked as constant, it's also not legal to use constant address space https://github.com/llvm/llvm-project/pull/110182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] 90b7fe4 - [HLSL] Remove `__builtin_hlsl_create_handle` (#109910)

2024-09-26 Thread via cfe-commits
Author: Helena Kotas Date: 2024-09-26T13:56:49-07:00 New Revision: 90b7fe42d8e6f8647ce9279d6d026c36ccfcbb8f URL: https://github.com/llvm/llvm-project/commit/90b7fe42d8e6f8647ce9279d6d026c36ccfcbb8f DIFF: https://github.com/llvm/llvm-project/commit/90b7fe42d8e6f8647ce9279d6d026c36ccfcbb8f.diff

[clang] [llvm] [HLSL] Remove `__builtin_hlsl_create_handle` (PR #109910)

2024-09-26 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/109910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Remove `__builtin_hlsl_create_handle` (PR #109910)

2024-09-26 Thread Helena Kotas via cfe-commits
hekota wrote: > LGTM > > It's a shame we don't have a better way to review changes like this, so I'm a > little uncomfortable about a commit leaving things in a transitional state, > but I think my appreciation of being able to review this separately from the > next step outweighs that. Yeah

[clang] [HLSL] Allow resource type attributes only on `__hlsl_resource_t` (PR #110143)

2024-09-26 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/110143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-26 Thread Damyan Pepper via cfe-commits
@@ -2272,8 +2272,8 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T) const { #include "clang/Basic/AMDGPUTypes.def" #define HLSL_INTANGIBLE_TYPE(Name, Id, SingletonId) case BuiltinType::Id: #include "clang/Basic/HLSLIntangibleTypes.def" - Width = 0; - Align = 8;

[clang] [llvm] [BPF] Do atomic_fetch_*() pattern matching with memory ordering (PR #107343)

2024-09-26 Thread Ulrich Weigand via cfe-commits
uweigand wrote: Looks like the new test case is failing on SystemZ: https://lab.llvm.org/buildbot/#/builders/42/builds/1192 ``` struct.error: unpack_from requires a buffer of at least 402653196 bytes for unpacking 12 bytes at offset 402653184 (actual buffer size is 479) ``` At first glance, thi

[libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-09-26 Thread Louis Dionne via cfe-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/110171 This is what we started doing in libc++ and it straightens up a lot of things that only happened to work before, notably the presence of relative rpaths in dylibs when running from the build tree. This unlocks

[libcxxabi] [libunwind] [libc++abi][libunwind] Run c++abi and unwind tests against a fake install root (PR #110171)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxxabi Author: Louis Dionne (ldionne) Changes This is what we started doing in libc++ and it straightens up a lot of things that only happened to work before, notably the presence of relative rpaths in dylibs when running from the build tree. This

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Zhengxing li via cfe-commits
https://github.com/lizhengxing updated https://github.com/llvm/llvm-project/pull/108849 >From a48abd93d9261a9026531bfd69aff52b0374d8d8 Mon Sep 17 00:00:00 2001 From: Zhengxing Li Date: Fri, 13 Sep 2024 13:19:31 -0700 Subject: [PATCH] [HLSL] Implementation of the elementwise fmod builtin This c

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/110154 >From 2df58c48c063b162128f7826c5605f06f5684a7c Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 18:59:33 +0100 Subject: [PATCH] [Clang] Update Interpreter tests to use clang_target_link_

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/110154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,36 @@ +//===--- TemplateVirtualMemberFunctionCheck.h - clang-tidy --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-09-26 Thread Brad Richardson via cfe-commits
everythingfunctional wrote: > That was all @banach-space's work, I only rebased his commit. Don't think > that's worth co-authorship; though ultimately you can decide, You did some of the leg work and pointed me at it. I think that deserves at least some credit, and it's already there, so I do

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-26 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/108083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >