================ @@ -2108,7 +2116,7 @@ class CodeCompleteFlow { } // namespace -clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const { +clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts(bool ForceLoadExternal) const { ---------------- ChuanqiXu9 wrote:
I found the `CodeCompleteOptions` are passing to `codeComplete`. So if we pass the information if modules are enabled when initialize `clangd::CodeCompleteOptions`, we may need to update all the places using `clangd::CodeCompleteOptions`. I feel it is bigger but unnecessary change. I don't feel bad with the current style. WDYT? https://github.com/llvm/llvm-project/pull/110083 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits