[clang] [flang] [mlir] [clang][flang][mlir] Reapply "Support -frecord-command-line option (#102975)" (PR #110132)

2024-09-26 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu created https://github.com/llvm/llvm-project/pull/110132 The underlying issue was caused by a file included in two different places which resulted in duplicate definition errors when linking individual shared libraries. This was fixed in c3201ddaeac02a2c86a38b [#

[clang] [C++20][Modules] Fix non-determinism in serialized AST (PR #110131)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Dmitry Polukhin (dmpolukhin) Changes Summary: https://github.com/llvm/llvm-project/pull/109167 serializes FunctionToLambdasMap in the order of pointers in DenseMap. It gives different order with different memory layouts. Fix this issue by

[clang] [C++20][Modules] Fix non-determinism in serialized AST (PR #110131)

2024-09-26 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: @eaeltsin because I don't have a reproducer for the issue, could you please check that fix helps on your reproducer? https://github.com/llvm/llvm-project/pull/110131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang] Fix eager skipping on new with unknown type and no new-initializer (PR #110133)

2024-09-26 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource created https://github.com/llvm/llvm-project/pull/110133 i.e., in `function(new Unknown);` the parser should skip only until the semicolon. Before this change, everything was skipped until a balanced closing parenthesis or brace was found. This

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-09-26 Thread Erich Keane via cfe-commits
@@ -571,6 +571,9 @@ New features if class of allocation and deallocation function mismatches. `Documentation `__. +- Function effects (the ``nonblocking`` and ``nonallocating`` "performance

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-26 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/109855 >From 085965b324efde41168c5d51db3a368578d3458f Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Mon, 23 Sep 2024 14:44:32 -0700 Subject: [PATCH 1/3] Add clang/docs/FunctionEffectAnalysis.rst. --- clang/docs/F

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-26 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] [flang] [mlir] [clang][flang][mlir] Reapply "Support -frecord-command-line option (#102975)" (PR #110132)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Tarun Prabhu (tarunprabhu) Changes The underlying issue was caused by a file included in two different places which resulted in duplicate definition errors when linking individual shared libraries. This was fixed in c3201ddaeac02a2

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-09-26 Thread Oliver Stannard via cfe-commits
@@ -0,0 +1,343 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 +; RUN: llc -mtriple=armv7a-none-eabi %s -o - | FileCheck %s + +declare i32 @many_args_callee(i32 %0, i32 %1, i32 %2, i32 %3, i32 %4, i32 %5) + +define i32 @many

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-09-26 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard updated https://github.com/llvm/llvm-project/pull/109943 >From f96d3a1a44ade11f5a9879b49bb3d5296c4b225e Mon Sep 17 00:00:00 2001 From: Oliver Stannard Date: Thu, 9 May 2024 12:58:41 +0100 Subject: [PATCH 01/17] [ARM] Re-generate a test --- llvm/test/CodeGen/ARM/fp

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-09-26 Thread Pavel Yaskevich via cfe-commits
xedin wrote: > That being said, one question is whether we actually need type attributes to > be propagated in this case for Swift's interop. I don't think we do, we need swift_attr to help us augment Objective-C APIs to make existing frameworks pray well with Swift concurrency. I think C++ I

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/108849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/108849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-09-26 Thread Oliver Stannard via cfe-commits
ostannard wrote: @rnk I've already written a patch which modifies the existing strategy of using pseudo-instructions to do memory-memory copies, adding in a temporary on the stack where needed. https://github.com/llvm/llvm-project/pull/109943 ___ cfe

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-09-26 Thread Doug Wyatt via cfe-commits
@@ -4712,12 +4715,13 @@ class FunctionEffect { public: /// Identifies the particular effect. enum class Kind : uint8_t { -None = 0, -NonBlocking = 1, -NonAllocating = 2, -Blocking = 3, -Allocating = 4 +NonBlocking = 0, +NonAllocating = 1, +Bl

[clang] [flang] [flang][Driver] Support -fdiagnostics-color (PR #109210)

2024-09-26 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan approved this pull request. LG. Thanks Tarun. https://github.com/llvm/llvm-project/pull/109210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement NEON vscale intrinsics (PR #100347)

2024-09-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/5582 Here i

[clang] 24d707e - Fix "[AArch64] Implement NEON vscale intrinsics" (#110136)

2024-09-26 Thread via cfe-commits
Author: Lukacma Date: 2024-09-26T16:56:42+01:00 New Revision: 24d707e215a1e2d34d5c34156573a8607ab349f9 URL: https://github.com/llvm/llvm-project/commit/24d707e215a1e2d34d5c34156573a8607ab349f9 DIFF: https://github.com/llvm/llvm-project/commit/24d707e215a1e2d34d5c34156573a8607ab349f9.diff LOG:

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-26 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-09-26 Thread Doug Wyatt via cfe-commits
@@ -571,6 +571,9 @@ New features if class of allocation and deallocation function mismatches. `Documentation `__. +- Function effects (the ``nonblocking`` and ``nonallocating`` "performance

[clang] Fix "[AArch64] Implement NEON vscale intrinsics" (PR #110136)

2024-09-26 Thread via cfe-commits
https://github.com/Lukacma updated https://github.com/llvm/llvm-project/pull/110136 >From 32586c6e8ad4bab6bb27c85c30868ff34064f4a2 Mon Sep 17 00:00:00 2001 From: Lukacma Date: Thu, 26 Sep 2024 16:53:51 +0100 Subject: [PATCH 1/2] Update acle_neon_fscale.c --- .../test/CodeGen/aarch64-neon-fp8-

[clang] [nvlink-wrapper] Use a symbolic link instead of copying the file (PR #110139)

2024-09-26 Thread Artem Belevich via cfe-commits
Artem-B wrote: @rnk Are symlinks OK to use on windows? https://github.com/llvm/llvm-project/pull/110139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Fix musttail calls (PR #109943)

2024-09-26 Thread Oliver Stannard via cfe-commits
@@ -1,8 +1,31 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 ; RUN: llc -mtriple=arm-eabi -mattr=+neon -float-abi=soft %s -o - | FileCheck %s ; CHECK: function1 ; CHECK-NOT: vmov ostannard wrote: Don

[clang] [nvlink-wrapper] Use a symbolic link instead of copying the file (PR #110139)

2024-09-26 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > @rnk Are symlinks OK to use on windows? There's a caveat in the implementation stating that the links are soft on Linux but hard on Windows (as soft links require super-user privileges). I'm pretty sure a hard link also does the job here? Since all we need to do is give the s

[clang] [nvlink-wrapper] Use a symbolic link instead of copying the file (PR #110139)

2024-09-26 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Build bot says no, apparently. "The system cannot move the file to a different disk drive." https://github.com/llvm/llvm-project/pull/110139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] 8336819 - Use %errc to get text for system errors (#109852)

2024-09-26 Thread via cfe-commits
Author: Sean Perry Date: 2024-09-26T14:11:29-04:00 New Revision: 83368191a21340a6c3a8f88b01ecae6433640957 URL: https://github.com/llvm/llvm-project/commit/83368191a21340a6c3a8f88b01ecae6433640957 DIFF: https://github.com/llvm/llvm-project/commit/83368191a21340a6c3a8f88b01ecae6433640957.diff LO

[clang] [llvm] [ADT][NFC] Simplify SmallSet (PR #109412)

2024-09-26 Thread Victor Campos via cfe-commits
vhscampos wrote: Thanks for the investigation @nikic . I'll have a patch restoring `vfind` with an explanatory comment tomorrow. https://github.com/llvm/llvm-project/pull/109412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [analyzer] use `invalidateRegions()` in `VisitGCCAsmStmt` (PR #109838)

2024-09-26 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: > Looks correct to me. > Btw, do you think the invalidation should cause pointer escape? I have no > opinion. I rarely use this api. Wdyt? Maybe @NagyDonat or @Szelethus have an opinion on that https://github.com/llvm/llvm-project/pull/109838

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-09-26 Thread Pavel Yaskevich via cfe-commits
https://github.com/xedin updated https://github.com/llvm/llvm-project/pull/108631 >From c8784f8c9b0d7c66d924736476e7e112a92cf20a Mon Sep 17 00:00:00 2001 From: Pavel Yaskevich Date: Wed, 20 Dec 2023 14:04:22 -0800 Subject: [PATCH] [clang/AST] Make it possible to use SwiftAttr in type context S

[clang] [llvm] Use %errc to get text for system errors (PR #109852)

2024-09-26 Thread Sean Perry via cfe-commits
perry-ca wrote: Thanks for the offer David. I do have permission now. I held off merging yesterday because the builds were all broken from some other change. The builds all pass now. I'll merge it. https://github.com/llvm/llvm-project/pull/109852 ___

[clang] [flang] [mlir] [clang][flang][mlir] Reapply "Support -frecord-command-line option (#102975)" (PR #110132)

2024-09-26 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan approved this pull request. LG. https://github.com/llvm/llvm-project/pull/110132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-09-26 Thread Pavel Yaskevich via cfe-commits
xedin wrote: Updated release notes and added block tests requested by @Xazax-hun. https://github.com/llvm/llvm-project/pull/108631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-09-26 Thread Pavel Yaskevich via cfe-commits
@@ -7147,6 +7147,60 @@ static bool HandleWebAssemblyFuncrefAttr(TypeProcessingState &State, return false; } +static void HandleSwiftAttr(TypeProcessingState &State, TypeAttrLocation TAL, +QualType &QT, ParsedAttr &PAttr) { + if (TAL == TAL_DeclN

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread Thomas Fransham via cfe-commits
https://github.com/fsfod created https://github.com/llvm/llvm-project/pull/110154 This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins o

[clang] [llvm] Use %errc to get text for system errors (PR #109852)

2024-09-26 Thread Sean Perry via cfe-commits
https://github.com/perry-ca closed https://github.com/llvm/llvm-project/pull/109852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-26 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/109331 >From 50d21754119ac10c2ee2376ed8f79d12f73cd137 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Thu, 19 Sep 2024 00:13:51 + Subject: [PATCH 1/6] Codegen builtin --- clang/include/clang/Basic/Builtins.

[clang] [flang] [Flang][Driver][Offload] Support -Xoffload-linker argument in Flang (PR #109907)

2024-09-26 Thread Joseph Huber via cfe-commits
@@ -1,9 +1,10 @@ -! RUN %flang -### --target=x86_64-unknown-linux-gnu -fopenmp --offload-arch=gfx90a -Xoffload-linker a %s 2>&1 | FileCheck %s --check-prefixes=CHECK-XLINKER +! Test the -Xoffload-linker flag that forwards link commands to the clang-linker-wrapper used +! to hel

[clang] [flang] [Flang][Driver][Offload] Support -Xoffload-linker argument in Flang (PR #109907)

2024-09-26 Thread via cfe-commits
https://github.com/agozillon updated https://github.com/llvm/llvm-project/pull/109907 >From 22abf5c21692619f71bc87758f6b6433c245ed40 Mon Sep 17 00:00:00 2001 From: agozillon Date: Wed, 25 Sep 2024 00:18:26 -0500 Subject: [PATCH 1/8] [Flang][Driver][Offload] Support -Xoffload-linker argument in

[clang] [clang] Fix eager skipping on new with unknown type and no new-initializer (PR #110133)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alejandro Álvarez Ayllón (alejandro-alvarez-sonarsource) Changes i.e., in `function(new Unknown);` the parser should skip only until the semicolon. Before this change, everything was skipped until a balanced closing parenthesis or brace

[clang] [flang] [flang][Driver] Support -fdiagnostics-color (PR #109210)

2024-09-26 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: Thanks for the review, @MaskRay. @tblah, @kiranchandramohan, does this look ok to you? https://github.com/llvm/llvm-project/pull/109210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Thomas Fransham (fsfod) Changes This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plu

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/110099 >From 9cdba3e947705053b14f8eeca39c281fd18e21ce Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Thu, 26 Sep 2024 11:43:10 +0200 Subject: [PATCH 1/2] [clang-tidy] Port

[clang] 8ea2b41 - [flang][Driver] Support -fdiagnostics-color

2024-09-26 Thread via cfe-commits
Author: Tarun Prabhu Date: 2024-09-26T12:59:02-06:00 New Revision: 8ea2b417419344182053c0726cfff184d7917498 URL: https://github.com/llvm/llvm-project/commit/8ea2b417419344182053c0726cfff184d7917498 DIFF: https://github.com/llvm/llvm-project/commit/8ea2b417419344182053c0726cfff184d7917498.diff

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-09-26 Thread Erich Keane via cfe-commits
@@ -4712,12 +4715,13 @@ class FunctionEffect { public: /// Identifies the particular effect. enum class Kind : uint8_t { -None = 0, -NonBlocking = 1, -NonAllocating = 2, -Blocking = 3, -Allocating = 4 +NonBlocking = 0, +NonAllocating = 1, +Bl

[clang] [flang] [flang][Driver] Support -fdiagnostics-color (PR #109210)

2024-09-26 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu closed https://github.com/llvm/llvm-project/pull/109210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ADT][NFC] Simplify SmallSet (PR #109412)

2024-09-26 Thread Nikita Popov via cfe-commits
nikic wrote: Okay, I tried a few things, and can reproduce the regression just by using std::find inside vfind: https://github.com/llvm/llvm-project/commit/21f98691f6e7d8664c094bd4218a508432ab2d23 My best guess at the cause would be the forced unroll in: https://github.com/gcc-mirror/gcc/blob

[clang] Add clang/docs/FunctionEffectAnalysis.rst. (PR #109855)

2024-09-26 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,503 @@ + +Function Effect Analysis + + +Introduction + + +Clang Function Effect Analysis is a C++ language extension which can warn about "unsafe" +constructs. The feature is currently tailored for the Perform

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Zhengxing li via cfe-commits
https://github.com/lizhengxing updated https://github.com/llvm/llvm-project/pull/108849 >From 9ed71b8fb37dbc72bd5378c3b6be534b7bb51f60 Mon Sep 17 00:00:00 2001 From: Zhengxing Li Date: Fri, 13 Sep 2024 13:19:31 -0700 Subject: [PATCH] [HLSL] Implementation of the elementwise fmod builtin This c

[clang] [FMV][RISCV] Add __riscv_feature_bits.length check (PR #110098)

2024-09-26 Thread Philip Reames via cfe-commits
preames wrote: Why? There has only ever been one version of the features array, and that has not yet been published. Why do we need a version check here at all? https://github.com/llvm/llvm-project/pull/110098 ___ cfe-commits mailing list cfe-commit

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #108659)

2024-09-26 Thread Justin Bogner via cfe-commits
@@ -401,6 +401,194 @@ void SemaHLSL::DiagnoseAttrStageMismatch( << (AllowedStages.size() != 1) << join(StageStrings, ", "); } +template +static void castVector(Sema &S, ExprResult &E, QualType &Ty, unsigned Sz) { + if (const auto *VTy = Ty->getAs()) +Ty = VTy->getE

[clang] [ItaniumMangle] Use mangleType instead of mangleNameOrStandardSubstitution in mangleCXXCtorVTable function (PR #109970)

2024-09-26 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM, Thanks! Can you also add a release note, mentioning the potential ABI breaking change? Please wait 24h before merging in case the other reviewers want to chime in. https://github.com/llvm/llvm-project/pull/109970 ___

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f5b95db4c3ea266489a68a7655425b18ce5805f6 9ed71b8fb37dbc72bd5378c3b6be534b7bb51f60 --e

[clang] [nvlink-wrapper] Use a symbolic link instead of copying the file (PR #110139)

2024-09-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/110139 >From 393e05145d0c31a3b1b254f97a357c776617898c Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 26 Sep 2024 11:04:46 -0500 Subject: [PATCH 1/2] [nvlink-wrapper] Use a symbolic link instead of copying the

[clang] [llvm] [HLSL] Remove `__builtin_hlsl_create_handle` (PR #109910)

2024-09-26 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/109910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @lizhengxing please run clang-format. https://github.com/llvm/llvm-project/pull/108849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement `asint` casting using `bit_cast` (PR #110027)

2024-09-26 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/110027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Zhengxing li via cfe-commits
@@ -1645,6 +1645,18 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_elementwise_fmod: { lizhengxing wrote: Done. https://github.com/llvm/llvm-project/pull/1088

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Zhengxing li via cfe-commits
@@ -0,0 +1,37 @@ + +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify -verify-ignore-unexpected + +float test_too_few_arg() { + return __builtin_elementwise_fmod(); + // expecte

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-09-26 Thread via cfe-commits
h-vetinari wrote: > This was helpful for putting the symlink in, so I gave you co-authorship on > that commit. Let me know if you don't actually want it. That was all @banach-space's work, I only rebased his commit. Don't think that's worth co-authorship; though ultimately you can decide, I do

[clang] [HLSL] Implementation of the elementwise fmod builtin (PR #108849)

2024-09-26 Thread Zhengxing li via cfe-commits
https://github.com/lizhengxing updated https://github.com/llvm/llvm-project/pull/108849 >From a48abd93d9261a9026531bfd69aff52b0374d8d8 Mon Sep 17 00:00:00 2001 From: Zhengxing Li Date: Fri, 13 Sep 2024 13:19:31 -0700 Subject: [PATCH] [HLSL] Implementation of the elementwise fmod builtin This c

[clang] [nvlink-wrapper] Use a symbolic link instead of copying the file (PR #110139)

2024-09-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/110139 >From 393e05145d0c31a3b1b254f97a357c776617898c Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 26 Sep 2024 11:04:46 -0500 Subject: [PATCH] [nvlink-wrapper] Use a symbolic link instead of copying the file

[clang] [clang][test] add TestLanguage.def to specify all tested language versions (PR #94243)

2024-09-26 Thread Julian Schmidt via cfe-commits
5chmidti wrote: @Sirraide because this is touching the unit test infra, I held of on merging so you could take another look once you were back. https://github.com/llvm/llvm-project/pull/94243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [llvm] Implement operand bundles for floating-point operations (PR #109798)

2024-09-26 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > With the constrained intrinsics the default is safe because optimizations > don't recognize the constrained intrinsic and thus don't know how to optimize > it. If we instead rely on the strictfp attribute then we'll need possibly > thousands of checks for this attribute, we

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-26 Thread Helena Kotas via cfe-commits
@@ -2272,8 +2272,8 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T) const { #include "clang/Basic/AMDGPUTypes.def" #define HLSL_INTANGIBLE_TYPE(Name, Id, SingletonId) case BuiltinType::Id: #include "clang/Basic/HLSLIntangibleTypes.def" - Width = 0; - Align = 8;

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Artem Belevich via cfe-commits
Artem-B wrote: Well, it's certainly used that way in existing CUDA code and it's been around forever: Here are few random examples from both 10 years ago: https://stackoverflow.com/questions/20535683/cuda-5-5-cudamemcpytosymbol-constant-and-out-of-scope-error and a fairly recent example: https

[clang] [C++20][Modules] Fix non-determinism in serialized AST (PR #110131)

2024-09-26 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/110131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-26 Thread kadir çetinkaya via cfe-commits
@@ -2108,7 +2116,7 @@ class CodeCompleteFlow { } // namespace -clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const { +clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts(bool ForceLoadExternal) const { kadircet wrote

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-26 Thread Chuanqi Xu via cfe-commits
@@ -2108,7 +2116,7 @@ class CodeCompleteFlow { } // namespace -clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const { +clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts(bool ForceLoadExternal) const { ChuanqiXu9 wro

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-09-26 Thread Brad Richardson via cfe-commits
https://github.com/everythingfunctional updated https://github.com/llvm/llvm-project/pull/110023 >From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001 From: Brad Richardson Date: Wed, 25 Sep 2024 13:25:22 -0500 Subject: [PATCH 1/2] [flang][driver] rename flang-new to flang --

[clang] [HLSL] Allow resource type attributes only on `__hlsl_resource_t` (PR #110143)

2024-09-26 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/110143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver][Offload] Support -Xoffload-linker argument in Flang (PR #109907)

2024-09-26 Thread via cfe-commits
agozillon wrote: Passed this time, seems the addition of : "{{[^"]*}}clang-linker-wrapper{{.*}}" worked for both the CI and my local machine so that's good. Would love an additional approval from either of you @tblah @banach-space please if possible and the PR seems reasonable of course! http

[clang] [nvlink-wrapper] Use a symbolic link instead of copying the file (PR #110139)

2024-09-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/110139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 44950de - [nvlink-wrapper] Use a symbolic link instead of copying the file (#110139)

2024-09-26 Thread via cfe-commits
Author: Joseph Huber Date: 2024-09-26T18:48:01-07:00 New Revision: 44950de5b1496aaf524b73201579f56ff4325c52 URL: https://github.com/llvm/llvm-project/commit/44950de5b1496aaf524b73201579f56ff4325c52 DIFF: https://github.com/llvm/llvm-project/commit/44950de5b1496aaf524b73201579f56ff4325c52.diff

[clang] [C++20][Modules] Fix non-determinism in serialized AST (PR #110131)

2024-09-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/110131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3b96294 - [WebAssembly] Update type checker message in notypecheck.s

2024-09-26 Thread Heejin Ahn via cfe-commits
Author: Heejin Ahn Date: 2024-09-27T01:59:36Z New Revision: 3b96294f2d3dd5d9646803c7c4e35039a373792e URL: https://github.com/llvm/llvm-project/commit/3b96294f2d3dd5d9646803c7c4e35039a373792e DIFF: https://github.com/llvm/llvm-project/commit/3b96294f2d3dd5d9646803c7c4e35039a373792e.diff LOG: [W

[clang] [llvm] [HLSL] Remove `__builtin_hlsl_create_handle` (PR #109910)

2024-09-26 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. LGTM It's a shame we don't have a better way to review changes like this, so I'm a little uncomfortable about a commit leaving things in a transitional state, but I think my appreciation of being able to review this separately from the nex

[clang] d8a2815 - [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (#109208)

2024-09-26 Thread via cfe-commits
Author: Richard Smith Date: 2024-09-26T15:56:33-07:00 New Revision: d8a281590311010955c323806fb24fa484376f4d URL: https://github.com/llvm/llvm-project/commit/d8a281590311010955c323806fb24fa484376f4d DIFF: https://github.com/llvm/llvm-project/commit/d8a281590311010955c323806fb24fa484376f4d.diff

[clang] [llvm] Implement operand bundles for floating-point operations (PR #109798)

2024-09-26 Thread Andy Kaylor via cfe-commits
@@ -2994,6 +2994,29 @@ A "convergencectrl" operand bundle is only valid on a ``convergent`` operation. When present, the operand bundle must contain exactly one value of token type. See the :doc:`ConvergentOperations` document for details. +.. _ob_fpe: + +Floating-point Envir

[clang] [clang] implement current direction of CWG2765 for string literal comparisons in constant evaluation (PR #109208)

2024-09-26 Thread Richard Smith via cfe-commits
https://github.com/zygoloid closed https://github.com/llvm/llvm-project/pull/109208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [nvlink-wrapper] Use a symbolic link instead of copying the file (PR #110139)

2024-09-26 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/110139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #110195)

2024-09-26 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/110195 HLSL has a different set of usual arithmetic conversions for vector types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: https://github.com/micr

[clang] [HLSL] Vector Usual Arithmetic Conversions (PR #110195)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chris B (llvm-beanz) Changes HLSL has a different set of usual arithmetic conversions for vector types to resolve a common type for binary operator expressions. This PR implements the current spec proposal from: https://github.com/micros

[clang] Reapply "[clang][CodeGen] Zero init unspecified fields in initializers in C" (#109898) (PR #110051)

2024-09-26 Thread Eli Friedman via cfe-commits
@@ -1748,6 +1771,26 @@ void AggExprEmitter::VisitCXXParenListOrInitListExpr( CGF.getTypes().isZeroInitializable(ExprToVisit->getType())) break; +if (ZeroInitPadding) { + uint64_t StartBitOffset = Layout.getFieldOffset(field->getFieldIndex()); + Char

[clang] [llvm] [clang] Add "debug_transparent" attribute (PR #110188)

2024-09-26 Thread Augusto Noronha via cfe-commits
augusto2112 wrote: I opened this PR since I messed up https://github.com/llvm/llvm-project/pull/109490 https://github.com/llvm/llvm-project/pull/110188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [cuda][[HIP] `__constant__` should imply constant (PR #110182)

2024-09-26 Thread Alex Voicu via cfe-commits
AlexVlx wrote: > Well, it's certainly used that way in existing CUDA code and it's been around > forever: Here are few random examples: > > * from both 10 years ago: > > https://stackoverflow.com/questions/20535683/cuda-5-5-cudamemcpytosymbol-constant-and-out-of-scope-error > * fairly recent

[clang-tools-extra] [clang-tidy][bugprone-posix-return] support integer literals as LHS (PR #109302)

2024-09-26 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/109302 >From cc2c798193722b3a537c76e74981ff767d064efa Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 19 Sep 2024 23:46:16 +0800 Subject: [PATCH 1/5] [clang-tidy][bugprone-posix-return] support integer lite

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -146,13 +149,67 @@ class NoUncountedMemberChecker BR->emitReport(std::move(Report)); rniwa wrote: I'm not calling `setDeclWithIssue` in this checker since the checker works on classes, and not functions. I guess there could be classes declared within a

[clang] WebKit Checkers should set DeclWithIssue. (PR #109389)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/109389 >From b8f95b5b809cbeb8199de6cd24e18a605189f722 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Thu, 19 Sep 2024 23:41:10 -0700 Subject: [PATCH 1/4] WebKit Checkers should set DeclWithIssue. Set DeclWithIssue in

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -53,48 +53,49 @@ hasPublicMethodInBase(const CXXBaseSpecifier *Base, const char *NameToMatch) { return hasPublicMethodInBaseClass(R, NameToMatch) ? R : nullptr; } -std::optional isRefCountable(const CXXRecordDecl* R) -{ +std::optional isSmartPtrCompatible(const CXXRecord

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-09-26 Thread via cfe-commits
antangelo wrote: Friendly ping https://github.com/llvm/llvm-project/pull/98788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
@@ -1771,6 +1771,10 @@ def UncountedLambdaCapturesChecker : Checker<"UncountedLambdaCapturesChecker">, let ParentPackage = WebKitAlpha in { +def NoUncheckedPtrMemberChecker : Checker<"NoUncheckedPtrMemberChecker">, + HelpText<"Check for no unchecked member variables.">, +

[clang] [Clang] Implement resource directory headers for common GPU intrinsics (PR #110179)

2024-09-26 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: Probably want a longer prefix. _gpu or_llvm or similar. If the shared header gets the declarations then people can include the intrin.h and look at it to see what functions they have available, without going and looking through all the implementations. That seems like a

[clang] [clang][CGExpr] Avoid Type::getPointerTo() (NFC) (PR #110209)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Youngsuk Kim (JOE1994) Changes `Type::getPointerTo()` is to be removed soon. This also removes the whole code section for "C99 6.5.2.2p6"; It's essentially a no-op since llvm uses opaque pointers. --- Full diff: https://github.com/llvm/l

[clang] [clang][CGExpr] Avoid Type::getPointerTo() (NFC) (PR #110209)

2024-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Youngsuk Kim (JOE1994) Changes `Type::getPointerTo()` is to be removed soon. This also removes the whole code section for "C99 6.5.2.2p6"; It's essentially a no-op since llvm uses opaque pointers. --- Full diff: https://github.co

[clang] [clang][CGExpr] Avoid Type::getPointerTo() (NFC) (PR #110209)

2024-09-26 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 created https://github.com/llvm/llvm-project/pull/110209 `Type::getPointerTo()` is to be removed soon. This also removes the whole code section for "C99 6.5.2.2p6"; It's essentially a no-op since llvm uses opaque pointers. >From 763c84fc06c3cca97e9723b1f4773b3214458

[clang] [llvm] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member variable checker for CheckedPtr/CheckedRef (PR #108352)

2024-09-26 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/108352 >From ac0447762c98da3cfb41a6b462034e3ab410bc33 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Thu, 12 Sep 2024 02:13:12 -0700 Subject: [PATCH 1/5] [alpha.webkit.NoUncheckedPtrMemberChecker] Introduce member va

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-09-26 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,48 @@ +//===--- TemplateVirtualMemberFunctionCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] Implement operand bundles for floating-point operations (PR #109798)

2024-09-26 Thread Andy Kaylor via cfe-commits
@@ -357,6 +357,9 @@ class IRBuilderBase { void setConstrainedFPCallAttr(CallBase *I) { I->addFnAttr(Attribute::StrictFP); +MemoryEffects ME = MemoryEffects::inaccessibleMemOnly(); andykaylor wrote: >From the LangRef "Calls and invokes with operand b

<    1   2   3   4   5   6   >