================
@@ -2108,7 +2116,7 @@ class CodeCompleteFlow {
} // namespace
-clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const {
+clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts(bool
ForceLoadExternal) const {
----------------
kadircet wrote:
> we may need to update all the places using clangd::CodeCompleteOptions
i don't follow this one, i'd expect us to just set it once in ClangdMain.cpp,
with other CodeCompleteOpts fields we set based on command line flags/configs
and use it only once in `CodeCompleteOptions::getClangCompleteOpts` (modulo
tests that're specifically testing this behavior, not even all the tests).
What are the other places that need updating?
https://github.com/llvm/llvm-project/pull/110083
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
