AaronBallman wrote:
> > In fact, we used to have guidance that only the very first instance of the
> > diagnostic should be spelled out fully, and all subsequent ones should be
> > limited to just the bare minimum needed to identify what the diagnostic is.
> > That's why there are hundreds of
erichkeane wrote:
> >
>
> +1, it's why I stopped recommending this approach in my reviews.
While I agree for the most part, there are quite a few diagnostics that are
absurdly verbose (particularly ones with "did you mean to FLOOP it?"). I think
partial matches are good/fine, but they need
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/76838
>From 7cc2e01a4a272934861e0d36791985e9604d9794 Mon Sep 17 00:00:00 2001
From: prabhukr
Date: Mon, 4 Dec 2023 08:54:14 -0800
Subject: [PATCH 1/4] [UEFI] X86_64 UEFI Clang Driver
Introduce changes necessary for UE
https://github.com/Prabhuk edited
https://github.com/llvm/llvm-project/pull/76838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Prabhuk edited
https://github.com/llvm/llvm-project/pull/76838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Prabhuk edited
https://github.com/llvm/llvm-project/pull/76838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tkoeppe created
https://github.com/llvm/llvm-project/pull/109169
Make modernize-use-nullptr matcher also match "NULL", but not "0", when it
appears on a substituted type of a template specialization.
Previously, any matches on a substituted type were excluded, but this meant
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Thomas Köppe (tkoeppe)
Changes
Make modernize-use-nullptr matcher also match "NULL", but not "0", when it
appears on a substituted type of a template specialization.
Previously, any matches on a substituted type were excluded, but th
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/108786
>From 3052d9ab2225f32f0bed254f3d6eb64a096f3d5e Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Tue, 17 Sep 2024 21:47:45 -0400
Subject: [PATCH] [IR] Introduce `T` to `DataLayout` to
represent flat address spa
AaronBallman wrote:
> > > Gentle ping @AaronBallman , @philnik777 , @fpetrogalli :)
> >
> >
> > Ah, sorry -- because the PR is marked as a Draft, I figured it wasn't ready
> > for review yet.
> > I think I'd rather this was expressed differently; we already don't put
> > attribute information
hnrklssn wrote:
> In fact, we used to have guidance that only the very first instance of the
> diagnostic should be spelled out fully, and all subsequent ones should be
> limited to just the bare minimum needed to identify what the diagnostic is.
> That's why there are hundreds of instances o
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/106675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
An example, which is a bit closer to the original:
https://gcc.godbolt.org/z/5WMb78434.
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -0,0 +1,30 @@
+
+External Clang-Tidy Examples
+
+
+Introduction
+
+
+This page provides examples of what people have done with
:program:`clang-tidy` that
+might serve as useful guides (or starting points) to
https://github.com/5chmidti approved this pull request.
https://github.com/llvm/llvm-project/pull/106675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Prabhuk updated
https://github.com/llvm/llvm-project/pull/76838
>From 7cc2e01a4a272934861e0d36791985e9604d9794 Mon Sep 17 00:00:00 2001
From: prabhukr
Date: Mon, 4 Dec 2023 08:54:14 -0800
Subject: [PATCH 1/3] [UEFI] X86_64 UEFI Clang Driver
Introduce changes necessary for UE
steakhal wrote:
> > I'm okay with the PR, but this leaves me wonder how did you end up with
> > this crash? How did you manage to avoid all the zillion other ways to crash
> > the Z3 solver? Have you experienced such issues?
>
> Thanks Balazs, TBH I'm not sure we've found all the ways to crash
hnrklssn wrote:
> > >
> >
> >
> > +1, it's why I stopped recommending this approach in my reviews.
>
> While I agree for the most part, there are quite a few diagnostics that are
> absurdly verbose (particularly ones with "did you mean to FLOOP it?"). I
> think partial matches are good/fine
@@ -245,6 +246,7 @@ class DataLayout {
unsigned getDefaultGlobalsAddressSpace() const {
return DefaultGlobalsAddrSpace;
}
+ unsigned getFlatAddressSpace() const { return FlatAddressSpace; }
arichardson wrote:
I don't think this is a good API - returni
mikaelholmen wrote:
Hello,
I noticed that before this patch
```clang empty.c -fsanitize=undefined -ffine-grained-bitfield-accesses -c
-Werror```
(on empty file empty.c) resulted in
```warning: option '-ffine-grained-bitfield-accesses' cannot be enabled
together with a sanitizer; flag ignored``
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/109098
None
>From cbbfe3853d19b095e63b1ff1a016d4bd8aed0dfc Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Wed, 18 Sep 2024 10:33:34 +0200
Subject: [PATCH] [clang][NFC] Remove trailing spaces from Sema diag messag
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/108693
>From 4e05a1972e539d08589b44677031f506b0c91203 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 14 Sep 2024 18:31:42 +0800
Subject: [PATCH] [Clang] Avoid transforming lambdas when rebuilding immediate
exp
Author: Younan Zhang
Date: 2024-09-18T16:34:55+08:00
New Revision: dd222ff25129f4d67473a9af598a78d0adfcfd29
URL:
https://github.com/llvm/llvm-project/commit/dd222ff25129f4d67473a9af598a78d0adfcfd29
DIFF:
https://github.com/llvm/llvm-project/commit/dd222ff25129f4d67473a9af598a78d0adfcfd29.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/108693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6037,13 +6038,24 @@ class AttributedType : public Type, public
llvm::FoldingSetNode {
private:
friend class ASTContext; // ASTContext creates these
+ const Attr *Attribute;
+
QualType ModifiedType;
QualType EquivalentType;
AttributedType(QualType canon, attr
mahesh-attarde wrote:
@phoebewang can you merge please?
https://github.com/llvm/llvm-project/pull/108537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/109112
Patch by Arseniy Zaostrovnykh!
>From 408ee82b1ee3ae15302b2a0dde9faded3e43bf0f Mon Sep 17 00:00:00 2001
From: Arseniy Zaostrovnykh
Date: Wed, 18 Sep 2024 11:30:10 +0200
Subject: [PATCH] [analyzer] Note last "fc
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balazs Benics (steakhal)
Changes
Patch by Arseniy Zaostrovnykh!
---
Full diff: https://github.com/llvm/llvm-project/pull/109112.diff
2 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp (+
https://github.com/MainakSil updated
https://github.com/llvm/llvm-project/pull/108804
>From 43e6c22f25f419b64678374dd247eaf8bc28fa57 Mon Sep 17 00:00:00 2001
From: Mainak Sil
Date: Mon, 16 Sep 2024 09:50:33 +0530
Subject: [PATCH 1/8] [clang] Increase VecLib bitfield size to 4 bits in
CodeGenOp
https://github.com/DeinAlptraum approved this pull request.
Rest looks good to me.
Regarding releases, I'm not too familiar with the process here, but I believe
backports aren't done unless it's a critical security bug or similar. @Endilll
can you confirm, and do you also want to sign off on t
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -570,6 +570,26 @@ def test_enum_values_cpp(self):
self.assertEqual(ham.kind, CursorKind.ENUM_CONSTANT_DECL)
self.assertEqual(ham.enum_value, 0x100)
+def test_enum_values_on_elaborated_type(self):
+tu = get_tu(
+"using myUType
https://github.com/DeinAlptraum edited
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MacDue updated
https://github.com/llvm/llvm-project/pull/108853
>From 6db9f6d56f0bbd56d017156f858eae68653fbd1b Mon Sep 17 00:00:00 2001
From: Benjamin Maxwell
Date: Mon, 16 Sep 2024 16:27:23 +
Subject: [PATCH 1/5] Precommit math-libcalls-tbaa-indirect-args.c
---
.../mat
carlosgalvezp wrote:
> But the template mark is really hard to understand
I agree. Did you intend to remove that in this commit as well? I see it's still
present.
https://github.com/llvm/llvm-project/pull/109068
___
cfe-commits mailing list
cfe-commi
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/108988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vabridgers wrote:
> I'm okay with the PR, but this leaves me wonder how did you end up with this
> crash? How did you manage to avoid all the zillion other ways to crash the Z3
> solver? Have you experienced such issues?
Thanks Balazs, TBH I'm not sure we've found all the ways to crash the Z3
https://github.com/ofAlpaca updated
https://github.com/llvm/llvm-project/pull/108142
>From efcf875af403831bbd4d472a9a3a9fbff4438753 Mon Sep 17 00:00:00 2001
From: ofAlpaca
Date: Wed, 11 Sep 2024 11:24:55 +0800
Subject: [PATCH 1/2] [clang] Fix TemplatedDecl being nullptr and cause crash
---
cl
@@ -839,100 +842,84 @@ static void
updateResourceClassFlagsFromRecordType(RegisterBindingFlags &Flags,
const Type *FieldTy = FD->getType().getTypePtr();
if (const HLSLAttributedResourceType *AttrResType =
dyn_cast(FieldTy)) {
-updateResourceCl
justinfargnoli wrote:
Ping @plotfi @nikic for review.
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
Our internal releases have been blocked on this issue, since even a local
revert is not an option at the moment due to the number of dependent commits
and problems in other parts of LLVM. We would appreciate if we could get a
resolution in the next day or two. If there's no clear
nicovank wrote:
Ha, TIL that `LLVM_ENABLE_ASSERTIONS` is only in `Debug` mode, not
`RelWithDebInfo` which I use in my local build. I assume CI uses `Debug` so
this is fine, just wanted to be sure something always breaks if ever this was
changed again. Thanks!
https://github.com/bogner edited
https://github.com/llvm/llvm-project/pull/108919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bogner approved this pull request.
Yeah, I think this is overall an improvement for readability. Thanks!
https://github.com/llvm/llvm-project/pull/108919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
@@ -2,18 +2,27 @@
typedef vector float4;
-// CHECK: -TypeAliasDecl 0x{{[0-9a-f]+}}
-// CHECK: -HLSLAttributedResourceType 0x{{[0-9a-f]+}} '__hlsl_resource_t
{{\[\[}}hlsl::resource_class(UAV)]] {{\[\[}}hlsl::contained_type(int)]]' sugar
+// CHECK: -TypeAliasDecl 0x{{[0-9a-f]
@@ -189,19 +190,23 @@
#define LLVM_TEMPLATE_ABI __declspec(dllimport)
#define LLVM_EXPORT_TEMPLATE
#endif
+#define LLVM_ABI_EXPORT __declspec(dllexport)
compnerd wrote:
Why is this being added? I'm weary of any macro that is always export only
because the val
@@ -165,4 +166,8 @@ const std::list>
&getAttributePluginInstances();
} // namespace clang
+namespace llvm {
+extern template class CLANG_TEMPLATE_ABI llvm::Registry;
compnerd wrote:
```suggestion
extern template class CLANG_TEMPLATE_ABI Registry;
```
This
https://github.com/nicovank approved this pull request.
https://github.com/llvm/llvm-project/pull/109145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/108475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 ready_for_review
https://github.com/llvm/llvm-project/pull/108475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
Buildkite is green with this approach! Graduated patch from "Draft" state.
https://github.com/llvm/llvm-project/pull/108475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/108475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,99 @@
+//===- unittests/AST/RawCommentForDeclTestTest.cpp
+//-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -444,7 +444,7 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl(
return CommentlessRedeclChains.lookup(CanonicalD);
}();
- for (const auto Redecl : D->redecls()) {
+ for (const auto Redecl : CanonicalD->redecls()) {
HighCommander4 wrote:
(
https://github.com/HighCommander4 edited
https://github.com/llvm/llvm-project/pull/108475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
antangelo wrote:
Friendly ping
https://github.com/llvm/llvm-project/pull/98788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -444,7 +444,7 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl(
return CommentlessRedeclChains.lookup(CanonicalD);
}();
- for (const auto Redecl : D->redecls()) {
+ for (const auto Redecl : CanonicalD->redecls()) {
zyn0217 wrote:
Yup, in
@@ -440,14 +440,23 @@ const RawComment *ASTContext::getRawCommentForAnyRedecl(
// Any redeclarations of D that we haven't checked for comments yet?
// We can't use DenseMap::iterator directly since it'd get invalid.
- auto LastCheckedRedecl = [this, CanonicalD]() -> const
fursov wrote:
Sorry, I'm not familiar with the process (this is my first PR on github) - how
the change gets now to the repo? Someone from llvm-project should push it?
https://github.com/llvm/llvm-project/pull/108769
___
cfe-commits mailing list
cfe-c
kparzysz wrote:
Right now it's about 400 check-clang failures for all changes together. Adding
AST nodes for directives in templates causes 12 failures (mostly in slightly
differing diagnostics), adding capturing regions for all constituents will have
its own share, but the majority comes fro
https://github.com/mahesh-attarde updated
https://github.com/llvm/llvm-project/pull/108537
>From 396eb4274cfff1e6f67be3f795594a54f0518407 Mon Sep 17 00:00:00 2001
From: mattarde
Date: Fri, 13 Sep 2024 03:26:14 -0700
Subject: [PATCH 1/7] update clr
---
clang/lib/Headers/CMakeLists.txt
HerrCai0907 wrote:
> LGTM, thanks for splitting the patch!
>
> Personally I don't quite see the added value of having the quotes, I actually
> find them a bit noisy. It would have been good to write the motivation for
> this change in the commit message.
>
> But this is quite subjective so if
https://github.com/fursov updated
https://github.com/llvm/llvm-project/pull/108769
>From 4d9f2e2e9ac57b4279a4aafc078a3b4fb3ff646f Mon Sep 17 00:00:00 2001
From: Dmitry Fursov
Date: Sun, 15 Sep 2024 18:14:48 +0300
Subject: [PATCH 1/2] Fix evaluation of the unsigned enumeration values
If the typ
https://github.com/ofAlpaca updated
https://github.com/llvm/llvm-project/pull/108142
>From efcf875af403831bbd4d472a9a3a9fbff4438753 Mon Sep 17 00:00:00 2001
From: ofAlpaca
Date: Wed, 11 Sep 2024 11:24:55 +0800
Subject: [PATCH 1/3] [clang] Fix TemplatedDecl being nullptr and cause crash
---
cl
AaronBallman wrote:
I think there are multiple bugs here, at least one seems to be preexisting. It
seems that perhaps diagnostics issued early enough in the driver do not seem to
honor diagnostic groups: https://godbolt.org/z/sh4e9noe1
Note how it's missing `[-Woption-ignored]` like you get in
JonPsson1 wrote:
gentle ping to @nikic
https://github.com/llvm/llvm-project/pull/100757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ofAlpaca wrote:
> Also, please add the example code from the linked issue to
> `ast-dump-concepts.cpp` so that we more clearly demonstrate that the issue
> was fixed.
Hi @AaronBallman
The example code provided by @zyn0217 has already in the
`ast-dump-concepts.cpp`.
https://github.com/llvm/
Author: Mahesh-Attarde
Date: 2024-09-18T21:01:51+08:00
New Revision: 311e4e3245818d42e2bd148157c960f567f37096
URL:
https://github.com/llvm/llvm-project/commit/311e4e3245818d42e2bd148157c960f567f37096
DIFF:
https://github.com/llvm/llvm-project/commit/311e4e3245818d42e2bd148157c960f567f37096.diff
ccotter wrote:
bump @ymand @PiotrZSL?
https://github.com/llvm/llvm-project/pull/101450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bradh352 wrote:
> By and large this looks ok, (as long as your rst change was generated using
> the docs/tools/dump_format_style.py)
Yes, it was generated via the script.
https://github.com/llvm/llvm-project/pull/108241
___
cfe-commits mailing list
https://github.com/bradh352 updated
https://github.com/llvm/llvm-project/pull/108241
>From 6ec2e5423026599fd2d90356e71b08d787c1989c Mon Sep 17 00:00:00 2001
From: Brad House
Date: Wed, 11 Sep 2024 10:27:50 -0400
Subject: [PATCH] Add AlignFunctionDeclarations attribute to
AlignConsecutiveDeclar
https://github.com/bradh352 updated
https://github.com/llvm/llvm-project/pull/108241
>From 89d238800f0287f29f95165e05530d3f5e397245 Mon Sep 17 00:00:00 2001
From: Brad House
Date: Wed, 11 Sep 2024 10:27:50 -0400
Subject: [PATCH 1/2] Add AlignFunctionDeclarations attribute to
AlignConsecutiveDe
@@ -409,6 +409,21 @@ the configuration (without a prefix: ``Auto``).
int *p;
int (*f)();
+ * ``bool AlignFunctionDeclarations`` Only for
``AlignConsecutiveDeclarations``. Whether function declarations
bradh352 wrote:
I added version 20, let
@@ -265,6 +279,7 @@ struct FormatStyle {
AcrossComments == R.AcrossComments &&
AlignCompound == R.AlignCompound &&
AlignFunctionPointers == R.AlignFunctionPointers &&
+ AlignFunctionDeclarations == R.AlignFunctionDeclarations &
https://github.com/labrinea updated
https://github.com/llvm/llvm-project/pull/101712
>From 2fe8ef63846989952a1c72b83114aabe6f36637a Mon Sep 17 00:00:00 2001
From: Alexandros Lamprineas
Date: Fri, 2 Aug 2024 17:32:23 +0100
Subject: [PATCH 1/2] [AArch64] Split FeatureLS64 to LS64_ACCDATA and LS64
https://github.com/bradh352 updated
https://github.com/llvm/llvm-project/pull/108241
>From 6ec2e5423026599fd2d90356e71b08d787c1989c Mon Sep 17 00:00:00 2001
From: Brad House
Date: Wed, 11 Sep 2024 10:27:50 -0400
Subject: [PATCH 1/2] Add AlignFunctionDeclarations attribute to
AlignConsecutiveDe
https://github.com/bradh352 updated
https://github.com/llvm/llvm-project/pull/108241
>From 00cbf31807ca8d8e1c0c86c6a691c47835522fe9 Mon Sep 17 00:00:00 2001
From: Brad House
Date: Wed, 11 Sep 2024 10:27:50 -0400
Subject: [PATCH] Add AlignFunctionDeclarations attribute to
AlignConsecutiveDeclar
Author: Jay Foad
Date: 2024-09-18T09:32:37+01:00
New Revision: 24748339f517ede038b45202680d281b38809ceb
URL:
https://github.com/llvm/llvm-project/commit/24748339f517ede038b45202680d281b38809ceb
DIFF:
https://github.com/llvm/llvm-project/commit/24748339f517ede038b45202680d281b38809ceb.diff
LOG:
rorth wrote:
I can confirm that the patch fixes the error I'm seeing on the Solaris
buildbots. Thanks.
https://github.com/llvm/llvm-project/pull/109050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/109004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/109099
This patch disables all clang warnings when running include-cleaner, as
users aren't interested in other findings and in-development code might
have them temporarily. This ensures tool can keep working even in
p
@@ -1448,6 +1464,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind
Language) {
LLVMStyle.AlignConsecutiveAssignments.PadOperators = true;
LLVMStyle.AlignConsecutiveBitFields = {};
LLVMStyle.AlignConsecutiveDeclarations = {};
+ LLVMStyle.AlignConsecutiveDeclaration
@@ -504,10 +504,10 @@ struct FragmentCompiler {
auto Fast = isFastTidyCheck(Str);
if (!Fast.has_value()) {
diag(Warning,
- llvm::formatv(
- "Latency of clang-tidy check '{0}' is not known. "
- "It will only run if
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/109098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Balazs Benics
Date: 2024-09-18T11:43:56+02:00
New Revision: 707169acb5520149cd5f96cc8f381ca51107d356
URL:
https://github.com/llvm/llvm-project/commit/707169acb5520149cd5f96cc8f381ca51107d356
DIFF:
https://github.com/llvm/llvm-project/commit/707169acb5520149cd5f96cc8f381ca51107d356.diff
steakhal wrote:
Thanks for the prompt review!
https://github.com/llvm/llvm-project/pull/109098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/serge-sans-paille updated
https://github.com/llvm/llvm-project/pull/109028
>From fc06c00eb299b070106dcffd7d13f3a11eb4c1f0 Mon Sep 17 00:00:00 2001
From: serge-sans-paille
Date: Wed, 18 Sep 2024 08:31:04 +0200
Subject: [PATCH 1/2] Consistent strict flex array
---
clang/lib/S
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/109098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3682,6 +3682,8 @@ static const struct Extension {
{"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}},
{"sve2p1", {AArch64::FeatureSVE2p1}},
{"ls64", {AArch64::FeatureLS64}},
+{"ls64_v", {AArch64::FeatureLS64_V}},
+{"ls64_accdata", {AArch64::FeatureLS64_ACCD
phoebewang wrote:
@mahesh-attarde please solve the conflict.
https://github.com/llvm/llvm-project/pull/108537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov wrote:
I have also left a few comments in the parallel discussion on the RFC.
https://github.com/llvm/llvm-project/pull/106730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
https://github.com/mydeveloperday approved this pull request.
By and large this looks ok, (as long as your rst change was generated using the
docs/tools/dump_format_style.py)
I'd like @owenca, @HazardyKnusperkeks and @rymiel to take a look
https://github.com/llvm/llvm-project/pull/108241
@@ -1448,6 +1464,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind
Language) {
LLVMStyle.AlignConsecutiveAssignments.PadOperators = true;
LLVMStyle.AlignConsecutiveBitFields = {};
LLVMStyle.AlignConsecutiveDeclarations = {};
+ LLVMStyle.AlignConsecutiveDeclaration
@@ -265,6 +279,7 @@ struct FormatStyle {
AcrossComments == R.AcrossComments &&
AlignCompound == R.AlignCompound &&
AlignFunctionPointers == R.AlignFunctionPointers &&
+ AlignFunctionDeclarations == R.AlignFunctionDeclarations &
https://github.com/mydeveloperday edited
https://github.com/llvm/llvm-project/pull/108241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -409,6 +409,21 @@ the configuration (without a prefix: ``Auto``).
int *p;
int (*f)();
+ * ``bool AlignFunctionDeclarations`` Only for
``AlignConsecutiveDeclarations``. Whether function declarations
mydeveloperday wrote:
I sometimes wonder
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/108634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
> In the future, it would be better to push the unrelated parts of the pr in
> separate NFC commits, for ease of review.
Oops, I thought that was not too large, so I refactored that along the way of
the call... anyways, I'll be careful next time :)
https://github.com/llvm/llvm-
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/108693
>From 4e05a1972e539d08589b44677031f506b0c91203 Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Sat, 14 Sep 2024 18:31:42 +0800
Subject: [PATCH] [Clang] Avoid transforming lambdas when rebuilding immediate
exp
https://github.com/cor3ntin requested changes to this pull request.
There are some comments on the RFC, fyi
https://github.com/llvm/llvm-project/pull/106730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
201 - 300 of 410 matches
Mail list logo
