erichkeane wrote:

> > 
> 
> +1, it's why I stopped recommending this approach in my reviews.

While I agree for the most part, there are quite a few diagnostics that are 
absurdly verbose (particularly ones with "did you mean to FLOOP it?").  I think 
partial matches are good/fine, but they need enough of the diag to not be 
ambiguous.

https://github.com/llvm/llvm-project/pull/108658
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to